diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2020-06-12 16:34:20 +0200 |
|---|---|---|
| committer | Neels Hofmeyr <neels@hofmeyr.de> | 2020-06-12 16:35:26 +0200 |
| commit | 0b6a8c8446497da32970b8442c68eca796518b6d (patch) | |
| tree | eec5a70afcd5d4fa73b35f1779da486f609c692c /src/utils.c | |
| parent | c71f771a8411105c9437afd50c08772150591f58 (diff) | |
osmo_bcd2str: also validate start_nibble parameter
If start_nibble were passed negative, we'd end up accessing invalid memory.
Safeguard against that.
Change-Id: Ied3c1e02c3a01d868e08195cbd8dfa52d2c19ac3
Diffstat (limited to 'src/utils.c')
| -rw-r--r-- | src/utils.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/utils.c b/src/utils.c index 038288c5..18e105f8 100644 --- a/src/utils.c +++ b/src/utils.c @@ -154,7 +154,7 @@ int osmo_bcd2str(char *dst, size_t dst_size, const uint8_t *bcd, int start_nibbl int nibble_i; int rc = 0; - if (!dst || dst_size < 1) + if (!dst || dst_size < 1 || start_nibble < 0) return -ENOMEM; for (nibble_i = start_nibble; nibble_i < end_nibble && dst < dst_end; nibble_i++, dst++) { |