diff options
| author | Holger Hans Peter Freyther <holger@moiji-mobile.com> | 2013-07-07 13:54:53 +0200 |
|---|---|---|
| committer | Holger Hans Peter Freyther <holger@moiji-mobile.com> | 2013-07-07 13:59:16 +0200 |
| commit | 47aa482bb0094edfc21bbb45dc0f0e8c9c42c521 (patch) | |
| tree | 3456dd938cd25440091ad6c9c8d3d58abb76d49b /src/gsm/gsm_utils.c | |
| parent | 98de27a18740ea147ffee634ed3d2006329b254f (diff) | |
gsm: Revert the gsm_7bit_encode changes as they are wrong
This reverts commit f996b05dbddccb8e8788dd69777a4fedfa2373eb
and 2b0cac4ef83137ee0bdd583aee877eac467abeab. A detailed
explanation can be found here:
http://lists.osmocom.org/pipermail/openbsc/2013-July/004737.html
The short description is that:
1.) The API should return (as out parameter) the number of
octets used.
2.) The handling for the <CR> encoding only applies to USSD
and it is incomplete. On top of that it broke the SMS test.
Diffstat (limited to 'src/gsm/gsm_utils.c')
| -rw-r--r-- | src/gsm/gsm_utils.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/gsm/gsm_utils.c b/src/gsm/gsm_utils.c index fa77eae4..9569cf32 100644 --- a/src/gsm/gsm_utils.c +++ b/src/gsm/gsm_utils.c @@ -241,12 +241,6 @@ int gsm_septets2octets(uint8_t *result, const uint8_t *rdata, uint8_t septet_len result[z++] = cb; shift++; } - /* To avoid the situation where the receiving entity confuses 7 binary - * zero pad bits as the @ character, the carriage return or <CR> - * character (defined in subclause 7.1.1) shall be used for padding in - * this situation. */ - if (shift == 7) - result[z - 1] |= 0x1a; free(data); |