diff options
| author | Holger Hans Peter Freyther <holger@moiji-mobile.com> | 2013-10-25 11:02:05 +0200 |
|---|---|---|
| committer | Holger Hans Peter Freyther <holger@moiji-mobile.com> | 2013-10-25 11:02:51 +0200 |
| commit | 7c91bfdd4e8a91d4888e772a6adbe8d406c2e599 (patch) | |
| tree | 0bcd46434463d1811b1101aacb70784ec27975ec | |
| parent | 0cccf408602f509943c6556676327f3cb18b5f59 (diff) | |
gprs: Address coverity warning on unchecked return of gprs_ns_tx_status
We could consider creating a CHECK MACRO that will print a message
in case of a tx failure.
Fixes: Coverity CID 1111544
| -rw-r--r-- | src/gb/gprs_ns.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/gb/gprs_ns.c b/src/gb/gprs_ns.c index b667998c..027f6529 100644 --- a/src/gb/gprs_ns.c +++ b/src/gb/gprs_ns.c @@ -860,7 +860,10 @@ static int gprs_ns_rx_reset_ack(struct gprs_nsvc **nsvc, struct msgb *msg) if (!TLVP_PRESENT(&tp, NS_IE_VCI) || !TLVP_PRESENT(&tp, NS_IE_NSEI)) { LOGP(DNS, LOGL_ERROR, "NS RESET ACK Missing mandatory IE\n"); - gprs_ns_tx_status(*nsvc, NS_CAUSE_MISSING_ESSENT_IE, 0, msg); + rc = gprs_ns_tx_status(*nsvc, NS_CAUSE_MISSING_ESSENT_IE, 0, msg); + if (rc < 0) + LOGP(DNS, LOGL_ERROR, "TX failed (%d) to peer %s\n", + rc, gprs_ns_ll_str(*nsvc)); return -EINVAL; } |