aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeels Hofmeyr <neels@hofmeyr.de>2021-06-10 00:47:03 +0200
committerNeels Hofmeyr <neels@hofmeyr.de>2021-06-29 22:35:03 +0200
commit26e53b181c3a8e82350f3e65625bd24bf501e1f7 (patch)
tree7c23003bd76ab70869333c08ef24ca24b0bf6bd4
parentc7f547f89793f3da48ff1f93a53b1be7596b425b (diff)
add fixme: enforce 8 byte length of Kc
-rw-r--r--src/gsm/gsm0808_utils.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/gsm/gsm0808_utils.c b/src/gsm/gsm0808_utils.c
index b5b8431f..78cbe92e 100644
--- a/src/gsm/gsm0808_utils.c
+++ b/src/gsm/gsm0808_utils.c
@@ -721,6 +721,8 @@ uint8_t gsm0808_enc_encrypt_info(struct msgb *msg,
}
msgb_put_u8(msg, perm_algo);
+ /* FIXME: 48.008 3.2.2.10 Encryption Information says:
+ * "When present, the key shall be 8 octets long." */
ptr = msgb_put(msg, ei->key_len);
memcpy(ptr, ei->key, ei->key_len);
@@ -760,6 +762,8 @@ int gsm0808_dec_encrypt_info(struct gsm0808_encrypt_info *ei,
}
ei->perm_algo_len = perm_algo_len;
+ /* FIXME: 48.008 3.2.2.10 Encryption Information says:
+ * "When present, the key shall be 8 octets long." */
ei->key_len = len - 1;
memcpy(ei->key, elem, ei->key_len);
elem+=ei->key_len;