aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeels Hofmeyr <nhofmeyr@sysmocom.de>2016-10-20 13:46:23 +0200
committerNeels Hofmeyr <nhofmeyr@sysmocom.de>2016-10-20 17:53:10 +0200
commit694f72d148882987cc8e4ffd0c4143d8099e09bf (patch)
treeaee5178c5b1696c12164f6e2112fc30139c37636
parenteb604cf44f2182904e9e104c5d226d7391e54102 (diff)
Revert "Constify ctrl_cmd struct fields where appropriate"
This reverts commit ed9d6da5df98538adc70aa03cb569eb9505d04b6. The commit is good as such, but it causes many compiler warnings in the OpenBSC build. We want this to be re-applied as soon as we have patches ready that fix the fallout in openbsc.git. See also https://lists.osmocom.org/pipermail/openbsc/2016-October/009802.html Related: OS#1829 Change-Id: I722ad60232a6ef5b4cb984b92c42851de26b3ccd
-rw-r--r--TODO-RELEASE1
-rw-r--r--include/osmocom/ctrl/control_cmd.h6
2 files changed, 3 insertions, 4 deletions
diff --git a/TODO-RELEASE b/TODO-RELEASE
index b67d6dd7..648b6a6d 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -4,4 +4,3 @@ libosmocore change major external talloc dependency / internal talloc removal
libosmocore change major size of ph_data_param struct changed / Extend L1SAP PH-DATA with presence information
libosmocore change major size of ph_data_param struct changed / Extend L1SAP PH-DATA with measurement information
libosmocore change major size of ph_tch_param struct changed / Extend with RTP Marker
-libosmocore change minor mark as const id, variable & value fields of ctrl_cmd struct
diff --git a/include/osmocom/ctrl/control_cmd.h b/include/osmocom/ctrl/control_cmd.h
index cd96038e..8f2eaa25 100644
--- a/include/osmocom/ctrl/control_cmd.h
+++ b/include/osmocom/ctrl/control_cmd.h
@@ -53,10 +53,10 @@ struct ctrl_connection {
struct ctrl_cmd {
struct ctrl_connection *ccon;
enum ctrl_type type;
- const char *id;
+ char *id;
void *node;
- const char *variable;
- const char *value;
+ char *variable;
+ char *value;
char *reply;
};