aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVadim Yanitskiy <vyanitskiy@sysmocom.de>2021-01-05 14:53:25 +0100
committerfixeria <vyanitskiy@sysmocom.de>2021-01-05 15:21:39 +0000
commitc9f4c49f81e1f65f6671844c04fa194014b1903e (patch)
tree0b3a1d46e8da2b6d2bba33007ed5dd59d3199ebe
parent222e8447187ed75bcc89cf3a0e483f1f684074d0 (diff)
gprs_bssgp: fix uninitialized struct fields in bssgp_create_rim_ri()
Change-Id: Ifc3dda1fe5e9743072751dbb14c2d973388cb3b2 Fixes: CID#215836
-rw-r--r--src/gb/gprs_bssgp.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c
index fd2a48ce..bf0e821a 100644
--- a/src/gb/gprs_bssgp.c
+++ b/src/gb/gprs_bssgp.c
@@ -398,9 +398,12 @@ int bssgp_create_rim_ri(uint8_t *buf, const struct bssgp_rim_routing_info *ri)
/* Note: 3GPP TS 24.301 Figure 9.9.3.32.1 and 3GPP TS 24.008
* Figure 10.5.130 specify MCC/MNC encoding in the same way,
* so we can re-use gsm48_encode_ra() for that. */
- raid_temp.mcc = ri->eutran.tai.mcc;
- raid_temp.mnc = ri->eutran.tai.mnc;
- raid_temp.mnc_3_digits = ri->eutran.tai.mnc_3_digits;
+ raid_temp = (struct gprs_ra_id) {
+ .mcc = ri->eutran.tai.mcc,
+ .mnc = ri->eutran.tai.mnc,
+ .mnc_3_digits = ri->eutran.tai.mnc_3_digits,
+ };
+
gsm48_encode_ra((struct gsm48_ra_id *)buf, &raid_temp);
osmo_store16be(ri->eutran.tai.tac, buf + 3);
OSMO_ASSERT(ri->eutran.global_enb_id_len <=