From 5cfda55c70865455433e14716acf7e86b7f8375b Mon Sep 17 00:00:00 2001 From: Philipp Maier Date: Wed, 26 Jan 2022 10:57:32 +0100 Subject: sccp_user: do not force the role ASP when configured differently The current implementation of osmo_sccp_simple_client forces the ASP to run in ASP role. Even then when the user has configured it differently via VTY. The osmo_sccp_simple_client should respect the VTY configuration. Change-Id: Ib57c513407747d36e503a4fb01c50c69dea0cb85 Related: SYS#5796 --- src/sccp_user.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/sccp_user.c b/src/sccp_user.c index ade9487..839ef64 100644 --- a/src/sccp_user.c +++ b/src/sccp_user.c @@ -633,7 +633,11 @@ osmo_sccp_simple_client_on_ss7_id(void *ctx, uint32_t ss7_id, const char *name, /* Ensure that the ASP we use is set to client mode. */ asp->cfg.is_server = false; - asp->cfg.role = OSMO_SS7_ASP_ROLE_ASP; + + /* Make sure that the role of this ASP is set to ASP unless the user + * made a concious decision about the role via the VTY */ + if (!asp->cfg.role_set_by_vty) + asp->cfg.role = OSMO_SS7_ASP_ROLE_ASP; /* Restart ASP */ if (prot != OSMO_SS7_ASP_PROT_IPA) -- cgit v1.2.3