aboutsummaryrefslogtreecommitdiffstats
path: root/src/sccp_vty.c
AgeCommit message (Collapse)AuthorFilesLines
2023-07-11sccp: Use tdef to implement osmo_sccp_timersPau Espin Pedrol1-23/+17
Related: OS#4372 Change-Id: I1dbe49a83a1bcddf074d5e638babd065834a0ebd
2023-05-10add osmo_sccp_set_max_optional_data()Neels Hofmeyr1-2/+2
So far, the optional data limit can only be modified via cs7 VTY, because struct osmo_sccp_instance is private. Provide public API to set this limit from C. Change-Id: If3d22a0f65a7ed0be043027652402b32c356e322
2023-04-24SCCP: implement variable limit on Optional Data (CR,CC,CREF,RLSD)Neels Hofmeyr1-0/+35
When the Optional Data surpasses 130 bytes, it is not sent as part of SCCP CR, CC, CREF or RLSD messages, but gets sent separately in a Data Form 1. Make this 130 user configurable. This is specified to be 130 bytes exactly, but to interop with non-conforming peers, make this limit adjustable per cs7 instance, via osmo_sccp_vty_init(). Add and test new VTY config: cs7 instance N sccp max-optional-data (<0-999999>|standard) Related: ITU-T Q.713 4.2 to 4.5 Related: Ia68dad973ef18513b52f5accb5264c557c7295ea osmo-ttcn3-hacks Related: SYS#6423 Change-Id: If35697234796af8943691b2de62218e7dc93a08c
2020-10-06vty: add attributes to VTY commands indicating when they applyPhilipp Maier1-2/+2
Change-Id: If77aea2223891663d465f162614ce8db18168c09 Related: SYS#4937, OS#1601
2020-10-04vty: use install_lib_element() and install_lib_element_ve()Vadim Yanitskiy1-5/+5
See https://lists.osmocom.org/pipermail/openbsc/2020-October/013278.html. Change-Id: I727e27f4d4d9550e34cb0073134a9ed7faae3c66 Depends: I8baf31ace93c536421893c2aa4e3d9d298dcbcc6 Related: SYS#4937
2018-09-27make SCCP timers configurableNeels Hofmeyr1-0/+116
The previous hardcoded SCCP timers may cause SCCP connection releases, if the peer is configured with far lower timers than libosmo-sccp. Testing with a specific SCCPlite MSC, I experienced an iar of just over three minutes, meaning that calls would be cut off by the MSC, since the osmo-bsc failed to send an Inactivity Timer message until seven minutes have passed. With this patch, SCCP timers are configurable by the user. Define constant global default timers, and variable user-configurable timers with each osmo_sccp_instance. Add VTY UI to configure the timers. Users must call osmo_sccp_vty_init() to get the sccp-timer config nodes under the 'cs7' node. Show the new UI in ss7_asp_test.vty. Note that even though this function is not new at all, until recently, all of our SCCP users (osmo-bsc, osmo-msc, osmo-sgsn, osmo-hnbgw) failed to call osmo_sccp_vty_init(), and thus also missed out on the various 'show' commands defined in sccp_vty.c. In other words, to benefit from the timer configurability, the patches to call osmo_sccp_vty_init() must first be merged to the corresponding master branches. If a 'sccp-timer' config command occurs, the cs7 instance must allocate an SCCP instance in order to store the timer config. Do that by calling the recently added osmo_ss7_ensure_sccp() function. Hence remove the limitation that the SCCP instance must not be populated from the "simple" setup function. If we want to configure SCCP timers beforehand, there must be an SCCP instance for that, and there is no hard reason to require a NULL SCCP instance, besides the desire to prevent this function from being invoked twice. Change-Id: I28a7362aa838e648ecc9b26ee53dbcade81a9d65
2018-09-27sccp_vty: fix doc strings for show ... ssn,connectionsNeels Hofmeyr1-2/+3
For 'show cs7 instance 0 ssn', fix doc string for 'ssn', and add missing one for the SSN arg. This fixes depending builds that see VTY test failures due to the missing doc string. For 'show cs7 instance 0 connectsion', fix doc string for 'connections'. Change-Id: I214ea51fc6bfa2a9a4dd7c34b43add0c77ffe22e
2018-09-27sccp_vty: define SCCP_STR onceNeels Hofmeyr1-6/+3
Define SCCP_STR in sccp_internal.h, because I know that I want to also use it in osmo_ss7_vty.c. Fix "Signaling" to "Signalling" upon copying the old string. Change-Id: Ic93e4771147070a9222c73f80b5f7c29ae7eec35
2017-11-13Add SPDX-License-Identifier + missing copyright statementsHarald Welte1-0/+2
Change-Id: I113232bbeaa7a835871df7f9b883ba573d8a2534
2017-08-09consistency: use OSMO_SS7_PC_INVALID for osmo_sccp_userNeels Hofmeyr1-1/+1
A previous patch added ss7_instance primary_pc validity checks by means of OSMO_SS7_PC_INVALID. To be consistent, also adjust sccp_user accordingly. (see I7f0f0c89b7335d9da24161bfac8234be214ca00c) Remove the osmo_sccp_user's pc_valid field, replaced by pc=OSMO_SS7_PC_INVALID. Adjust all code paths. Simplify some log printing, using the fact that osmo_ss7_pointcode_print() now outputs "(no PC)" for unset point codes. Change-Id: I8684c9b559712072c772012890bbf7efa7c8eb35
2017-04-14SCCP: Add VTY interface for SCCPHarald Welte1-0/+149
Change-Id: I100daaa947dbab6a4528c4e9fbd0d30790288f63