aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOliver Smith <osmith@sysmocom.de>2019-04-03 14:04:22 +0200
committerOliver Smith <osmith@sysmocom.de>2019-04-03 15:06:02 +0200
commit67b895e156f7066432b020c68cb5c579a7fbdd02 (patch)
treece65e74744163e2daeb2732a5079c0eacbe921d8
parent3f2ff8183140d908b46d4766eb0fc9db474ff9cb (diff)
Cosmetic: sccp_scoc: fix local reference comments
Remove all comments, that claim conn_id is the local reference. This is only a hack, and should not be something to rely on. A properly separated local reference will be introduced shortly. Related: OS#3871 Change-Id: I900124037da76caaaf5ecee323eb82e1c6d2e368
-rw-r--r--src/sccp_internal.h2
-rw-r--r--src/sccp_scoc.c6
2 files changed, 4 insertions, 4 deletions
diff --git a/src/sccp_internal.h b/src/sccp_internal.h
index 000f0f7..ad8a6fd 100644
--- a/src/sccp_internal.h
+++ b/src/sccp_internal.h
@@ -47,7 +47,7 @@ struct osmo_sccp_instance {
struct llist_head users;
/* routing context to be used in all outbound messages */
uint32_t route_ctx;
- /* next local reference to allocate */
+ /* next connection ID to allocate */
uint32_t next_id;
struct osmo_ss7_instance *ss7;
void *priv;
diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c
index e58251f..726426c 100644
--- a/src/sccp_scoc.c
+++ b/src/sccp_scoc.c
@@ -458,7 +458,7 @@ static struct sccp_connection *conn_find_by_id(struct osmo_sccp_instance *inst,
#define INIT_TIMER(x, fn, priv) do { (x)->cb = fn; (x)->data = priv; } while (0)
-/* allocate + init a SCCP Connection with given ID (local reference) */
+/* allocate + init a SCCP Connection with given ID */
static struct sccp_connection *conn_create_id(struct osmo_sccp_instance *inst,
uint32_t conn_id)
{
@@ -480,7 +480,7 @@ static struct sccp_connection *conn_create_id(struct osmo_sccp_instance *inst,
/* this might change at runtime, as it is not a constant :/ */
sccp_scoc_fsm.log_subsys = DLSCCP;
- /* we simply use the local reference as FSM instance name */
+ /* we simply use the connection ID as FSM instance name */
snprintf(name, sizeof(name), "%u", conn->conn_id);
conn->fi = osmo_fsm_inst_alloc(&sccp_scoc_fsm, conn, conn,
LOGL_DEBUG, name);
@@ -493,7 +493,7 @@ static struct sccp_connection *conn_create_id(struct osmo_sccp_instance *inst,
return conn;
}
-/* Search for next free connection ID (local reference) and allocate conn */
+/* Search for next free connection ID and allocate conn */
static struct sccp_connection *conn_create(struct osmo_sccp_instance *inst)
{
uint32_t conn_id;