aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeels Hofmeyr <neels@hofmeyr.de>2019-03-13 02:11:16 +0100
committerNeels Hofmeyr <nhofmeyr@sysmocom.de>2019-03-14 03:41:59 +0000
commitbf7eded0fcd60df96fa2fbe6ed80654f891d4f21 (patch)
tree1d17349086bef2932d5c7c5669566764e97b8f7b
parent93940a2e353061c1423e266eb27637471c05caa2 (diff)
improve logging for rejected AS in xua_rkm.c
Change a loglevel from NOTICE to ERROR, for when a routing key gets re-purposed. Add another error log for insufficient resources case. Change-Id: Id22e3c6bab5f7b597df3514eedb162277ce0ef7d
-rw-r--r--src/xua_rkm.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/xua_rkm.c b/src/xua_rkm.c
index a77460d..4b760ee 100644
--- a/src/xua_rkm.c
+++ b/src/xua_rkm.c
@@ -214,7 +214,7 @@ static int handle_rkey_reg(struct osmo_ss7_asp *asp, struct xua_msg *inner,
if (as) {
LOGPASP(asp, DLSS7, LOGL_NOTICE, "RKM: Found existing AS for RCTX %u\n", rctx);
if (as->cfg.routing_key.pc != dpc) {
- LOGPASP(asp, DLSS7, LOGL_NOTICE, "RKM: DPC doesn't match (%u != %u)\n",
+ LOGPASP(asp, DLSS7, LOGL_ERROR, "RKM: DPC doesn't match, rejecting AS (%u != %u)\n",
as->cfg.routing_key.pc, dpc);
msgb_append_reg_res(resp, rk_id, M3UA_RKM_REG_ERR_INVAL_RKEY, 0);
return -1;
@@ -250,6 +250,8 @@ static int handle_rkey_reg(struct osmo_ss7_asp *asp, struct xua_msg *inner,
if (*nas_idx >= max_nas_idx) {
osmo_ss7_route_destroy(rt);
osmo_ss7_as_destroy(as);
+ LOGPASP(asp, DLSS7, LOGL_ERROR, "RKM: not enough room for newly assigned AS (max %u AS)\n",
+ max_nas_idx+1);
msgb_append_reg_res(resp, rk_id, M3UA_RKM_REG_ERR_INSUFF_RESRC, 0);
return -1;
}