aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Welte <laforge@osmocom.org>2021-04-30 12:06:20 +0200
committerHarald Welte <laforge@osmocom.org>2021-04-30 12:06:20 +0200
commit03e3b0423443cd48f901762e36e8aa5b75c27c37 (patch)
treee28d941c2165510d3233e220514356a7481449ae
parenta25251a15b99aebeaea3879150851473281f9ae8 (diff)
osmo_ss7: free the sock_name string once an ASP socket is closed
It's confusing to keep around a string representation of what peer the socket was previously connected to. Change-Id: I00d47fc355bfe24915653767ad75c1f491c060d5
-rw-r--r--src/osmo_ss7.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index 6d68290..617f6bb 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -1759,6 +1759,10 @@ static void xua_cli_close(struct osmo_stream_cli *cli)
osmo_fsm_inst_dispatch(asp->fi, XUA_ASP_E_SCTP_COMM_DOWN_IND, asp);
/* send M-SCTP_RELEASE.ind to XUA Layer Manager */
xua_asp_send_xlm_prim_simple(asp, OSMO_XLM_PRIM_M_SCTP_RELEASE, PRIM_OP_INDICATION);
+
+ /* no connection means no socket means no socket name */
+ talloc_free(asp->sock_name);
+ asp->sock_name = NULL;
}
static void xua_cli_close_and_reconnect(struct osmo_stream_cli *cli)
@@ -1892,6 +1896,10 @@ static int xua_srv_conn_closed_cb(struct osmo_stream_srv *srv)
osmo_ss7_asp_destroy(asp);
}
+ /* no connection means no socket means no socket name */
+ talloc_free(asp->sock_name);
+ asp->sock_name = NULL;
+
return 0;
}