aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Welte <laforge@gnumonks.org>2016-11-26 15:49:21 +0100
committerHarald Welte <laforge@gnumonks.org>2016-12-01 15:52:53 +0100
commite63f88146d353091488322a1fb6a2b9b10887bef (patch)
tree13a1920ff9ce530844077620dab2c231cd2a84ee
parenta47c8a3f3f1ccbf8963f2a6379562bcf52a381a6 (diff)
stream-client: check read() return value before using it as length input to memcpy
Change-Id: Id962821c71b3a1c4c01c1131eb809b8ec8eaa062 Fixes: Coverity CID 57859
-rw-r--r--examples/stream-client.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/examples/stream-client.c b/examples/stream-client.c
index c54db02..b0aea5e 100644
--- a/examples/stream-client.c
+++ b/examples/stream-client.c
@@ -72,8 +72,9 @@ static int kbd_cb(struct osmo_fd *fd, unsigned int what)
int ret;
ret = read(STDIN_FILENO, buf, sizeof(buf));
-
LOGP(DSTREAMTEST, LOGL_NOTICE, "read %d byte from keyboard\n", ret);
+ if (ret < 0)
+ return ret;
msg = msgb_alloc(1024, "STREAMCLIENT/test");
if (msg == NULL) {