diff options
| author | Vadim Yanitskiy <vyanitskiy@sysmocom.de> | 2023-12-09 05:19:06 +0700 |
|---|---|---|
| committer | Vadim Yanitskiy <vyanitskiy@sysmocom.de> | 2023-12-09 05:19:55 +0700 |
| commit | be55e1fd83f768aadfc8e8c1cd19d4f810bb9cfe (patch) | |
| tree | d0a4ec3cb2670a8d6ae20c9088f2a448298c2ee1 | |
| parent | 0160c666fe10008f53c3a55d10977a0dd021b5da (diff) | |
llc: fix l3par check in gprs_llc_lle_generate_xid()
A NULL pointer dereference is possible if this function is called
with l3par being NULL, but l3par_len being greater than 0.
Change-Id: I80c18a45a248b85901d455bfb17e81734fa5961d
Fixes: CID#300602
| -rw-r--r-- | src/llc/llc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/llc/llc.c b/src/llc/llc.c index 48d1ba6..f8c6ba1 100644 --- a/src/llc/llc.c +++ b/src/llc/llc.c @@ -475,7 +475,7 @@ static int gprs_llc_lle_generate_xid(struct gprs_llc_lle *lle, uint8_t *bytes, i xid_fields[2].type = OSMO_GPRS_LLC_XID_T_N201_I; xid_fields[2].val = lle->params.n201_i; - if (l3par_len > 0) { + if (l3par != NULL && l3par_len > 0) { xid_fields[3].type = OSMO_GPRS_LLC_XID_T_L3_PAR; xid_fields[3].var.val_len = l3par_len; if (l3par_len > 0) { |