From a54269c81eda71611c05fae036f4eee78fb254f8 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Wed, 17 Aug 2011 23:23:08 +0200 Subject: ipaccess: fix segfault if bsc port already in used This patch fixes a segfault if we try to bind to an already busy port, it can be easily reproduced with: $ test/./e1inp_ipa_bsc_test & <0003> ipaccess.c:830 enabling ipaccess BSC mode <0000> e1inp_ipa_bsc_test.c:241 entering main loop $ test/./e1inp_ipa_bsc_test segfault --- src/input/ipaccess.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/input') diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index ef96bc4..836c2f8 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -840,7 +840,6 @@ static int ipaccess_line_update(struct e1inp_line *line, if (ipa_server_link_open(oml_link) < 0) { LOGP(DLINP, LOGL_ERROR, "cannot open OML BSC link: %s\n", strerror(errno)); - ipa_server_link_close(oml_link); ipa_server_link_destroy(oml_link); return -EIO; } @@ -855,7 +854,6 @@ static int ipaccess_line_update(struct e1inp_line *line, if (ipa_server_link_open(rsl_link) < 0) { LOGP(DLINP, LOGL_ERROR, "cannot open RSL BSC link: %s\n", strerror(errno)); - ipa_server_link_close(rsl_link); ipa_server_link_destroy(rsl_link); return -EIO; } -- cgit v1.2.3