aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-08-25Bump version: 0.3.2 → 0.4.00.4.0Max3-8/+18
Change-Id: Ibefe53a7f5b06fb8a9294574af41dacac68bdbe9
2017-08-08Use release helper from libosmocoreMax2-0/+6
Change-Id: Ifc88e5c942a8b430b2436d429c86560d82984a95 Related: OS#1861
2017-07-13contrib: Enable -Werror by defaultPau Espin Pedrol1-1/+1
Change-Id: I065b18dd6c4f7616f981aa4273e68e23825a7294
2017-07-13configure.ac: Fix RTP_SIGNAL_PTR_CAST config in FreeBSD buildPau Espin Pedrol1-2/+3
Move function definition to the first argument of AC_LANG_PROGRAM (prologue) instead of the second (body). Content of the body is writen into the main() function of the file being compiled, while prologue is writen before it. Compiler from FreeBSD build host doesn't like definitions inside the main function, it fails with the following error: conftest.c:28:73: error: function definition is not allowed here As the compilation test fails, unsigned int is used instead of void*, which doesn't match the current headers in the current build, and then a warning (or error with -Werror) is printed. Change-Id: I83fc3997e5067b499bf43cea4ff953604d6cbeae
2017-07-12check for missing result of rate_ctr_group_alloc()Harald Welte1-0/+5
In case the counter group allocation fails, we must handle this gracefully and fail the allocation of the parent object, too. Change-Id: Iff8506832d3472ab193b19b43cfbe7a9511075d1 Related: OS#2361
2017-07-10jenkins.sh: Proper error message if local environment isn't set upHarald Welte1-0/+6
Change-Id: Ibb34f07164adb175a44f460d02f54586b56a5b95
2017-07-05configure.ac: Fix C(PP)FLAGS for BSD buildPau Espin Pedrol1-4/+4
Issue first found in libosmocore. It seems the BSD build doesn't use bash which means using += to append to a variable doesn't work correctly. Change-Id: Id509351104bc7466114d4b9be450814254110f44
2017-06-29osmo_ortp.c: Duration of a RTP frame affects timestamp of the next onePau Espin Pedrol1-1/+1
Duration of an RTP frames dictates the timestamp used for the next frame, not for the one being sent now. It was done like this before to account for possible losses. Implementation wise, the duration was understood as "duration between last frame was sent and now when current one is sent". It makes more sense to use it as the duration in number of sampling ticks as described on the function documentation, specially now that we can account for extra time by means of osmo_rtp_skipped_frame. Change-Id: Ib8f5fa5509059fe908c09a4381844c613d478548
2017-06-29osmo_ortp: Add osmo_rtp_drop_frame APIPau Espin Pedrol2-0/+23
This API will be used by osmo-bts to maintain the sampling clock of the RTP socket whenever a frame should be sent but it is not available, for instance due to low quality of signal. Change-Id: Id6099372b6231c0a4b6ea0716f46f5daee7049e1
2017-06-22Revert "configure.ac: Use -Werror in C(PP)FLAGS"Neels Hofmeyr1-2/+2
As discussed in chat, -Werror should not be enabled by default. Instead it should be added in our jenkins build scripts. This reverts commit 7d1f53143e8eaeb25bae8979fb80dac57ddbf827. Change-Id: Ied6e21b72b24fcb623fd945ed9560b742a8eedf5
2017-06-22configure.ac: Use -Werror in C(PP)FLAGSPau Espin Pedrol1-2/+2
Change-Id: Ic674bf28d781b9806dc023777e1fea4ee1a0257a
2017-06-22configure.ac: Use -Wall in C(PP)FLAGSPau Espin Pedrol1-0/+3
Change-Id: I5033387e4a4206f7d34d1db3c6ede9255d199941
2017-06-22osmo_ortp.c: Fix warning: check ortp API in rtp_session_signal_connectPau Espin Pedrol2-4/+21
Since ortp commit 5ab29c50adc7948b11449e3aeee66010379ff7dc preceeding ortp 0.24, the API is fixed and requests a pointer instead of an unsigned long. As we now require at least ortp 0.22 since libosmo-abis 15d9b7929d449e4138bcb003c614035bceadc3d1, we need to support both old and new version of the API to continue having support for 0.22 but still supporting new versions of the library. Change-Id: I2dbd0498d75160358eca4336850e1a0ad2efdbeb
2017-06-22osmo_ortp.c: Fix warning: implicit use of functionPau Espin Pedrol1-1/+5
Explicitly state that we are using an internal API from ortp, and define the function we are using to avoid printing a warning. Change-Id: I9cadcb31ce7ade3632d83753be97fdc9ea518b5b
2017-06-07src: use osmo_timer_setup()Pablo Neira Ayuso4-8/+4
Use new function available in libosmocore to set up timers. Compile tested only. Change-Id: I4ca4950e49a09c63b608b13ac7561ebbd351889a
2017-05-26Revert "ipacces.c: Remove ipa_bts_id_resp() and use libosmocore"Harald Welte1-4/+85
This reverts commit d517db06ced45bbe0a70799487964e52edd8a375, which for some reason broke the IPA client functionality. This needs to be investigated and properly fixed. But until that happens: revert. Change-Id: Ic168f437c5bf1fcdb7441b0541c80a4805463004
2017-05-25Add value_string for input signal names (e1inp_signal_names)Harald Welte2-0/+13
Change-Id: I1662d4a969d2d12677646f3120b25be9a20c6d22
2017-04-15ipacces.c: Remove ipa_bts_id_resp() and use libosmocoreHarald Welte1-85/+4
In Chanage-Id Icbcd8827a75fd5f3393351c1ca372de85275ad35 we introduced a very similar function to libosocore. Let's use that rather than our own version here. Change-Id: I858920db1fb5f5d66e71b676d28c84d330d7904a
2017-04-04Fix HAVE_ORTP_LOG_DOMAIN detection on FreeBSDHarald Welte1-0/+3
We need to use the include path[s] resolved by pkg-config for ortp before trying to compile our test program. Without this patch, compilation will fail e.g. on FreeBSD 11. Change-Id: I0c95e37cc449297389bf31dd9d5dcaa922d75d0c
2017-03-29Fix RTP jitter buffer that never stop to increase.Jean-Francois Dionne1-1/+1
Duration passed to osmo_rtp_send_frame_ext function is based on the last frame and the current one. Duration must then be added to the timestamp before being transmitted. Change-Id: I0593d6530c097cca34125a0ae2dd1b019b4dd80d
2017-03-27configure: Fix compilation with new libortpPau Espin Pedrol2-3/+21
Commit 0c8d9ddaea8c1afdc0e9b8c37a31c9d158e57efd in ortp broke old API: function ortp_set_log_level_mask requires one new parameter 'domain'. This commit fixes compilation in my Archlinux box using ortp 1.0.1. Change-Id: I46e565f1873c7baf3c3b0aafe73951d20ce083b4
2017-03-18README.md: Use <> around all hyperlinks to render them as links in cgitHarald Welte1-6/+6
Change-Id: I4b1004d5275972249d463083e0c2af41dc46dad2
2017-03-16jenkins: add value_string termination checkNeels Hofmeyr1-0/+2
Change-Id: I37c14c1a18207f64aa5e15ec0d2503bc834b2627 Depends: libosmocore change-id I2bc93ab4781487e7685cfb63091a489cd126b1a8
2017-03-16Add README file to libosmo-abis repositoryHarald Welte2-1/+67
Change-Id: I76ced414b22637792389fcf79ae6c7159502259b
2017-03-15lapd: log pointer addressesPhilipp Maier1-2/+7
Add pointer address output to the sap alloc/free functions in order to track the objects later in the debug output (we have three of them) Change-Id: I9b961d5e36967cfd953551b24696849541257a1c
2017-03-14lapd: Reduce N200 (SABM retransmission count)Philipp Maier1-2/+2
N200, which controls the maxium number of LAPD retransmissions, is set to 300. This will cause a long waiting time until LAPD detects a failed link. This commit reduces the retransmission count to 50 in order to get a faster link re-establishment in case of link failure. This patch will only affect the ericsson LAPD profile, all other lapd profiles will not be touched. Change-Id: I4f56f9d00520adc0c0a4497547762cd054030867
2017-03-08add basic unixsocket supportAlexander Couzens7-4/+411
Allow to connect to a unix socket for communicating with LAPD. Change-Id: Ia5723b09a5c68a0505829dc732def981e60a907a
2017-02-20Enable sanitizeMax2-2/+14
Add ./configure option to enable ASAN checks and use it for jenkins tests. While at it - also move to /bin/sh shebang as we don't use bashisms anyway. Change-Id: Ie26e54ab6b850c9adf124a6bc613ec9bc9e8a6e2
2017-01-23misc: Fix build failure/warning when building on alpine linuxHolger Hans Peter Freyther3-11/+3
alpine linux is using the musl libc and this triggered some minor compilation issues. Remove unused mISDN include and defines from the general E1 input handling and address the other warnings and errors. /usr/include/sys/fcntl.h:1:2: warning: #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h> [-Wcpp] #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h> ^~~~~~~ In file included from input/misdn.c:48:0: ../include/mISDNif.h:286:2: error: unknown type name 'u_int' u_int id; ^~~~~ Change-Id: I997e45a456faedb5f370fd02ded300c1e36b791b
2017-01-21undup: subchan_demux.c: use libosmocore's llist_count()Neels Hofmeyr1-12/+1
Depends on libosmocore Change-Id Ic49adc7a346f5722bf624d7d3b4a735e4220ae15 Change-Id: I47f1831f1835dc07925dabbc115677087e48fa1b
2017-01-09handle_ts1_read(): log sign_link() errorMax1-3/+4
Change-Id: I95779ee8590ab16b7af4ad2c79ede68da3a12e5a
2016-12-31ipaccess_line_update(): log connection IP addresses and portsMax1-6/+9
Remove dup: call function to obtain IPA address only once. Log explicitly IP address and ports to which IPA is bound or connected. Change-Id: I841c40abdcba0fdd695a43231391c5d7cee20fae
2016-12-22Add gerrit settingsMax1-0/+3
Make it simple to setup and use this repo with 'git review' command. Change-Id: I04aeee90641555df19e969f925474ec6f9a23354
2016-12-21Integrate Debian packaging changesMax3-14/+135
debian/control: * restructure to make it easier to incorporate further changes * update package descriptions * update project URL debian/rules: * use proper hardening syntax * restructure to make it easier to incorporate further changes * add cleanup override debian/copyright: add file matching Debian format Change-Id: I6af8ab7f5c75b4d161cebf492f3de5d9dbd00220 Related: OS#1694
2016-12-16Enable adaptive jitter compensationMax1-10/+16
* check RTP socket parameter and enable necessary jitter buffering * return the status of requested jitter buffering instead of always returning 0 * document function parameters and return value Change-Id: I87d4d9fe990683adbb02b64cb39b78de533d8046
2016-12-16Remove obsolete compile-time conditionalMax1-4/+0
Change-Id: If8f87587227b09635361b758873f75d8b6aa3497
2016-12-12Expand network error callbackMax1-1/+1
ortp: use extra parameter for network_error callback in log message as it's described in oRTP documentation (error string). Change-Id: I581db499d453b80230198d95000f0f6fc20752d1
2016-12-05osmo_rtp_socket_poll(): Fix log message to match function nameMax1-1/+2
Change-Id: I5c36bbc35e2ba794b5e446f52a0752bcf1367d11
2016-11-26don't pass negative error to strerror()Harald Welte1-1/+1
Change-Id: I48c25c78148d1fe9ce4e4a88cdfe5cf74dc95b17 Fixes: Coverity CID 57858
2016-11-26call strerror() not on negative valueHarald Welte1-1/+1
Change-Id: I0ba1eab49f93d9b34d162682f2528d106b56d6d6 Fixes: Coverity CID 57857
2016-11-26fix signed/unsigned bug in ipa_client_conn_open()Harald Welte1-4/+2
If osmo_sock_init() would ever return a negative FD together with errno == EINPROGRESS, we would have attempted to register that negative FD with the select() main loop handling, whihc of course doesn't work. EINPROGRESS for a non-blocking connecting socket is handled inside osmo_sock_init() and would result in it returning a positive FD, so the above case is of theoretical significance only. Change-Id: Id01eb0d48eea6cab1fbc720c52361101b8ea4e35 Fixes: Coverity CID 57856
2016-11-26osmo_rtp_socket_fdreg(): Check return value of osmo_fd_register()Harald Welte1-2/+11
Change-Id: I4969e0a9e7109d426066e6c2b80ed44c396b65b5 Fixes: Coverity CID 57631
2016-11-26input/ipaccess.c: Check return value of osmo_fd_register()Harald Welte1-1/+6
Change-Id: I81659e0533ceb5d43292d97a63300b500044add7 Fixes: Coverity CID 57630
2016-11-16e1_input: remove superflous semi colonAlexander Couzens1-1/+1
Change-Id: I7e9079cbac1d9920da2aace35810682b49ec532f
2016-11-16lapd_pcap.h: Add missing #include linesHarald Welte1-0/+3
we reference 'struct msgb' and mode_t, so we have to #include the right header files. Change-Id: Iac8f905182b60782202bdf75e04d47ea89dc3863
2016-11-03e1_input.h: add missing extern for value string arraysArran Cudbard-Bell1-2/+2
Mark two value string arrays as extern, so symbols aren't created for each source file that includes the headers. Tweaked-by: nhofmeyr (commit log) Signed-off-by: Arran Cudbard-Bell <a.cudbardb@freeradius.org> Change-Id: Iebf4b3922a48ca2cc20d478aba06224dd89d38cb
2016-11-02lapd: adding support for ericsson's lapd dialectPhilipp2-0/+37
Ericsson's RBS2111-BTS (and similar) implements a lapdm dialect which uses a link establishment method that differs from the standard. While the BSC is transmitting sabm frames on one specific timeslot, the BTS will periodically scan through all timeslots to check for incoming sabm frames. When the BTS detcts the sabm fames on one of the timeslots it will stay there and continue to commence the link establishment. The described procedure requires a slightly modified lapd profile, the t200 retransmission timeout has to be configured to exactly 300 msek. Otherwise the link establishment will fail. Since the BTS will switch from timeslot to timeslot most of the sabm frames will not be seen by the BTS, so the maximum retransmission has to be increased. This patch suggests a maximum retry count of 300, which is an educated guess and has worked fine during our tests. Change-Id: I892af57013d7ab4216e9e2d0873a69129aaeb8e5
2016-10-28Fix metadata corruptionHarald Welte1-2/+3
Use separate pointer for payload to make sure mblk->b_rptr is not advanced (which breaks the use of rtp_get_* macros that assume mblk->b_rptr is pointing to the RTP header, not the payload). Committed by: Max <msuraev@sysmocom.de> Change-Id: I205630e1da98693ba0ac25e86e21780284185077 Related: OS#1802
2016-10-27Unify RTP receivingMax1-31/+21
* Remove code duplication * Use return value of rtp_get_payload() instead of pointer arithmetic Change-Id: Id42e85b55eab33c5eb81ac7a2cdea7962b2e30ef
2016-10-21Extend RTP RX callback parametersMax3-1/+7
While debugging low-level RTP issues it is handy to be able to match exact RTP packet with the payload available to higher-level functions. Having Sequence number and Timestamp RTP fields as parameter to receiving callback is the easiest way to do so. Change-Id: I0c9b08d247d7342d6139badca77ce64fda0cf274