diff options
| author | Philipp Maier <pmaier@sysmocom.de> | 2023-04-17 13:02:52 +0200 |
|---|---|---|
| committer | Philipp Maier <pmaier@sysmocom.de> | 2023-04-18 11:45:39 +0200 |
| commit | d0c61dc1c23e1328c02d735a0c2c2b0c7f7dfb56 (patch) | |
| tree | b760881f19bc75dda3ebfecbafe90057e122e2c7 | |
| parent | d07528148e9cfed8ec6bd96a5d9cefb2d6990eca (diff) | |
e1d: clean up error logging in handle_ts_sign_read
The error logging in handle_ts_sign_read can be organized the same way
as in handle_ts_raw_read, then we do not need to check the return code
twice.
Change-Id: Ife3bb07fb4180dbd73d0efdc5acade8b20e8a5da
| -rw-r--r-- | src/input/e1d.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/src/input/e1d.c b/src/input/e1d.c index a42c87d..289e693 100644 --- a/src/input/e1d.c +++ b/src/input/e1d.c @@ -64,16 +64,13 @@ handle_ts_sign_read(struct osmo_fd *bfd) return -ENOMEM; ret = read(bfd->fd, msg->data, TS_SIGN_ALLOC_SIZE - 16); - if (ret < 0) { - LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); + if (ret < 1) { + LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "%s read error: %d %s\n", __func__, ret, + ret < 0 ? strerror(errno) : "bytes read"); return ret; } msgb_put(msg, ret); - if (ret <= 1) { - LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); - return ret; - } return e1inp_rx_ts_lapd(e1i_ts, msg); } |