summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEmmanuel Thierry <emmanuel.thierry@telecom-bretagne.eu>2013-04-24 18:39:19 +0200
committerThomas Graf <tgraf@suug.ch>2013-04-28 10:34:50 +0200
commit979ea335b0141eb62682056be42ccb4b01e6e2a2 (patch)
tree4cca69f69d311883e3b405ec95de7a6a9f5d4bd3
parent3a6d256da598d2fd9dc20137f208b88295374b67 (diff)
Wrong calcultation in nla_reserve
There seams to be an error in the calculation of needed space for the message in nla_reserve. The current size of the message is counted twice: Once in NLMSG_ALIGN, once in the condition below. This causes nla_put_* calls to be rejected if the allocation size of the message has been strictly calculated by the caller. Signed-off-by: Thomas Graf <tgraf@suug.ch>
-rw-r--r--lib/attr.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/attr.c b/lib/attr.c
index 6fc6af5..535f10c 100644
--- a/lib/attr.c
+++ b/lib/attr.c
@@ -464,7 +464,7 @@ struct nlattr *nla_reserve(struct nl_msg *msg, int attrtype, int attrlen)
tlen = NLMSG_ALIGN(msg->nm_nlh->nlmsg_len) + nla_total_size(attrlen);
- if ((tlen + msg->nm_nlh->nlmsg_len) > msg->nm_size)
+ if (tlen > msg->nm_size)
return NULL;
nla = (struct nlattr *) nlmsg_tail(msg->nm_nlh);