From b8b5177a79319cd74ee5b0c6d2a83104e0fe07f5 Mon Sep 17 00:00:00 2001 From: kpfleming Date: Thu, 5 Oct 2006 16:10:01 +0000 Subject: don't segfault when an argument without a close parenthesis is found stop parsing as soon as that situation occurs git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@44476 f38db490-d61c-443f-a65b-d21fe96a405b --- main/app.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'main/app.c') diff --git a/main/app.c b/main/app.c index b6a7f73a9..e640a762e 100644 --- a/main/app.c +++ b/main/app.c @@ -1302,14 +1302,14 @@ int ast_app_parse_options(const struct ast_app_option *options, struct ast_flags if (*s == '(') { /* Has argument */ arg = ++s; - s = strchr(s, ')'); - if (*s) { + if ((s = strchr(s, ')'))) { if (argloc) args[argloc - 1] = arg; *s++ = '\0'; } else { ast_log(LOG_WARNING, "Missing closing parenthesis for argument '%c' in string '%s'\n", curarg, arg); res = -1; + break; } } else if (argloc) { args[argloc - 1] = NULL; -- cgit v1.2.3