From e2bf2462cfa877038cb102b548428181a3960018 Mon Sep 17 00:00:00 2001 From: russell Date: Tue, 19 Jun 2007 15:22:36 +0000 Subject: Fix a crash that could occur when handing device state changes. When the state of a device changes, the device state thread tells the extension state handling code that it changed. Then, the extension state code calls the callback in chan_sip so that it can update subscriptions to that extension. A pointer to a sip_pvt structure is passed to this function as the call which needs a NOTIFY sent. However, there was no locking done to ensure that the pvt struct didn't disappear during this process. (issue #9946, reported by tdonahue, patch by me, patch updated to trunk to use the sip_pvt lock wrappers by eliel) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@69944 f38db490-d61c-443f-a65b-d21fe96a405b --- channels/chan_sip.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'channels') diff --git a/channels/chan_sip.c b/channels/chan_sip.c index 2da9dd7c1..d6f513a64 100644 --- a/channels/chan_sip.c +++ b/channels/chan_sip.c @@ -8281,6 +8281,8 @@ static int cb_extensionstate(char *context, char* exten, int state, void *data) { struct sip_pvt *p = data; + ast_mutex_lock(&p->lock); + switch(state) { case AST_EXTENSION_DEACTIVATED: /* Retry after a while */ case AST_EXTENSION_REMOVED: /* Extension is gone */ @@ -8301,6 +8303,9 @@ static int cb_extensionstate(char *context, char* exten, int state, void *data) if (option_verbose > 1) ast_verbose(VERBOSE_PREFIX_1 "Extension Changed %s new state %s for Notify User %s\n", exten, ast_extension_state2str(state), p->username); + + ast_mutex_unlock(&p->lock); + return 0; } -- cgit v1.2.3