From f4f5933ae72307afd6fcfff40ac77a7c25638a7a Mon Sep 17 00:00:00 2001 From: russell Date: Sun, 28 Dec 2008 15:15:14 +0000 Subject: Merged revisions 166772 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r166772 | russell | 2008-12-28 09:13:48 -0600 (Sun, 28 Dec 2008) | 4 lines Use strncat() instead of an sprintf() in which source and target buffers overlap http://lists.digium.com/pipermail/asterisk-dev/2008-December/035919.html ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@166773 f38db490-d61c-443f-a65b-d21fe96a405b --- channels/misdn_config.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'channels/misdn_config.c') diff --git a/channels/misdn_config.c b/channels/misdn_config.c index 29723e17c..0a7109276 100644 --- a/channels/misdn_config.c +++ b/channels/misdn_config.c @@ -790,8 +790,9 @@ void misdn_cfg_get_config_string (int port, enum misdn_cfg_elements elem, char* else iter = port_cfg[0][place].ml; if (iter) { - for (; iter; iter = iter->next) - sprintf(tempbuf, "%s%s, ", tempbuf, iter->msn); + for (; iter; iter = iter->next) { + strncat(tempbuf, iter->msn, sizeof(tempbuf) - strlen(tempbuf) - 1); + } tempbuf[strlen(tempbuf)-2] = 0; } snprintf(buf, bufsize, " -> msns: %s", *tempbuf ? tempbuf : "none"); -- cgit v1.2.3