From 76e741a54b997b0a21f5bb7a48df61fcdd672669 Mon Sep 17 00:00:00 2001 From: tilghman Date: Tue, 4 Nov 2008 20:52:11 +0000 Subject: Merged revisions 154366 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r154366 | tilghman | 2008-11-04 14:51:18 -0600 (Tue, 04 Nov 2008) | 16 lines Merged revisions 154365 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r154365 | tilghman | 2008-11-04 14:49:33 -0600 (Tue, 04 Nov 2008) | 9 lines On busy systems, it's possible for the values checked within a single line of code to change, unless the structure is locked to ensure a consistent state. (closes issue #13717) Reported by: kowalma Patches: 20081102__bug13717.diff.txt uploaded by Corydon76 (license 14) Tested by: kowalma ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@154367 f38db490-d61c-443f-a65b-d21fe96a405b --- channels/chan_iax2.c | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'channels/chan_iax2.c') diff --git a/channels/chan_iax2.c b/channels/chan_iax2.c index 6f26cf615..0ed11e070 100644 --- a/channels/chan_iax2.c +++ b/channels/chan_iax2.c @@ -1703,12 +1703,21 @@ static int __find_callno(unsigned short callno, unsigned short dcallno, struct s /* This will occur on the first response to a message that we initiated, * such as a PING. */ + if (dcallno) { + ast_mutex_lock(&iaxsl[dcallno]); + } if (callno && dcallno && iaxs[dcallno] && !iaxs[dcallno]->peercallno && match(sin, callno, dcallno, iaxs[dcallno], check_dcallno)) { iaxs[dcallno]->peercallno = callno; res = dcallno; store_by_peercallno(iaxs[dcallno]); + if (!res || !return_locked) { + ast_mutex_unlock(&iaxsl[dcallno]); + } return res; } + if (dcallno) { + ast_mutex_unlock(&iaxsl[dcallno]); + } #ifdef IAX_OLD_FIND /* If we get here, we SHOULD NOT find a call structure for this -- cgit v1.2.3