From 58818426d60d583c4becc6a99b398cbac1b7b12f Mon Sep 17 00:00:00 2001 From: russell Date: Wed, 19 Oct 2005 18:19:02 +0000 Subject: Massive cleanups to applications for LOCAL_USER handling and some other things. In general, LOCAL_USER_ADD/REMOVE should be the first/last thing called in an application. An exception is if there is some *fast* setup code that might halt the execution of the application, such as checking to see if an argument exists. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6832 f38db490-d61c-443f-a65b-d21fe96a405b --- apps/app_math.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'apps/app_math.c') diff --git a/apps/app_math.c b/apps/app_math.c index 225c929df..8f351b519 100755 --- a/apps/app_math.c +++ b/apps/app_math.c @@ -108,14 +108,19 @@ static int math_exec(struct ast_channel *chan, void *data) deprecation_warning = 1; } - if (!data) { + if (!data || ast_strlen_zero(data)) { ast_log(LOG_WARNING, "No parameters passed. !\n"); return -1; } LOCAL_USER_ADD(u); - - s = ast_strdupa((void *) data); + + s = ast_strdupa(data); + if (!s) { + ast_log(LOG_ERROR, "Out of memory\n"); + LOCAL_USER_REMOVE(u); + return -1; + } mvar = strsep(&s, "|"); mvalue1 = strsep(&s, "|"); -- cgit v1.2.3