From b093da8912c4243011e2614dc560cf7ac6436632 Mon Sep 17 00:00:00 2001 From: root Date: Fri, 10 Feb 2006 21:03:04 +0000 Subject: automerge commit git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.2-netsec@9422 f38db490-d61c-443f-a65b-d21fe96a405b --- cdr.c | 4 +--- channels/chan_mgcp.c | 8 ++------ channels/chan_modem.c | 17 ++++++++--------- channels/chan_sip.c | 4 +--- devicestate.c | 8 ++------ dnsmgr.c | 6 ++---- 6 files changed, 16 insertions(+), 31 deletions(-) diff --git a/cdr.c b/cdr.c index d9cff74bd..442de9c1f 100644 --- a/cdr.c +++ b/cdr.c @@ -1,7 +1,7 @@ /* * Asterisk -- An open source telephony toolkit. * - * Copyright (C) 1999 - 2005, Digium, Inc. + * Copyright (C) 1999 - 2006, Digium, Inc. * * Mark Spencer * @@ -1197,8 +1197,6 @@ static int do_reload(void) if it does not exist */ if (enabled && batchmode && (!was_enabled || !was_batchmode) && (cdr_thread == AST_PTHREADT_NULL)) { ast_cond_init(&cdr_pending_cond, NULL); - pthread_attr_init(&attr); - pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED); if (ast_pthread_create(&cdr_thread, &attr, do_cdr, NULL) < 0) { ast_log(LOG_ERROR, "Unable to start CDR thread.\n"); ast_sched_del(sched, cdr_sched); diff --git a/channels/chan_mgcp.c b/channels/chan_mgcp.c index 4447bd7ff..d3b68e226 100644 --- a/channels/chan_mgcp.c +++ b/channels/chan_mgcp.c @@ -1,7 +1,7 @@ /* * Asterisk -- An open source telephony toolkit. * - * Copyright (C) 1999 - 2005, Digium, Inc. + * Copyright (C) 1999 - 2006, Digium, Inc. * * Mark Spencer * @@ -3469,10 +3469,6 @@ static void *do_monitor(void *data) static int restart_monitor(void) { - pthread_attr_t attr; - pthread_attr_init(&attr); - pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED); - /* If we're supposed to be stopped -- stay stopped */ if (monitor_thread == AST_PTHREADT_STOP) return 0; @@ -3490,7 +3486,7 @@ static int restart_monitor(void) pthread_kill(monitor_thread, SIGURG); } else { /* Start a new monitor */ - if (ast_pthread_create(&monitor_thread, &attr, do_monitor, NULL) < 0) { + if (ast_pthread_create(&monitor_thread, NULL, do_monitor, NULL) < 0) { ast_mutex_unlock(&monlock); ast_log(LOG_ERROR, "Unable to start monitor thread.\n"); return -1; diff --git a/channels/chan_modem.c b/channels/chan_modem.c index f37a29e12..09adc4733 100644 --- a/channels/chan_modem.c +++ b/channels/chan_modem.c @@ -1,7 +1,7 @@ /* * Asterisk -- An open source telephony toolkit. * - * Copyright (C) 1999 - 2005, Digium, Inc. + * Copyright (C) 1999 - 2006, Digium, Inc. * * Mark Spencer * @@ -718,16 +718,15 @@ static int restart_monitor() return -1; } if (monitor_thread != AST_PTHREADT_NULL) { - pthread_cancel(monitor_thread); - /* Nudge it a little, as it's probably stuck in select */ pthread_kill(monitor_thread, SIGURG); pthread_join(monitor_thread, NULL); - } - /* Start a new monitor */ - if (ast_pthread_create(&monitor_thread, NULL, do_monitor, NULL) < 0) { - ast_mutex_unlock(&monlock); - ast_log(LOG_ERROR, "Unable to start monitor thread.\n"); - return -1; + } else { + /* Start a new monitor */ + if (ast_pthread_create(&monitor_thread, NULL, do_monitor, NULL) < 0) { + ast_mutex_unlock(&monlock); + ast_log(LOG_ERROR, "Unable to start monitor thread.\n"); + return -1; + } } ast_mutex_unlock(&monlock); return 0; diff --git a/channels/chan_sip.c b/channels/chan_sip.c index 2c45421f5..537ede871 100644 --- a/channels/chan_sip.c +++ b/channels/chan_sip.c @@ -1,7 +1,7 @@ /* * Asterisk -- An open source telephony toolkit. * - * Copyright (C) 1999 - 2005, Digium, Inc. + * Copyright (C) 1999 - 2006, Digium, Inc. * * Mark Spencer * @@ -11451,8 +11451,6 @@ static int restart_monitor(void) /* Wake up the thread */ pthread_kill(monitor_thread, SIGURG); } else { - pthread_attr_init(&attr); - pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED); /* Start a new monitor */ if (ast_pthread_create(&monitor_thread, &attr, do_monitor, NULL) < 0) { ast_mutex_unlock(&monlock); diff --git a/devicestate.c b/devicestate.c index 73b779568..b19709152 100644 --- a/devicestate.c +++ b/devicestate.c @@ -1,7 +1,7 @@ /* * Asterisk -- An open source telephony toolkit. * - * Copyright (C) 1999 - 2005, Digium, Inc. + * Copyright (C) 1999 - 2006, Digium, Inc. * * Mark Spencer * @@ -271,12 +271,8 @@ static void *do_devstate_changes(void *data) /*--- ast_device_state_engine_init: Initialize the device state engine in separate thread */ int ast_device_state_engine_init(void) { - pthread_attr_t attr; - ast_cond_init(&change_pending, NULL); - pthread_attr_init(&attr); - pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED); - if (ast_pthread_create(&change_thread, &attr, do_devstate_changes, NULL) < 0) { + if (ast_pthread_create(&change_thread, NULL, do_devstate_changes, NULL) < 0) { ast_log(LOG_ERROR, "Unable to start device state change thread.\n"); return -1; } diff --git a/dnsmgr.c b/dnsmgr.c index 204033e15..bc577c852 100644 --- a/dnsmgr.c +++ b/dnsmgr.c @@ -1,7 +1,7 @@ /* * Asterisk -- An open source telephony toolkit. * - * Copyright (C) 2005, Kevin P. Fleming + * Copyright (C) 2005-2006, Kevin P. Fleming * * Kevin P. Fleming * @@ -342,9 +342,7 @@ static int do_reload(int loading) /* if this reload enabled the manager, create the background thread if it does not exist */ if (enabled && !was_enabled && (refresh_thread == AST_PTHREADT_NULL)) { - pthread_attr_init(&attr); - pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED); - if (ast_pthread_create(&refresh_thread, &attr, do_refresh, NULL) < 0) { + if (ast_pthread_create(&refresh_thread, NULL, do_refresh, NULL) < 0) { ast_log(LOG_ERROR, "Unable to start refresh thread.\n"); } else { -- cgit v1.2.3