From 6e3f3974e1bc405508906a198e4704ad534857a2 Mon Sep 17 00:00:00 2001 From: mmichelson Date: Tue, 24 Mar 2009 22:42:26 +0000 Subject: Merged revisions 184079 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r184079 | mmichelson | 2009-03-24 17:40:39 -0500 (Tue, 24 Mar 2009) | 15 lines Merged revisions 184078 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r184078 | mmichelson | 2009-03-24 17:34:45 -0500 (Tue, 24 Mar 2009) | 9 lines Change NULL pointer check to be ast_strlen_zero. The 'digit' variable is guaranteed to be non-NULL, so the if statement could never evaluate true. Changing to ast_strlen_zero makes the logic correct. This was found while reviewing ast_channel_ao2 code review. ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@184082 f38db490-d61c-443f-a65b-d21fe96a405b --- apps/app_senddtmf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/app_senddtmf.c b/apps/app_senddtmf.c index 05faf2221..9842c412e 100644 --- a/apps/app_senddtmf.c +++ b/apps/app_senddtmf.c @@ -106,7 +106,7 @@ static int manager_play_dtmf(struct mansession *s, const struct message *m) astman_send_error(s, m, "Channel not specified"); return 0; } - if (!digit) { + if (ast_strlen_zero(digit)) { astman_send_error(s, m, "No digit specified"); ast_channel_unlock(chan); return 0; -- cgit v1.2.3