From 12fcc41d8a608497bd40872831b6b76812d48372 Mon Sep 17 00:00:00 2001 From: mmichelson Date: Tue, 15 Sep 2009 15:13:06 +0000 Subject: Merged revisions 218499,218504 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r218499 | mmichelson | 2009-09-15 09:59:50 -0500 (Tue, 15 Sep 2009) | 3 lines Fix off-by-one error when reading SDP sent over TCP. ........ r218504 | mmichelson | 2009-09-15 10:05:53 -0500 (Tue, 15 Sep 2009) | 3 lines Ensure that SDP read from TCP socket is null-terminated. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@218507 f38db490-d61c-443f-a65b-d21fe96a405b --- channels/chan_sip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/channels/chan_sip.c b/channels/chan_sip.c index d7072dee1..58ba06f06 100644 --- a/channels/chan_sip.c +++ b/channels/chan_sip.c @@ -2818,10 +2818,11 @@ static void *_sip_tcp_helper_thread(struct sip_pvt *pvt, struct ast_tcptls_sessi if (sscanf(get_header(&reqcpy, "Content-Length"), "%30d", &cl)) { while (cl > 0) { ast_mutex_lock(&tcptls_session->lock); - if (!fread(buf, (cl < sizeof(buf)) ? cl : sizeof(buf), 1, tcptls_session->f)) { + if (!fread(buf, MIN(sizeof(buf) - 1, cl), 1, tcptls_session->f)) { ast_mutex_unlock(&tcptls_session->lock); goto cleanup; } + buf[sizeof(buf)-1] = '\0'; ast_mutex_unlock(&tcptls_session->lock); if (me->stop) goto cleanup; -- cgit v1.2.3