aboutsummaryrefslogtreecommitdiffstats
path: root/res
AgeCommit message (Collapse)AuthorFilesLines
2010-06-23Ensure a NULL file while debugging cannot crash AEL.tilghman4-4/+4
(closes issue #17215) Reported by: vazir Patches: 20100518__issue17215.diff.txt uploaded by tilghman (license 14) Tested by: tilghman git-svn-id: http://svn.digium.com/svn/asterisk/trunk@272260 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-22Resolve some errors that occur on a graceful shutdown.russell2-36/+43
Don't Finalize() if Initialize() did not succeed. This resulted in an error about trying to Finalize() an invalid handle. Also trim some trailing whitespace while in the area. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@271867 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-22Change the method of retrieving the Asterisk version string.russell1-3/+2
Using this method makes it so res_fax doesn't have to be rebuilt on every svn update. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@271833 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-21Conflict kqueue on OS X, since it doesn't work there yet, anyway.tilghman1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@271657 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-21Merged revisions 271552 via svnmerge from jpeeler1-46/+47
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r271552 | jpeeler | 2010-06-21 15:37:47 -0500 (Mon, 21 Jun 2010) | 7 lines Do not use sizeof to calculate size of a heap allocated character array. Change left out from 271399. (closes issue #16053) Reported by: diLLec ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@271554 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-21fixes logic error introduced by slin16 sip supportdvossel1-1/+2
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@271551 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-18Merged revisions 271399 via svnmerge from jpeeler1-20/+59
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r271399 | jpeeler | 2010-06-18 14:28:24 -0500 (Fri, 18 Jun 2010) | 11 lines Fix crash when parsing some heavily nested statements in AEL on reload. Due to the recursion used when compiling AEL in gen_prios, all the stack space was being consumed when parsing some AEL that contained nesting 13 levels deep. Changing a few large buffers to be heap allocated fixed the crash, although I did not test how many more levels can now be safely used. (closes issue #16053) Reported by: diLLec Tested by: jpeeler ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@271483 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-17adds support for slin16 in sipdvossel1-1/+1
(closes issue #16153) Reported by: kfister Patches: 16153-1.6.2.0-rc5.patch uploaded by kfister (license 912) slin16.sip.patch.1 uploaded by malcolmd (license 924) Tested by: kfister, malcolmd git-svn-id: http://svn.digium.com/svn/asterisk/trunk@271261 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-17adds speex 16khz audio supportdvossel1-0/+1
(closes issue #17501) Reported by: fabled Patches: asterisk-trunk-speex-wideband-v2.patch uploaded by fabled (license 448) Tested by: malcolmd, fabled, dvossel git-svn-id: http://svn.digium.com/svn/asterisk/trunk@271231 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-16addition of G.719 pass-through supportdvossel1-0/+1
(closes issue #16293) Reported by: malcolmd Patches: g719.passthrough.patch.7 uploaded by malcolmd (license 924) format_g719.c uploaded by malcolmd (license 924) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@270940 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-16MSG_OOB flag on HANGUP packet removed.pabelanger1-5/+5
Per Tilghman's request on IRC (#asterisk-bugs). (closes issue #17506) Reported by: brycebaril Tested by: pabelanger, tilghman git-svn-id: http://svn.digium.com/svn/asterisk/trunk@270936 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-15Don't send files twice and remove extra \r\n from headertwilson1-14/+3
After the manager http auth changes, we forgot to remove the manual sending of the file. Also, ast_http_send adds two \r\n to the header that is passed to it, so a trailing \r\n is removed from the Content-type header. It might be better to change ast_http_send, but I don't like changing the behavior of an API function. (closes issue #17239) Reported by: cjacobsen Patches: patch2.diff uploaded by cjacobsen (license 1029) Tested by: lathama, cjacobsen git-svn-id: http://svn.digium.com/svn/asterisk/trunk@270660 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-15Argh, mixed declarations and code.tilghman1-5/+8
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@270552 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-15Add distributed devicestate via the XMPP protocol.tilghman1-254/+1146
(closes issue #15757) Reported by: Marquis Patches: distributed_devstate-XMPP.txt uploaded by lmadsen (license 10) Tested by: Marquis, lmadsen, marcelloceschia Review: https://reviewboard.asterisk.org/r/351/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@270519 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-14Merged revisions 270331 via svnmerge from pabelanger1-4/+9
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r270331 | pabelanger | 2010-06-14 17:31:59 -0400 (Mon, 14 Jun 2010) | 14 lines Properly play first file in sort list. When using sort=alpha we would always skip the first file in the list first time through. We now check for that properly. (closes issue #17470) Reported by: pabelanger Patches: sort.aplha.patch uploaded by pabelanger (license 224) Tested by: lmadsen Review: https://reviewboard.asterisk.org/r/703/ ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@270332 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-09fixes crash in moh when cachertclasses flag is useddvossel1-1/+4
The result for moh_register was not verified to guarantee the mohclass as added to the container. (closes issue #16993) Reported by: dmitri Patches: res_musiconhold_rtclass2.patch uploaded by dmitri (license 1001) moh_crash2.diff uploaded by dvossel (license 671) Tested by: dmitri git-svn-id: http://svn.digium.com/svn/asterisk/trunk@269271 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-08Fix some doxygen warnings.lmadsen2-0/+3
(closes issue #17336) Reported by: snuffy Patches: doxygen-fixes1.diff uploaded by snuffy (license 35) Tested by: russell git-svn-id: http://svn.digium.com/svn/asterisk/trunk@268969 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-08Release list lock before returning on error.tilghman1-0/+2
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@268933 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-08Add SRTP support for Asterisktwilson3-18/+478
After 5 years in mantis and over a year on reviewboard, SRTP support is finally being comitted. This includes generic CHANNEL dialplan functions that work for getting the status of whether a call has secure media or signaling as defined by the underlying channel technology and for setting whether or not a new channel being bridged to a calling channel should have secure signaling or media. See doc/tex/secure-calls.tex for examples. Original patch by mikma, updated for trunk and revised by me. (closes issue #5413) Reported by: mikma Tested by: twilson, notthematrix, hemanshurpatel Review: https://reviewboard.asterisk.org/r/191/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@268894 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-07Avoid unloading res_smdi twice.tilghman1-0/+7
(closes issue #17237) Reported by: pabelanger git-svn-id: http://svn.digium.com/svn/asterisk/trunk@268653 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-01Use the correct ical.h filetwilson1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@266832 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-01Don't register functions until the last possible point, so they're not ↵tilghman1-12/+19
unloaded unnecessarily. (closes issue #15996) Reported by: junky Patches: sdmi_wait.diff uploaded by junky (license 177) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@266735 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-28Fix ical library handling (again)twilson2-2/+2
Newer versions of libical (which we require) store the header file in a libical/ subfolder and include an ical.h file that does a #warning for deprecation and then #includes <libical/ical.h>. Since we now test for libical/ical.h, we can change the #includes back to <libical/ical.h> and remove the test which specifically adds /usr/include/libical as an include directory. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@266386 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-26Remove unrelated MOH change from previous commit.mmichelson1-4/+0
Thanks Kevin! git-svn-id: http://svn.digium.com/svn/asterisk/trunk@266094 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-26Fix misspelling of macro args.mmichelson1-0/+4
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@266092 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-26Merged revisions 265910 via svnmerge from tilghman1-3/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r265910 | tilghman | 2010-05-26 11:21:00 -0500 (Wed, 26 May 2010) | 7 lines Not finding rows in the DB does not rise to the level of a warning. (closes issue #17062) Reported by: drookie Patches: 20100525__issue17062.diff.txt uploaded by tilghman (license 14) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@265923 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-26Construct socket name, according to the Postgres docs, and document as such.tilghman1-3/+3
(closes issue #17392) Reported by: dps Patches: 20100525__issue17392.diff.txt uploaded by tilghman (license 14) Tested by: dps git-svn-id: http://svn.digium.com/svn/asterisk/trunk@265894 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-26Ensure that libneon > 0.29.0 is installed for res_calendar_ewstwilson1-1/+1
This uses a modified version of pabelanger's patch that checks for NTLM support instead, which was added in 0.29.0 which is what is required for res_calendar_ews. (closes issue #17391) Reported by: loloski Patches: issue17391.patch.v2 uploaded by pabelanger (license 224) Tested by: twilson git-svn-id: http://svn.digium.com/svn/asterisk/trunk@265793 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-26Use configure to determine the prefixes and include directories properly.tilghman4-23/+23
This ensures cross-platform compatibility, even among Linux distributions, which don't always put headers in the same place. (closes issue #17391) Reported by: loloski git-svn-id: http://svn.digium.com/svn/asterisk/trunk@265747 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-24Calendaring support for Exchange Server 2007+ via EWStwilson2-0/+847
This commit adds support for calendaring with Exchange Server 2007+ via Exchange Web Services. Full write support and for querying attendees. Many thanks to Jan Kaláb for the feature. (closes issue #17022) Reported by: pitel Patches: res_calendar_ews.c uploaded by pitel (license 1008) Tested by: pitel, twilson Review: https://reviewboard.asterisk.org/r/557/ Review: https://reviewboard.asterisk.org/r/668/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@265317 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-21Log spandsp's fax debug output to the FAX logger level.mmichelson3-1/+18
Review: https://reviewboard.asterisk.org/r/658 git-svn-id: http://svn.digium.com/svn/asterisk/trunk@264953 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-19fixes crash during dtmfdvossel1-2/+3
During the processing of Cisco dtmf the dtmf samples were not being calculated correctly. In an attempt to determine what sample rate was being used, a NULL frame was processed which caused a crash. This patch resolves this. (closes issue #17248) Reported by: falves11 Patches: issue_17248.diff uploaded by dvossel (license 671) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@264114 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-18Make happy green color come backtilghman1-0/+2
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@263858 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-13For FreeBSDtilghman1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@262987 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-13Hmmm, probably should have read the manpage more thoroughly.tilghman1-3/+3
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@262940 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-13Add kqueue(2) implementation to Asterisk in various places.tilghman1-0/+390
This will save a considerable amount of CPU on the BSDs, including Mac OS X, as it eliminates several places in the code that we previously used a busy loop. Additionally, this adds a res_timing interface, using kqueue timers. Review: https://reviewboard.asterisk.org/r/543/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@262852 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-12Revert previous WARNING message removal.lmadsen1-1/+2
Marquis42 suggested a better method of doing what I wanted because I ended up removing the WARNING message for all instances when really I just wanted to remove it for the 'return' keyword, not everything. (issue #17145) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@262798 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-12Remove unnecessary WARNING message in ael/pval.clmadsen1-2/+0
(closes issue #17145) Reported by: okrief git-svn-id: http://svn.digium.com/svn/asterisk/trunk@262796 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-11Merged revisions 262421 via svnmerge from qwell1-2/+6
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r262421 | qwell | 2010-05-11 14:55:42 -0500 (Tue, 11 May 2010) | 11 lines Use a less silly method for modifying a flex-generated file. The sed syntax that was used wasn't actually valid, causing some versions to choke. This is the method that is used in 1.6.x+ for similar changes. (closes issue #16696) Reported by: bklang Patches: 16696-sedfix.diff uploaded by qwell (license 4) Tested by: qwell ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@262422 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-30Merged revisions 260345 via svnmerge from mmichelson1-3/+14
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r260345 | mmichelson | 2010-04-30 15:08:15 -0500 (Fri, 30 Apr 2010) | 18 lines Fix potential crash from race condition due to accessing channel data without the channel locked. In res_musiconhold.c, there are several places where a channel's stream's existence is checked prior to calling ast_closestream on it. The issue here is that in several cases, the channel was not locked while checking the stream. The result was that if two threads checked the state of the channel's stream at approximately the same time, then there could be a situation where both threads attempt to call ast_closestream on the channel's stream. The result here is that the refcount for the stream would go below 0, resulting in a crash. I have added proper channel locking to res_musiconhold.c to ensure that we do not try to check chan->stream without the channel locked. A Digium customer has been using this patch for several weeks and has not had any crashes since applying the patch. ABE-2147 ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@260346 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-27Fix compile on systems without HAVE_NULLSAFE_PRINTF defined.qwell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@259617 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-26Update res_fax and res_fax_spandsp to be compatible with Fax For Asterisk 1.2.mnicholson2-289/+613
The fax session initilization code for T.38 faxes has been rewritten. T.38 session initialization was removed from generic_fax_exec, and split into two different code paths for receive and send. Also the 'z' option (to send a T.38 reinvite if we do not receive one) was added to sendfax. In the output of 'fax show sessions', the 'Type' column has been renamed to 'Tech' and replaced with a new 'Tech' column that will report 'G.711' or 'T.38'. Control of ECM defaults has been added to res_fax A 'fax show settings' CLI command has been added. Support of the new AST_T38_REQUEST_PARMS control method request to handle channels that have already received a T.38 reinvite before the FAX application is start has been added. Support for the 'fax show settings' command has been added to res_fax_spandsp and handling of the ECM flag has been slightly altered. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@258896 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-25Merged revisions 258775 via svnmerge from tilghman1-0/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r258775 | tilghman | 2010-04-25 13:09:05 -0500 (Sun, 25 Apr 2010) | 6 lines When StopMonitor is called, ensure that it will not be restarted by a channel event. (closes issue #16590) Reported by: kkm Patches: resmonitor-16590-trunk.239289.diff uploaded by kkm (license 888) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@258776 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-22Remove ABI differences that occured when compiling with DEBUG_THREADS.qwell1-12/+0
"Bad Things" would happen if Asterisk was compiled with DEBUG_THREADS, but a loaded module was not (or vice versa). This also immensely simplifies the lock code, since there are no longer 2 separate versions of them. Review: https://reviewboard.asterisk.org/r/508/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@258557 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-21Fix the \brief description in the res_calendar_*.c files.lmadsen3-3/+3
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@258265 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-21Added MixMonitorMute manager commandjmls1-13/+0
Added a new manager command to mute/unmute MixMonitor audio on a channel. Added a new feature to audiohooks so that you can mute either read / write (or both) types of frames - this allows for MixMonitor to mute either side of the conversation without affecting the conversation itself. (closes issue #16740) Reported by: jmls Review: https://reviewboard.asterisk.org/r/487/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@258190 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-03Consolidate ast_channel.cid.cid_rdnis into ast_channel.redirecting.from.number.rmudgett2-3/+3
SWP-1229 ABE-2161 * Ensure chan_local.c:local_call() will not leak cid.cid_dnid when copying. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@256104 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-02Allow symbol export filtering to work properly on platforms that have symbol ↵kpfleming23-164/+164
prefixes. Some platforms prefix externally-visible symbols in object files generated from C sources (most commonly, '_' is the prefix). On these platforms, the existing symbol export filtering process ends up suppressing all the symbols that are supposed to be left visible. This patch allows the prefix string to be supplied to the top-level Makefile in the LINKER_SYMBOL_PREFIX variable, and then generates the linker scripts as required to include the prefix supplied. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@255906 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-25Recorded merge of revisions 254452 via svnmerge from mmichelson1-13/+37
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r254452 | mmichelson | 2010-03-25 10:59:56 -0500 (Thu, 25 Mar 2010) | 44 lines Several fixes regarding RFC2833 DTMF detection. Here is a copy and paste of the details from my request on reviewboard that dealt with these changes: Fix 1. The first change in place is to fix Mantis issue 15811, which deals with a situation where Asterisk will incorrectly interpret out of order RFC2833 frames as duplicate DTMF digits. For instance, we would receive a sequence like: seqno 1: DTMF 1 seqno 2: DTMF 1 seqno 3: DTMF 1 seqno 4: DTMF 1 seqno 6: DTMF 1 (end) seqno 5: DTMF 1 seqno 7: DTMF 1 (end) seqno 8: DTMF 1 (end) Prior to this patch when we received the frame with seqno 5, we would interpret this as a new DTMF 1. With this patch, we will check the seqno of the incoming digit and not process the frame if the seqno is lower than the last recorded seqno. Note that we do not record the seqno of the dropped DTMF frame for future processing. While the above situation is what was designed to be fixed, the patch is written in such a way that the following would also be fixed too: seqno 9: DTMF 1 seqno 10: DTMF 1 (end) seqno 11: DTMF 1 (end) seqno 13: DTMF 2 seqno 12: DTMF 1 (end) seqno 14: DTMF 2 seqno 15: DTMF 2 (end) seqno 16: DTMF 2 (end) seqno 17: DTMF 2 (end) In this second situation, the beginning of the DTMF 2 arrives before the final end frame of the DTMF 1. With the patch, seqno 12 is no processed and thus we properly interpret the DTMF. Fix 2. The second change in place is to fix an issue like the following: seqno 1: DTMF 1 seqno 2: DTMF 1 seqno 3: DTMF 1 (end) *packet lost* seqno 4: DTMF 1 (end) *packet lost* seqno 5: DTMF 1 (end) *packet lost* seqno 6: DTMF 2 When we receive seqno 6, we had code in place that was supposed to properly end the previously unended DTMF 1. The problem was that the code was essentially a no-op. The code would set up an end frame for the DTMF 1 but would immediately overwrite the frame with the begin for DTMF 2. I changed process_dtmf_rfc2833() so that instead of returning a single frame, it is given as an output parameter a list of frames. Each frame that needs to be returned is appended to this list. Fix 3. The final change is a minor one where an AST_CONTROL_SRCCHANGE frame could get lost. If we process a cisco DTMF or an RFC 3389 frame and no frame was returned, then we would return &ast_null_frame. The problem is that earlier in the function, we may have generated an AST_CONTROL_SRCCHANGE frame and put it in the list of frames we wish to return. This frame would be lost in such a case. The patch fixes this problem ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@254454 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-25Improve handling of T.38 re-INVITEs that arrive before a T.38-capablekpfleming1-38/+63
application is executing on a channel. This patch addresses an issue found during working with end-users using res_fax. If an incoming call is answered in the dialplan, or jumps to the 'fax' extension due to reception of a CNG tone (with faxdetect enabled), and then the remote endpoint sends a T.38 re-INVITE, it is possible for the channel's T.38 state to be 'T38_STATE_NEGOTIATING' when the application starts up. Unfortunately, even if the application wants to use T.38, it can't respond to the peer's negotiation request, because the AST_CONTROL_T38_PARAMETERS control frame that chan_sip sent originally has been lost, and the application needs the content of that frame to be able to formulate a reply. This patch adds a new 'request' type to AST_CONTROL_T38_PARAMETERS, AST_T38_REQUEST_PARMS. If the application sends this request, chan_sip will re-send the original control frame (with AST_T38_REQUEST_NEGOTIATE as the request type), and the application can respond as normal. If this occurs within the five second timeout in chan_sip, the automatic cancellation of the peer reinvite will be stopped, and the application will 'own' the negotiation process from that point onwards. This also improves the code path in chan_sip to allow sip_indicate(), when called for AST_CONTROL_T38_PARAMETERS, to be able to return a non-zero response, which should have been in place before since the control frame *can* fail to be processed properly. It also modifies ast_indicate() to return whatever result the channel driver returned for this control frame, rather than converting all non-zero results into '-1'. Finally, the new request type intentionally returns a positive value, so that an application that sends AST_T38_REQUEST_PARMS can know for certain whether the channel driver accepted it and will be replying with a control frame of its own, or whether it was ignored (if the sip_indicate()/ast_indicate() path had properly supported failure responses before, this would not be necessary). This patch also modifies res_fax to take advantage of the new request. In addition, this patch makes sip_t38_abort() actually lock the private structure before doing its work... bad programmer, no donut. This patch also enhances chan_sip's 'faxdetect' support to allow triggering on T.38 re-INVITEs received as well as CNG tone detection. Review: https://reviewboard.asterisk.org/r/556/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@254450 f38db490-d61c-443f-a65b-d21fe96a405b
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-02 09:07:50 +0000