aboutsummaryrefslogtreecommitdiffstats
path: root/pbx
AgeCommit message (Collapse)AuthorFilesLines
2007-11-07In response to 10578, I just ran 1.4 thru valgrind; some of the config ↵murf1-2/+5
leakage I've already fixed, but it doesn't hurt to double check. I found and fixed leaks in res_jabber, cdr_tds, pbx_ael. Nothing major, tho. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89088 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-31closes issue #11108 -- where the 'dialplan save' cli command saves a file ↵murf1-1/+1
where the semicolon is not escaped. Fixed this; User also wanted comments to be preserved across dialplan save, but this is impossible at this point in time, because comments are not stored in the dialplan. They are 'compiled' out of extensions.conf. The only way to preserve those comments is to use the config file reader/writer that the GUI uses to allow online user edits. extensions.conf is first and foremost, a config file, and is read in by the normal config-file reading routines. Then, it is processed into a dialplan (context/exten structs). git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@87849 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-31Included some verbage in the check_includes func, to inform the user that ↵murf1-2/+3
included contexts that have no match in the AEL, might be OK, as AEL cannot check in the extensions.conf or the in-memory contexts, as they may not be there at the time of the check. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@87775 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-26closes issue #11086 where a user complains that references to following ↵murf8-1071/+1090
contexts report a problem; The problem was REALLy that he was referring to empty contexts, which were being ignored. Reporter stated that empty contexts should be OK. I checked it out against extensions.conf, and sure enough, empty contexts ARE ok. So, I removed the restriction from AEL. This, though, highlighted a problem with multiple contexts of the same name. This should be OK, also. So, I added the extend keyword to AEL, and it can preceed the 'context' keyword (mixed with 'abstract', if nec.). This will turn off the warnings in AEL if the same context name is used 2 or more times. Also, I now call ast_context_find_or_create for contexts now, instead of just ast_context_create; I did this because pbx_config does this. The 'extend' keyword thus becomes a statement of intent. AEL can now duplicate the behavior of pbx_config, git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@87168 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-24closes issue #11037 -- unable to specify app:spec in hint argumentsmurf2-401/+415
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@86936 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-22Fix tab completion for dundi show peer.file1-1/+3
(closes issue #11041) Reported by: jsmith Patches: asterisk-dundicomplete.diff.txt uploaded by jamesgolovich (license 176) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@86661 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-15Ensure the buffer passed to ast_canmatch_extension() is properly initialized sorussell1-2/+2
that it is null terminated. (issue #10977) Reported by: dimas Patches: pbxdundi.patch uploaded by dimas (license 88) - small mods by me git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@85556 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-14Don't create the context for users in users.conf until we know at least one ↵russell1-4/+11
user exists. (closes issue #10971) Reported by: dimas Patches: pbxconfig.patch uploaded by dimas (license 88) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@85540 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-12Fix the potential use of an uninitialized buffer in a log message.russell1-2/+4
(closes issue #10958) Reported by: dimas Patches: realtime.patch uploaded by dimas (license 88) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@85515 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-03closes issue #10870 ; where a CUT() function call in a switch expr doesn't ↵murf1-8/+29
execute correctly, because the commas in the function args are not converted to vertbars before the func is called. I modified just the switch code to convert the commas to vertbars if there, but if more of these sort of probs are found, I may have to resort to something a little more fundamental. We'll see, I guess. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@84544 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-03closes issue #10834 ; where a null input to a switch statement results in a ↵murf9-52/+158
hangup; since switch is implemented with extensions, and the default case is implemented with a '.', and the '.' matches 1 or more remaining characters, the case where 0 characters exist isn't matched, and the extension isn't matched, and the goto fails, and a hangup occurs. Now, when a default case is generated, it also generates a single fixed extension that will match a null input. That extension just does a goto to the default extension for that switch. I played with an alternate solution, where I just tack an extra char onto all the patterns and the goto, but not the default case's pattern. Then even a null input will still have at least one char in it. But it made me nervous, having that extra char in , even if that's a pretty secret and low-level issue. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@84511 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-01Anything to keep gcc 4.2 happy...murf1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@84273 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-01closes issue #10777 -- by returning a null for the parse tree when there's ↵murf3-5/+7
really nothing there, and making sure we don't try to do checking on a null tree. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@84239 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-29This is a regression update that matches what I did in 84134 for AEL ↵murf16-44/+174
regressions. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@84135 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-29This issue sort of closes 10786; All config files support #include with ↵murf2-180/+349
globbing (you know, *,[chars],?,{list,list},etc), so I've updated the AEL system to support this also. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@84133 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-27remove a todo item that has been completedrussell1-2/+0
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@83976 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-22This closes issue #10788 -- The exact same fixes are made here for the first ↵murf1-3/+38
arg in the for(arg1; arg2; arg3) {} statement, as were done for the 3rd arg. It can now be an assignment that will embedded in a Set() app, or a macro call, or an app call. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@83589 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-22This closes issue #10788 -- the 3rd arg in the for statement is now wrapped ↵murf1-5/+40
in Set() only if there's an '=' in that string. Otherwise, if it begins with '&', then a Macro call is generated; otherwise it is made into an app call. A bit more accomodating, keeps the new guys happy, and the guys with ael-1 code should be happy, too git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@83558 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-21gcc 4.2 has a new set of warnings dealing with cosnt pointers. This set ofrussell3-20/+18
changes gets all of Asterisk (minus chan_alsa for now) to compile with gcc 4.2. (closes issue #10774, patch from qwell) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@83432 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-18When copying the contents from the wildcard peer, do a deep copy instead ofrussell1-1/+31
shallow copy so that it doesn't crash when beging destroyed. (closes issue #10546, patch by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82802 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-13Fix a small typo.qwell1-1/+1
retrytime > waittime git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82358 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-11The sample dundi.conf claims support for a wildcard peer entry - [*], but therussell1-3/+34
code did not support it. This patch makes it work. (closes issue #10546, patch by dds, with some changes by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82250 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-11(closes issue #10577)file1-0/+5
Reported by: jamesgolovich Patches: asterisk-dundifree.diff.txt uploaded by jamesgolovich (license 176) Don't leak memory when unloading DUNDi. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82243 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-28revert unintentional changes in rev 81226russell1-5/+0
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81228 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-28Add Russian tones. (closes issue #7953, hanabana)russell1-0/+5
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81226 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-27Add a \todo to note that this module leaks most of the memory it allocates onrussell1-0/+1
unload and should be fixed (when I'm not in the middle of something else ...). git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81074 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-27explicity define a variable as a booleanrussell1-1/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81065 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-24backport of 80649, a fix to an unreported problem in the ael parser, that ↵murf3-236/+230
results in a crash on a 64bit machine git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@80689 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-13memset really, really needs to be used here.murf1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@79363 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-13This patch fixes bug 10411. I added a new regression test, some regression ↵murf9-129/+193
test cleanups git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@79255 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-10From a user complaint on #asterisk, I have forced pbx_spool to explain what ↵murf1-1/+1
reason codes mean, when they are logged git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@79099 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-18Backport GCC 4.2 fixes. Without these Asterisk won't build under devmode ↵file1-1/+1
using GCC 4.2. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@75712 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-18(closes issue #10224)file1-6/+7
Reported by: irroot Record the threadid of each running thread before shutting them down as the thread themselves may change the value. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@75583 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-09Few minor thread synchronization tweaks. (issue #10124 reported by gzero)file1-4/+13
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@74045 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-09Add a few sanity checks when writing out the dialplan. (issue #10157 ↵file1-2/+2
reported by dome) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@73930 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-01Merged revisions 72805 via svnmerge from russell1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r72805 | russell | 2007-07-01 18:51:34 -0500 (Sun, 01 Jul 2007) | 5 lines When appending lines to call files to keep track of retries, write a leading newline just in case the original call file did not have a newline at the end. This fix is in response to a problem I saw reported on the asterisk-users mailing list. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@72806 f38db490-d61c-443f-a65b-d21fe96a405b
2007-06-27Merged revisions 72267 via svnmerge from russell1-0/+2
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r72267 | russell | 2007-06-27 16:06:45 -0500 (Wed, 27 Jun 2007) | 5 lines Fix a minor issue with parsing the priority number. You could have as much whitespace as you want around a numeric priority, but you couldn't have any whitespace around a special priority like "n" or "hint". (issue #10039, reported by mitheloc, fixed by me) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@72272 f38db490-d61c-443f-a65b-d21fe96a405b
2007-06-27Make unloading of pbx_dundi actually work.file1-2/+15
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@72006 f38db490-d61c-443f-a65b-d21fe96a405b
2007-06-11"dialplan save" produced garbage in the config filetilghman1-8/+19
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@68595 f38db490-d61c-443f-a65b-d21fe96a405b
2007-06-05this fixes bug 9883, wherein macros were not allowing the includes ↵murf3-231/+270
construct. fixed and tested, looks OK. Now includes can serve as an adjunct to catch. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@67526 f38db490-d61c-443f-a65b-d21fe96a405b
2007-06-05Added code to automatically add a default case to switches that don't have ↵murf1-0/+27
one. In some cases, rather than fall thru, it results in a goto with -1 result, which terminates the extension; a sort of dialplan seqfault, sort of. This was required to fix bug reported in 9881 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@67420 f38db490-d61c-443f-a65b-d21fe96a405b
2007-05-03updated the ael regressions to match what's in trunkmurf6-14/+456
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@62913 f38db490-d61c-443f-a65b-d21fe96a405b
2007-05-03These mods fix bug 9623, where an '@' in the eswitch contents causes a ↵murf8-1176/+1185
syntax error. I also updated the regressions. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@62883 f38db490-d61c-443f-a65b-d21fe96a405b
2007-04-02continue in for-loop should go to the incrementer, not the test. As per ↵murf1-1/+1
9435, thanks to marcelbarbulescu git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@59688 f38db490-d61c-443f-a65b-d21fe96a405b
2007-03-27via 9373 (duplicate context in AEL crashes asterisk), kpfleming pointed on ↵murf1-1/+1
asterisk-dev, that DECLINE in this case the proper thing to do. This change now has it doing the proper thing. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@59261 f38db490-d61c-443f-a65b-d21fe96a405b
2007-03-26fix for 9373 (duplicate context in AEL crashes asterisk). I turned a ↵murf1-3/+3
duplicate context from a WARNING to an ERROR. Now you get a module load failure, and asterisk just exits. That's better than a crash, right\? git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@59228 f38db490-d61c-443f-a65b-d21fe96a405b
2007-03-26A fix for the flex input files, DONT_COMPILE, and STANDALONE_AELmurf2-6/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@59206 f38db490-d61c-443f-a65b-d21fe96a405b
2007-03-26Have ast_copy_string magically appear in the aelparse binary! DONT_OPTIMIZE ↵file1-0/+4
should now work once again. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@59200 f38db490-d61c-443f-a65b-d21fe96a405b
2007-03-20The fix for the AEL <<security hole>> (bug 9316) is here...murf1-11/+16
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@59069 f38db490-d61c-443f-a65b-d21fe96a405b
2007-03-03Updated the regression testsmurf4-35/+41
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@57707 f38db490-d61c-443f-a65b-d21fe96a405b