aboutsummaryrefslogtreecommitdiffstats
path: root/pbx/pbx_spool.c
AgeCommit message (Collapse)AuthorFilesLines
2010-01-20Modify fix for issue 16554 to be more inline with what is already in trunk.seanbright1-8/+9
I should have taken a closer look at trunk/1.6.x, as this bug has already been fixed in a much more simple manner, by just settings o->vars to NULL after the ast_pbx_outgoing_* calls. (issue #16554) Reported by: mav3rick git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@241544 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-20Fix a memory leak in pbx_spool when using SetVar in a call file.seanbright1-7/+10
In pbx_spool, when we are freeing our 'outgoing' struct, we weren't deallocating the ast_variable list we had built from SetVars in a call file. Adding a call to ast_variables_destroy in our deallocation routine works, but only if the variables have not already been passed into ast_pbx_outgoing_app() or _exten(), both of which take care of destroying the variable list for us. (closes issue #16554) Reported by: mav3rick Patches: issue16554_20100119.patch uploaded by seanbright (license 71) Tested by: mav3rick git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@241543 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-10AST-2009-005tilghman1-5/+5
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@211528 f38db490-d61c-443f-a65b-d21fe96a405b
2009-06-03Fix a possible crash in pbx_spool.seanbright1-3/+3
We were trying to reference members of a struct that had previously been freed. This patch makes sure that we free the struct after it has been removed from the spooler queue. (closes issue #15072) Reported by: garlew Patches: spool.diff uploaded by garlew (license 376) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@198957 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-03If an entry is added to the directory during a scan when another entry expires,tilghman1-2/+6
then that new entry will not be processed promptly, but must wait for either a future entry to start or a current entry's retry to occur. If no other entries exist in the directory (other than the new entries) when a bunch expire, then the new entries must wait until another new entry is added to be processed. This was a rather weird race condition, really. Fixes AST-147. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@160558 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-03Don't start scanning the directory until all modules are loaded, because sometilghman1-1/+8
required modules (channels, apps, functions) may not yet be in memory yet. Fixes AST-149. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@160551 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-31Specify codecs in callfiles and manager, to allow video calls to be set uptilghman1-2/+7
from callfiles and AMI. (closes issue #9531) Reported by: Geisj Patches: 20080715__bug9531__1.4.diff.txt uploaded by Corydon76 (license 14) 20080715__bug9531__1.6.0.diff.txt uploaded by Corydon76 (license 14) Tested by: Corydon76 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134976 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-18Set the variables top-down, so that if a script sets a variable more than once,tilghman1-3/+12
the last one will take precedence. (closes issue #12673) Reported by: phber Patches: 20080519__bug12673.diff.txt uploaded by Corydon76 (license 14) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@123710 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-21Revert accidental commit of the last changetilghman1-12/+3
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@117523 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-21Strip the preamble from the output also when -rx is not being usedtilghman1-3/+12
(Related to issue #12702) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@117519 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-13Fix a small typo.qwell1-1/+1
retrytime > waittime git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82358 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-10From a user complaint on #asterisk, I have forced pbx_spool to explain what ↵murf1-1/+1
reason codes mean, when they are logged git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@79099 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-01Merged revisions 72805 via svnmerge from russell1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r72805 | russell | 2007-07-01 18:51:34 -0500 (Sun, 01 Jul 2007) | 5 lines When appending lines to call files to keep track of retries, write a leading newline just in case the original call file did not have a newline at the end. This fix is in response to a problem I saw reported on the asterisk-users mailing list. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@72806 f38db490-d61c-443f-a65b-d21fe96a405b
2007-01-31Merged revisions 53045 via svnmerge from russell1-0/+2
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r53045 | russell | 2007-01-31 15:25:11 -0600 (Wed, 31 Jan 2007) | 3 lines Fix a bunch of places where pthread_attr_init() was called, but pthread_attr_destroy() was not. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@53046 f38db490-d61c-443f-a65b-d21fe96a405b
2006-11-27Merged revisions 48037 via svnmerge from file1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r48037 | file | 2006-11-27 10:30:37 -0500 (Mon, 27 Nov 2006) | 2 lines Do not reference the freed outgoing structure in the debug message. (issue #8425 reported by arkadia) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@48038 f38db490-d61c-443f-a65b-d21fe96a405b
2006-10-25apparently developers are still not aware that they should be use ↵kpfleming1-7/+7
ast_copy_string instead of strncpy... fix up many more users, and fix some bugs in the process git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@46200 f38db490-d61c-443f-a65b-d21fe96a405b
2006-10-04update thread creation code a bitkpfleming1-1/+1
reduce standard thread stack size slightly to allow the pthreads library to allocate the stack+data and not overflow a power-of-2 allocation in the kernel and waste memory/address space add a new stack size for 'background' threads (those that don't handle PBX calls) when LOW_MEMORY is defined git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@44378 f38db490-d61c-443f-a65b-d21fe96a405b
2006-08-21merge new_loader_completion branch, including (at least):kpfleming1-13/+3
- restructured build tree and makefiles to eliminate recursion problems - support for embedded modules - support for static builds - simpler cross-compilation support - simpler module/loader interface (no exported symbols) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@40722 f38db490-d61c-443f-a65b-d21fe96a405b
2006-06-07simplify autoconfig include mechanism (make tholo happy he can use lint ↵kpfleming1-4/+4
again :-) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@32846 f38db490-d61c-443f-a65b-d21fe96a405b
2006-05-25Add Archive option to call files and add documentation on them. (issue #5426 ↵file1-13/+61
reported by ezio - props to blitzrage for proof reading the documentation) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@30299 f38db490-d61c-443f-a65b-d21fe96a405b
2006-05-19Make the new behavior where the timestamp is checked on the call file beforerussell1-6/+29
deleting it optional, defaulting to the old behavior, where it is always deleted (issue #6750, jcollie) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@28832 f38db490-d61c-443f-a65b-d21fe96a405b
2006-05-19only delete call files if the timestamp on the file is not in the future, sorussell1-1/+5
that a call file can be reused (issue #6750, patch by moy, committed patch is slightly simplified) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@28705 f38db490-d61c-443f-a65b-d21fe96a405b
2006-05-08 use pid_t instead of long for pid variables. #7099 (casper)bweschke1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@25488 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-14This rather large commit changes the way modules are loaded. rizzo1-11/+7
As partly documented in loader.c and include/asterisk/module.h, modules are now expected to return all of their methods and flags into a structure 'mod_data', and are normally loaded with RTLD_NOW | RTLD_LOCAL, so symbols are resolved immediately and conflicts should be less likely. Only in a small number of cases (res_*, typically) modules are loaded RTLD_GLOBAL, so they can export symbols. The core of the change is only the two files loader.c and include/asterisk/module.h, all the rest is simply adaptation of the existing modules to the new API, a rather mechanical (but believe me, time and finger-consuming!) process whose detail you can figure out by svn diff'ing any single module. Expect some minor compilation issue after this change, please report it on mantis http://bugs.digium.com/view.php?id=6968 so we collect all the feedback in one place. I am just sorry that this change missed SVN version number 20000! git-svn-id: http://svn.digium.com/svn/asterisk/trunk@20003 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-08since the module API is changing, it's a good time to const-ify the ↵kpfleming1-2/+2
description() and key() return values git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18552 f38db490-d61c-443f-a65b-d21fe96a405b
2006-02-24Reverting revision 10998 that was accidentaly committed to trunk. My apologies.oej1-4/+4
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@10989 f38db490-d61c-443f-a65b-d21fe96a405b
2006-02-24Update to trunkoej1-4/+4
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@10988 f38db490-d61c-443f-a65b-d21fe96a405b
2006-02-11Merged revisions 9581 via svnmerge from russell1-7/+6
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r9581 | russell | 2006-02-11 13:15:00 -0500 (Sat, 11 Feb 2006) | 2 lines now that CDR is a loadable module, don't depend on it elsewhere (issue #6460) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@9582 f38db490-d61c-443f-a65b-d21fe96a405b
2006-01-09Merged revisions 7908 via svnmerge fromtilghman1-1/+2
/branches/1.2 git-svn-id: http://svn.digium.com/svn/asterisk/trunk@7909 f38db490-d61c-443f-a65b-d21fe96a405b
2006-01-07Merged revisions 7848 via svnmerge fromtilghman1-4/+6
/branches/1.2 git-svn-id: http://svn.digium.com/svn/asterisk/trunk@7849 f38db490-d61c-443f-a65b-d21fe96a405b
2005-11-29git-svn-id: http://svn.digium.com/svn/asterisk/trunk@7221 ↵kpfleming1-0/+0
f38db490-d61c-443f-a65b-d21fe96a405b
2005-11-20Make conform to coding guidelines... thanks drumkilla :)twisted1-4/+2
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@7145 f38db490-d61c-443f-a65b-d21fe96a405b
2005-11-20issue #5806twisted1-4/+9
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@7143 f38db490-d61c-443f-a65b-d21fe96a405b
2005-10-24Doxygen documentation update from oej (issue #5505)russell1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6847 f38db490-d61c-443f-a65b-d21fe96a405b
2005-10-12Back out improper freeing of variablesmarkster1-6/+0
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6751 f38db490-d61c-443f-a65b-d21fe96a405b
2005-10-11allow semicolons to be escaped in call files (issue #5407)russell1-3/+11
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6742 f38db490-d61c-443f-a65b-d21fe96a405b
2005-10-11Fix memory leak in outbound calls (bug #5406, with mods)markster1-6/+16
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6741 f38db490-d61c-443f-a65b-d21fe96a405b
2005-09-14update MANY more files with proper copyright/license info (thanks Ian!)kpfleming1-5/+16
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6596 f38db490-d61c-443f-a65b-d21fe96a405b
2005-07-15Allow manager originate to specifiy more than one variable to be set.russell1-11/+19
Allow manager originate and spool files to set writable dialplan functions, including those that use the pipe symbol to seperate arguments. Allow CDR dialplan function to be able to set the account code and userfield. This deprecates the use of the Account header in manager originate and spool files, as well as the SetAccount and SetCDRUserField applications. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6147 f38db490-d61c-443f-a65b-d21fe96a405b
2005-07-15fix some indentationrussell1-83/+83
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6130 f38db490-d61c-443f-a65b-d21fe96a405b
2005-07-07make CLI output use singular/plural when appropriate (bug #4654)kpfleming1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6047 f38db490-d61c-443f-a65b-d21fe96a405b
2005-06-06more file version tagskpfleming1-9/+13
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@5866 f38db490-d61c-443f-a65b-d21fe96a405b
2005-06-06major Makefile and build process improvements, including removal of all ↵kpfleming1-1/+1
hardcoded paths (modules must now use run-time paths as they should) (bug #4116) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@5855 f38db490-d61c-443f-a65b-d21fe96a405b
2005-04-21use double-quotes instead of angle-brackets for non-system include files ↵kpfleming1-10/+10
(bug #4058) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@5490 f38db490-d61c-443f-a65b-d21fe96a405b
2005-04-01optimize file reading in pbx_spool (bug #3927)kpfleming1-4/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@5351 f38db490-d61c-443f-a65b-d21fe96a405b
2005-04-01Fix spool files that lack their last returnmarkster1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@5332 f38db490-d61c-443f-a65b-d21fe96a405b
2005-02-02Include uniqueid in response for ManagerOriginate stuff (bug #3439)markster1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@4948 f38db490-d61c-443f-a65b-d21fe96a405b
2005-01-21update copyright headers for 2005russell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@4868 f38db490-d61c-443f-a65b-d21fe96a405b
2004-10-02Huge callerid rework (might break H.323, others)markster1-5/+7
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@3874 f38db490-d61c-443f-a65b-d21fe96a405b
2004-08-08Merge BSD stack size work (bug #2067)markster1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@3596 f38db490-d61c-443f-a65b-d21fe96a405b