aboutsummaryrefslogtreecommitdiffstats
path: root/main
AgeCommit message (Collapse)AuthorFilesLines
2010-02-01Revert previous chan_local fix (r236981) and fix instead by destroying ↵tilghman1-15/+15
expired frames in the queue. (closes issue #16525) Reported by: kobaz Patches: 20100126__issue16525.diff.txt uploaded by tilghman (license 14) 20100129__issue16525__1.6.0.diff.txt uploaded by tilghman (license 14) Tested by: kobaz, atis (closes issue #16581) Reported by: ZX81 (closes issue #16681) Reported by: alexr1 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@244070 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-27Use a safe list traversal while checking for duplicate vars in ↵mmichelson1-2/+3
pbx_builtin_setvar_helper. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@243486 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-26Remove unnecessary code in ast_read as issue 16058 has been fully solved now.jpeeler1-13/+0
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@243258 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-25Err, and use the new menuselect define, too.tilghman1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@242969 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-25Restore FreeBSD to able-to-compile-ish-modetilghman1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@242852 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-25Remove debugging that indeed should have been gone before commit. Sorry.oej1-3/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@242851 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-25Report error when writing to functions returns error in AMI setvar actionoej1-3/+14
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@242850 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-25Buildbot pointed out an error (thanks, buildbot!)tilghman1-4/+4
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@242728 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-25Oops, should have used CMD_PREFIX, not ECHO_PREFIX, for the commands.tilghman1-4/+4
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@242723 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-25Make the build of the Asterisk expression parser match that of the AEL parser.tilghman1-5/+15
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@242683 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-22Add Dialed Number Identifier (DNID) field to cdr.alecdavis1-0/+1
Branch support, retains ABI, if backend CDR collector is adaptive then database requires 'dnid' field to be added, otherwise no functional changes. Reported by: alecdavis Tested by: alecdavis Patch cdr_dnid.diff2.txt uploaded by alecdavis (license 585) Review: https://reviewboard.asterisk.org/r/455/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@242142 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-20Update CDR variables as pbx startsalecdavis1-0/+4
Allows CDR variables added in cdr.c:set_one_cid to become visable during the call, by executing ast_cdr_update() early in __ast_pbx_run. Based on cdr_update.diff3.txt (issue #16638) Reported by: alecdavis Patches: cdr_update.diff3.txt uploaded by alecdavis (license 585) Tested by: alecdavis git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@241458 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-18Plug a memory leak when reading configs with their comments.seanbright1-8/+15
While reading through configuration files with the intent of returning their full contents (comments specifically) we allocated some memory and then forgot to free it. This doesn't fix 16554 but clears up a leak I had in the lab. (issue #16554) Reported by: mav3rick Patches: issue16554_20100118.patch uploaded by seanbright (license 71) Tested by: seanbright git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@241015 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-13add silence gen to wait appsdvossel1-7/+25
asterisk.conf's 'transmit_silence' option existed before this patch, but was limited to only generating silence while recording and sending DTMF. Now enabling the transmit_silence option generates silence during wait times as well. To achieve this, ast_safe_sleep has been modified to generate silence anytime no other generators are present and transmit_silence is enabled. Wait apps not using ast_safe_sleep now generate silence when transmit_silence is enabled as well. (closes issue 0016524) Reported by: kobaz (closes issue 0016523) Reported by: kobaz Tested by: dvossel Review: https://reviewboard.asterisk.org/r/456/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@239718 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-09-1 is interpreted as an error, intead of the maximum mask.tilghman1-1/+1
(closes issue #16241) Reported by: vnovy Patches: manager.c.patch uploaded by vnovy (license 922) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@238915 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-08Properly calculate the remaining space in the output string when reducing ↵mnicholson1-4/+7
format strings. (closes issue #16560) Reported by: goldwein git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@238629 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-05Change a NOTICE log message to DEBUG where it belongs.russell1-1/+3
(closes issue #16479) Reported by: alexrecarey (closes SWP-577) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@237697 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-04Bounds checking for input stringtilghman1-25/+25
(closes issue #16407) Reported by: qwell Patches: 20100104__issue16407.diff.txt uploaded by tilghman (license 14) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@237573 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-04Regression in issue #15421 - Pattern matchingtilghman1-22/+20
(closes issue #16482) Reported by: wdoekes Patches: astsvn-16482-betterfix.diff uploaded by wdoekes (license 717) 20091223__issue16482.diff.txt uploaded by tilghman (license 14) Tested by: wdoekes, tilghman git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@237493 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-04Add a flag to disable the Background behavior, for AGI users.tilghman1-1/+6
This is in a section of code that relates to two other issues, namely issue #14011 and issue #14940), one of which was the behavior of Background when called with a context argument that matched the current context. This fix broke FreePBX, however, in a post-Dial situation. Needless to say, this is an extremely difficult collision of several different issues. While the use of an exception flag is ugly, fixing all of the issues linked is rather difficult (although if someone would like to propose a better solution, we're happy to entertain that suggestion). (closes issue #16434) Reported by: rickead2000 Patches: 20091217__issue16434.diff.txt uploaded by tilghman (license 14) 20091222__issue16434__1.6.1.diff.txt uploaded by tilghman (license 14) Tested by: rickead2000 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@237405 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-18Correct CDR dispositions for BUSY/FAILEDjpeeler1-1/+3
This patch is simple in that it reorders the disposition defines so that the fix for issue 12946 works properly (the default CDR disposition was changed to AST_CDR_NOANSWER). Also, the AST_CDR_FLAG_ORIGINATED flag was set in ast_call to ensure all CDR records are written. The side effects of CDR changes are scary, so I'm documenting the test cases performed to attempt to catch any regressions. The following tests were all performed using 1.4 rev 195881 vs head (235571) + patch: A calls B C calls B (busy) Hangup C Hangup A (Both SIP and features) A calls B A blind transfers to C Hangup C (Both SIP and features) A calls B A attended transfers to C Hangup C A calls B A attended transfers to C (SIP) C blind transfers to A (features) Hangup A All of the test scenario CDRs matched. The following tests were performed just with the patch to ensure proper operation (with unanswered=yes): exten =>s,1,Answer exten =>s,n,ResetCDR(w) exten =>s,n,ResetCDR(w) exten =>s,1,ResetCDR(w) exten =>s,n,ResetCDR(w) (closes issue #16180) Reported by: aatef Patches: bug16180.patch uploaded by jpeeler (license 325) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@235635 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-17Use context from which Macro is executed, not macro context, if applicable.tilghman1-3/+13
Also, ensure that the extension COULD match, not just that it won't match more. (closes issue #16113) Reported by: OrNix Patches: 20091216__issue16113.diff.txt uploaded by tilghman (license 14) Tested by: OrNix git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@235421 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-09Fix breakage of the "module load <module>" CLI command.russell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@233879 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-09Set a module load priority for format modules.russell1-46/+72
A recent change to app_voicemail made it such that the module now assumes that all format modules are available while processing voicemail configuration. However, when autoloading modules, it was possible that app_voicemail was loaded before the format modules. Since format modules don't depend on anything, set a module load priority on them to ensure that they get loaded first when autoloading. This version of the patch is specific to Asterisk 1.4 and 1.6.0. These versions did not already support module load priority in the module API. This adds a trivial version of this which is just a module flag to include it in a pass before loading "everything". Thanks to mmichelson for the review! (closes issue #16412) Reported by: jiddings Tested by: russell Review: https://reviewboard.asterisk.org/r/445/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@233782 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-07hex escape control and non 7-bit clean characters in uri_encodedvossel1-1/+1
In ast_uri_encode, non 7-bit clean characters were being hex escaped correctly, but control characters were not. (issue #16299) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@233609 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-04Only do frame payload check for HOLD frames.russell1-3/+3
This code was added for helping to debug the source of invalid HOLD frames. However, a side effect of this is that it will incorrectly report errors for frames that have an integer payload. Make the check for this block specific to the HOLD frame case. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@233092 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-04Warning message gets displayed only oncemnick1-1/+6
Added additional field 'int display_inband_dtmf_warning', which when set to '1' displays the warning ('Inband DTMF is not supported on codec %s. Use RFC2833'), and when set to '0' doesn't display the warning. Otherwise you would get hundreds of warnings every second. (closes issue #15769) Reported by: falves11 Patches: patch_15769_14.txt uploaded by mnick (license 874) Tested by: mnick, falves11 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@233014 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-02Send ack (response/message) after receiving manager action usereventjpeeler1-0/+1
(closes issue #16264) Reported by: dimas Patches: event-ack.patch uploaded by dimas (license 88) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@232581 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-02ast_outaddrfor doesn't do htons() on port, looks odd in strace.dvossel1-1/+1
(closes issue #16290) Reported by: wdoekes git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@232350 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-02Fix compiling without devmodetwilson1-1/+3
(closes issue #16367) Reported by: falves11 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@232165 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-01Fix a warning pointed out by buildbot.russell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@232007 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-01log channel name in dev mode as welljpeeler1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@231926 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-01Fix crash with invalid frame datajpeeler1-0/+11
The crash was happening as a result of a frame containing an invalid data pointer, but was set with data length of zero. The few times the issue was reproduced it _seemed_ that the frame was queued properly, that is the data pointer was set to NULL. I never could reproduce the crash so as a last resort the crash has been fixed, but a check in __ast_read has been added to give as much information about the source of problematic frames in the future. (closes issue #16058) Reported by: atis git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@231911 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-01WaitExten m option with no parameters generates frame with zero datalen but ↵dvossel1-1/+1
non-null data ptr git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@231853 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-01Ignore unknown formats in ast_format_str_reduce() and return an error if no ↵mnicholson1-2/+15
know formats are found. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@231740 f38db490-d61c-443f-a65b-d21fe96a405b
2009-11-30Remove duplicate entries from voicemail format lists. This prevents ↵mnicholson2-6/+66
app_voicemail from entering an infinite loop when the same format is specified twice in the format list. (closes issue #15625) Reported by: Shagg63 Tested by: mnicholson Review: https://reviewboard.asterisk.org/r/429/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@231614 f38db490-d61c-443f-a65b-d21fe96a405b
2009-11-30fixes crash caused by RTP comfort noise payload greater than 24 bytesdvossel1-1/+0
AST-2009-010 (closes issue #16242) Reported by: amorsen Patches: issue16242.diff uploaded by oej (license 306) Tested by: amorsen, oej, dvossel git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@231441 f38db490-d61c-443f-a65b-d21fe96a405b
2009-11-25After a frame duplication failure, unlock the channel before returning.tilghman1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@231298 f38db490-d61c-443f-a65b-d21fe96a405b
2009-11-19Update copyright year in visible output. (cli)mvanbaak1-3/+3
Spotted by Stuart Henderson git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@230469 f38db490-d61c-443f-a65b-d21fe96a405b
2009-11-11Solaris doesn't like NULL going to ast_logdbrooks1-4/+5
Solaris will crash if NULL is passed to ast_log. This simple patch simply uses S_OR to get around this. (closes issue #15392) Reported by: yrashk git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@229498 f38db490-d61c-443f-a65b-d21fe96a405b
2009-11-10If two pattern classes start with the same digit and have the same number of ↵tilghman1-18/+36
characters, they will compare equal. The example given in the issue report is that of [234] and [246], which have these characteristics, yet they are clearly not equivalent. The code still uses these two characteristics, yet when the two scores compare equal, an additional check will be done to compare all characters within the class to verify equality. (closes issue #15421) Reported by: jsmith Patches: 20091109__issue15421__2.diff.txt uploaded by tilghman (license 14) Tested by: jsmith, thedavidfactor git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@229360 f38db490-d61c-443f-a65b-d21fe96a405b
2009-11-09Update WARNING message.lmadsen1-1/+1
Update a WARNING message to give a suggested fix when encountered. (closes issue #16198) Reported by: atis Tested by: atis git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@228896 f38db490-d61c-443f-a65b-d21fe96a405b
2009-11-06fixes audiohook write crash occuring in chan_spy whisper mode.dvossel1-2/+10
After writing to the audiohook list in ast_write(), frames were being freed incorrectly. Under certain conditions this resulted in a double free crash. (closes issue #16133) Reported by: wetwired (closes issue #16045) Reported by: bluecrow76 Patches: issue16045.diff uploaded by dvossel (license 671) Tested by: bluecrow76, dvossel, habile git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@228692 f38db490-d61c-443f-a65b-d21fe96a405b
2009-11-06Fix a bug caused by a partially invalid frame (from the jitterbuffer) ↵file1-5/+1
passing through the Asterisk core. (closes issue #15560) Reported by: jvandal (closes issue #15709) Reported by: covici git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@228409 f38db490-d61c-443f-a65b-d21fe96a405b
2009-11-06Properly handle '=' while decoding base64 messages and null terminate ↵mnicholson1-1/+1
strings returned from BASE64_DECODE. (closes issue #15271) Reported by: chappell Patches: base64_fix.patch uploaded by chappell (license 8) Tested by: kobaz git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@228378 f38db490-d61c-443f-a65b-d21fe96a405b
2009-11-06fixes crash in astfd.cdvossel1-4/+9
(closes issue #15981) Reported by: slavon git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@228338 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-27Manager output is not always NULL-terminated, so force a NULL at the end of ↵tilghman1-2/+6
the filestream. (closes issue #15495) Reported by: pdf Patches: 20090916__issue15495.diff.txt uploaded by tilghman (license 14) Tested by: pdf git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@226138 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-21Revert 225169, as this doesn't account for the possibility of a list of frames.russell1-6/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@225171 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-21Isolate the frame returned from ast_translate().russell1-2/+6
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@225169 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-21Fix documentation for ast_softhangup() and correct the misuse thereof.tilghman1-2/+3
(closes issue #16103) Reported by: majorbloodnok git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@225105 f38db490-d61c-443f-a65b-d21fe96a405b
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-23 19:08:34 +0000