aboutsummaryrefslogtreecommitdiffstats
path: root/main
AgeCommit message (Collapse)AuthorFilesLines
2008-06-04Fix a log message and add a message for when the dialplan is done reloading.file1-1/+1
(closes issue #12716) Reported by: chappell Patches: dialplan_reload_2.diff uploaded by chappell (license 8) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@120282 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-03(closes issue #11594)jpeeler1-0/+4
Reported by: yem Tested by: yem This change decreases the buffer size allocated on the stack substantially in config_text_file_load when LOW_MEMORY is turned on. This change combined with the fix from revision 117462 (making mkintf not copy the zt_chan_conf structure) was enough to prevent the crash. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@120173 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-03When listing the manager users, managers in users.conf are not shown, eventilghman1-1/+66
though they are allowed to connect. (closes issue #12594) Reported by: bkruse Patches: 12594-managerusers-2.diff uploaded by qwell (license 4) Tested by: bkruse git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@120061 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-02Improve CLI command blacklist checking for the command manager action. ↵russell1-9/+50
Previously, it did not handle case or whitespace properly. This made it possible for blacklisted commands to get executed anyway. (closes issue #12765) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@119742 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-30Fix a bug I found while testing for another issue.file1-14/+13
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@119354 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-29Fix a race condition in channel autoservice. There was still a small window ↵russell1-60/+83
of opportunity for a DTMF frame, or some other deferred frame type, to come in and get dropped. (closes issue #12656) (closes issue #12656) Reported by: dimas Patches: v3-12656.patch uploaded by dimas (license 88) -- with some modifications by me git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@119156 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-29Add some debugging code that ensures that when we do deadlock avoidance, wetilghman1-0/+28
don't lose the information about how a lock was originally acquired. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@118953 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-29(closes issue #10668)murf1-33/+40
(closes issue #11721) (closes issue #12726) Reported by: arkadia Tested by: murf These changes: 1. revert the changes made via bug 10668; I should have known that such changes, even tho they made sense at the time, seemed like an omission, etc, were actually integral to the CDR system via forkCDR. It makes sense to me now that forkCDR didn't natively end any CDR's, but rather depended on natively closing them all at hangup time via traversing and closing them all, whether locked or not. I still don't completely understand the benefits of setvar and answer operating on locked cdrs, but I've seen enough to revert those changes also, and stop messing up users who depended on that behavior. bug 12726 found reverting the changes fixed his changes, and after a long review and working on forkCDR, I can see why. 2. Apply the suggested enhancements proposed in 10668, but in a completely compatible way. ForkCDR will behave exactly as before, but now has new options that will allow some actions to be taken that will slightly modify the outcome and side-effects of forkCDR. Based on conversations I've had with various people, these small tweaks will allow some users to get the behavior they need. For instance, users executing forkCDR in an AGI script will find the answer time set, and DISPOSITION set, a situation not covered when the routines were first written. 3. A small problem in the cdr serializer would output answer and end times even when they were not set. This is now fixed. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@118858 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-27When showing an error message for a command, don't shorten the command output,tilghman1-1/+1
as it tends to confuse the user (it's fine for suggesting other commands, however). Reported by: seanbright (on #asterisk-dev) Fixed by: me git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@118551 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-27NULL character should terminate only commands back to the core, not logtilghman1-7/+14
messages to the console. (closes issue #12731) Reported by: seanbright Patches: 20080527__bug12731.diff.txt uploaded by Corydon76 (license 14) Tested by: seanbright git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@118465 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-23Don't declare a function that takes variable arguments as inline, because it'srussell1-0/+14
not valid, and on some compilers, will emit a warning. http://gcc.gnu.org/onlinedocs/gcc/Inline.html#Inline (closes issue #12289) Reported by: francesco_r Patches by Tilghman, final patch by me git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@118048 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-22Also remove preamble from asynchronous events (reported by jsmith on ↵tilghman1-0/+9
#asterisk-dev) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@117899 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-21Strip the preamble from the output also when -rx is not being usedtilghman1-0/+8
(Related to issue #12702) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@117519 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-21Don't filter the magic character in the network verboser. It gets filteredrussell1-3/+0
once it reaches the client. (related to issue #12702, pointed out by tilghman) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@117514 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-211) Don't print the verbose marker in front of every message from ast_verbose()russell1-0/+3
being sent to remote consoles. 2) Fix pbx_gtkconsole to filter out the verbose marker. (related to issue #12702) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@117507 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-21Don't display the verbose marker for calls to ast_verbose() that do not includerussell1-1/+5
a VERBOSE_PREFIX in front of the message. (closes issue #12702) Reported by: johnlange Patched by me git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@117479 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-14Add ast_assert(), which can be used to handle fatal errors. It is only compiledrussell5-13/+8
in if dev-mode is enabled, and only aborts if DO_CRASH is defined. (inspired by issue #12650) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@116463 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-14Add linux-gnueabi in.file1-1/+1
(closes issue #12529) Reported by: tzafrir git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@116352 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-13A change to the way channel locks are handled when DEBUG_CHANNEL_LOCKS is ↵mmichelson1-5/+15
defined. After debugging a deadlock, it was noticed that when DEBUG_CHANNEL_LOCKS is enabled in menuselect, the actual origin of channel locks is obscured by the fact that all channel locks appear to happen in the function ast_channel_lock(). This code change redefines ast_channel_lock to be a macro which maps to __ast_channel_lock(), which then relays the proper file name, line number, and function name information to the core lock functions so that this information will be displayed in the case that there is some sort of locking error or core show locks is issued. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@116088 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-13Fix an issue that I noticed in autoservice while mmichelson and I were debuggingrussell1-5/+9
a different problem. I noticed that it was theoretically possible for two threads to attempt to start the autoservice thread at the same time. This change makes the process of starting the autoservice thread, thread-safe. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@115990 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-13If the socket dies (read returns 0=EOF), return immediately.tilghman1-1/+1
(Closes issue #12637) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@115884 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-12If a thread holds no locks, do not print any information on the thread when ↵mmichelson1-38/+40
issuing a core show locks command. This will help to de-clutter output somewhat. Russell said it would be fine to place this improvement in the 1.4 branch, so that's why it's going here too. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@115735 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-08Don't use a channel before checking for channel allocation failure.russell1-6/+6
(closes issue #12609) Reported by: edantie git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@115551 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-06Don't print the terminating NUL. (Closes issue #12589)tilghman1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@115415 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-05Separate verbose output from CLI output, by using a preamble.tilghman2-5/+41
(closes issue #12402) Reported by: Corydon76 Patches: 20080410__no_verbose_in_rx_output.diff.txt uploaded by Corydon76 (license 14) 20080501__no_verbose_in_rx_output__1.4.diff.txt uploaded by Corydon76 (license 14) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@115333 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-01'#' is another reserved character for URIs that also needs to be escaped.tilghman1-1/+1
(closes issue #10543) Reported by: blitzrage Patches: 20080418__bug10543.diff.txt uploaded by Corydon76 (license 14) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@115017 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-23Improve some broken cookie parsing code. Previously, manager login over HTTPrussell1-48/+39
would only work if the mansession_id cookie was first. Now, the code builds a list of all of the cookies in the Cookie header. This fixes a problem observed by users of the Asterisk GUI. (closes AST-20) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114600 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-23Fix an issue that caused getting the correct next channel to not always work.russell1-1/+1
Also, remove setting the amount of time to wait for a digit from 5 seconds back down to 1/10 of a second. I believe this was so the beep didn't get played over and over really fast, but a while back I put in another fix for that issue. (closes issue #12498) Reported by: jsmith Patches: app_chanspy_channel_walk.trunk.patch uploaded by jsmith (license 15) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114597 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-23Store the manager session ID explicitly as 4 byte ID instead of a ulong. Therussell1-7/+7
mansession_id cookie is coded to be limited to 8 characters of hex, and this could break logins from 64-bit machines in some cases. (inspired by AST-20) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114591 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-23Instead of stopping dialplan execution when SayNumber attempts to say a ↵file1-1/+6
large number that it can not print out a message informing the user and continue on. (closes issue #12502) Reported by: bcnit git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114579 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-22I thought I was going to be able to leave 1.4 alone, but that was not the case.russell3-11/+43
I ran into some problems with G.722 in 1.4, so I have merged in all of the fixes in this area that I have made in trunk/1.6.0, and things are happy again. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114550 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-18Don't destroy a manager session if poll() returns an error of EAGAIN.russell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114284 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-18Clearing up error messages so they make a bit more sense. Also removing a ↵mmichelson1-2/+2
redundant error message. Issue AST-15 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114257 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-17Remove redundant safety net. The check for the autoservice channel list staterussell1-4/+0
accomplishes the same goal in a better way. (issue #12470) Reported By: atis git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114230 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-17Add prototype for ast_dsp_frame_freed. I'm not sure how this wasmmichelson1-0/+1
compiling before... git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114211 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-17It was possible for a reference to a frame which was part of a freed DSP to ↵mmichelson2-1/+35
still be referenced, leading to memory corruption and eventual crashes. This code change ensures that the dsp is freed when we are finished with the frame. This change is very similar to a change Russell made with translators back a month or so ago. (closes issue #11999) Reported by: destiny6628 Patches: 11999.patch uploaded by putnopvut (license 60) Tested by: destiny6628, victoryure git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114207 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-14Increase the retry count when attempting to show channels. This apparentlymmichelson1-2/+2
cleared an issue someone was seeing when attempting to show channels when the load was high. (closes issue #11667) Reported by: falves11 Patches: 11677.txt uploaded by russell (license 2) Tested by: falves11 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114117 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-14Save a local copy of the generate callback prior to unlocking the channel inmmichelson1-1/+5
case the generate callback goes NULL on us after the channel is unlocked. Thanks to Russell for pointing this need out to me. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114106 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-14Don't change the SSRC when a new source comes into play, this might happen ↵file1-1/+0
quite often and depending on the remote side... they might not like this. (closes issue #12353) Reported by: dimas git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114100 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-11It's possible that a channel can have an async goto on the successful ↵qwell1-2/+4
execution of an application as well. Closes issue #12172. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114072 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-10Fix 1.4 build when LOW_MEMORY is enabled.mmichelson1-0/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114051 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-10Only try to prefix language if we are not using an absolute path (suffix it ↵qwell1-6/+1
otherwise). en/var/lib/asterisk/sounds/blah.gsm is a very silly path. (closes issue #12379) Reported by: kuj Patches: 12379-absolutepath.diff uploaded by qwell (license 4) Tested by: kuj, qwell git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114035 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-08Work around some silliness caused by sys/capability.h - this should fix ↵qwell1-5/+6
compile errors a number of users have been experiencing. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113402 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-08If audio suddenly gets fed into one side of a channel after a lapse of ↵file2-4/+31
frames flush the other factory so that old audio does not remain in the factory causing the sync code to not execute. (closes issue #12296) Reported by: jvandal git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113296 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-07This fix prevents a deadlock that was experienced in chan_local. There wasmmichelson1-0/+10
deadlock prevention in place in chan_local, but it would not work in a specific case because the channel was recursively locked. By unlocking the channel prior to calling the generator's generate callback in ast_read_generator_actions(), we prevent the recursive locking, and therefore the deadlock. (closes issue #12307) Reported by: callguy Patches: 12307.patch uploaded by putnopvut (license 60) Tested by: callguy git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113065 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-04Pass in the path to Zaptel for systems that install Zaptel headers in a ↵file1-0/+1
separate location. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@112711 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-04One thing at a time... let's get 1.4 building.file1-1/+5
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@112709 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-03add a Zaptel timer check to verify the timer is responding when Zaptel ↵dhubbard1-1/+29
support is compiled into Asterisk and Zaptel drivers are loaded. This will help people not waste their valuable time debugging side effects. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@112689 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-02Fix a race condition in the manager. It is possible that a new manager eventmmichelson1-0/+13
could be appended during a brief time when the manager is not waiting for input. If an event comes during this period, we need to set an indicator that there is an event pending so that the manager doesn't attempt to wait forever for an event that already happened. (closes issue #12354) Reported by: bamby Patches: manager_race_condition.diff uploaded by bamby (license 430) (comments added by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@112468 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-01Disable Packet2Packet bridging when we need to feed DTMF frames into the ↵file1-3/+3
core. Some implementations do not like how we switch between things. (closes issue #12212) Reported by: bamby git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@112209 f38db490-d61c-443f-a65b-d21fe96a405b