aboutsummaryrefslogtreecommitdiffstats
path: root/main/utils.c
AgeCommit message (Collapse)AuthorFilesLines
2010-01-05Merged revisions 237699 via svnmerge from russell1-1/+3
https://origsvn.digium.com/svn/asterisk/trunk ................ r237699 | russell | 2010-01-05 11:16:01 -0600 (Tue, 05 Jan 2010) | 14 lines Merged revisions 237697 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r237697 | russell | 2010-01-05 11:13:28 -0600 (Tue, 05 Jan 2010) | 7 lines Change a NOTICE log message to DEBUG where it belongs. (closes issue #16479) Reported by: alexrecarey (closes SWP-577) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@237712 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-07Merged revisions 233611 via svnmerge from dvossel1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r233611 | dvossel | 2009-12-07 17:28:51 -0600 (Mon, 07 Dec 2009) | 4 lines fixes incorrect logic in ast_uri_encode issue #16299 ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@233614 f38db490-d61c-443f-a65b-d21fe96a405b
2009-11-06Merged revisions 228620 via svnmerge from mnicholson1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r228620 | mnicholson | 2009-11-06 13:47:11 -0600 (Fri, 06 Nov 2009) | 15 lines Merged revisions 228378 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r228378 | mnicholson | 2009-11-06 10:26:59 -0600 (Fri, 06 Nov 2009) | 8 lines Properly handle '=' while decoding base64 messages and null terminate strings returned from BASE64_DECODE. (closes issue #15271) Reported by: chappell Patches: base64_fix.patch uploaded by chappell (license 8) Tested by: kobaz ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@228651 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-04Merged revisions 216506 via svnmerge from mvanbaak1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r216506 | mvanbaak | 2009-09-04 17:05:05 +0200 (Fri, 04 Sep 2009) | 9 lines Merged revisions 216435 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r216435 | mvanbaak | 2009-09-04 15:56:10 +0200 (Fri, 04 Sep 2009) | 2 lines make asterisk compile under devmode with DEBUG_THREADS enabled on OpenBSD ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@216507 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-10AST-2009-005tilghman1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@211551 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-28Merged revisions 197538 via svnmerge from file1-1/+5
https://origsvn.digium.com/svn/asterisk/trunk ........ r197538 | file | 2009-05-28 11:51:43 -0300 (Thu, 28 May 2009) | 5 lines Fix a bug in stringfields where it did not actually free the pools of memory. (closes issue #15074) Reported by: pj ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@197539 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-05Merged revisions 192357 via svnmerge from kpfleming1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r192357 | kpfleming | 2009-05-05 15:18:21 +0200 (Tue, 05 May 2009) | 5 lines Correct some flaws in the memory accounting code for stringfields and ao2 objects Under some conditions, the memory allocation for stringfields and ao2 objects would not have supplied valid file/function names for MALLOC_DEBUG tracking, so this commit corrects that. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@192358 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-05Merged revisions 192279 via svnmerge from kpfleming1-20/+49
https://origsvn.digium.com/svn/asterisk/trunk ........ r192279 | kpfleming | 2009-05-05 10:51:06 +0200 (Tue, 05 May 2009) | 5 lines Ensure that string pools allocated to hold stringfields are properly accounted in MALLOC_DEBUG mode This commit modifies the stringfield pool allocator to remember the 'owner' of the stringfield manager the pool is being allocated for, and ensures that pools allocated in the future when fields are populated are owned by that file/function. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@192280 f38db490-d61c-443f-a65b-d21fe96a405b
2009-03-18Merged revisions 182847 via svnmerge from russell1-2/+2
https://origsvn.digium.com/svn/asterisk/trunk ................ r182847 | russell | 2009-03-17 21:28:55 -0500 (Tue, 17 Mar 2009) | 52 lines Merged revisions 182810 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r182810 | russell | 2009-03-17 21:09:13 -0500 (Tue, 17 Mar 2009) | 44 lines Fix cases where the internal poll() was not being used when it needed to be. We have seen a number of problems caused by poll() not working properly on Mac OSX. If you search around, you'll find a number of references to using select() instead of poll() to work around these issues. In Asterisk, we've had poll.c which implements poll() using select() internally. However, we were still getting reports of problems. vadim investigated a bit and realized that at least on his system, even though we were compiling in poll.o, the system poll() was still being used. So, the primary purpose of this patch is to ensure that we're using the internal poll() when we want it to be used. The changes are: 1) Remove logic for when internal poll should be used from the Makefile. Instead, put it in the configure script. The logic in the configure script is the same as it was in the Makefile. Ideally, we would have a functionality test for the problem, but that's not actually possible, since we would have to be able to run an application on the _target_ system to test poll() behavior. 2) Always include poll.o in the build, but it will be empty if AST_POLL_COMPAT is not defined. 3) Change uses of poll() throughout the source tree to ast_poll(). I feel that it is good practice to give the API call a new name when we are changing its behavior and not using the system version directly in all cases. So, normally, ast_poll() is just redefined to poll(). On systems where AST_POLL_COMPAT is defined, ast_poll() is redefined to ast_internal_poll(). 4) Change poll() in main/poll.c to be ast_internal_poll(). It's worth noting that any code that still uses poll() directly will work fine (if they worked fine before). So, for example, out of tree modules that are using poll() will not stop working or anything. However, for modules to work properly on Mac OSX, ast_poll() needs to be used. (closes issue #13404) Reported by: agalbraith Tested by: russell, vadim http://reviewboard.digium.com/r/198/ ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@182945 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-18Merged revisions 177035 via svnmerge from dbailey1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r177035 | dbailey | 2009-02-18 11:24:07 -0600 (Wed, 18 Feb 2009) | 2 lines Fixed error where a check for an zero length, terminated string was needed. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@177038 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-18Merged revisions 176948 via svnmerge from dbailey1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r176948 | dbailey | 2009-02-18 10:09:12 -0600 (Wed, 18 Feb 2009) | 2 lines Need to take into account the \0 terminator of the old string to determine the amount available. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@177004 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-16Merged revisions 176255 via svnmerge from kpfleming1-18/+38
https://origsvn.digium.com/svn/asterisk/trunk ................ r176255 | kpfleming | 2009-02-16 15:45:54 -0600 (Mon, 16 Feb 2009) | 13 lines Merged revisions 176216 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r176216 | kpfleming | 2009-02-16 15:10:38 -0600 (Mon, 16 Feb 2009) | 3 lines fix a flaw in the ast_string_field_build() family of API calls; these functions made no attempt to reuse the space already allocated to a field, so every time the field was written it would allocate new space, leading to what appeared to be a memory leak. ........ r176254 | kpfleming | 2009-02-16 15:41:46 -0600 (Mon, 16 Feb 2009) | 3 lines correct a logic error in the last stringfields commit... don't mark additional space as allocated if the string was built using already-allocated space ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@176258 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-22Merged revisions 166317 via svnmerge from russell1-12/+25
https://origsvn.digium.com/svn/asterisk/trunk ................ r166317 | russell | 2008-12-22 11:29:10 -0600 (Mon, 22 Dec 2008) | 10 lines Merged revisions 166297 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r166297 | russell | 2008-12-22 11:22:56 -0600 (Mon, 22 Dec 2008) | 2 lines Fix up timeout handling in ast_carefulwrite(). ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@166319 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-22Merged revisions 166282 via svnmerge from russell1-24/+90
https://origsvn.digium.com/svn/asterisk/trunk ........ r166282 | russell | 2008-12-22 11:09:36 -0600 (Mon, 22 Dec 2008) | 12 lines Introduce ast_careful_fwrite() and use in AMI to prevent partial writes. This patch introduces a function to do careful writes on a file stream which will handle timeouts and partial writes. It is currently used in AMI to address the issue that has been reported. However, there are probably a few other places where this could be used. (closes issue #13546) Reported by: srt Tested by: russell http://reviewboard.digium.com/r/104/ ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@166283 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-18Merged revisions 165801 via svnmerge from russell1-13/+38
https://origsvn.digium.com/svn/asterisk/trunk ................ r165801 | russell | 2008-12-18 15:44:47 -0600 (Thu, 18 Dec 2008) | 19 lines Merged revisions 165796 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r165796 | russell | 2008-12-18 15:39:25 -0600 (Thu, 18 Dec 2008) | 11 lines Make ast_carefulwrite() be more careful. This patch handles some additional cases that could result in partial writes to the file description. This was done to address complaints about partial writes on AMI. (issue #13546) (more changes needed to address potential problems in 1.6) Reported by: srt Tested by: russell Review: http://reviewboard.digium.com/r/99/ ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@165802 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Merged revisions 164882 via svnmerge from russell1-0/+6
https://origsvn.digium.com/svn/asterisk/trunk ................ r164882 | russell | 2008-12-16 15:39:15 -0600 (Tue, 16 Dec 2008) | 17 lines Merged revisions 164881 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164881 | russell | 2008-12-16 15:38:29 -0600 (Tue, 16 Dec 2008) | 9 lines Fix an issue where DEBUG_THREADS may erroneously report that a thread is exiting while holding a lock. If the last lock attempt was a trylock, and it failed, it will still be in the list of locks so that it can be reported. (closes issue #13219) Reported by: pj ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@164883 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-09Merged revisions 162414 via svnmerge from russell1-62/+0
https://origsvn.digium.com/svn/asterisk/trunk ................ r162414 | russell | 2008-12-09 16:25:06 -0600 (Tue, 09 Dec 2008) | 16 lines Merged revisions 162413 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r162413 | russell | 2008-12-09 16:17:39 -0600 (Tue, 09 Dec 2008) | 8 lines Remove the test_for_thread_safety() function completely. The test is not valid. Besides, if we actually suspected that recursive mutexes were not working, we would get a ton of LOG_ERROR messages when DEBUG_THREADS is turned on. (inspired by a discussion on the asterisk-dev list) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@162415 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-29Merged revisions 159818 via svnmerge from kpfleming1-3/+0
https://origsvn.digium.com/svn/asterisk/trunk ........ r159818 | kpfleming | 2008-11-29 11:57:39 -0600 (Sat, 29 Nov 2008) | 18 lines incorporates r159808 from branches/1.4: ------------------------------------------------------------------------ r159808 | kpfleming | 2008-11-29 10:58:29 -0600 (Sat, 29 Nov 2008) | 7 lines update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors since this branch already had some printf format attributes, enable checking for them and tag functions that didn't have them format attributes in a consistent way ------------------------------------------------------------------------ in addition: move some format attributes from main/utils.c to the header files they belong in, and fix up references to the relevant functions based on new compiler warnings ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@159855 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-03port gcc 4.3.x warning fixes from trunk to this branchkpfleming1-2/+5
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@153743 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-23Merged revisions 132964 via svnmerge from kpfleming1-11/+42
https://origsvn.digium.com/svn/asterisk/trunk ................ r132964 | kpfleming | 2008-07-23 11:30:18 -0500 (Wed, 23 Jul 2008) | 10 lines Merged revisions 132872 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r132872 | kpfleming | 2008-07-23 06:52:18 -0500 (Wed, 23 Jul 2008) | 2 lines minor optimization for stringfields: when a field is being set to a larger value than it currently contains and it happens to be the most recent field allocated from the currentl pool, it is possible to 'grow' it without having to waste the space it is currently using (or potentially even allocate a new pool) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@132965 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-11Merged revisions 130129 via svnmerge from bbryant1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r130129 | bbryant | 2008-07-11 13:09:35 -0500 (Fri, 11 Jul 2008) | 8 lines Janitor patch to change uses of sizeof to ARRAY_LEN (closes issue #13054) Reported by: pabelanger Patches: ARRAY_LEN.patch2 uploaded by pabelanger (license 224) Tested by: seanbright ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@130130 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-27Merged revisions 125794 via svnmerge from tilghman1-4/+4
https://origsvn.digium.com/svn/asterisk/trunk ................ r125794 | tilghman | 2008-06-27 08:54:13 -0500 (Fri, 27 Jun 2008) | 10 lines Merged revisions 125793 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r125793 | tilghman | 2008-06-27 08:45:03 -0500 (Fri, 27 Jun 2008) | 2 lines In this debugging function, copy to a buffer instead of using potentially unsafe pointers. ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@125795 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-26Merged revisions 125589 via svnmerge from qwell1-0/+3
https://origsvn.digium.com/svn/asterisk/trunk ................ r125589 | qwell | 2008-06-26 18:04:18 -0500 (Thu, 26 Jun 2008) | 9 lines Merged revisions 125587 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r125587 | qwell | 2008-06-26 18:03:15 -0500 (Thu, 26 Jun 2008) | 1 line Make sure to unlock the lock_info lock (huh?). Possible deadlock? ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@125590 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-19Merged revisions 124064 via svnmerge from bbryant1-0/+14
https://origsvn.digium.com/svn/asterisk/trunk ........ r124064 | bbryant | 2008-06-19 14:48:26 -0500 (Thu, 19 Jun 2008) | 2 lines Add errors that report any locks held by threads when they are being closed. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@124065 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-29Merged revisions 118955,118957 via svnmerge from tilghman1-0/+28
https://origsvn.digium.com/svn/asterisk/trunk ................ r118955 | tilghman | 2008-05-29 12:35:19 -0500 (Thu, 29 May 2008) | 11 lines Merged revisions 118953 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r118953 | tilghman | 2008-05-29 12:20:16 -0500 (Thu, 29 May 2008) | 3 lines Add some debugging code that ensures that when we do deadlock avoidance, we don't lose the information about how a lock was originally acquired. ........ ................ r118957 | tilghman | 2008-05-29 12:39:50 -0500 (Thu, 29 May 2008) | 10 lines Merged revisions 118954 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r118954 | tilghman | 2008-05-29 12:33:01 -0500 (Thu, 29 May 2008) | 2 lines Define also when not DEBUG_THREADS ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@118958 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-23Merged revisions 118049 via svnmerge from russell1-0/+16
https://origsvn.digium.com/svn/asterisk/trunk ................ r118049 | russell | 2008-05-23 07:37:31 -0500 (Fri, 23 May 2008) | 17 lines Merged revisions 118048 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r118048 | russell | 2008-05-23 07:30:53 -0500 (Fri, 23 May 2008) | 9 lines Don't declare a function that takes variable arguments as inline, because it's not valid, and on some compilers, will emit a warning. http://gcc.gnu.org/onlinedocs/gcc/Inline.html#Inline (closes issue #12289) Reported by: francesco_r Patches by Tilghman, final patch by me ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@118050 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-12Merged revisions 115737 via svnmerge from mmichelson1-38/+40
https://origsvn.digium.com/svn/asterisk/trunk ................ r115737 | mmichelson | 2008-05-12 12:55:08 -0500 (Mon, 12 May 2008) | 15 lines Merged revisions 115735 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r115735 | mmichelson | 2008-05-12 12:51:14 -0500 (Mon, 12 May 2008) | 7 lines If a thread holds no locks, do not print any information on the thread when issuing a core show locks command. This will help to de-clutter output somewhat. Russell said it would be fine to place this improvement in the 1.4 branch, so that's why it's going here too. ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@115738 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-01Merged revisions 115018 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r115018 | tilghman | 2008-05-01 14:00:18 -0500 (Thu, 01 May 2008) | 14 lines Merged revisions 115017 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r115017 | tilghman | 2008-05-01 13:59:08 -0500 (Thu, 01 May 2008) | 6 lines '#' is another reserved character for URIs that also needs to be escaped. (closes issue #10543) Reported by: blitzrage Patches: 20080418__bug10543.diff.txt uploaded by Corydon76 (license 14) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@115020 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-10Merged revisions 114052 via svnmerge from mmichelson1-0/+2
https://origsvn.digium.com/svn/asterisk/trunk ................ r114052 | mmichelson | 2008-04-10 17:02:32 -0500 (Thu, 10 Apr 2008) | 11 lines Merged revisions 114051 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114051 | mmichelson | 2008-04-10 15:59:49 -0500 (Thu, 10 Apr 2008) | 3 lines Fix 1.4 build when LOW_MEMORY is enabled. ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@114056 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-19Merged revisions 109839 via svnmerge from russell1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r109839 | russell | 2008-03-18 23:06:31 -0500 (Tue, 18 Mar 2008) | 10 lines Merged revisions 109838 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r109838 | russell | 2008-03-18 23:06:05 -0500 (Tue, 18 Mar 2008) | 2 lines Tweak spacing in a recent change because I'm very picky. ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@109840 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-18Merged revisions 109447 via svnmerge from russell1-0/+4
https://origsvn.digium.com/svn/asterisk/trunk ........ r109447 | twilson | 2008-03-18 10:43:34 -0500 (Tue, 18 Mar 2008) | 3 lines Go through and fix a bunch of places where character strings were being interpreted as format strings. Most of these changes are solely to make compiling with -Wsecurity and -Wformat=2 happy, and were not actual problems, per se. I also added format attributes to any printf wrapper functions I found that didn't have them. -Wsecurity and -Wmissing-format-attribute added to --enable-dev-mode. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@109459 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-17Merged revisions 109227 via svnmerge from mmichelson1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r109227 | mmichelson | 2008-03-17 17:06:44 -0500 (Mon, 17 Mar 2008) | 20 lines Merged revisions 109226 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r109226 | mmichelson | 2008-03-17 17:05:49 -0500 (Mon, 17 Mar 2008) | 12 lines Fix a logic flaw in the code that stores lock info which is displayed via the "core show locks" command. The idea behind this section of code was to remove the previous lock from the list if it was a trylock that had failed. Unfortunately, instead of checking the status of the previous lock, we were referencing the index immediately following the previous lock in the lock_info->locks array. The result of this problem, under the right circumstances, was that the lock which we currently in the process of attempting to acquire could "overwrite" the previous lock which was acquired. While this does not in any way affect typical operation, it *could* lead to misleading "core show locks" output. ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@109228 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-06Merged revisions 105840 via svnmerge from russell1-6/+6
https://origsvn.digium.com/svn/asterisk/trunk ........ r105840 | tilghman | 2008-03-04 17:04:29 -0600 (Tue, 04 Mar 2008) | 2 lines Whitespace changes only ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@106306 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-28Merged revisions 105116 via svnmerge from russell1-5/+9
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r105116 | russell | 2008-02-28 16:23:05 -0600 (Thu, 28 Feb 2008) | 8 lines Fix a bug in the lock tracking code that was discovered by mmichelson. The issue is that if the lock history array was full, then the functions to mark a lock as acquired or not would adjust the stats for whatever lock is at the end of the array, which may not be itself. So, do a sanity check to make sure that we're updating lock info for the proper lock. (This explains the bizarre stats on lock #63 in BE-396, thanks Mark!) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@105144 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25Merged revisions 104102 via svnmerge from russell1-1/+10
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r104102 | russell | 2008-02-25 17:19:05 -0600 (Mon, 25 Feb 2008) | 7 lines Improve the lock tracking code a bit so that a bunch of old locks that threads failed to lock don't sit around in the history. When a lock is first locked, this checks to see if the last lock in the list was one that was failed to be locked. If it is, then that was a lock that we're no longer sitting in a trylock loop trying to lock, so just remove it. (inspired by issue #11712) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@104103 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-11Just some minor coding style cleanup...file1-3/+3
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@103318 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-16New module res_config_curl (closes issue #11747)tilghman1-1/+1
Reported by: Corydon76 Patches: res_config_curl.c uploaded by Corydon76 (license 14) 20080116__bug11747.diff.txt uploaded by Corydon76 (license 14) Tested by: jmls git-svn-id: http://svn.digium.com/svn/asterisk/trunk@98981 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-08Merged revisions 97194 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r97194 | tilghman | 2008-01-08 14:47:07 -0600 (Tue, 08 Jan 2008) | 3 lines Increase constants to where we're less likely to hit them while debugging. (Closes issue #11694) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@97198 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-19Add a new API function, written at least twice in app_voicemail.crizzo1-0/+37
and likely in other places too. This is quite useful when placing mail/html stuff in config files. /*! \brief Convert some C escape sequences (\b\f\n\r\t) into the equivalent characters. \brief s The string to be converted (will be modified). \return The converted string. */ char *ast_unescape_c(char *s); git-svn-id: http://svn.digium.com/svn/asterisk/trunk@93950 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-17Merged revisions 93377 via svnmerge from file1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r93377 | file | 2007-12-17 18:28:09 -0400 (Mon, 17 Dec 2007) | 7 lines Do not try to access information about a lock when printing out a trylock attempt. It is possible for the lock that it references to no longer be valid. This would have caused segfaults or deadlocks. (issue #BE-263) (closes issue #11080) Reported by: callguy (closes issue #11100) Reported by: callguy ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@93378 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-12Conversions of free to ast_free, where applicable, and several other ↵tilghman1-1/+1
formatting fixes. Reported by: eliel Patch by: eliel,tilghman (Closes issue #11209) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@92594 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-07Merged revisions 91830 via svnmerge from russell1-1/+6
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r91830 | russell | 2007-12-07 15:24:33 -0600 (Fri, 07 Dec 2007) | 5 lines Make the lock protecting each thread's list of locks it currently holds recursive. I think that this will fix the situation where some people have said that "core show locks" locks up the CLI. (related to issue #11080) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@91831 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-05Merged revisions 91074 via svnmerge from russell1-0/+4
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r91074 | russell | 2007-12-04 18:48:47 -0600 (Tue, 04 Dec 2007) | 4 lines When DEBUG_THREADS is enabled, we only have the details about who is holding a lock that we are waiting on for a mutex, not rwlocks. This should fix the problem where people have reported "core show locks" crashing sometimes. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@91077 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-27Ensure the value returned from ast_random is between 0 and RAND_MAX on ↵file1-1/+3
64-bit platforms. (closes issue #11348) Reported by: sperreault git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89637 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-26Revert change for 11348 until it can be looked at even more.file1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89582 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-26Make the behavior of using /dev/urandom for random numbers the same as random().file1-2/+4
(closes issue #11348) Reported by: sperreault Patches: ast_random2.diff uploaded by sperreault (license 252) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89576 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-21remove a bunch of useless #include "options.h"rizzo1-1/+0
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89511 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-21There existed about a 1 in 4 billion chance that reading from /dev/urandommmichelson1-1/+1
would return LONG_MIN (1 in 9 quintillion if using 64-bit longs). Since there is no positive equivalent of LONG_MIN, the result of labs() in this case is unpredictable. This fixes that situation. (closes issue #11336, reported and patched by sperreault) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89487 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-19another bunch of include removals (errno.h and asterisk/logger.h)rizzo1-2/+0
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89425 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-17start using asterisk/network.h for network related headers.rizzo1-4/+2
Also remove some unnecessary includes. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89380 f38db490-d61c-443f-a65b-d21fe96a405b
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-28 00:15:24 +0000