aboutsummaryrefslogtreecommitdiffstats
path: root/main/manager.c
AgeCommit message (Collapse)AuthorFilesLines
2010-07-20Merged revisions 278024 via svnmerge from tilghman1-7/+8
https://origsvn.digium.com/svn/asterisk/trunk ................ r278024 | tilghman | 2010-07-20 11:50:11 -0500 (Tue, 20 Jul 2010) | 14 lines Merged revisions 278023 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r278023 | tilghman | 2010-07-20 11:37:18 -0500 (Tue, 20 Jul 2010) | 7 lines Off-by-one error (closes issue #16506) Reported by: nik600 Patches: 20100629__issue16506.diff.txt uploaded by tilghman (license 14) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@278025 f38db490-d61c-443f-a65b-d21fe96a405b
2010-07-16Merged revisions 277263 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r277263 | tilghman | 2010-07-16 13:14:05 -0500 (Fri, 16 Jul 2010) | 12 lines Merged revisions 277261 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r277261 | tilghman | 2010-07-16 13:04:11 -0500 (Fri, 16 Jul 2010) | 5 lines If variable gotten is not set, will segfault on Solaris. (closes issue #17636) Reported by: bklang ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@277264 f38db490-d61c-443f-a65b-d21fe96a405b
2010-07-01Merged revisions 273352 via svnmerge from mnicholson1-10/+10
https://origsvn.digium.com/svn/asterisk/trunk ........ r273352 | mnicholson | 2010-07-01 09:37:37 -0500 (Thu, 01 Jul 2010) | 2 lines Fixed whitespace problems ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@273353 f38db490-d61c-443f-a65b-d21fe96a405b
2010-07-01Merged revisions 273350 via svnmerge from mnicholson1-4/+3
https://origsvn.digium.com/svn/asterisk/trunk ........ r273350 | mnicholson | 2010-07-01 09:34:31 -0500 (Thu, 01 Jul 2010) | 2 lines Altered my comment about TCP_NODELAY ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@273351 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-30Merged revisions 273270 via svnmerge from mnicholson1-0/+15
https://origsvn.digium.com/svn/asterisk/trunk ........ r273270 | mnicholson | 2010-06-30 13:48:21 -0500 (Wed, 30 Jun 2010) | 2 lines Set TCP_NODELAY on manager TCP sockets to prevent delays on outgoing packets. This regression was introduced in r48338. AST-359 ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@273271 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-30Merged revisions 273144 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r273144 | tilghman | 2010-06-29 20:07:02 -0500 (Tue, 29 Jun 2010) | 8 lines Permission checking for the system application is backwards. (closes issue #17550) Reported by: kenner Patches: manager.c.diff uploaded by kenner (license 1040) Tested by: kenner ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@273145 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-23Merged revisions 272252 via svnmerge from pabelanger1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r272252 | pabelanger | 2010-06-23 16:35:45 -0400 (Wed, 23 Jun 2010) | 8 lines Correct manager variable 'EventList' case. (closes issue #17520) Reported by: kobaz Patches: manager.patch uploaded by kobaz (license 834) Tested by: lmadsen ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@272253 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-07Merged revisions 268653,268731 via svnmerge from tilghman1-0/+5
https://origsvn.digium.com/svn/asterisk/trunk ........ r268653 | tilghman | 2010-06-07 12:14:40 -0500 (Mon, 07 Jun 2010) | 2 lines Avoid unloading res_smdi twice. (closes issue #17237) Reported by: pabelanger ........ r268731 | tilghman | 2010-06-07 13:59:27 -0500 (Mon, 07 Jun 2010) | 4 lines Event well was going dry. (issue #17234) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@268732 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-05Merged revisions 268454 via svnmerge from tilghman1-1/+3
https://origsvn.digium.com/svn/asterisk/trunk ........ r268454 | tilghman | 2010-06-05 12:27:12 -0500 (Sat, 05 Jun 2010) | 5 lines Verify event is not NULL before attempting to lower its usecount. (closes issue #17234) Reported by: mav3rick ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@268455 f38db490-d61c-443f-a65b-d21fe96a405b
2010-06-01Merged revisions 266682 via svnmerge from tilghman1-43/+49
https://origsvn.digium.com/svn/asterisk/trunk ........ r266682 | tilghman | 2010-06-01 11:41:00 -0500 (Tue, 01 Jun 2010) | 16 lines Eliminate stale manager events after a set interval, even if AMI clients don't query for them. Actions (or failures to act) by external clients should not cause memory leaks in Asterisk, especially when those continued leaks could cause Asterisk to misbehave later. (closes issue #17234) Reported by: mav3rick Patches: 20100510__issue17234.diff.txt uploaded by tilghman (license 14) 20100517__issue17234__trunk.diff.txt uploaded by tilghman (license 14) Tested by: mav3rick, davidw (closes issue #17365) Reported by: davidw ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@266683 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-24Merged revisions 265320,265467 via svnmerge from twilson1-0/+3
https://origsvn.digium.com/svn/asterisk/trunk ........ r265320 | twilson | 2010-05-24 14:06:40 -0500 (Mon, 24 May 2010) | 14 lines Add the FullyBooted AMI event It is possible to connect to the manager interface before all Asterisk modules are loaded. To ensure that an application does not send AMI actions that might require a module that has not yet loaded, the application can listen for the FullyBooted manager event. It will be sent upon connection if all modules have been loaded, or as soon as loading is complete. The event: Event: FullyBooted Privilege: system,all Status: Fully Booted Review: https://reviewboard.asterisk.org/r/639/ ........ r265467 | twilson | 2010-05-24 17:21:58 -0500 (Mon, 24 May 2010) | 1 line Merge the rest of the FullyBooted patch ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@265521 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-17Merged revisions 263457 via svnmerge from lmadsen1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r263457 | lmadsen | 2010-05-17 09:37:35 -0500 (Mon, 17 May 2010) | 19 lines Recorded merge of revisions 263456 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r263456 | lmadsen | 2010-05-17 09:35:18 -0500 (Mon, 17 May 2010) | 11 lines Manager cookies are not compatible with RFC2109. The Version field in the cookies we're setting contain quotes around the version number which is not compatible with RFC2109 and breaks some implementations. (closes issue #17231) Reported by: ecarruda Patches: manager_rfc2109-trunk-v1.patch uploaded by ecarruda (license 559) manager_rfc2109-1.6.2-v1.patch uploaded by ecarruda (license 559) Tested by: ecarruda, russell ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@263458 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-13Merged revisions 257146 via svnmerge from mnicholson1-1/+26
https://origsvn.digium.com/svn/asterisk/trunk ................ r257146 | mnicholson | 2010-04-13 13:10:30 -0500 (Tue, 13 Apr 2010) | 16 lines Merged revisions 257070 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r257070 | mnicholson | 2010-04-13 11:46:30 -0500 (Tue, 13 Apr 2010) | 9 lines Add an option to restore past broken behavor of the Events manager action Before r238915, certain values for the EventMask parameter of the Events action would result in no response being returned. This patch adds an option to restore that broken behavior. Also while fixing this bug I discovered that passing an empty EventMasks parameter would also result in no response being returned, this has been fixed as well while being preserved when the broken behavior is requested. (closes issue #17023) Reported by: nblasgen Review: https://reviewboard.asterisk.org/r/602/ ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@257184 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-28Ensure manager hooks are executed when there are no manager sessions.jpeeler1-21/+25
Conditional expanded to check for hooks before aborting manager event processing. The other two changes are just optimizations. (closes issue #16455) Reported by: atis Patches: manager_hooks_16.patch uploaded by atis (license 242) Tested by: atis git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@243989 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-25Merged revisions 242904 via svnmerge from oej1-6/+13
https://origsvn.digium.com/svn/asterisk/trunk ................ r242904 | oej | 2010-01-25 21:27:59 +0100 (Mån, 25 Jan 2010) | 10 lines Merged revisions 242850 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r242850 | oej | 2010-01-25 21:03:38 +0100 (Mån, 25 Jan 2010) | 2 lines Report error when writing to functions returns error in AMI setvar action ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@242917 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-09Merged revisions 238916 via svnmerge from tilghman1-2/+2
https://origsvn.digium.com/svn/asterisk/trunk ................ r238916 | tilghman | 2010-01-08 19:08:04 -0600 (Fri, 08 Jan 2010) | 13 lines Merged revisions 238915 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r238915 | tilghman | 2010-01-08 18:57:58 -0600 (Fri, 08 Jan 2010) | 6 lines -1 is interpreted as an error, intead of the maximum mask. (closes issue #16241) Reported by: vnovy Patches: manager.c.patch uploaded by vnovy (license 922) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@238985 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-02Merged revisions 232582 via svnmerge from jpeeler1-0/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r232582 | jpeeler | 2009-12-02 16:02:43 -0600 (Wed, 02 Dec 2009) | 14 lines Merged revisions 232581 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r232581 | jpeeler | 2009-12-02 15:57:42 -0600 (Wed, 02 Dec 2009) | 7 lines Send ack (response/message) after receiving manager action userevent (closes issue #16264) Reported by: dimas Patches: event-ack.patch uploaded by dimas (license 88) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@232585 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-02Merged revisions 232576 via svnmerge from jpeeler1-2/+2
https://origsvn.digium.com/svn/asterisk/trunk ........ r232576 | jpeeler | 2009-12-02 15:32:50 -0600 (Wed, 02 Dec 2009) | 8 lines Make manager response to "Action: events" finish with empty line (closes issue #16275) Reported by: vnovy Patches: manager.c.diff uploaded by vnovy (license 922) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@232579 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-27Merged revisions 226159 via svnmerge from tilghman1-2/+5
https://origsvn.digium.com/svn/asterisk/trunk ................ r226159 | tilghman | 2009-10-27 15:22:07 -0500 (Tue, 27 Oct 2009) | 14 lines Merged revisions 226138 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r226138 | tilghman | 2009-10-27 15:16:49 -0500 (Tue, 27 Oct 2009) | 7 lines Manager output is not always NULL-terminated, so force a NULL at the end of the filestream. (closes issue #15495) Reported by: pdf Patches: 20090916__issue15495.diff.txt uploaded by tilghman (license 14) Tested by: pdf ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@226170 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-27Merged revisions 214514 via svnmerge from tilghman1-5/+17
https://origsvn.digium.com/svn/asterisk/trunk ........ r214514 | tilghman | 2009-08-27 16:26:37 -0500 (Thu, 27 Aug 2009) | 7 lines Ensure that we check for the special value CONFIG_STATUS_FILEINVALID. (closes issue #15786) Reported by: a_villacis Patches: asterisk-1.6.2.0-beta4-manager-fix-crash-on-include-nonexistent-file.patch uploaded by a villacis (license 660) (Plus a few of my own, to catch the remaining places within manager.c where it could have been a problem) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@214515 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-18Merged revisions 212764 via svnmerge from seanbright1-1/+3
https://origsvn.digium.com/svn/asterisk/trunk ................ r212764 | seanbright | 2009-08-18 12:38:36 -0400 (Tue, 18 Aug 2009) | 18 lines Merged revisions 212763 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r212763 | seanbright | 2009-08-18 12:36:00 -0400 (Tue, 18 Aug 2009) | 11 lines Delay the creation of temporary files until we have a valid manager command to handle. Without this patch, asterisk creates a temporary file before determining if the specified command is valid. If invalid, we weren't properly cleaning up the file. (closes issue #15730) Reported by: zmehmood Patches: M15730.diff uploaded by junky (license 177) Tested by: zmehmood ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@212767 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-10AST-2009-005tilghman1-5/+5
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@211580 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-21Merged revisions 207723 via svnmerge from mmichelson1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r207723 | mmichelson | 2009-07-21 09:29:40 -0500 (Tue, 21 Jul 2009) | 11 lines Merged revisions 207714 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r207714 | mmichelson | 2009-07-21 09:26:00 -0500 (Tue, 21 Jul 2009) | 5 lines Document default timeout for AMI originations. AST-224 ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@207727 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-26Merged revisions 196945 via svnmerge from seanbright1-6/+7
https://origsvn.digium.com/svn/asterisk/trunk ........ r196945 | seanbright | 2009-05-26 18:38:05 -0400 (Tue, 26 May 2009) | 13 lines Add ActionID to CoreShowChannel event. There is inconsistency in how we handle manager responses that are lists of items and, unfortunately, third parties have come to rely on ActionID being on every event within those lists instead of just keeping track of the ActionID for the current response. This change makes CoreShowChannels include the ActionID with each CoreShowChannel event generated as a result of it being called. (closes issue #15001) Reported by: sum Patches: patchactionid2.patch uploaded by sum (license 766) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@196950 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-18Merged revisions 195369 via svnmerge from eliel1-2/+3
https://origsvn.digium.com/svn/asterisk/trunk ........ r195369 | eliel | 2009-05-18 16:49:20 -0400 (Mon, 18 May 2009) | 8 lines Fix the CLI command 'manager show command' documentation and functionality. The CLI command 'manager show command' supports passing multiple action names in the same line, but it was not allowing that because of a incorrect check in the argumentes counter. Also the documentation was updated to show that this usage of the command is possible. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@195405 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-18Merged revisions 195021 via svnmerge from russell1-0/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r195021 | russell | 2009-05-18 07:59:11 -0500 (Mon, 18 May 2009) | 12 lines Recorded merge of revisions 195020 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r195020 | russell | 2009-05-18 07:57:46 -0500 (Mon, 18 May 2009) | 5 lines Don't try to unlock a bogus channel. (closes issue #15144) Reported by: cristiandimache ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@195024 f38db490-d61c-443f-a65b-d21fe96a405b
2009-04-10Merged revisions 187599 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r187599 | tilghman | 2009-04-09 22:55:27 -0500 (Thu, 09 Apr 2009) | 2 lines Modify headers and macros, according to Russell's suggestions on the -dev list ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@187601 f38db490-d61c-443f-a65b-d21fe96a405b
2009-04-09Merged revisions 187483 via svnmerge from tilghman1-6/+17
https://origsvn.digium.com/svn/asterisk/trunk ................ r187483 | tilghman | 2009-04-09 13:40:01 -0500 (Thu, 09 Apr 2009) | 15 lines Merged revisions 187428 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r187428 | tilghman | 2009-04-09 13:08:20 -0500 (Thu, 09 Apr 2009) | 8 lines Race condition between ast_cli_command() and 'module unload' could cause a deadlock. Add lock timeouts to avoid this potential deadlock. (closes issue #14705) Reported by: jamessan Patches: 20090320__bug14705.diff.txt uploaded by tilghman (license 14) Tested by: jamessan ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@187487 f38db490-d61c-443f-a65b-d21fe96a405b
2009-04-07Merged revisions 186720 via svnmerge from mmichelson1-3/+4
https://origsvn.digium.com/svn/asterisk/trunk ................ r186720 | mmichelson | 2009-04-07 15:46:18 -0500 (Tue, 07 Apr 2009) | 12 lines Merged revisions 186719 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r186719 | mmichelson | 2009-04-07 15:43:49 -0500 (Tue, 07 Apr 2009) | 6 lines Ensure that \r\n is printed after the ActionID in an OriginateResponse. (closes issue #14847) Reported by: kobaz ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@186723 f38db490-d61c-443f-a65b-d21fe96a405b
2009-04-01Merged revisions 185912 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r185912 | tilghman | 2009-04-01 15:13:28 -0500 (Wed, 01 Apr 2009) | 4 lines Merge changes from str_substitution that are unrelated to that branch. Included is a small bugfix to an ast_str helper, but most of these changes are simply doxygen fixes. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@185947 f38db490-d61c-443f-a65b-d21fe96a405b
2009-03-27Merged revisions 184726 via svnmerge from russell1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r184726 | russell | 2009-03-27 13:04:43 -0500 (Fri, 27 Mar 2009) | 2 lines Use ast_random() instead of rand() to ensure we use the best RNG available. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@184729 f38db490-d61c-443f-a65b-d21fe96a405b
2009-03-10Reset the thread local string buffer when handling the UserEvent action.file1-0/+3
(closes issue #14593) Reported by: JimDickenson git-svn-id: http://svn.digium.com/svn/asterisk/trunk@180800 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-10Fix an fd leak that would occur in HTTP AMI sessionsmmichelson1-217/+269
The explanation behind this fix is a bit complicated, and I've already typed it up in the code as a huge comment inside of manager.c, so I'll give the abridged version here. We needed a way to separate action-specific data from session-specific data. Unfortunately, the only way to maintain API compatibility and to not have to change every single manager action was to rename the current mansession structure and wrap it inside a new mansession structure which actually contains action- specific data. (closes issue #14364) Reported by: awk Patches: 14364_better.patch uploaded by putnopvut (license 60) Tested by: putnopvut Review: http://reviewboard.digium.com/r/148/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@174764 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-06Resolve a memory leak that would occur on an invalid channel given to ↵russell1-0/+1
Action: Status git-svn-id: http://svn.digium.com/svn/asterisk/trunk@173848 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-02Reverting commit number 173028 as there are somemmichelson1-71/+0
potential issues git-svn-id: http://svn.digium.com/svn/asterisk/trunk@173047 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-02Add a CLI command to log out a manager usermmichelson1-0/+71
(closes issue #13877) Reported by: eliel Patches: cli_manager_logout.patch.txt uploaded by eliel (license 64) Tested by: eliel, putnopvut git-svn-id: http://svn.digium.com/svn/asterisk/trunk@173028 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-28Merged revisions 172030 via svnmerge from murf1-2/+13
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r172030 | murf | 2009-01-28 11:51:16 -0700 (Wed, 28 Jan 2009) | 46 lines This patch fixes h-exten running misbehavior in manager-redirected situations. What it does: 1. A new Flag value is defined in include/asterisk/channel.h, AST_FLAG_BRIDGE_HANGUP_DONT, which used as a messenge to the bridge hangup exten code not to run the h-exten there (nor publish the bridge cdr there). It will done at the pbx-loop level instead. 2. In the manager Redirect code, I set this flag on the channel if the channel has a non-null pbx pointer. I did the same for the second (chan2) channel, which gets run if name2 is set... and the first succeeds. 3. I restored the ending of the cdr for the pbx loop h-exten running code. Don't know why it was removed in the first place. 4. The first attempt at the fix for this bug was to place code directly in the async_goto routine, which was called from a large number of places, and could affect a large number of cases, so I tested that fix against a fair number of transfer scenarios, both with and without the patch. In the process, I saw that putting the fix in async_goto seemed not to affect any of the blind or attended scenarios, but still, I was was highly concerned that some other scenarios I had not tested might be negatively impacted, so I refined the patch to its current scope, and jmls tested both. In the process, tho, I saw that blind xfers in one situation, when the one-touch blind-xfer feature is used by the peer, we got strange h-exten behavior. So, I inserted code to swap CDRs and to set the HANGUP_DONT field, to get uniform behavior. 5. I added code to the bridge to obey the HANGUP_DONT flag, skipping both publishing the bridge CDR, and running the h-exten; they will be done at the pbx-loop (higher) level instead. 6. I removed all the debug logs from the patch before committing. 7. I moved the AUTOLOOP set/reset in the h-exten code in res_features so it's only done if the h-exten is going to be run. A very minor performance improvement, but technically correct. (closes issue #14241) Reported by: jmls Patches: 14241_redirect_no_bridgeCDR_or_h_exten_via_transfer uploaded by murf (license 17) Tested by: murf, jmls ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@172063 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-19Merged revisions 169364 via svnmerge from tilghman1-7/+6
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r169364 | tilghman | 2009-01-19 13:49:25 -0600 (Mon, 19 Jan 2009) | 4 lines Truncate userevents at the end of a line, when the command exceeds the buffer. (closes issue #14278) Reported by: fnordian ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@169365 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-22Introduce ast_careful_fwrite() and use in AMI to prevent partial writes.russell1-24/+1
This patch introduces a function to do careful writes on a file stream which will handle timeouts and partial writes. It is currently used in AMI to address the issue that has been reported. However, there are probably a few other places where this could be used. (closes issue #13546) Reported by: srt Tested by: russell http://reviewboard.digium.com/r/104/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@166282 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-18(closes issue #13993)jpeeler1-3/+7
Reported by: mika Add ActionID response to ping if sent with request. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@165798 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Merged revisions 164806 via svnmerge from russell1-0/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164806 | russell | 2008-12-16 14:35:25 -0600 (Tue, 16 Dec 2008) | 9 lines Add "restart gracefully" to the AMI blacklist of CLI commands. "module unload" was already identified as a command that can not be used from the AMI. "restart gracefully" effectively unloads all modules, and will run in to the same problems. (closes issue #13894) Reported by: kernelsensei ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164807 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-13Merge ast_str_opaque branch (discontinue usage of ast_str internals)tilghman1-12/+14
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163991 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-08Allocate enough space initially for the message.tilghman1-2/+2
(closes issue #14027) Reported by: junky Patches: M14027.diff uploaded by junky (license 177) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@161790 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-05Janitor, use ARRAY_LEN() when possible.eliel1-1/+1
(closes issue #13990) Reported by: eliel Patches: array_len.diff uploaded by eliel (license 64) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@161218 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-03Another place this is missingqwell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@160700 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-03Fix typo when ListCategories returns none.qwell1-1/+1
(closes issue #13994) Reported by: mika Patches: ListCategoriesActionPatch.diff uploaded by mika (license 624) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@160699 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-01Merged revisions 159976 via svnmerge from seanbright1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r159976 | mvanbaak | 2008-12-01 11:08:36 -0500 (Mon, 01 Dec 2008) | 3 lines Get rid of the useless format string and argument in the Bogus/ manager channelname. Noted by kpfleming and name Bogus/manager suggested by eliel ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@160172 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-01Merged revisions 159897 via svnmerge from mvanbaak1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r159897 | mvanbaak | 2008-12-01 15:05:41 +0100 (Mon, 01 Dec 2008) | 4 lines make manager compile on OpenBSD. The last (10th) argument to ast_channel_alloc here should be a pointer and NULL is not really a pointer. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@159898 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-26add support for event suppression for AMI-over-HTTPkpfleming1-2/+9
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@159629 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-25This is basically a complete rollback of r155401, as it was determined thatseanbright1-2/+2
it would be best to maintain API compatibility. Instead, this commit introduces ao2_callback_data() which is functionally identical to ao2_callback() except that it allows you to pass arbitrary data to the callback. Reviewed by Mark Michelson via ReviewBoard: http://reviewboard.digium.com/r/64 git-svn-id: http://svn.digium.com/svn/asterisk/trunk@158959 f38db490-d61c-443f-a65b-d21fe96a405b