aboutsummaryrefslogtreecommitdiffstats
path: root/doc/CODING-GUIDELINES
AgeCommit message (Collapse)AuthorFilesLines
2009-08-10Merged revisions 211584 via svnmerge from tilghman1-3/+4
https://origsvn.digium.com/svn/asterisk/trunk ................ r211584 | tilghman | 2009-08-10 14:49:41 -0500 (Mon, 10 Aug 2009) | 9 lines Merged revisions 211583 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r211583 | tilghman | 2009-08-10 14:48:48 -0500 (Mon, 10 Aug 2009) | 1 line Conversion specifiers, not format specifiers ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@211587 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-10AST-2009-005tilghman1-0/+11
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@211551 f38db490-d61c-443f-a65b-d21fe96a405b
2008-10-09Merged revisions 147807 via svnmerge from murf1-0/+6
https://origsvn.digium.com/svn/asterisk/trunk ........ r147807 | murf | 2008-10-09 08:17:33 -0600 (Thu, 09 Oct 2008) | 15 lines (closes issue #13557) Reported by: nickpeirson Patches: pbx.c.patch uploaded by nickpeirson (license 579) replace_bzero+bcopy.patch uploaded by nickpeirson (license 579) Tested by: nickpeirson, murf 1. replaced all refs to bzero and bcopy to memset and memmove instead. 2. added a note to the CODING-GUIDELINES 3. add two macros to asterisk.h to prevent bzero, bcopy from creeping back into the source 4. removed bzero from configure, configure.ac, autoconfig.h.in ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@147809 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-02Merged revisions 127363 via svnmerge from russell1-0/+226
https://origsvn.digium.com/svn/asterisk/trunk ........ r127363 | russell | 2008-07-02 07:08:33 -0500 (Wed, 02 Jul 2008) | 13 lines Add a locking section to the coding guidelines document. This section covers some locking fundamentals, as well as some information on locking as it is used in Asterisk. It describes some of the ways that are used and could be used to achieve deadlock avoidance. It also demonstrates the unfortunate conclusion that with the use of recursive locks, none of the constructs in use today are failsafe from deadlocks. Finally, it makes some recommendations for new code being written. As proper locking strategies is a complex subject, this section still has room for expansion and improvement. This is a result of collaboration between Luigi Rizzo and myself on the asterisk-dev mailing list. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@127364 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-17Merged revisions 114202 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r114202 | tilghman | 2008-04-17 10:12:52 -0500 (Thu, 17 Apr 2008) | 2 lines fileio.h does not exist; io.h does, though. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@114203 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-261) Make braces mandatory for if/for/while, even around single statements.tilghman1-10/+14
2) Revise the argument parsing section, showing use of the standard macros. 3) Fix a typo. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@104176 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-18A minor update, caused by a recent bug report ;-)oej1-6/+5
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@93557 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-18small documentation update (nothing important).rizzo1-2/+6
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@93536 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-10add a bit of info on the build infrastructurerizzo1-0/+41
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@92084 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-22new info on the management of headersrizzo1-2/+79
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89526 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-14Merged revisions 82376 via svnmerge from mmichelson1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r82376 | mmichelson | 2007-09-14 09:42:29 -0500 (Fri, 14 Sep 2007) | 5 lines Fixing a typo in the coding guidelines (closes issue #10717, reported and patched by leedm777) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@82377 f38db490-d61c-443f-a65b-d21fe96a405b
2007-06-05add a note about inline commentsrussell1-0/+8
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@67273 f38db490-d61c-443f-a65b-d21fe96a405b
2007-05-24add a note about using the intenal API for creating detached threadsrussell1-0/+4
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@65991 f38db490-d61c-443f-a65b-d21fe96a405b
2007-05-04a small upgrade to the coding standard, and an update to the code that ↵murf1-5/+13
triggered the upgrade. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@63048 f38db490-d61c-443f-a65b-d21fe96a405b
2006-09-11More spelling fixes (issue 7930)tilghman1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@42735 f38db490-d61c-443f-a65b-d21fe96a405b
2006-09-11fix minor typo in coding guidelinesrussell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@42684 f38db490-d61c-443f-a65b-d21fe96a405b
2006-07-23update to mention svn instead of cvsrussell1-8/+6
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@38089 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-10fix typo in the provided indent commandrussell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18694 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-04Clarify syntax of new manager events that reports a status.oej1-0/+13
We do not longer approve "ThisEventOn" and "ThisEventOff" named events, they need to be named "ThisEvent" with a status header showing the current status. (Approved by Mark) Old events won't be changed to keep backwards compatibility, until we have a revision plan for the AMI. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@17199 f38db490-d61c-443f-a65b-d21fe96a405b
2006-02-12major dialplan functions updatekpfleming1-2/+4
deprecate LANGUAGE() and MUSICCLASS(), in favor of CHANNEL() git-svn-id: http://svn.digium.com/svn/asterisk/trunk@9674 f38db490-d61c-443f-a65b-d21fe96a405b
2006-01-13Various cleanups from comments in an email from Luigi Rizzo. Thank you!russell1-0/+4
- Use a cleaner syntax for declaring the allocation macros - Fix return value for ast_strdup/ast_strndup - remove safe_strdup from app_macro, since ast_strup does the same thing - fix a place in app_queue where ast_calloc+strncpy was used instead of ast_strdup. If you are helping out with these conversions, please watch out for other places where this is done. - add a note to the coding guidelines about the fix to app_queue git-svn-id: http://svn.digium.com/svn/asterisk/trunk@8065 f38db490-d61c-443f-a65b-d21fe96a405b
2006-01-11fix typo, thanks Qwell!russell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@7953 f38db490-d61c-443f-a65b-d21fe96a405b
2006-01-10Add wrappers for commonly used memory allocation functions. These wrappersrussell1-11/+27
add an automatically generated Asterisk log message if the allocation fails for some reason. Otherwise, they are functionally the same, with the exception of ast_strdup and ast_strndup. These functions have the added ability to accept a NULL argument without error, which will just be ignored without generating an error. The coding guidelines have also been updated to reflect all of this information. (issue #4996) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@7952 f38db490-d61c-443f-a65b-d21fe96a405b
2005-11-29git-svn-id: http://svn.digium.com/svn/asterisk/trunk@7221 ↵kpfleming1-0/+0
f38db490-d61c-443f-a65b-d21fe96a405b
2005-11-10issue #5709russell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@7050 f38db490-d61c-443f-a65b-d21fe96a405b
2005-10-31various text/formatting updates (issue #5503 plus some minor additions)kpfleming1-105/+194
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6909 f38db490-d61c-443f-a65b-d21fe96a405b
2005-07-19update guidelines to explain indent parameteres (bug #4742)russell1-2/+21
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6163 f38db490-d61c-443f-a65b-d21fe96a405b
2005-07-10more thoughtskpfleming1-0/+10
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6078 f38db490-d61c-443f-a65b-d21fe96a405b
2005-07-10minor fixes, and more topics coveredkpfleming1-22/+120
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6077 f38db490-d61c-443f-a65b-d21fe96a405b
2005-06-07update guidelines to follow their own rules for whitespace (bug #4486)kpfleming1-9/+10
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@5880 f38db490-d61c-443f-a65b-d21fe96a405b
2005-06-02add guidelines for doxygen documentation writing (bug #4417, with mods)kpfleming1-1/+50
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@5818 f38db490-d61c-443f-a65b-d21fe96a405b
2005-06-02add a minor allocation/zeroing guidelinekpfleming1-0/+22
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@5817 f38db490-d61c-443f-a65b-d21fe96a405b
2005-05-19add IAXPEER function (bug #4310, with minor formatting and doc changes)kpfleming1-1/+24
add note to CODING-GUIDELINES about minimizing indentation in function bodies git-svn-id: http://svn.digium.com/svn/asterisk/trunk@5733 f38db490-d61c-443f-a65b-d21fe96a405b
2005-05-15more strncpy -> ast_copy_string conversions, fixing some buglets along the waykpfleming1-1/+6
add recommendation to CODING-GUIDELINES to use ast_copy_string instead of strncpy in new code git-svn-id: http://svn.digium.com/svn/asterisk/trunk@5686 f38db490-d61c-443f-a65b-d21fe96a405b
2005-05-01add some notes regarding the distinction between applications and functionskpfleming1-1/+25
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@5542 f38db490-d61c-443f-a65b-d21fe96a405b
2005-04-23add guideline comment about not using '%i' with scanfkpfleming1-0/+4
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@5501 f38db490-d61c-443f-a65b-d21fe96a405b
2005-04-01Update README to reflect modern Asterisk features and requirementskpfleming1-1/+11
Add note in UPGRADE.txt about compiler requirements Add note to CODING-GUIDELINES about new policy for CLI command structure git-svn-id: http://svn.digium.com/svn/asterisk/trunk@5335 f38db490-d61c-443f-a65b-d21fe96a405b
2005-01-19Modify code example suggestionanthm1-11/+22
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@4844 f38db490-d61c-443f-a65b-d21fe96a405b
2005-01-18Additional coding guidelines (bug #3374)markster1-0/+67
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@4840 f38db490-d61c-443f-a65b-d21fe96a405b
2004-11-08Provide "ident" command line (at least the start of one)markster1-0/+5
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@4185 f38db490-d61c-443f-a65b-d21fe96a405b
2004-05-18Update coding guidelinesmarkster1-6/+21
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@3000 f38db490-d61c-443f-a65b-d21fe96a405b
2004-05-15Update coding guidelines, fix "say.c" compile on older compilers, update ↵markster1-0/+5
coding guidelines (includes bug #1631) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@2967 f38db490-d61c-443f-a65b-d21fe96a405b
2004-05-02Add doc/CODING-GUIDELINES documentcitats1-0/+53
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@2863 f38db490-d61c-443f-a65b-d21fe96a405b