aboutsummaryrefslogtreecommitdiffstats
path: root/channels
AgeCommit message (Collapse)AuthorFilesLines
2008-04-21Only drop audio if we receive it without a progress indication. We allow ↵file1-1/+1
other frames through such as DTMF because they may be needed to complete the call. (closes issue #12440) Reported by: aragon git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114322 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-18Clearing up error messages so they make a bit more sense. Also removing a ↵mmichelson1-4/+1
redundant error message. Issue AST-15 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114257 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-18Ensure that we don't ast_strdupa(NULL)russell1-1/+1
(closes issue #12476) Reported by: davidw Patch by me git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114248 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-18Only complete the SIP channel name once for 'sip show channel <channel>'seanbright1-0/+4
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114245 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-16use the ZT_SET_DIALPARAMS ioctl properly by initializing the structure to ↵kpfleming1-0/+2
all zeroes in case it contains fields that we don't write values into (which it does as of Zaptel 1.4.10) (closes issue #12456) Reported by: fnordian git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114184 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-16Backport revisions for latest vpb drivers to 1.4tilghman1-1316/+1157
(Closes issue #12457) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114180 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-16Fix "fallthrough" behavior here, so config options in a previously ↵qwell1-5/+4
configured user don't override settings in general. (closes issue #12458) Reported by: tzafrir Patches: chanzap_users_sections.diff uploaded by tzafrir (license 46) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114173 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-15Handle subscribe queues in all situations... Thanks to festr_ on irc for ↵oej1-1/+6
telling me about this bug. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114148 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-14The call_token on the pvt can occasionally be NULL, causing a crash.qwell1-1/+1
If it is NULL, we can skip this channel, since it can't the one we're looking for. (closes issue #9299) Reported by: vazir git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114120 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-14It is possible for the remote side to say they want T38 but not give any ↵file1-1/+1
capabilities. (closes issue #12414) Reported by: MVF git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114103 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-11Several places in the code called find_callno() (which releases the lock on ↵twilson1-12/+29
the pvt structure) and then immediately locked the call and did things with it. Unfortunately, the call can disappear between the find_callno and the lock, causing Bad Stuff(tm) to happen. Added find_callno_locked() function to return the callno withtout unlocking for instances that it is needed. (issue #12400) Reported by: ztel git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114083 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-10Be sure that we're not about to set bridgepvt NULL prior to dereferencing it.mmichelson1-1/+1
(closes issue #11775) Reported by: fujin git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114045 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-10Don't add custom URI options if they don't exist OR they are empty.file1-1/+1
(closes issue #12407) Reported by: homesick Patches: uri_options-1.4.diff uploaded by homesick (license 91) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@114021 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-09We need to set the persistant_route [sic] parameter for the sip_pvtmmichelson1-2/+3
during the initial INVITE, no matter if we're building the route set from an INVITE request or response. (closes issue #12391) Reported by: benjaminbohlmann Tested by: benjaminbohlmann git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113927 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-09If we receive an AUTHREQ from the remote server and we are unable to reply ↵file1-0/+4
(for example they have a secret configured, but we do not) then queue a hangup frame on the Asterisk channel. This will cause the channel to hangup and a HANGUP to be sent via IAX2 to the remote side which is the proper thing to do in this scenario. (closes issue #12385) Reported by: viraptor git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113784 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-09If Asterisk receives a 488 on an INVITE (not a reinvite), thenmmichelson1-1/+4
we should not send a BYE. (closes issue #12392) Reported by: fnordian Patches: chan_sip.patch uploaded by fnordian (license 110) with small modification from me git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113681 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-09Initialize fr->cacheable to make valgrind happytwilson1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113596 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-08Add a little more that is required for previously added devices.qwell1-0/+21
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113504 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-08Add support for several new(ish) devices - most notably, 7942/7945, ↵qwell1-0/+23
7962/7965, 7975. Thanks to Greg Oliver for providing me the required information. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113454 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-08Move check for still-bridged channels out a little further, to avoid possibletilghman1-10/+26
deadlocks. (Closes issue #12252) Reported by: callguy Patches: 20080319__bug12252.diff.txt uploaded by Corydon76 (license 14) Tested by: callguy git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113348 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-07(closes issue #12362) [redo of 113012]jpeeler1-2/+2
This fixes a for loop (in realtime_peer) to check all the ast_variables the loop was intending to test rather than just the first one. The change exposed the problem of calling memcpy on a NULL pointer, in this case the passed in sockaddr_in struct which is now checked. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113240 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-07Allow playback with noanswer (and add earlyrtp option).qwell1-14/+37
(closes issue #9077) Reported by: pj Patches: earlyrtp.diff uploaded by wedhorn (license 30) Tested by: pj, qwell, DEA, wedhorn git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113118 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-07(closes issue #12362)jpeeler1-1/+1
(closes issue #12372) Reported by: vinsik Tested by: tecnoxarxa This one line change makes an if inside a for loop (in realtime_peer) check all the ast_variables the loop was intending to test rather than just the first one. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113012 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-04Free newly allocated channel before returningphsultan1-1/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@112820 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-04Prevent call connections when codecs don't match.phsultan1-44/+123
(closes issue #10604) Reported by: keepitcool Patches: branch-1.4-10604-2.diff uploaded by phsultan (license 73) Tested by: phsultan git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@112766 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-03Fix the testing of the "res" variable so that it is more logically correct and mmichelson1-14/+16
makes the correct warning and debug messages print. (closes issue #12361) Reported by: one47 Patches: chan_zap_deferred_digit.patch uploaded by one47 (license 23) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@112599 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-01Do not pass audio until the remote side has indicated they are providing ↵file1-0/+5
early media, or if the channel has been answered. (closes issue #11823) Reported by: SDamm git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@112204 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-28Remove unimplemented softkeys. Prompted by issue #12325.qwell1-3/+3
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@111720 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-26If we are requested to authenticate a reinvite make sure that it contains ↵file1-1/+1
T38 SDP if need be. (closes issue #11995) Reported by: fall git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@111020 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-26Make sure that full video frames are sent whenever the 15 bit timestamp ↵file1-3/+27
rolls over. (closes issue #11923) Reported by: mihai Patches: asterisk-fullvideo.patch uploaded by mihai (license 94) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@111014 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-25This one line change makes an if inside a for loop (in realtime_peer) check ↵jpeeler1-1/+1
all the ast_variables the loop was intending to test rather than just the first one. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@110727 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-25When reverting a commit, I accidentally left in this bit which was an experimentmmichelson1-1/+3
to see what would happen. It passed the compile test, and I didn't notice I had left this change in too. So this is a revert of a revert...sort of. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@110635 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-24This is a revert for revision 108288. The reason is that that revisionmmichelson1-6/+3
was not for an actual bug fix per se, and so it really should not have been in 1.4 in the first place. Plus, people who compile with DO_CRASH are more likely to encounter a crash due to this change. While I think the usage of DO_CRASH in ast_sched_del is a bit absurd, this sort of change is beyond the scope of 1.4 and should be done instead in a developer branch based on trunk so that all scheduler functions are fixed at once. I also am reverting the change to trunk and 1.6 since they also suffer from the DO_CRASH potential. (closes issue #12272) Reported by: qq12345 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@110618 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-24Turn a NOTICE into a DEBUG message.russell1-4/+4
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@110614 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-20Merged revisions 110335 via svnmerge from russell2-13/+9
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r110335 | russell | 2008-03-20 16:53:27 -0500 (Thu, 20 Mar 2008) | 6 lines Fix some very broken code that was introduced in 1.2.26 as a part of the security fix. The dnsmgr is not appropriate here. The dnsmgr takes a pointer to an address structure that a background thread continuously updates. However, in these cases, a stack variable was passed. That means that the dnsmgr thread would be continuously writing to bogus memory. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@110336 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-18Make sure an agent doesn't try to send dtmf to a NULL channelmmichelson1-2/+6
closes issue #12242 Reported by Yourname git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@109575 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-18Merged revisions 109391 via svnmerge from qwell1-2/+0
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r109391 | qwell | 2008-03-18 10:08:41 -0500 (Tue, 18 Mar 2008) | 3 lines Do not return with a successful authentication if the From header ends up empty. (AST-2008-003) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@109393 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-18Put a maximum limit on the number of payloads accepted, and also make sure a ↵file1-13/+21
given payload does not exceed our maximum value. (AST-2008-002) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@109386 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-17Update the directory of placed calls on skinny phones ↵mvanbaak1-0/+1
when dialing a channel that does not provide progress (analog ZAP lines) The phone does handle the double update on calls to channels that do provide progress and wont insert duplicate items (closes issue #12239) Reported by: DEA Patches: chan_skinny-call-log.txt uploaded by DEA (license 3) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@109171 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-17200 OKs in response to a reinvite need to be sent reliably. If the remote ↵file1-1/+1
side does not receive one the dialog will be torn down. (closes issue #12208) Reported by: atrash git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@109107 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-14Fix a channel name issue. chan_oss registers the "Console" channel type,russell1-1/+1
but it created channels with an "OSS" prefix. (closes issue #12194, reported by davidw, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@108796 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-14Fix a race condition in the SIP packet scheduler which could cause a crash.mmichelson1-6/+27
chan_sip uses the scheduler API in order to schedule retransmission of reliable packets (such as INVITES). If a retransmission of a packet is occurring, then the packet is removed from the scheduler and retrans_pkt is called. Meanwhile, if a response is received from the packet as previously transmitted, then when we ACK the response, we will remove the packet from the scheduler and free the packet. The problem is that both the ACK function and retrans_pkt attempt to acquire the same lock at the beginning of the function call. This means that if the ACK function acquires the lock first, then it will free the packet which retrans_pkt is about to read from and write to. The result is a crash. The solution: 1. If the ACK function fails to remove the packet from the scheduler and the retransmit id of the packet is not -1 (meaning that we have not reached the maximum number of retransmissions) then release the lock and yield so that retrans_pkt may acquire the lock and operate. 2. Make absolutely certain that the ACK function does not recursively lock the lock in question. If it does, then releasing the lock will do no good, since retrans_pkt will still be unable to acquire the lock. (closes issue #12098) Reported by: wegbert (closes issue #12089) Reported by: PTorres Patches: 12098-putnopvutv3.patch uploaded by putnopvut (license 60) Tested by: jvandal git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@108737 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-13Make a tweak that gets the LEDs on polycom phones to blink when an extension ↵russell1-1/+1
that has been subscribed to goes on hold. Otherwise, they just stay on like it does when an extension is in use. (closes issue #11263) Reported by: russell Patches: notify_hold.rev1.txt uploaded by russell (license 2) Tested by: russell git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@108530 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-12Change AST_SCHED_DEL use to ast_sched_del for autocongestion in chan_sip.mmichelson1-3/+3
The scheduler callback will always return 0. This means that this id is never rescheduled, so it makes no sense to loop trying to delete the id from the scheduler queue. If we fail to remove the item from the queue once, it will fail every single time. (Yes I realize that in this case, the macro would exit early because the id is set to -1 in the callback, but it still makes no sense to use that macro in favor of calling ast_sched_del once and being done with it) This is the first of potentially several such fixes. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@108288 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-12if we receive an INVITE with a Content-Length that is not a valid number, or ↵kpfleming1-0/+15
is zero, then don't process the rest of the message body looking for an SDP closes issue #11475 Reported by: andrebarbosa git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@108086 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11Copy voicemail dependency logic for res_adsi to chan_gtalk (for jabber).qwell1-0/+7
(closes issue #12014) Reported by: junky git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107714 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11get chan_vpb to build properly in dev modekpfleming1-2/+0
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107713 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11fix various other problems found by gcc 4.3kpfleming2-10/+6
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107464 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11If we fail to alloc a channel, we should re-lock the pvt structure before ↵twilson1-0/+1
returning. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107290 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-10Make sure to reenable echo can after a "failed" (canceled, etc) three-way call.qwell1-0/+1
(closes issue #11335) Reported by: rebuild git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107173 f38db490-d61c-443f-a65b-d21fe96a405b
generated by cgit v1.2.3 (git 2.25.1) at 2024-04-27 11:15:53 +0000