aboutsummaryrefslogtreecommitdiffstats
path: root/channels
AgeCommit message (Collapse)AuthorFilesLines
2008-03-18Merged revisions 109391 via svnmerge from qwell1-2/+0
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r109391 | qwell | 2008-03-18 10:08:41 -0500 (Tue, 18 Mar 2008) | 3 lines Do not return with a successful authentication if the From header ends up empty. (AST-2008-003) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@109393 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-18Put a maximum limit on the number of payloads accepted, and also make sure a ↵file1-13/+21
given payload does not exceed our maximum value. (AST-2008-002) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@109386 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-17Update the directory of placed calls on skinny phones ↵mvanbaak1-0/+1
when dialing a channel that does not provide progress (analog ZAP lines) The phone does handle the double update on calls to channels that do provide progress and wont insert duplicate items (closes issue #12239) Reported by: DEA Patches: chan_skinny-call-log.txt uploaded by DEA (license 3) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@109171 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-17200 OKs in response to a reinvite need to be sent reliably. If the remote ↵file1-1/+1
side does not receive one the dialog will be torn down. (closes issue #12208) Reported by: atrash git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@109107 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-14Fix a channel name issue. chan_oss registers the "Console" channel type,russell1-1/+1
but it created channels with an "OSS" prefix. (closes issue #12194, reported by davidw, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@108796 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-14Fix a race condition in the SIP packet scheduler which could cause a crash.mmichelson1-6/+27
chan_sip uses the scheduler API in order to schedule retransmission of reliable packets (such as INVITES). If a retransmission of a packet is occurring, then the packet is removed from the scheduler and retrans_pkt is called. Meanwhile, if a response is received from the packet as previously transmitted, then when we ACK the response, we will remove the packet from the scheduler and free the packet. The problem is that both the ACK function and retrans_pkt attempt to acquire the same lock at the beginning of the function call. This means that if the ACK function acquires the lock first, then it will free the packet which retrans_pkt is about to read from and write to. The result is a crash. The solution: 1. If the ACK function fails to remove the packet from the scheduler and the retransmit id of the packet is not -1 (meaning that we have not reached the maximum number of retransmissions) then release the lock and yield so that retrans_pkt may acquire the lock and operate. 2. Make absolutely certain that the ACK function does not recursively lock the lock in question. If it does, then releasing the lock will do no good, since retrans_pkt will still be unable to acquire the lock. (closes issue #12098) Reported by: wegbert (closes issue #12089) Reported by: PTorres Patches: 12098-putnopvutv3.patch uploaded by putnopvut (license 60) Tested by: jvandal git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@108737 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-13Make a tweak that gets the LEDs on polycom phones to blink when an extension ↵russell1-1/+1
that has been subscribed to goes on hold. Otherwise, they just stay on like it does when an extension is in use. (closes issue #11263) Reported by: russell Patches: notify_hold.rev1.txt uploaded by russell (license 2) Tested by: russell git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@108530 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-12Change AST_SCHED_DEL use to ast_sched_del for autocongestion in chan_sip.mmichelson1-3/+3
The scheduler callback will always return 0. This means that this id is never rescheduled, so it makes no sense to loop trying to delete the id from the scheduler queue. If we fail to remove the item from the queue once, it will fail every single time. (Yes I realize that in this case, the macro would exit early because the id is set to -1 in the callback, but it still makes no sense to use that macro in favor of calling ast_sched_del once and being done with it) This is the first of potentially several such fixes. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@108288 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-12if we receive an INVITE with a Content-Length that is not a valid number, or ↵kpfleming1-0/+15
is zero, then don't process the rest of the message body looking for an SDP closes issue #11475 Reported by: andrebarbosa git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@108086 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11Copy voicemail dependency logic for res_adsi to chan_gtalk (for jabber).qwell1-0/+7
(closes issue #12014) Reported by: junky git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107714 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11get chan_vpb to build properly in dev modekpfleming1-2/+0
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107713 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11fix various other problems found by gcc 4.3kpfleming2-10/+6
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107464 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11If we fail to alloc a channel, we should re-lock the pvt structure before ↵twilson1-0/+1
returning. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107290 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-10Make sure to reenable echo can after a "failed" (canceled, etc) three-way call.qwell1-0/+1
(closes issue #11335) Reported by: rebuild git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107173 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-08don't generate D-Channel "up" and "down" messages unless the channel state ↵kpfleming1-7/+13
is actually changing; also, generate the "up" message when an implicit "up" occurs due to reception of a normal event when we thought the channel was "down" git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106945 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-07Safely use the strncat() function.tilghman1-10/+5
(closes issue #11958) Reported by: norman Patches: 20080209__bug11958.diff.txt uploaded by Corydon76 (license 14) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106552 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-05Fix a potential deadlock and a few different potential crashes.russell1-11/+28
(closes issue #12145, reported by thiagarcia, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106237 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-05Add a control frame to indicate the source of media has changed. Depending ↵file8-62/+83
on the underlying technology it may need to change some things. (closes issue #12148) Reported by: jcomellas git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106235 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-05when a PRI call must be moved to a different B channel at the request of the ↵kpfleming1-16/+23
other endpoint, ensure that any DSP active on the original channel is moved to the new one (closes issue #11917) Reported by: mavetju Tested by: mavetju git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106038 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-05Correctly initialize retransid in SIP, and ensure that the warning when ↵tilghman1-0/+1
failing to delete a schedule entry can actually hit the log. (closes issue #12140) Reported by: slavon Patches: sch2.patch uploaded by slavon (license 288) (Patch slightly modified by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106015 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-04When a new source of audio comes in (such as music on hold) make sure the ↵file1-1/+6
marker bit gets set. (closes issue #10355) Reported by: wdecarne Patches: 10355.diff uploaded by file (license 11) (closes issue #11491) Reported by: kanderson git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105674 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-03In the case of an ast_channel allocation failure, take the local_pvt out of therussell1-1/+8
pvt list before destroying it. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105570 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-03Fix a potential memory leak of the local_pvt struct when ast_channel allocationrussell1-10/+14
fails. Also, in passing, centralize the code necessary to destroy a local_pvt. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105568 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-03Add a comment to describe some logic.file1-0/+1
(closes issue #12120) Reported by: flefoll Patches: chan_sip.c.br14.patch-just-a-comment uploaded by flefoll (license 244) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105557 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-28According to a video at www.cisco.com, the 7921G supports 6 line appearances.qwell1-1/+4
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104920 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-27When we receive a known alarm, make sure that the unknown alarm flag is not ↵russell1-0/+4
still set to make sure that when we come back out of alarm, it gets reported in the log and manager interface (after discussion with tzafrir on the -dev list) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104591 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-27Zaptel 1.4 now exposes FXO battery state as an alarm. However, Asterisk 1.4russell1-16/+47
does not know what to do with these alarms. Only Asterisk 1.6 cares about it. So, if we get an unknown alarm in chan_zap, don't generate confusing log messages about it. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104332 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-26Merge changes from team/russell/smdi-1.4russell1-1/+1
This commit brings in a significant set of changes to the SMDI support in Asterisk. There were a number of bugs in the current implementation, most notably being that it was very likely on busy systems to pop off the wrong message from the SMDI message queue. So, this set of changes fixes the issues discovered as well as introducing some new ways to use the SMDI support which are required to avoid the bugs with grabbing the wrong message off of the queue. This code introduces a new interface to SMDI, with two dialplan functions. First, you get an SMDI message in the dialplan using SMDI_MSG_RETRIEVE() and then you access details in the message using the SMDI_MSG() function. A side benefit of this is that it now supports more than just chan_zap. For example, with this implementation, you can have some FXO lines being terminated on a SIP gateway, but the SMDI link in Asterisk. Another issue with the current implementation is that it is quite common that the station ID that comes in on the SMDI link is not necessarily the same as the Asterisk voicemail box. There are now additional directives in the smdi.conf configuration file which let you map SMDI station IDs to Asterisk voicemail boxes. Yet another issue with the current SMDI support was related to MWI reporting over the SMDI link. The current code could only report a MWI change when the change was made by someone calling into voicemail. If the change was made by some other entity (such as with IMAP storage, or with a web interface of some kind), then the MWI change would never be sent. The SMDI module can now poll for MWI changes if configured to do so. This work was inspired by and primarily done for the University of Pennsylvania. (also related to issue #9260) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104119 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-26IPTOS_MINCOST is not defined on Solaris.qwell1-1/+1
(closes issue #12050) Reported by: asgaroth Patches: 12050.patch uploaded by putnopvut (license 60) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104111 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25Make it so a users.conf user creates both a SIP peer and a SIP user. The ↵file1-5/+11
user will be used for inbound authentication for the device, and peer will be used for placing calls to the device. (closes issue #9044) Reported by: queuetue Patches: sip-gui-friend.diff uploaded by qwell (license 4) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104095 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25Ensure that the channel doesn't disappear in agent_logoff(). If it does, itrussell1-2/+21
could cause a crash. (fixes the crash reported in BE-396) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104086 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25If a resubscription comes in for a dialog we no longer know about tell the ↵file1-0/+12
remote side that the dialog does not exist so they subscribe again using a new dialog. (closes issue #10727) Reported by: s0l4rb03 Patches: 10727-2.diff uploaded by file (license 11) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104084 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25Due to recent changes tag will no longer be NULL if not present so we have ↵file1-1/+1
to use ast_strlen_zero to see if it's actually blank. (closes issue #12061) Reported by: flefoll Patches: chan_sip.c.br14.patch_pedantic_no_totag uploaded by flefoll (license 244) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104082 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-22Backwards debug message.tilghman1-2/+2
(closes issue #12052) Reported by: flefoll Patches: chan_sip.c.br14.patch_found-notfound uploaded by flefoll (license 244) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104037 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-21And as a followup to revision 104026, completely remove event-relatedmmichelson1-4/+0
calls from a section of code where we know there was no event to handle or get. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104027 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-21Remove an incorrect debug message. It reported that it had received a ↵mmichelson1-2/+0
specific event and tried to report which event was received. What actually was happening was that it was reporting the number of bytes returned from a call to read(). Thanks to Jared Smith for bringing the issue up on IRC git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104026 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-20Don't wait for additional digits when overlap dialing is enabled if the ↵file1-1/+1
setup message contains the sending_complete information element. (closes issue #11785) Reported by: klaus3000 Patches: sending_complete_overlap_asterisk-1.4.17.patch.txt uploaded by klaus3000 (license 65) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103953 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-20Fix a crash if the channel becomes NULL while attempting to lock it.mmichelson1-3/+5
(closes issue #12039) Reported by: danpwi git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103904 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-19Send CallerID Name in setup message.file1-2/+3
(closes issue #11241) Reported by: tusar Patches: h323id_as_callerid_name.patch uploaded by tusar (license 344) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103823 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-19Account for the fact that the "other" channel can disappear while the local pvtrussell1-13/+11
is not locked. (fixes a problem introduced in rev 100581) (closes issue #12012) Reported by: stevedavies Patch by me git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103821 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-19Fix building of chan_sip.file1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103807 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-19Make sure we send error replies correctly by checking the via header.oej1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103806 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-18Fix previous commit so that we actually disable echocanbridged if echocancel ↵qwell1-2/+8
is off. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103795 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-18Correct a message when echocancelwhenbridged is on, but echocancel is not.qwell1-1/+1
Issue #12019 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103790 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-18When a SIP channel is being auto-destroyed, it's possible for it to still betilghman1-12/+24
in bridge code. When that happens, we crash. Delay the RTP destruction until the bridge is ended. (closes issue #11960) Reported by: norman Patches: 20080215__bug11960__2.diff.txt uploaded by Corydon76 (license 14) Tested by: norman git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103780 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-18Fix a linked list corruption that under the right circumstancesmmichelson1-0/+3
could lead to a looped list, meaning it will traverse forever. (closes issue #11818) Reported by: michael-fig Patches: 11818.patch uploaded by putnopvut (license 60) Tested by: michael-fig git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103770 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-18Don't care if the extension given doesn't exist for subscription based MWI.file1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103763 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-15Fix a crash in chan_iax2 due to a race conditionrussell1-4/+7
(closes issue #11780) Reported by: guillecabeza Patches: bug_iax2_jb_1.4.patch uploaded by guillecabeza (license 380) bug_iax2_jb_trunk.patch uploaded by guillecabeza (license 380) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103741 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-13We aren't talking to ourselves; we're talking to someone else.tilghman1-1/+5
(closes issue #11771) Reported by: msetim Patches: ami_agent_talkingto-1.4.diff uploaded by caio1982 (license 22) Tested by: caio1982, msetim git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103607 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-12Even if no CallerID name or number has been provided by the remote party ↵file1-4/+4
still use the configured sip.conf ones. (closes issue #11977) Reported by: pj git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103385 f38db490-d61c-443f-a65b-d21fe96a405b