aboutsummaryrefslogtreecommitdiffstats
path: root/channels
AgeCommit message (Collapse)AuthorFilesLines
2008-02-13We aren't talking to ourselves; we're talking to someone else.tilghman1-1/+5
(closes issue #11771) Reported by: msetim Patches: ami_agent_talkingto-1.4.diff uploaded by caio1982 (license 22) Tested by: caio1982, msetim git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103607 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-12Even if no CallerID name or number has been provided by the remote party ↵file1-4/+4
still use the configured sip.conf ones. (closes issue #11977) Reported by: pj git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103385 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-08Yield the thread and return -1 if the ioctl fails for Zaptel timing device.mmichelson1-3/+5
(closes issue #11891) Reported by: tzafrir git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103070 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-08Make sure the presence of dbsecret is factored into user scoring.file1-1/+1
(closes issue #11952) Reported by: bbhoss git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@102968 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-06Only consider a T.38-only INVITE compatible if we have both a joint ↵file1-1/+1
capability between us and them and if they provided T.38. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@102725 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-05Clear the DTMF buffer on hangup.mmichelson1-0/+3
(closes issue #11919) Reported by: eferro Patches: mgcp_dtmfclean_on_hangup.diff uploaded by eferro (license 337) Tested by: eferro git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@102453 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-05If a REGISTER attempt comes in that is a retransmission of a previous ↵file1-3/+9
REGISTER do not create a new nonce value. (issue #BE-381) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@102450 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-05ensure that components of chan_misdn.so are built using any special build ↵kpfleming1-0/+2
options that the configure script generated (reported by Philipp Kempgen on asterisk-dev) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@102425 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-03Use the same CSEQ on CANCEL as on INVITE (according to RFC 3261)oej1-2/+2
(closes issue #9492) Reported by: kryptolus Patches: bug9492.txt uploaded by oej (license 306) Tested by: oej git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@102142 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-03Handle ACK and CANCEL in an invite transaction - even if we get INFO ↵oej1-6/+11
transactions during the actual call setup. (closes issue #10567) Reported by: jacksch Tested by: oej Patch by: oej inspired by suggestions from neutrino88 in the bug tracker git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@102090 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-01Change the SDP_SAMPLE_RATE macro. It turns out that even though G.722 is 16 ↵russell1-1/+6
kHz, it is supposed to specified as 8 kHz in the RTP, and RTP timestamps are supposed to be calculated based on 8 kHz. (Apparently this is due to a bug in a spec, but people follow it anyway, because it's the spec ...) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101989 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-01Add some more sanity checking on IAX2 dial strings for the case that no peerrussell1-7/+19
or hostname was provided, which is the one part of the dial string that is absolutely required. If it's not there, bail out. (closes issue #11897) Reported by sokhapkin Patch by me git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101693 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-31Solaris compat fixes for struct in_addr funkiness.qwell2-3/+6
Issue #11885, patch by snuffy. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101482 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-31Add more missing locking of the agents list ...russell1-3/+11
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101433 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-31Move the locking from find_agent() into the agent dialplan function handler torussell1-2/+8
ensure that the agent doesn't disappear while we're looking at it. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101414 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-31Add missing locking to the find_agent() function.russell1-0/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101413 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-30Stop musiconhold on attended transfer.oej1-1/+3
(closes issue #11872) Reported by: gareth Patches: svn-101018.patch uploaded by gareth (license 208) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101152 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-29Initialize an array to 0s if config option not specified.qwell1-1/+2
(closes issue #11860) Patches: misdn_get_config.v1.diff uploaded by IgorG (license 20) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100930 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-29Allow zap groups above 30 to work properly.qwell1-3/+3
(closes issue #11590) Reported by: tbsky git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100835 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-29fixed potential segfault in misdn show channels CLI commandcrichter1-1/+9
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100793 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-29(closes issue #11736)oej1-6/+25
Reported by: MVF Patches: bug11736-2.diff uploaded by oej (license 306) Tested by: oej, MVF, revolution (russellb: This was the showstopper for the release.) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100740 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-28Undoing the deprecation of chan_vpb. It is alive and well.mmichelson1-6/+0
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100673 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-28For some reason, the use of this strdupa() is leading to memory corruption onrussell1-3/+3
freebsd sparc64. This trivial workaround fixes it. (closes issue #10300, closes issue #11857, reported by mattias04 and Home-of-the-Brave) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100629 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-28Correct a comment which made little/no sense.qwell1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100624 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-28Make some deadlock related fixes. These bugs were discovered and reportedrussell1-19/+18
internally at Digium by Steve Pitts. - Fix up chan_local to ensure that the channel lock is held before the local pvt lock. - Don't hold the channel lock when executing the timing function, as it can cause a deadlock when using chan_local. This actually changes the code back to be how it was before the change for issue #10765. But, I added some other locking that I think will prevent the problem reported there, as well. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100581 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-27When deleting a task from the scheduler, ignoring the return value couldtilghman5-198/+119
possibly cause memory to be accessed after it is freed, which causes all sorts of random memory corruption. Instead, if a deletion fails, wait a bit and try again (noting that another thread could change our taskid value). (closes issue #11386) Reported by: flujan Patches: 20080124__bug11386.diff.txt uploaded by Corydon76 (license 14) Tested by: Corydon76, flujan, stuarth` git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100465 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-25Deprecating chan_vpb. It is now preferred that users of Voicetronix productsmmichelson1-0/+6
use chan_zap in combination with their zaptel drivers. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100418 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-25This would have never been true, since we're passing (sizeof(req.data) - 1) ↵qwell1-4/+3
as the len to recvfrom(). git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100378 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-23Second attempt. Don't change invitestate when receiving 18x messages in ↵oej1-2/+4
CANCEL state. (issue #11736) Reported by: MVF Patch by oej. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99978 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-23Make sure we don't cancel destruction on calls in CANCEL state, even if weoej1-5/+5
get 183 while waiting for answer on our CANCEL. (issue #11736) Reported by: MVF Patches: bug11736.txt uploaded by oej (license 306) Tested by: MVF git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99977 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-23These flag tests were illogical. They were testing sip_peer flags on a sip_pvt.mmichelson1-2/+2
Thanks to Russell for helping to get this odd problem figured out. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99878 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-22Thanks to Russell's education I realize that BUFSIZ has changed since I ↵oej1-41/+43
learned the C language over 20 years ago... Resetting chan_sip to the size of BUFSIZ that I expected in my old head to avoid to heavy memory allocations on some systems. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99652 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-22Add more dependencies on chan_local and add a note to the description of ↵oej2-1/+4
chan_local so that people don't disable it in menuselect just to clean up. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99594 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-22Cleaning up some documentation that led to confusion in a bug reportoej1-5/+6
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99501 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-21Fixing an issue wherein monitoring local channels was not possible. During a ↵mmichelson1-0/+11
channel masquerade, the monitors on the two channels involved are swapped. In 99% of the cases this results in the desired effect. However, if monitoring a local channel, this caused the monitor which was on the local channel to get moved onto a channel which is immediately hung up after the masquerade has completed. By swapping the monitors prior to the masquerade, we avoid the problem by tricking the masquerade into placing the monitor back onto the channel where we want it. During the investigation of the issue, the channel's monitor was the only thing that was swapped in such a manner which did not make sense to have done. All other variable swapping made sense. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99426 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-21Bump the buffer size for Via headers up to 512. There are some exceptionally ↵file1-3/+3
large Via headers out there. (closes issue #11783) Reported by: ofirroval git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99301 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-17Have IAX2 optimize the codec translation path just like chan_sip does it. Ifrussell1-7/+18
the caller's codec is in our codec list, move it to the top to avoid transcoding. (closes issue #10500) Reported by: stevedavies Patches: iax-prefer-current-codec.patch uploaded by stevedavies (license 184) iax-prefer-current-codec.1.4.patch uploaded by stevedavies (license 184) Tested by: stevedavies, pj, sheldonh git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99004 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-16Add missing NULLs at end of two ast_load_realtimes.file1-2/+2
(closes issue #11769) Reported by: tequ Patches: chaniax.patch uploaded by dimas (license 88) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98966 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-16Fix a deadlock in chan_local in local_hangup. There was contention becausemmichelson1-1/+9
the local_pvt was held and it was attempting to lock a channel, which is the incorrect locking order. (closes issue #11730) Reported by: UDI-Doug Patches: 11730.patch uploaded by putnopvut (license 60) Tested by: UDI-Doug git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98964 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-16Don't drop the old record route information when dealing with packets ↵file1-1/+2
related to a reinvite. (closes issue #11545) Reported by: kebl0155 Patches: reinvite-patch.txt uploaded by kebl0155 (license 356) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98955 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-15Change a buffer in check_auth() to be a thread local dynamically allocatedrussell1-3/+12
buffer, instead of a massive buffer on the stack. This fixes a crash reported by Qwell due to running out of stack space when building with LOW_MEMORY defined. On a very related note, the usage of BUFSIZ in various places in chan_sip is arbitrary and careless. BUFSIZ is a system specific define. On my machine, it is 8192, but by definition (according to google) could be as small as 256. So, this buffer in check_auth was 16 kB. We don't even support SIP messages larger than 4 kB! Further usage of this define should be avoided, unless it is used in the proper context. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98946 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-15Commit a fix for some memory access errors pointed out by the valgrind2.txtrussell1-1/+1
output on issue #11698. The issue here is that it is possible for an instance of a translator to get destroyed while the frame allocated as a part of the translator is still being processed. Specifically, this is possible anywhere between a call to ast_read() and ast_frame_free(), which is _a lot_ of places in the code. The reason this happens is that the channel might get masqueraded during this time. During a masquerade, existing translation paths get destroyed. So, this patch fixes the issue in an API and ABI compatible way. (This one is for you, paravoid!) It changes an int in ast_frame to be used as flag bits. The 1 bit is still used to indicate that the frame contains timing information. Also, a second flag has been added to indicate that the frame came from a translator. When a frame with this flag gets released and has this flag, a function is called in translate.c to let it know that this frame is doing being processed. At this point, the flag gets cleared. Also, if the translator was requested to be destroyed while its internal frame still had this flag set, its destruction has been deffered until it finds out that the frame is no longer being processed. Admittedly, this feels like a hack. But, it does fix the issue, and I was not able to think of a better solution ... git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98943 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-15Based on the boundary found move over the correct amount.file1-2/+5
(closes issue #11750) Reported by: tasker git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98934 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-14Accept "; boundary=" not just ";boundary=" in the multipart mixed content type.file1-1/+1
(closes issue #11750) Reported by: tasker git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98894 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-11Back out changes from revision 97077, since it wasn't perfecttilghman1-147/+89
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98164 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-101) When we get a translated frame out, clone it, because if thetilghman1-4/+11
translator pvt is freed before we use the frame, bad things happen. 2) Getting a failure from ast_sched_delete means that the schedule ID is currently running. Don't just ignore it. (Closes issue #11698) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97973 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-09Set the caller id within the gtalk_alloc function.phsultan1-15/+4
As underlined in issue #10437 by Josh, we need to prevent a possible memory leak. We only set the name part of the caller id, the number part is not relevant when dealing with JIDs. Closes issue #11549. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97489 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-09pass the right variable to get an error string... oopskpfleming1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97448 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-09add error number output to ioctl failure messages to help with debuggingkpfleming1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97410 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-08Fix various DTMF issues in chan_mgcp.file1-11/+49
(closes issue #11443) Reported by: eferro Patches: dtmf_control_hybrid-inband-mode.patch uploaded by eferro (license 337) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97195 f38db490-d61c-443f-a65b-d21fe96a405b