Age | Commit message (Collapse) | Author | Files | Lines |
|
This re-renames ast_rtp_update_source to ast_rtp_new_source
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@253158 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
https://origsvn.digium.com/svn/asterisk/trunk
........
r252089 | twilson | 2010-03-12 16:04:51 -0600 (Fri, 12 Mar 2010) | 20 lines
Only change the RTP ssrc when we see that it has changed
This change basically reverts the change reviewed in
https://reviewboard.asterisk.org/r/374/ and instead limits the
updating of the RTP synchronization source to only those times when we
detect that the other side of the conversation has changed the ssrc.
The problem is that SRCUPDATE control frames are sent many times where
we don't want a new ssrc, including whenever Asterisk has to send DTMF
in a normal bridge. This is also not the first time that this mistake
has been made. The initial implementation of the ast_rtp_new_source
function also changed the ssrc--and then it was removed because of
this same issue. Then, we put it back in again to fix a different
issue. This patch attempts to only change the ssrc when we see that
the other side of the conversation has changed the ssrc.
It also renames some functions to make their purpose more clear.
Review: https://reviewboard.asterisk.org/r/540/
........
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@252175 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@211528 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Mostly trivial changes, but I did not know of any other way to fix the
"dereferencing type-punned pointer will break strict-aliasing rules" error
without creating a tmp variable in chan_skinny.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@208746 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
We have seen a number of problems caused by poll() not working properly on
Mac OSX. If you search around, you'll find a number of references to using
select() instead of poll() to work around these issues. In Asterisk, we've
had poll.c which implements poll() using select() internally. However, we
were still getting reports of problems.
vadim investigated a bit and realized that at least on his system, even
though we were compiling in poll.o, the system poll() was still being used.
So, the primary purpose of this patch is to ensure that we're using the
internal poll() when we want it to be used.
The changes are:
1) Remove logic for when internal poll should be used from the Makefile.
Instead, put it in the configure script. The logic in the configure
script is the same as it was in the Makefile. Ideally, we would have
a functionality test for the problem, but that's not actually possible,
since we would have to be able to run an application on the _target_
system to test poll() behavior.
2) Always include poll.o in the build, but it will be empty if AST_POLL_COMPAT
is not defined.
3) Change uses of poll() throughout the source tree to ast_poll(). I feel
that it is good practice to give the API call a new name when we are
changing its behavior and not using the system version directly in all cases.
So, normally, ast_poll() is just redefined to poll(). On systems where
AST_POLL_COMPAT is defined, ast_poll() is redefined to ast_internal_poll().
4) Change poll() in main/poll.c to be ast_internal_poll().
It's worth noting that any code that still uses poll() directly will work fine
(if they worked fine before). So, for example, out of tree modules that are
using poll() will not stop working or anything. However, for modules to work
properly on Mac OSX, ast_poll() needs to be used.
(closes issue #13404)
Reported by: agalbraith
Tested by: russell, vadim
http://reviewboard.digium.com/r/198/
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@182810 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
being passed to printf()-like functions and ignored results from read()/write() and friends
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@153337 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
there are places where ast_rtp_new_source may be called
where the tech_pvt of a channel may not yet have an
rtp structure allocated. This caused a crash in chan_skinny,
which was fixed earlier, but now the same crash has been
reported against chan_h323 as well. It seems that the best
solution is to modify ast_rtp_new_source to not attempt to
set the marker bit if the rtp structure passed in is NULL.
This change to ast_rtp_new_source also allows the removal
of what is now a redundant pointer check from chan_skinny.
(closes issue #13247)
Reported by: pj
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@136062 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #13215)
Reported by: qwell
Patches:
2008080100_bug13215.diff.txt uploaded by mvanbaak (license 7)
Tested by: mvanbaak
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@135055 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@123113 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
on it.
(closes issue #12669)
Reported by: sbisker
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@116799 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113504 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
7962/7965, 7975.
Thanks to Greg Oliver for providing me the required information.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113454 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #9077)
Reported by: pj
Patches:
earlyrtp.diff uploaded by wedhorn (license 30)
Tested by: pj, qwell, DEA, wedhorn
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113118 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@111720 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
when dialing a channel that does not provide progress (analog ZAP lines)
The phone does handle the double update on calls to channels that do
provide progress and wont insert duplicate items
(closes issue #12239)
Reported by: DEA
Patches:
chan_skinny-call-log.txt uploaded by DEA (license 3)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@109171 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
on the underlying technology it may need to change some things.
(closes issue #12148)
Reported by: jcomellas
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106235 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104920 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Issue 11586, patch by sobomax.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@93764 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Reported by: haklin
Don't set the callerid name and number a second time on a newly created channel. ast_channel_alloc itself already sets it and setting it twice would cause a memory leak.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@79174 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(ASA-2007-019)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@78375 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Also make note of the "A" option of date format.
Issue 9779, modifications by DEA, wedhorn, and myself.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@77996 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
If this happens during call setup, we need to give up.
Issue 10325.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@77993 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Also rearrange messages to better fit with what a wireshark trace shows it should be.
Issue 10299, initial patch and solution by sbisker, modified by me to fit with wireshark trace.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@77947 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
"From: 5555" rather than "From: s"
Issue 10358, initial patch by DEA, reworked by me to use S_OR, tested by sbisker
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@77894 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Issue 10291, patch by DEA.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@77890 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
the 7921),
due to sending packets in the wrong order during hangup.
Also make sure we clear tones/messages on the correct line/instance.
Issue 10291, patch by DEA, tested by sbisker and myself.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@77883 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Don't try to play dialtone in some unimplemented features.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@76656 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Issue 10276.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@76620 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Reported by: mvanbaak
Patches:
chan_skinny_openbsd.diff uploaded by mvanbaak (license 7)
Add another OS that has to use the Macros for byte ordering.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@76519 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Cancel ringing if endpoint hangs up before answering.
Fixes were backported from trunk (there was apparently a bit of confusion during merge of a previous patch).
(closes issue #10241)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@76178 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
immediately after/during sending a digit.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@76174 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@75980 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
recent ast_ time stuff from Tilghman
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@75807 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@75732 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Issue 9245, patch by slimey.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@75711 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Issue 9887, patches by DEA
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@75707 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r75449 | russell | 2007-07-17 15:57:09 -0500 (Tue, 17 Jul 2007) | 3 lines
Properly check for the length in the skinny packet to prevent an invalid memcpy.
(ASA-2007-016)
........
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@75450 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
actually do much of anything.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@74866 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@74864 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Issue 10136, fix provided by DEA.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@74839 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
reported by gzero)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@74082 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@74045 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Issue 9958.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@70494 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
correct length.
Issue 9887, patch by DEA.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@68249 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
instead of just at registration.
Issue 9152, yet another patch by DEA.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@67421 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
If there is no traffic from the phone for (keep_alive * 1100) ms (arbitrarily
adding 10% for network issues, etc), unregister the device.
Issue 8394, patch by DEA.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@67156 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
This patch makes chan_skinny usable again. I did not end up testing this,
but there are multiple positive test reports listed in the bug report.
(issue #9596, reported by pj, testing by pj and mvanbaak, and the fix was
written by DEA)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@66881 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
refinement, but this won't have as many folks bothered.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@60989 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(issue #9002)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@58023 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Don't crash if hold is pressed when no call is active.
Don't return in places that we shouldn't..
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@56569 f38db490-d61c-443f-a65b-d21fe96a405b
|