aboutsummaryrefslogtreecommitdiffstats
path: root/channels/chan_skinny.c
AgeCommit message (Collapse)AuthorFilesLines
2008-11-01fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings ↵kpfleming1-3/+3
being passed to printf()-like functions and ignored results from read()/write() and friends git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@153337 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-06Since adding the AST_CONTROL_SRCUPDATE frame type,mmichelson1-3/+1
there are places where ast_rtp_new_source may be called where the tech_pvt of a channel may not yet have an rtp structure allocated. This caused a crash in chan_skinny, which was fixed earlier, but now the same crash has been reported against chan_h323 as well. It seems that the best solution is to modify ast_rtp_new_source to not attempt to set the marker bit if the rtp structure passed in is NULL. This change to ast_rtp_new_source also allows the removal of what is now a redundant pointer check from chan_skinny. (closes issue #13247) Reported by: pj git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@136062 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-01fix some potential deadlocks in chan_skinnymvanbaak1-0/+4
(closes issue #13215) Reported by: qwell Patches: 2008080100_bug13215.diff.txt uploaded by mvanbaak (license 7) Tested by: mvanbaak git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@135055 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-16Port "hasvoicemail" change from SIP to other channel driverstilghman1-0/+4
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@123113 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-16Check to make sure an RTP structure exists before calling ast_rtp_new_source ↵file1-1/+3
on it. (closes issue #12669) Reported by: sbisker git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@116799 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-08Add a little more that is required for previously added devices.qwell1-0/+21
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113504 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-08Add support for several new(ish) devices - most notably, 7942/7945, ↵qwell1-0/+23
7962/7965, 7975. Thanks to Greg Oliver for providing me the required information. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113454 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-07Allow playback with noanswer (and add earlyrtp option).qwell1-14/+37
(closes issue #9077) Reported by: pj Patches: earlyrtp.diff uploaded by wedhorn (license 30) Tested by: pj, qwell, DEA, wedhorn git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@113118 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-28Remove unimplemented softkeys. Prompted by issue #12325.qwell1-3/+3
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@111720 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-17Update the directory of placed calls on skinny phones ↵mvanbaak1-0/+1
when dialing a channel that does not provide progress (analog ZAP lines) The phone does handle the double update on calls to channels that do provide progress and wont insert duplicate items (closes issue #12239) Reported by: DEA Patches: chan_skinny-call-log.txt uploaded by DEA (license 3) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@109171 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-05Add a control frame to indicate the source of media has changed. Depending ↵file1-0/+3
on the underlying technology it may need to change some things. (closes issue #12148) Reported by: jcomellas git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106235 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-28According to a video at www.cisco.com, the 7921G supports 6 line appearances.qwell1-1/+4
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104920 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-18FreeBSD also does not have byte swap functions.qwell1-1/+1
Issue 11586, patch by sobomax. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@93764 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-13(closes issue #10437)file1-2/+0
Reported by: haklin Don't set the callerid name and number a second time on a newly created channel. ast_channel_alloc itself already sets it and setting it twice would cause a memory leak. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@79174 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-07Properly check the capabilities count to avoid a segfault.qwell1-2/+8
(ASA-2007-019) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@78375 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-02Make sure we actually allow 6 chars to be sent.qwell1-2/+2
Also make note of the "A" option of date format. Issue 9779, modifications by DEA, wedhorn, and myself. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@77996 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-02If a device disconnects, the session will go away.qwell1-0/+5
If this happens during call setup, we need to give up. Issue 10325. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@77993 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-02Make sure we clear the prompt status message on a hangup.qwell1-42/+45
Also rearrange messages to better fit with what a wireshark trace shows it should be. Issue 10299, initial patch and solution by sbisker, modified by me to fit with wireshark trace. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@77947 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-02Make sure that we show the correct extension if dialed from a macroqwell1-4/+10
"From: 5555" rather than "From: s" Issue 10358, initial patch by DEA, reworked by me to use S_OR, tested by sbisker git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@77894 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-01Put in some additional debug information for softkey/stimulus messages.qwell1-43/+44
Issue 10291, patch by DEA. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@77890 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-01Fix an issue that caused one-way audio on some newer devices (specifically ↵qwell1-57/+68
the 7921), due to sending packets in the wrong order during hangup. Also make sure we clear tones/messages on the correct line/instance. Issue 10291, patch by DEA, tested by sbisker and myself. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@77883 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-23Fix some incorrect softkey labels in messages.qwell1-8/+3
Don't try to play dialtone in some unimplemented features. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@76656 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-23Don't try to queue up hold/unhold frames on a non-existent channel.qwell1-0/+8
Issue 10276. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@76620 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-23(closes issue #10268)file1-1/+1
Reported by: mvanbaak Patches: chan_skinny_openbsd.diff uploaded by mvanbaak (license 7) Add another OS that has to use the Macros for byte ordering. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@76519 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-20Allow getting a call from an existing "sub" channel.qwell1-26/+25
Cancel ringing if endpoint hangs up before answering. Fixes were backported from trunk (there was apparently a bit of confusion during merge of a previous patch). (closes issue #10241) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@76178 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-20It's possible for sub->owner to be NULL here if you cancel the call ↵qwell1-1/+1
immediately after/during sending a digit. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@76174 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-19Remove some duplicate code.qwell1-1/+0
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@75980 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-18Need to make sure we set milliseconds and timestamp - pointed out by the ↵qwell1-0/+2
recent ast_ time stuff from Tilghman git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@75807 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-18Umm, why are we transmitting dialtone on cfwdall?qwell1-1/+0
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@75732 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-18Fixes for 7935/7936 conference phones.qwell1-19/+96
Issue 9245, patch by slimey. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@75711 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-18Fix issues with new 79x1 phones.qwell1-11/+20
Issue 9887, patches by DEA git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@75707 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-17Merged revisions 75449 via svnmerge from russell1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r75449 | russell | 2007-07-17 15:57:09 -0500 (Tue, 17 Jul 2007) | 3 lines Properly check for the length in the skinny packet to prevent an invalid memcpy. (ASA-2007-016) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@75450 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-12It helps if I actually add this stuff for the 7921 too - otherwise it won't ↵qwell1-0/+3
actually do much of anything. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@74866 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-12Add device ID for 7921 wireless skinny phoneqwell1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@74864 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-12Fix dialing in skinny that was broken in some cases.qwell1-1/+1
Issue 10136, fix provided by DEA. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@74839 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-09Only destroy the scheduler context if it was allocated. (issue #10124 ↵file1-2/+3
reported by gzero) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@74082 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-09Few minor thread synchronization tweaks. (issue #10124 reported by gzero)file1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@74045 f38db490-d61c-443f-a65b-d21fe96a405b
2007-06-20Make sure we clear the previously dialed number if it did not exist.qwell1-0/+3
Issue 9958. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@70494 f38db490-d61c-443f-a65b-d21fe96a405b
2007-06-07Fix an issue with newer phones which require packets be padded out to the ↵qwell1-6/+25
correct length. Issue 9887, patch by DEA. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@68249 f38db490-d61c-443f-a65b-d21fe96a405b
2007-06-05Correctly update date/time on devices throughout the life of the device, ↵qwell1-1/+3
instead of just at registration. Issue 9152, yet another patch by DEA. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@67421 f38db490-d61c-443f-a65b-d21fe96a405b
2007-06-04Fix for skinny keepalives.qwell1-5/+11
If there is no traffic from the phone for (keep_alive * 1100) ms (arbitrarily adding 10% for network issues, etc), unregister the device. Issue 8394, patch by DEA. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@67156 f38db490-d61c-443f-a65b-d21fe96a405b
2007-06-01Changes to the way DTMF is handled in the core broke dialing in chan_skinny.russell1-30/+87
This patch makes chan_skinny usable again. I did not end up testing this, but there are multiple positive test reports listed in the bug report. (issue #9596, reported by pj, testing by pj and mvanbaak, and the fix was written by DEA) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@66881 f38db490-d61c-443f-a65b-d21fe96a405b
2007-04-09This is a big improvement over the current CDR fixes. It may still need ↵murf1-1/+1
refinement, but this won't have as many folks bothered. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@60989 f38db490-d61c-443f-a65b-d21fe96a405b
2007-03-06Return an error of transmit_response is called without a session.russell1-0/+6
(issue #9002) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@58023 f38db490-d61c-443f-a65b-d21fe96a405b
2007-02-24Make sure to set a speeddials parent on creation.qwell1-2/+8
Don't crash if hold is pressed when no call is active. Don't return in places that we shouldn't.. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@56569 f38db490-d61c-443f-a65b-d21fe96a405b
2007-02-17Fix an issue where callerid would not be displayed on some phones.qwell1-6/+15
Issue 8995, initial patch and research done by wedhorn git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@55217 f38db490-d61c-443f-a65b-d21fe96a405b
2007-01-31Merged revisions 53045 via svnmerge from russell1-0/+1
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r53045 | russell | 2007-01-31 15:25:11 -0600 (Wed, 31 Jan 2007) | 3 lines Fix a bunch of places where pthread_attr_init() was called, but pthread_attr_destroy() was not. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@53046 f38db490-d61c-443f-a65b-d21fe96a405b
2007-01-23Update channel drivers to use module referencing so that unloading them ↵file1-8/+1
while in use will not result in crashes. (issue #8897 reported by junky) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@51788 f38db490-d61c-443f-a65b-d21fe96a405b
2007-01-19Merge the changes from the /team/group/vldtmf_fixup branch.russell1-2/+2
The main bug being addressed here is a problem introduced when two SIP channels using SIP INFO dtmf have their media directly bridged. So, when a DTMF END frame comes into Asterisk from an incoming INFO message, Asterisk would try to emulate a digit of some length by first sending a DTMF BEGIN frame and sending a DTMF END later timed off of incoming audio. However, since there was no audio coming in, the DTMF_END was never generated. This caused DTMF based features to no longer work. To fix this, the core now knows when a channel doesn't care about DTMF BEGIN frames (such as a SIP channel sending INFO dtmf). If this is the case, then Asterisk will not emulate a digit of some length, and will instead just pass through the single DTMF END event. Channel drivers also now get passed the length of the digit to their digit_end callback. This improves SIP INFO support even further by enabling us to put the real digit duration in the INFO message instead of a hard coded 250ms. Also, for an incoming INFO message, the duration is read from the frame and passed into the core instead of just getting ignored. (issue #8597, maybe others...) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@51311 f38db490-d61c-443f-a65b-d21fe96a405b
2007-01-05Merged revisions 49635 via svnmerge from kpfleming1-9/+2
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r49635 | kpfleming | 2007-01-05 10:56:40 -0600 (Fri, 05 Jan 2007) | 2 lines ensure that threads which are supposed to be detached (because we aren't going to wait on them) are created properly ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@49636 f38db490-d61c-443f-a65b-d21fe96a405b