aboutsummaryrefslogtreecommitdiffstats
path: root/channels/chan_misdn.c
AgeCommit message (Collapse)AuthorFilesLines
2009-11-05chan_misdn Asterisk 1.4.27-rc2 crashdbrooks1-0/+1
Crash related to chan_misdn connection. Patch submitted by gknispel_proformatique, tested by francesco_r. "I have many crash since i have upgraded to Asterisk 1.4.27-rc2. Attached a full bt." This patch zeros out an ast_frame. (closes issue #16041) Reported by: francesco_r git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@228078 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-07chan_misdn.c:process_ast_dsp() memory leakrmudgett1-2/+6
misdn.conf: astdtmf must be set to "yes". With "no", buffer loss does not occur. The translated frame "f2" when passing through ast_dsp_process() is not freed whenever it is not used further in process_ast_dsp(). Then in the end it is never ever freed. Patches: translate.patch JIRA ABE-1993 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@222691 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-10AST-2009-005tilghman1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@211528 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-14Fixes several call transfer issues with chan_misdn.rmudgett1-286/+417
* issue #14355 - Crash if attempt to transfer a call to an application. Masquerade the other pair of the four asterisk channels involved in the two calls. The held call already must be a bridged call (not an applicaton) or it would have been rejected. * issue #14692 - Held calls are not automatically cleared after transfer. Allow the core to initate disconnect of held calls to the ISDN port. This also fixes a similar case where the party on hold hangs up before being transferred or taken off hold. * JIRA ABE-1903 - Orphaned held calls left in music-on-hold. Do not simply block passing the hangup event on held calls to asterisk core. * Fixed to allow held calls to be transferred to ringing calls. Previously, held calls could only be transferred to connected calls. * Eliminated unused call states to simplify hangup code. * Eliminated most uses of "holded" because it is not a word. (closes issue #14355) (closes issue #14692) Reported by: sodom Patches: misdn_xfer_v14_r205839.patch uploaded by rmudgett (license 664) Tested by: rmudgett git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@206487 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-14Fix some memory leaks in chan_misdn.rmudgett1-22/+53
JIRA ABE-1911 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@206284 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-02Removed confusing warning message "Got Busy in Connected State"rmudgett1-2/+0
If an incoming mISDN call is answered with the Answer application and a subsequent Dial gets a busy endpoint then it is valid for that already connected channel to get the busy indication. Asterisk will play the busy tones until the dialplan plays something else or hangs up the call. (closes issue #11974) Reported by: fvdb git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@204834 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-22Fix a bug where using immediate with mISDN caused a cause code of 16 to get ↵file1-2/+3
sent back instead of 1 if the 's' extension did not exist. (closes issue #12286) Reported by: lmamane git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@196116 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-11Sent wrong message to clear a call we started if the other end has not ↵rmudgett1-2/+2
responed yet. In the state MISDN_CALLING (i.e. SETUP was sent but no answer has arrived yet), it is not allowed to clear the call with RELEASE_COMPLETE. It must be cleared with DISCONNECT. A RELEASE_COMPLETE is only allowed as an answer to a SETUP. (See Q.931 ch. 5.3.2, 5.3.2.a, 5.3.2.b) Patches: chan-misdn-ccstate7.patch uploaded by customer. JIRA ABE-1862 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@193613 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-07Give a more helpful message when an incoming call's dialed extension does ↵rmudgett1-8/+14
not match. Added the dialed extension and context to the chan_misdn messages warning that the dialed number cannot be matched in the dialplan. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@193050 f38db490-d61c-443f-a65b-d21fe96a405b
2009-04-16Only disable mISDN DSP if Asterisk DSP is enabled. Leave jitter setting alone.rmudgett1-1/+0
JIRA ABE-1835 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@188833 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-13Revert unnecessary indications API change from rev 122314russell1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168561 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-09* Fix for JIRA AST-175/ABE-1757rmudgett1-22/+222
* Miscellaneous doxygen comments added. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168191 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-29update dev-mode compiler flags to match the ones used by default on Ubuntu ↵kpfleming1-1/+1
Intrepid, so all developers will see the same warnings and errors since this branch already had some printf format attributes, enable checking for them and tag functions that didn't have them format attributes in a consistent way git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@159808 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-20Merged revision 157977 fromrmudgett1-31/+46
https://origsvn.digium.com/svn/asterisk/team/group/issue8824 ........ Fixes JIRA ABE-1726 The dial extension could be empty if you are using MISDN_KEYPAD to control ISDN provider features. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@158010 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-04JIRA ABE-1703rmudgett1-1/+1
mISDN sets the channel to the wrong state when it receives the indication AST_CONTROL_RINGING. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@154266 f38db490-d61c-443f-a65b-d21fe96a405b
2008-10-16Fix memory leak found by customerrmudgett1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@150124 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-30channels/chan_misdn.crmudgett1-1898/+1750
channels/misdn/isdn_lib.c * Miscellaneous other fixes from trunk to make merging easier later. ........ r145200 | rmudgett | 2008-09-30 16:00:54 -0500 (Tue, 30 Sep 2008) | 7 lines * Miscellaneous formatting changes to make v1.4 and trunk more merge compatible in the mISDN area. channels/chan_misdn.c * Eliminated redundant code in cb_events() EVENT_SETUP ........ r144257 | crichter | 2008-09-24 03:42:55 -0500 (Wed, 24 Sep 2008) | 9 lines improved helptext of misdn_set_opt. ........ r142181 | rmudgett | 2008-09-09 12:30:52 -0500 (Tue, 09 Sep 2008) | 1 line Cleaned up comment ........ r138738 | rmudgett | 2008-08-18 16:07:28 -0500 (Mon, 18 Aug 2008) | 30 lines channels/chan_misdn.c * Made bearer2str() use allowed_bearers_array[] * Made use the causes.h defines instead of hardcoded numbers. * Made use Asterisk presentation indicator values if either of the mISDN presentation or screen options are negative. * Updated the misdn_set_opt application option descriptions. * Renamed the awkward Caller ID presentation misdn_set_opt application option value not_screened to restricted. Deprecated the not_screened option value. channels/misdn/isdn_lib.c * Made use the causes.h defines instead of hardcoded numbers. * Fixed some spelling errors and typos. * Added all defined facility code strings to fac2str(). channels/misdn/isdn_lib.h * Added doxygen comments to struct misdn_bchannel. channels/misdn/isdn_lib_intern.h * Added doxygen comments to struct misdn_stack. channels/misdn_config.c configs/misdn.conf.sample * Updated the mISDN presentation and screen parameter descriptions. doc/misdn.txt (doc/tex/misdn.tex) * Updated the misdn_set_opt application option descriptions. * Fixed some spelling errors and typos. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@145293 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-24improved helptext of misdn_set_opt.crichter1-1/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@144238 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-06* The allowed_bearers setting in misdn.conf misspelled onermudgett1-51/+57
of its options: digital_restricted. * Fixed some other spelling errors and typos. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@136241 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-12Adds DAHDI support alongside Zaptel. DAHDI usage favored, but all Zap stuff ↵jpeeler1-2/+2
should continue working. Release announcement to follow. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@122314 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11fix various other problems found by gcc 4.3kpfleming1-5/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107464 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-07Safely use the strncat() function.tilghman1-10/+5
(closes issue #11958) Reported by: norman Patches: 20080209__bug11958.diff.txt uploaded by Corydon76 (license 14) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106552 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-29fixed potential segfault in misdn show channels CLI commandcrichter1-1/+9
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100793 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-27When deleting a task from the scheduler, ignoring the return value couldtilghman1-1/+1
possibly cause memory to be accessed after it is freed, which causes all sorts of random memory corruption. Instead, if a deletion fails, wait a bit and try again (noting that another thread could change our taskid value). (closes issue #11386) Reported by: flujan Patches: 20080124__bug11386.diff.txt uploaded by Corydon76 (license 14) Tested by: Corydon76, flujan, stuarth` git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100465 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-03make sure frame is completely clean, before we send it to asterisk as DTMF. ↵crichter1-0/+1
If we don't make it clean, it happens that one way audio occurs.. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@96199 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-03when overlapdial was used and no number was dialed, the call was dropped, ↵crichter1-1/+8
now we just jump into the s extension, which makes a lot more sense. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@96198 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-14fixed the sequencing of WAITING_4DIGS state setting and overlap_task thread ↵crichter1-1/+1
starting. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@92934 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-20added RR patch from iroot #10908, thanks.crichter1-5/+7
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89445 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12if we're NT and no number was dialed and overlapdial is set, we wait for the ↵crichter1-0/+11
ISDN timeout instead of starting our own timer. added a comment for the misdn.conf.sample for the overlapdial config option. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89173 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12added restart all interfaces Restart_Indicator, to automatically send a ↵crichter1-7/+10
RESTART after the L2 of a PTP Port comes up. Also fixed some places where we have send a RELEASE without need for it. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89172 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12fixed a state/event issue with overlapdial=yes when no extension matched. ↵crichter1-2/+1
removed the general sending of a RELEASE_COMPLETE when we receive a RELEASE, this is done by mISDNuser/mISDN. This makes it possible to use asterisk-1.4 with mISDN trunk, but requires users of mISDN/mISDNuser-1.1.X to upgrade to at least mISDNuser-1.1.6 (when using the NT mode at all) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89171 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12aded ntkeepcalls option, to avoid droÃpping calls when the L2 goes down on ↵crichter1-1/+4
a PTP link. There are some pbx which do turn off the L1 for a very short while and restart it immediately. normally T310 should be started and after 10 seconds or so the calls should be dropped, this is a simple fix wihtout this timer. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89169 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-22we send DISCONNECT instead of RELEASE/RELEASE_COMPLETE if the dialplan does ↵crichter1-4/+2
not match after an overlap call. Also added out_cause=1 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@86598 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-02terminate USERUSER String with 0crichter1-1/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@84345 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-26Fix building chan_misdn under dev-mode. (please run the configure scriptrussell1-7/+8
with --enable-dev-mode so this doesn't happen again ...) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@83910 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-24fixed round_robin group dial method, this never worked well on BRI Ports (2 ↵crichter1-51/+55
channels) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@83620 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-21gcc 4.2 has a new set of warnings dealing with cosnt pointers. This set ofrussell1-5/+5
changes gets all of Asterisk (minus chan_alsa for now) to compile with gcc 4.2. (closes issue #10774, patch from qwell) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@83432 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-19removed comment which violates the coding guidelines.crichter1-1/+0
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@83024 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-19added 'astdtmf' option to allow configuring the asterisk dtmf detector ↵crichter1-4/+16
instead of the mISDN_dsp ones. also added the patch from irroot #10190, so that dtmf tones detected by the asterisk detector are passed outofband to asterisk, to make any use of dtmf tones at all. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@83023 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-11fixed a hold/retrieve issue.crichter1-3/+5
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82249 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-30Fixed some warnings.crichter1-5/+5
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81373 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-30Fixed a severe issue where a misdn_read would lock the channel, but read wouldcrichter1-12/+37
not return because it blocks. later chan_misdn would try to queue a frame like a AST_CONTROL_ANSWER which could result in a deadlock situation. misdn_read will now not block forever anymore, and we don't queue the ANSWER frame at all when we already was called with misdn_answer -> answer would be called twice. Also we don't explicitly send a RELEASE_COMPLETE on receiption of a RELEASE anymore, because mISDN does that for us, this resulted in a problem on some switches, which would block our port after some calls for a short while. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81367 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-23make chan_misdn compile without warningsdhubbard1-76/+86
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@80601 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-17sometimes we don't need to signal dtmf tones to asterisk, we just want them ↵crichter1-4/+5
to go through as inband. Otherwise they might be generated by the other channel partner and then there is a double tone. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@79833 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-13(closes issue #10437)file1-7/+1
Reported by: haklin Don't set the callerid name and number a second time on a newly created channel. ast_channel_alloc itself already sets it and setting it twice would cause a memory leak. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@79174 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-10fixed a bug with the useruser information element. We send them now also in ↵crichter1-0/+9
the disconnect message. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@78936 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-04Merged revisions 73207 via svnmerge from crichter1-1/+6
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r73207 | crichter | 2007-07-04 10:20:54 +0200 (Mi, 04 Jul 2007) | 1 line bad bug in overlapdial case, we called start_pbx multiple times, because the state wasn't changed.. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@73208 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-03Merged revisions 73004 via svnmerge from crichter1-5/+0
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r73004 | crichter | 2007-07-03 10:04:35 +0200 (Di, 03 Jul 2007) | 1 line fixed issue, that misdn_l2l1_check could only be called from mISDN Source channels.. #9449 ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@73005 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-02Merged revisions 72585 via svnmerge from crichter1-1/+13
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r72585 | crichter | 2007-06-29 15:08:26 +0200 (Fr, 29 Jun 2007) | 1 line check if the bchannel stack id is already used, if so don't use it a second time. Also added a release_chan lock, so that the same chan_list object cannot be freed twice. chan_misdn does not crash anymore on heavy load with these changes. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@72852 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-02Merged revisions 72099 via svnmerge from crichter1-2/+4
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r72099 | crichter | 2007-06-27 15:22:37 +0200 (Mi, 27 Jun 2007) | 1 line simplified generation for dummy bchannels, also we mark them as dummies, so they are not used later as real-bchannels, optimized the RESTART mechanisms, we block a channel now on cause:44, and send out a RESTART automatically, then on reception of RESTART_ACKNOWLEDGE we unblock the channel again. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@72851 f38db490-d61c-443f-a65b-d21fe96a405b