aboutsummaryrefslogtreecommitdiffstats
path: root/channels/chan_agent.c
AgeCommit message (Collapse)AuthorFilesLines
2008-08-09Merge more changes from the resolve-shadow-warnings branch (henceforth knownseanbright1-16/+16
as RSW since i am too lazy to keep typing it all out). This time a few of the channels. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@136888 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-25Deprecate *_device_state_* APIs in favor of *_devstate_* APIstilghman1-10/+10
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@133860 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-25Merged revisions 133649 via svnmerge from tilghman1-8/+15
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r133649 | tilghman | 2008-07-25 12:19:39 -0500 (Fri, 25 Jul 2008) | 8 lines Fix some errant device states by making the devicestate API more strict in terms of the device argument (only without the unique identifier appended). (closes issue #12771) Reported by: davidw Patches: 20080717__bug12771.diff.txt uploaded by Corydon76 (license 14) Tested by: davidw, jvandal, murf ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@133665 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-24I made this change from DEVICE_STATE to DEVICE_STATE_CHANGE, but I had it ↵russell1-1/+1
backwards, this is the right event to subscribe to ... git-svn-id: http://svn.digium.com/svn/asterisk/trunk@133486 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-17Instead of attempting to pass through AST_EVENT_DEVICE_STATE, use ↵russell1-1/+2
DEVICE_STATE_CHANGE instead. DEVICE_STATE is a state change on one server, and DEVICE_STATE_CHANGE is the "real" state of that device across all servers sharing state. This would have only been a problem with distributed device state. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@131643 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-16Add missing terminator to ast_event_subscribe to fix a crash.russell1-1/+1
(from rev 131206 in the 1.6.0 branch) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@131207 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-13Unlock list before returningtilghman1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@130444 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-11Merged revisions 130102 via svnmerge from tilghman1-1/+59
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r130102 | tilghman | 2008-07-11 11:50:42 -0500 (Fri, 11 Jul 2008) | 9 lines Pass the devicestate from an underlying channel up through the Agent channel. This should make the Agent always report the correct device state, even when the underlying channel is used for other purposes. (closes issue #12773) Reported by: davidw Patches: 20080710__bug12773.diff.txt uploaded by Corydon76 (license 14) Tested by: davidw ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@130126 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-02Merged revisions 127560 via svnmerge from mmichelson1-0/+9
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r127560 | mmichelson | 2008-07-02 15:47:38 -0500 (Wed, 02 Jul 2008) | 3 lines Fix thread-safety of some of the pbx_builtin_getvar_helper calls ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@127562 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-02The ackcall and endcall options in agents.conf now have supplemental optionsmmichelson1-8/+32
acceptdtmf and enddtmf. These allow for the DTMF pressed to be configurable instead of being hardcoded to '#' and '*'. (AST-86) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@127558 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-11Merged revisions 121861 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r121861 | tilghman | 2008-06-11 13:18:16 -0500 (Wed, 11 Jun 2008) | 3 lines Make calls to ast_assert() actually test something, so that the error message printed is not nonsensical (reported by mvanbaak via #asterisk-bugs). ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@121867 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-09Merged revisions 121229 via svnmerge from mmichelson1-1/+11
https://origsvn.digium.com/svn/asterisk/branches/1.4 (Note that this is being merged to trunk/1.6.0 because it may affect non-callback agents with ackcall set) ........ r121229 | mmichelson | 2008-06-09 10:02:37 -0500 (Mon, 09 Jun 2008) | 16 lines A unique situation of timeouts brought forth a failure situation for autologoff in chan_agent. If using AgentCallbackLogin-style agents, then if the timeout specified by the Dial() to reach the agent's phone was shorter than the timeout specified in queues.conf, then autologoff would only work if the caller hung up while the agent's phone was ringing. This patch allows autologoff to work in this situation when the call in queue transfers to the next available agent (as it would have if the timeout in queues.conf were less than the timeout in the Dial()). (closes issue #12754) Reported by: Rodrigo Patches: 12754.patch uploaded by putnopvut (license 60) Tested by: Rodrigo ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@121230 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-07Merged revisions 121078 via svnmerge from russell1-1/+0
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r121078 | russell | 2008-06-07 09:10:56 -0500 (Sat, 07 Jun 2008) | 7 lines Don't run LIST_HEAD_DESTROY on a STATIC list (closes issue #12807) Reported by: ys Patches: chan_agent_local.diff uploaded by ys (license 281) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@121079 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-29Merged revisions 118953 via svnmerge from tilghman1-6/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r118953 | tilghman | 2008-05-29 12:20:16 -0500 (Thu, 29 May 2008) | 3 lines Add some debugging code that ensures that when we do deadlock avoidance, we don't lose the information about how a lock was originally acquired. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@118955 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-14Merged revisions 116463 via svnmerge from russell1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r116463 | russell | 2008-05-14 16:32:00 -0500 (Wed, 14 May 2008) | 4 lines Add ast_assert(), which can be used to handle fatal errors. It is only compiled in if dev-mode is enabled, and only aborts if DO_CRASH is defined. (inspired by issue #12650) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@116469 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-18Merged revisions 109575 via svnmerge from mmichelson1-2/+6
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r109575 | mmichelson | 2008-03-18 12:58:11 -0500 (Tue, 18 Mar 2008) | 6 lines Make sure an agent doesn't try to send dtmf to a NULL channel closes issue #12242 Reported by Yourname ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@109576 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25Merged revisions 104086 via svnmerge from russell1-2/+21
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r104086 | russell | 2008-02-25 12:38:10 -0600 (Mon, 25 Feb 2008) | 4 lines Ensure that the channel doesn't disappear in agent_logoff(). If it does, it could cause a crash. (fixes the crash reported in BE-396) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@104087 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-31Merged revisions 101433 via svnmerge from russell1-3/+11
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r101433 | russell | 2008-01-31 13:17:05 -0600 (Thu, 31 Jan 2008) | 2 lines Add more missing locking of the agents list ... ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@101449 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-31Merged revisions 101413-101414 via svnmerge from russell1-0/+8
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r101413 | russell | 2008-01-31 13:04:52 -0600 (Thu, 31 Jan 2008) | 2 lines Add missing locking to the find_agent() function. ........ r101414 | russell | 2008-01-31 13:07:46 -0600 (Thu, 31 Jan 2008) | 3 lines Move the locking from find_agent() into the agent dialplan function handler to ensure that the agent doesn't disappear while we're looking at it. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@101416 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-22Merged revisions 99594 via svnmerge from oej1-0/+3
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r99594 | oej | 2008-01-22 18:41:57 +0100 (Tis, 22 Jan 2008) | 3 lines Add more dependencies on chan_local and add a note to the description of chan_local so that people don't disable it in menuselect just to clean up. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@99596 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-02Change instances of AST_NONSTANDARD_APP_ARGS(foo, bar, ',') to ↵mmichelson1-1/+1
AST_STANDARD_APP_ARGS(foo, bar) (closes issue #11668, reported and patched by mvanbaak) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@95994 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-21remove another set of redundant #include "asterisk/options.h"rizzo1-1/+0
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89512 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-19include "logger.h" and errno.h from asterisk.h - usage shows that theyrizzo1-2/+0
were included almost everywhere. Remove some of the instances. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89424 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-16remove a bunch of duplicate includesrizzo1-1/+0
Reproduce with grep -r #include . | grep -v .svn | grep -v Binary | sort | uniq -c | sort -nr git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89348 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-16Start untangling header inclusion in a way that does not affectrizzo1-4/+0
build times - tested, there is no measureable difference before and after this commit. In this change: use asterisk/compat.h to include a small set of system headers: inttypes.h, unistd.h, stddef.h, stddint.h, sys/types.h, stdarg.h, stdlib.h, alloca.h, stdio.h Where available, the inclusion is conditional on HAVE_FOO_H as determined by autoconf. Normally, source files should not include any of the above system headers, and instead use either "asterisk.h" or "asterisk/compat.h" which does it better. For the time being I have left alone second-level directories (main/db1-ast, etc.). git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89333 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-14make the 'name' and 'value' fields in ast_variable const char *rizzo1-1/+1
This prevents modifying the strings in the stored variables, and catched a few instances where this was actually done. Given the differences between trunk and 1.4 (and the fact that this is effectively an API change) it is better to fix 1.4 independently. These are chan_sip.c::sip_register() chan_skinny.c:: near line 2847 config.c:: near line 1774 logger.c::make_components() res_adsi.c:: near line 1049 I may have missed some instances for modules that do not build here. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89268 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-08improve linked-list macros in two ways:kpfleming1-2/+2
- the *_CURRENT macros no longer need the list head pointer argument - add AST_LIST_MOVE_CURRENT to encapsulate the remove/add operation when moving entries between lists git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89106 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-06"show application <foo>" changes for clarity.mmichelson1-3/+3
(closes issue #11171, reported and patched by blitzrage) Many thanks! git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89044 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-06Update chan_agent documentation. Change a | to , as that is now the required ↵file1-1/+1
way. (closes issue #11167) Reported by: eliel Patches: chan_agent.c.patch uploaded by eliel (license 64) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@88974 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-26Correctly use defined return values in (some) load_module functions.qwell1-2/+2
(issue #11096) Patches: chan_agent.c.patch uploaded by eliel (license 64) chan_local.c.patch uploaded by eliel (license 64) chan_features.c.patch uploaded by eliel (license 64) chan_zap.c.patch uploaded by eliel (license 64) res_monitor.c.patch uploaded by eliel (license 64) res_realtime.c.patch uploaded by eliel (license 64) res_crypto.c.patch uploaded by eliel (license 64) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@87202 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-22Switch from AST_CLI (formerly NEW_CLI) to AST_CLI_DEFINE, since the former ↵qwell1-3/+3
didn't make much sense git-svn-id: http://svn.digium.com/svn/asterisk/trunk@86820 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-19Convert NEW_CLI to AST_CLI.qwell1-3/+3
Closes issue #11039, as suggested by seanbright. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@86536 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-01Merged revisions 84274 via svnmerge from dhubbard1-5/+8
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r84274 | dhubbard | 2007-10-01 16:25:37 -0500 (Mon, 01 Oct 2007) | 1 line moved get_base_channel() code from action_redirect to ast_channel_masquerade() for issue 7706 and BE-160 ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@84275 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-27Merged revisions 84018 via svnmerge from dhubbard1-0/+35
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r84018 | dhubbard | 2007-09-27 18:12:25 -0500 (Thu, 27 Sep 2007) | 1 line if an Agent is redirected, the base channel should actually be redirected. This was causing multiple issues, especially issue 7706 and BE-160 ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@84019 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-18(issue #10724)qwell1-48/+69
Reported by: eliel Patches: res_features.c.patch uploaded by eliel (license 64) res_agi.c.patch uploaded by seanbright (license 71) res_musiconhold.c.patch uploaded by seanbright (license 71) pbx.c.patch uploaded by moy (license 222) logger.c.patch uploaded by moy (license 222) frame.c.patch uploaded by moy (license 222) manager.c.patch uploaded by moy (license 222) http.c.patch uploaded by moy (license 222) dnsmgr.c.patch uploaded by moy (license 222) res_realtime.c.patch uploaded by eliel (license 64) res_odbc.c.patch uploaded by seanbright (license 71) res_jabber.c.patch uploaded by eliel (license 64) chan_local.c.patch uploaded by eliel (license 64) chan_agent.c.patch uploaded by eliel (license 64) chan_alsa.c.patch uploaded by eliel (license 64) chan_features.c.patch uploaded by eliel (license 64) chan_sip.c.patch uploaded by eliel (license 64) RollUp.1.patch (includes all of the above patches) uploaded by seanbright (license 71) Convert many CLI commands to the NEW_CLI format. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@82930 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-17convert various places that access the channel lock directly to use the ↵russell1-2/+0
channel lock wrappers git-svn-id: http://svn.digium.com/svn/asterisk/trunk@82728 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-27Merged revisions 81120 via svnmerge from mmichelson1-0/+6
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r81120 | mmichelson | 2007-08-27 16:08:48 -0500 (Mon, 27 Aug 2007) | 7 lines DTMF begin frames should be ignored so that when an agent acks a call with the '#' key, he doesn't cause a queue's announce file to be interrupted. Also went ahead and did the same for the '*' key and for ending a call. (closes issue #10528, reported by deskhack, patched by me) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@81121 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-16Merged revisions 79748 via svnmerge from mmichelson1-0/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r79748 | mmichelson | 2007-08-16 16:16:40 -0500 (Thu, 16 Aug 2007) | 8 lines Fixes a problem where agents would get stuck busy due to their wrapuptime being longer than the queue's wrapuptime and ringinuse=no for the queue. (closes issue #10215, reported by Doug, repaired by me) Special thanks to fkasumovic for pointing out the source of the problem and to bweschke for helping to come up with a solution! ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@79749 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-16Don't reload a configuration file if nothing has changed.tilghman1-8/+11
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@79747 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-08Add support for using epoll instead of poll. This should increase ↵file1-2/+2
scalability and is done in such a way that we should be able to add support for other poll() replacements. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@78683 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-06Add a TalkingToChan to the response of the "agents" manager action.qwell1-3/+12
This is similar to the existing "talking to" that you see what using the "agent show" CLI command. Closes issue #10102 git-svn-id: http://svn.digium.com/svn/asterisk/trunk@78312 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-26Do a massive conversion for using the ast_verb() macrorussell1-23/+12
(closes issue #10277, patches by mvanbaak) Basically, this changes ... if (option_verbose > 2) ast_verbose(VERBOSE_PREFIX_3, "Something\n"); to ... ast_verb(3, "Something\n"); git-svn-id: http://svn.digium.com/svn/asterisk/trunk@77299 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-23Merged revisions 76654 via svnmerge from file1-2/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r76654 | file | 2007-07-23 15:29:48 -0300 (Mon, 23 Jul 2007) | 12 lines Merged revisions 76653 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r76653 | file | 2007-07-23 15:28:13 -0300 (Mon, 23 Jul 2007) | 4 lines (closes issue #5866) Reported by: tyler Do not force channel format changes when a generator is present. The generator may have changed the formats itself and changing them back would cause issues. ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@76655 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-18Merge in ast_strftime branch, which changes timestamps to be accurate to the ↵tilghman1-1/+1
microsecond, instead of only to the second git-svn-id: http://svn.digium.com/svn/asterisk/trunk@75706 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-18Minor code tweaks. Variables were being checked wrong in some situations and ↵file1-2/+2
didn't need to be checked in others. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@75566 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-12Merged revisions 74997 via svnmerge from mmichelson1-4/+6
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@74999 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-11Merged revisions 74722 via svnmerge from mmichelson1-1/+3
https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r74722 | mmichelson | 2007-07-11 16:14:09 -0500 (Wed, 11 Jul 2007) | 13 lines Merged revisions 74719 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r74719 | mmichelson | 2007-07-11 16:12:30 -0500 (Wed, 11 Jul 2007) | 5 lines The cli command "agent logoff Agent/x soft" did not work...at all. Now it does. (closes issue #10178, reported and patched by makoto, with slight modification for 1.4 and trunk by me) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@74726 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-10Merged revisions 74379 via svnmerge from qwell1-4/+6
https://origsvn.digium.com/svn/asterisk/branches/1.4 (closes issue #10169) ................ r74379 | qwell | 2007-07-10 14:06:24 -0500 (Tue, 10 Jul 2007) | 12 lines Merged revisions 74376 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r74376 | qwell | 2007-07-10 14:03:45 -0500 (Tue, 10 Jul 2007) | 4 lines Fix an issue with wrapuptime not working when using AgentLogin. Issue 10169, patch by makoto, with a minor mod by me to not re-break issue 9618 ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@74382 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-10Fix building that was broken by recent monitor.h changes. Thanks Russell ↵qwell1-1/+1
for pointing this out (and pointing out what I probably did to prevent gcc from fixing it - don't ctrl-C builds) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@74272 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-09remove an unused variablerussell1-2/+0
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@74125 f38db490-d61c-443f-a65b-d21fe96a405b