aboutsummaryrefslogtreecommitdiffstats
path: root/apps
AgeCommit message (Collapse)AuthorFilesLines
2007-11-27Two changes with regards to the 'eventwhencalled' option of queues.confmmichelson1-3/+3
1) Due to some signed vs. unsigned silliness, setting 'eventwhencalled' to 'vars' or 'yes' did exactly the same thing. Thus the sign change of the ast_true call. 2) The vars2manager function overwrote a \n for every channel variable it parsed, resulting in bizarre output for the channel variables. This patch remedies this. (related to issue #11385, however I'm not sure if this will actually be enough to close it) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89837 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-27closes issue #11379; OK, this is an attempt to make both sides happy. To the ↵murf1-1/+21
cdr.conf file, I added the option 'unanswered', which defaults to 'no'. In this mode, you will see a cdr for a call, whether it was answered or not. The disposition will be NO ANSWER or ANSWERED, as appropriate. The src is as you'd expect, the destination channel will be one of the channels from the Dial() call, usually the last in the list if more than one chan was specified. With unanswered set to 'yes', you will still see this cdr entry in both cases. But in the case where the dial timed out, you will also see a cdr for each line attempted, marked NO ANSWER, with no destination channel name. The new option defaults to 'no', so you don't see the pesky extra cdr's by default, and you will not see the irritating 'not posted' messages. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89622 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-26After issuing a "say load new", if a caller hangs up during the middle of ↵mmichelson1-1/+5
playback of a number, app_playback will continue to try to play the remaining files. With this change, no more files will be played back upon hangup. (closes issue #11345, reported and patched by IgorG) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89618 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-26After issuing a "say load new" tons of warning messages are printedmmichelson1-4/+0
out to the CLI every time do_say in app_playback is called. Removing these warnings git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89616 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-26Close the audio file before sending it to the post processing application.file1-3/+3
(closes issue #11357) Reported by: reformed Patches: mixmonitor.patch uploaded by reformed (license 330) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89587 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-26Revert vmu->email back to an empty string if it was empty when imap_store_filemmichelson1-1/+12
was called. This prevents sending a duplicate e-mail. (closes issue #11204, reported by spditner, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89580 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-26When unloading app_meetme destroy any auto created contexts created by SLA.file1-0/+3
(closes issue #11367) Reported by: eliel git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89571 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-24Currently, zero-length voicemail messages cause a hangup in VoicemailMain.tilghman1-1/+4
This change fixes the problem, with a multi-faceted approach. First, we do our best to avoid these messages from being created in the first place, and second, if that fails, we detect when the voicemail message is zero-length and avoid exiting at that point. Reported by: dtyoo Patch by: gkloepfer,tilghman (Closes issue #11083) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89540 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-21Fix a small error I made in my previous commitmmichelson1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89495 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-21Changing an inaccurate debug message to be less inaccurate. Under the ↵mmichelson1-1/+1
circumstances, this message would always report that there were 0 members available, even though that may not be true. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89493 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-16Make realtime queues accessible from the QUEUE_MEMBER_COUNT function.mmichelson1-10/+2
(closes issue #11271, reported and patched by atis, with small modifications from me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89323 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-15Update the SLAStation application to account for the case where the SLA threadrussell1-0/+23
has a call out to the station, but the user has pressed a line button to answer the call instead of picking up the handset. If they do, the phone sends out a new INVITE. So, the SLAStation app must check to see if it is picking up a ringing trunk, and ensure that the other stations stop ringing. (reported internally, patched by me, tested by mogorman) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89296 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-13Reverting commit made in revision 89205 since it is unnecessary.mmichelson1-2/+2
Thanks to Kevin for pointing this out git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89241 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-13Some sanity checking for MixMonitor. If only 1 argument is given, then the ↵mmichelson1-2/+2
args.options and args.post_process strings are uninitialized and could contain garbage. This change handles this situation properly by only using arguments that we have parsed. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89205 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-08I made this same adjustment in trunk to fix a bug, and it makes sense to do ↵mmichelson1-1/+1
it in 1.4 as well. If an imapfolder is specified in voicemail.conf, don't ever explicitly connect to INBOX since it may not exist. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89111 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-07The member refcount must be incremented, to avoid using it after deallocation.tilghman1-0/+6
A huge thanks go to lvl- for patiently providing the necessary valgrind output that was necessary to finding this problem of memory corruption. Reported by: lvl- Patch by: tilghman Closes issue #11174 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89093 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-04Rename ast_string_field_free_pool to ast_string_field_free_memory,rizzo1-2/+2
and ast_string_field_free_all to ast_string_field_reset_all to avoid misuse (due to too similar names and an error in documentation). Fix two related memory leaks in app_meetme. No need to merge to trunk, different fix already applied there. Not applicable to 1.2 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@88471 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-01Fix up commit for my Zap channel with spies in Meetme fix. (thanks Tony ↵file1-2/+2
Mountifield!) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@88026 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-01If a Zap channel contains a spy or a spy is added take it out of the ↵file1-3/+3
conference in kernel space and make it go through Asterisk so the spy gets audio from both sides. (closes issue #10060) Reported by: mparker git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@87970 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-30Return 1.4 to a state where it builds. Changing the arguments to a function ↵file1-2/+2
and not changing where they are used is bad, mmmk? git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@87534 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-30 Fix issue where the recorded name wasn't getting removed correctly. bweschke1-5/+10
(closes issue #11115) Reported by: davevg Patches: followme-v3.diff git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@87514 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-29Removing a completely unnecessary quota check from IMAP code.mmichelson1-5/+0
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@87427 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-22Make sure res is a positive value before performing the check to determine ↵file1-1/+1
whether the user stopped it or not. (closes issue #11023) Reported by: cfc git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@86754 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-22Account for the fact that sometimes headers may be terminated with \r\n ↵mmichelson1-2/+2
instead of just \n (closes issue #11043, reported by yehavi) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@86694 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-19Fixed OSP module did not report source/devinfo IP in correct format.transnexus1-2/+30
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@86438 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-18If a non-existent file is specified to be played either as a periodic ↵mmichelson1-2/+2
announcement or as a hold/position announcement, the caller would be kicked out of the queue. No longer does this happen. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@86328 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-17Changing the strategy field of the call_queue struct to be signed instead of ↵mmichelson1-1/+1
unsigned, since the code attempts to set the strategy to -1 if you specify a bogus strategy. While this isn't a huge issue in 1.4, it could be a problem for someone who, say, tries to use the roundrobin strategy in trunk (despite all the deprecation warnings in 1.4). git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@86202 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-16Adding deprecated warning to monitor-join option, since the plan is tommichelson1-0/+10
no longer support this in favor of monitor-type = mixmonitor (related to issue #10885) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@86028 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-16Trying to remove a non-dynamic queue member via dynamic means can lead to somemmichelson1-1/+21
interesting (read nasty) situations. This patch clears up the issue by making only dynamic queue members removable via dynamic methods. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@85958 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-16Remove a pointless lock.russell1-3/+0
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@85896 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-16Fixing a double free which happens in the statechange thread.mmichelson1-4/+0
(closes issue #10987, reported by andrew) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@85852 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-16Check to make sure a value has been given to the VMCOUNT dialplan function.file1-0/+3
(closes issue #10996) Reported by: marsosa git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@85850 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-15Ensure that no pending state changes are leaked when the device state changerussell1-2/+9
thread gets stopped on module unload. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@85720 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-15Previously, app_queue created a thread to handle every single device staterussell1-14/+68
change. I changed this a while ago in trunk for performance reasons. However, bug 8407 points out that it is actually a race condition, causing device state changes to get processed in random order. So, I backported my changes from trunk to 1.4. (closes issue #8407, patch provided by tim_ringenbach, committed patch by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@85717 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-15Don't execute a gosub if the arguments is zero-len (not just NULL)tilghman1-2/+2
Reported by davevg Fixed by me Closes issue #10985 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@85687 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-10A bunch of changes from sprintf to snprintf.mmichelson1-81/+23
See security advisory AST-2002-022 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@85276 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-10Close voicemail message description file if duration did not meet the ↵file1-0/+1
minimum, or else we will eventually run out of file descriptors. (closes issue #10918) Reported by: brak2718 Patches: vm1.4.12.1.patch uploaded by brak2718 (license 279) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@85242 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-04Don't allocate space for queue members unless it's needed. You end up ↵mmichelson1-1/+2
deleting dynamic members on a reload. Not good. closes issue (#10879, reported by dazza76, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@84692 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-04Create a duplicate of the channel's member name as the tab completion stuff ↵file1-1/+1
will free it. (closes issue #10884) Reported by: adamg git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@84637 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-01Simplify the CAN_EARLY_BRIDGE macro a bit.russell1-1/+3
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@84166 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-01Only attempt early bridging if the options given to Dial() permit it.file1-4/+7
(closes issue #10861) Reported by: peekyb git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@84158 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-20If # is pressed after dialing an extension in DISA, stop trying to collect ↵qwell1-0/+4
more digits. (issue #10754) Reported by: atis Patches: app_disa.c.branch.patch uploaded by atis (license 242) app_disa.c.trunk.patch uploaded by atis (license 242) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@83246 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-19The System() and TrySystem() applications can take a substantial amount ofrussell1-0/+4
time to execute while not servicing the channel. So, put the channel in autoservice while the command is being executed. (closes issue #10726, reported by mnicholson) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@83179 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-19Protect the CDR record from modification by pbx_exec so that the application ↵file1-1/+5
data contains the Queue data. (closes issue #10761) Reported by: snar Patches: app-queue-mixmonitor.patch uploaded by snar (license 245) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@83074 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-19Change the description of app_flash to note how it can be a useful tool insteadrussell1-3/+4
of just saying that it is generally a worthless feature. (Thanks to Jim Van Meggelen for pointing it out and providing the proposed text) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82992 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-18Initialize a variable to NULL to make the world happy.file1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82961 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-18Moving the logic for handling an empty membername to the create_member ↵mmichelson1-15/+8
function so that there is a common place where this occurs instead of being spread out to several different places. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82865 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-18there is no need for conditional logic to select ->interface or ↵kpfleming1-11/+5
->membername, snince ->membername will always be populated git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82834 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-17Put a memset in ast_localtime() instead of a couple places in app_voicemailrussell1-3/+0
to prevent the problem everywhere instead of just a couple of places. (related to issue #10746) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82676 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-17Initialize some memory to fix crashes when leaving voicemail. This problemrussell1-1/+7
was fixed by running Asterisk under valgrind. (closes issue #10746, reported by arcivanov, patched by me) *** IMPORTANT NOTE: We need to check to see if this same bug exists elsewhere. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82644 f38db490-d61c-443f-a65b-d21fe96a405b
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-27 07:05:01 +0000