Age | Commit message (Collapse) | Author | Files | Lines |
|
fn2 was used in three functions. In every case, it was initialized
in the function it was used in. This meant there was no need
to have it in a malloc'd structure just taking up space. Furthermore
two of the functions it was used in were completely unnecessary since
fn2 was set to exactly the same value as the vm_state's fn string.
fn2 was a char array sized at PATH_MAX. On my system, PATH_MAX is
4096. This equates to a 4K memory savings per vm_state allocated.
Since there is a vm_state malloc'd for every voicemail user on
the system, this could potentially add up nicely if there are lots
of users. In addition, a vm_state is allocated on the stack each
time a caller calls the VoiceMailMain application, meaning that
there is a significant stack savings with this patch too.
Of course, a single vm_state struct still takes up approximately
20K on my system (when using IMAP storage. Without IMAP storage,
there would be about another 300 bytes fewer usage), even with
this removal. Further optimizations are probably possible,
but most likely not as easy as this one.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@129734 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
state_interface, if a state_interface was set, on reload because the
state_interface isn't stored in the ast_db.
(closes issue #13043)
Reported by: jvandal
Patches:
app_queue.patch uploaded by jvandal (license 413)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@129684 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@129270 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r129149 | tilghman | 2008-07-08 15:27:47 -0500 (Tue, 08 Jul 2008) | 8 lines
Cause SIP to return a 480 instead of a 404 when a sip peer exists, but is not
registered.
(closes issue #12885)
Reported by: ibc
Patches:
20080701__bug12885__2.diff.txt uploaded by Corydon76 (license 14)
Tested by: ibc
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@129152 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #13002)
Reported by: caio1982
Patches:
janitor_arraylen5.diff uploaded by caio1982 (license 22)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@129045 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
t38_terminal_release, and make sure that the phase E handler gets called
with proper status.
(closes issue #13020)
Reported by: dimas
Patches:
v1-appfax.patch uploaded by dimas (license 88)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@129006 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r128856 | tilghman | 2008-07-07 19:01:30 -0500 (Mon, 07 Jul 2008) | 7 lines
Check for non-NULL before stripping characters.
(closes issue #12954)
Reported by: bfsworks
Patches:
20080701__bug12954.diff.txt uploaded by Corydon76 (license 14)
Tested by: deti
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@128857 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r128812 | tilghman | 2008-07-07 18:21:52 -0500 (Mon, 07 Jul 2008) | 2 lines
Stop using deprecated method, as requested by Kevin.
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@128830 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@128733 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
app_voicemail would attempt to play a file called vm-foo instead of playing
vm-INBOX to play the "new" sound file. This commit fixes that issue.
This may fix one of the problems reported in issue #12987
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@128731 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Brought up by reporter on issue #12987
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@128690 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r127892 | kpfleming | 2008-07-03 17:18:38 -0500 (Thu, 03 Jul 2008) | 6 lines
a couple of small Solaris-related fixes
(closes issue #11885)
Reported by: snuffy, asgaroth
........
r127895 | kpfleming | 2008-07-03 17:20:16 -0500 (Thu, 03 Jul 2008) | 3 lines
remove this, it has been moved to the main Makefile
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@127903 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@127857 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
of the whisper or barge audiohooks fails.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@127856 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@127852 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #12986)
Reported by: andrew53
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@127831 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
explanation of the change may be found in configs/queues.conf.sample
(closes issue #12690)
Reported by: atis
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@127720 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@127622 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@127609 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(Closes issue #12892)
Reported by: jaroth
Patch originally by jaroth, fixed by me.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@127564 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r127244 | mmichelson | 2008-07-01 18:36:40 -0500 (Tue, 01 Jul 2008) | 5 lines
Add error message to failed open(2) calls inside the copy() function of
app_voicemail. This idea came as part of my work in helping to resolve
issue #12764.
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@127245 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
'dialcontext' is only going to be set once during the channel's lifetime, so make it a string field instead of a char array
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@126960 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@126571 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@125856 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Thanks to Russell for pointing out the problem
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@125855 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@125666 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
MixMonitor to mix audio. However, it was pointed out to me that because
of this, the command set for the MONITOR_EXEC variable is ignored as well.
This means that people can't do their own custom mixing commands at the end
of recordings in order to make, for instance, stereo recordings of calls.
With this patch, app_queue will set the "joinfiles" variable for the channel's
monitor if MONITOR_EXEC is not zero-length. This means that for normal audio
mixing, MixMonitor is still the preferred choice, but we allow custom
mixing to be done with the two Monitor streams if desired.
(closes issue #12923)
Reported by: snyfer
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@125649 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
to how language is handled between two channels whose native
language is different. Prior to this patch, app_dial would have
the callee inherit the caller's language, and app_queue would not.
After this patch, app_dial no longer has the language inheritance
capability. This seems to make the most sense since it seems more
natural for a person to hear files played back in his/her native
language instead of the language of the person on the far end of
the call. See the CHANGES file for hints on how to keep the
previous behavior of app_dial if desired.
(closes issue #12489)
Reported by: bcnit
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@125647 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@125591 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r125585 | mmichelson | 2008-06-26 17:52:39 -0500 (Thu, 26 Jun 2008) | 11 lines
Add the interface of a queue member to the output of the "queue show" command
so that it can easily be associated with a queue member's name. This helps
so that the appropriate queue member can be removed or paused since the
interface is required, not the member's name.
(closes issue #12783)
Reported by: davevg
Patches:
app_queue.diff uploaded by davevg (license 209) with small mod from me
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@125586 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r125476 | mmichelson | 2008-06-26 15:56:01 -0500 (Thu, 26 Jun 2008) | 11 lines
Prior to this patch, the "queue show" command used cached
information for realtime queues instead of giving up-to-date
info. Now realtime is queried for the latest and greatest in
queue info.
(closes issue #12858)
Reported by: bcnit
Patches:
queue_show.patch uploaded by putnopvut (license 60)
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@125477 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #12893)
Reported by: jaroth
Patches:
duplicate_saved.patch uploaded by jaroth (license 50)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@125438 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r125132 | kpfleming | 2008-06-25 17:21:30 -0500 (Wed, 25 Jun 2008) | 10 lines
allow tonezone to live in a different place than DAHDI/Zaptel, since dahdi-tools and dahdi-linux are now separate packages and can be installed in different places
don't include tonezone.h in dahdi_compat.h, because only a couple of modules need it
get app_rpt building again after the DAHDI changes
(closes issue #12911)
Reported by: tzafrir
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@125138 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r124910 | tilghman | 2008-06-24 16:08:52 -0500 (Tue, 24 Jun 2008) | 8 lines
Occasionally control characters find their way into CallerID. These need to
be stripped prior to placing CallerID in the headers of an email.
(closes issue #12759)
Reported by: RobH
Patches:
20080602__bug12759__2.diff.txt uploaded by Corydon76 (license 14)
Tested by: RobH
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@124912 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@124596 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r124540 | murf | 2008-06-21 20:54:52 -0600 (Sat, 21 Jun 2008) | 9 lines
(closes issue #12910)
Reported by: chris-mac
Sorry, my testing did not contain the simple case of forkCDR(v),
I am much embarrassed to admit. If I had, I would have
more solidly initialized the opts element for varset.
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@124541 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r124450 | tilghman | 2008-06-20 18:12:33 -0500 (Fri, 20 Jun 2008) | 6 lines
usleep with a value over 1,000,000 is nonportable. Changing to use sleep()
instead. (closes issue #12814)
Reported by: pputman
Patches:
app_rtp_sleep.patch uploaded by pputman (license 81)
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@124451 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
1. Filenames had an extra "msg" in the attachment name
2. The attachment was being saved twice
(closes issue #12894)
Reported by: jaroth
Patches:
imap_attach.patch uploaded by jaroth (license 50)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@124180 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
They want (char *)NULL as sentinel.
An example is OpenBSD (confirmed on 4.3) that ships with gcc 3.3.4
This commit introduces a contstant SENTINEL which is declared as:
#define SENTINEL ((char *)NULL)
All places I could test compile on my openbsd system are converted.
Update CODING-GUIDELINES to tell about this constant.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@124127 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r124112 | mmichelson | 2008-06-19 15:28:41 -0500 (Thu, 19 Jun 2008) | 8 lines
Fix IMAP forwarding so that messages are sent to the proper mailbox.
(closes issue #12897)
Reported by: jaroth
Patches:
destination_forward.patch uploaded by jaroth (license 50)
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@124121 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
to be marked urgent. This fixes that issue.
(closes issue #12895)
Reported by: jaroth
Patches:
urgent_forwarding.patch uploaded by jaroth (license 50)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123867 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #12891)
Reported by: chris-mac
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123865 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #12888)
Reported by: slavon
Patches:
app_queue_transfer_patch_trunk.diff uploaded by slavon (license 288)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123828 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
removed. No telling when it happened. Anyway, it's back in now
and works properly.
(Based on issue reported on mailing list)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123652 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
with the attended transfer logging.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123650 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #12840)
Reported by: pputman
Patches:
app_dial_threadsafe3.patch uploaded by pputman (license 81)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123648 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
counts so that they only get destroyed when all threads are done using
them, and memory does not get free'd causing strange issues with SIP.
This code was originally written by russellb in the team/group/issue_11972/ branch.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123546 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #12149)
Reported by: davevg
Patches:
app_talkdetect.c.diff uploaded by davevg (license 209)
(Plus a few additional cleanups by moi)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123544 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r123274 | mmichelson | 2008-06-17 10:56:55 -0500 (Tue, 17 Jun 2008) | 12 lines
davidw pointed out that the holdtime calculation used by
app_queue does not use "boxcar" filtering as the comments
say. The term "boxcar" means that the number of samples used
to calculate stays constant, with new samples replacing the
oldest ones. The queue holdtime calculation uses all holdtime
samples collected since the queue was loaded, so the comment
has been changed to be accurate.
(closes issue #12781)
Reported by: davidw
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123275 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Reported by: ys
Many thanks to ys for doing the research on this problem.
I didn't think it would be best to unlock the contexts
and then relock them after the remove_extension2() call,
so I added an extra arg to remove_extension2() and set it
appropriately in each call. There were not that many.
I considered forcing the code to lock the contexts before
the call to remove_extension2(), but that would require
a slightly greater degree of changes, especially since
the find_context_locked is local to pbx.c
I did a simple sanity test to make sure the code doesn't
mess things up in general.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123165 f38db490-d61c-443f-a65b-d21fe96a405b
|