aboutsummaryrefslogtreecommitdiffstats
path: root/apps
AgeCommit message (Collapse)AuthorFilesLines
2008-02-01Fix the VM_DUR variable for forwarded voicemail, and fixed several other bugstilghman1-29/+61
while I'm in the area. (closes issue #11615) Reported by: jamessan Patches: 20071226__bug11615__2.diff.txt uploaded by Corydon76 (license 14) Tested by: Corydon76, jamessan git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101942 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-01Remove a needless (and incorrect) call to feof() after fgets().qwell1-1/+1
This would have exited the loop early if you had an authentication file with no newline at the end. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101822 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-01off by one errorrussell1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101820 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-01Don't overwrite the last character of a line if it's not a newline. This wouldrussell1-1/+3
happen if the last line in the file doesn't have a newline. (pointed out by Qwell) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101818 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-01From bugtracker: "fix totalAnalysisTime to handle periods of no channel ↵mmichelson1-8/+40
activity" (closes issue #9256) Reported by: cmaj Patches: amd-dont-wait-too-long-for-frames-take3.diff.txt uploaded by cmaj (license 111) Tested by: cmaj, skygreg, ZX81, rjain git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101649 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-30Fix a logic error with regards to autofill. Prior to this change, it was ↵mmichelson1-2/+3
possible for a caller to go out of turn if autofill were enabled and callers ahead in the queue were attempting to call a member. This change fixes this. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101216 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-29Remove a memory leak from updating realtime queuesmmichelson1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101035 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-29Fixing an erroneous return value returned when attempting to pause or ↵mmichelson1-2/+2
unpause a queue member fails. Fixes BE-366, thanks to John Bigelow for writing the patch. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100973 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-29Don't forget to record the channel so we know whether it is bridged or not ↵file1-0/+1
later. (closes issue #11811) Reported by: slavon git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100934 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-28When using ODBC_STORAGE, make sure we put greeting files into the database ↵qwell1-33/+40
like we do with the others. Issue #11795 Reported by: dimas Patches: vmgreet.patch uploaded by dimas (license 88) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100672 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-23Fixing a typo.mmichelson1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99975 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-23ChanSpy issues a beep when it starts at the beginning of a list of channels torussell1-2/+5
potentially spy on. However, if there were no matching channels, it would beep at you over and over, which is pretty annoying. Now, it will only beep once in the case that there are no channels to spy on, but it will still beep again once it reaches the beginning of the channel list again. (closes issue #11738, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99923 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-23When we reset the password via an external command, we should also reset thetilghman1-1/+4
password stored in the in-memory list, too (otherwise it doesn't really take effect). (closes issue #11809) Reported by: davetroy Patches: fix_externpass.diff uploaded by davetroy (license 384) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99777 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-22Add more dependencies on chan_local and add a note to the description of ↵oej1-0/+4
chan_local so that people don't disable it in menuselect just to clean up. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99594 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-22Add dependency on chan_local to app_dial.oej1-0/+5
Dial still runs without chan_local, but will be missing forwarding functionality. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99592 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-16Replace current spy architecture with backport of audiohooks. This should ↵file3-181/+103
take care of current known spy issues. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98972 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-14Adding in appropriate unlocks for the locks I added. Thanks to joetester on IRCmmichelson1-0/+3
for pointing this out. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98849 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-14Fixing another compilation error. I'm a bit off today :(mmichelson1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98737 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-14Oops. Last commit had compilation error.mmichelson1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98734 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-14Adding explicit defaults for missing options to init_queue. This is ↵mmichelson1-0/+11
necessary because if a user either removes or comments one of these options and reloads their queues, the option will not reset to its default, instead maintaining the value from prior to the reload. Thanks to John Bigelow for pointing this error out to me. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98733 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-11Ensure the return value of ast_bridge_call is passed back up as the ↵file1-1/+0
application return value. This is needed for transfers to function so the PBX core knows to continue execution. (closes issue #10327) Reported by: kkiely git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98219 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-10Let us leave a voicemail for ourself if we have logged into VoiceMailMain ↵mmichelson1-2/+2
and chosen to leave a message. (closes issue #11735, reported and patched by jamessan) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97925 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-09Part 2 of app_queue doxygen improvements. Some smaller functions this timemmichelson1-4/+11
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97575 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-09Don't do conferencing totally in Zaptel if Monitor is running on the channel.file1-3/+3
(closes issue #11709) Reported by: BigJimmy Patches: patch-meetmerec uploaded by BigJimmy (license 371) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97450 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-09use the \retval doxygen command properlymmichelson1-1/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97308 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-08Part 1 of N of adding doxygen comments to app_queue. I picked some of the ↵mmichelson1-3/+82
most common functions used (which also happen to be some the biggest/ugliest functions too) to document first. I'm pretty new to doxygen so criticism is welcome. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97304 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-08Some coding guidelines-related cleanupmmichelson1-11/+11
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97206 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-08Making some changes designed to not allow for a corrupted mailstream for a ↵mmichelson1-4/+8
vm_state. 1. Add locking to the vm_state retrieval functions so that no linked list corruption occurs. 2. Make sure to always grab the persistent vm_state when mailstream access is necessary. 3. Correct an incorrect return value in the init_mailstream function. (closes issue #11304, reported by dwhite) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97192 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-08Make app_queue calls work with directed pickup.file1-0/+10
(closes issue #11700) Reported by: jbauer git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97093 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-02We need to reset the membername to NULL on each iteration of this loop, ↵mmichelson1-0/+1
otherwise the result is that multiple members can have the same name, since the variable was not reset on each iteration of the loop. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@96102 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-02app_macro only needs a rdlock on the contexts list.russell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@96020 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-02A change to improve the accuracy of queue logging in the case where a member ↵mmichelson1-6/+23
does not answer during the specified timeout period. Prior to this change, there was a small chance that the member name recorded in this case would be blank. Also prior to this change, if using the ringall strategy, if no one answered the call during the specified timeout, the member name listed in the queue log would randomly be one of the members that was rung. (closes issue #11498, reported and tested by hloubser, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@95890 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-28I found a bug while browsing the queue code and managed to reproduce it in a ↵mmichelson1-4/+2
small setup. If a queue uses the ringall strategy, it was possible through unfortunate coincidence for a single member at a given penalty level to make app_queue think that all members at that penalty level were unavailable and cause the members at the next penalty level to be rung. With this patch, we will only move to the next penalty level if ALL the members at a given penalty level are unreachable. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@95095 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-21Bunch of coding guidelines cleanupmmichelson1-79/+77
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@94543 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-21Better quota support for using IMAP storage voicemailmmichelson1-1/+38
(closes issue #11415, reported by jaroth) (closes issue #11152, reported by selsky) Patch provided by jaroth git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@94540 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-21The mail_copy c-client function does not expect a full imap mailbox string, ↵mmichelson1-7/+3
just the name of the mailbox. (closes issue #11419, reported and patched by jaroth, with additional patchwork from me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@94538 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-21Removing a debug message I accidentally just committedmmichelson1-1/+0
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@94464 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-21Fixing Portuguese syntax for saying dates and times. Also some coding ↵mmichelson1-0/+1
guidelines cleanup. (closes issue #11599, reported and patched by caio1982, coding guidelines cleanup by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@94420 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-17We need to create the directory for a voicemail user even if they are using ↵mmichelson1-2/+0
IMAP storage since greetings are stored in the filesystem. (closes issue #11388, reported by spditner, patch by me inspired by a patch by spditner) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@93291 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-17Issue 11574: Add dependencies on res_monitor and res_features. oej1-0/+4
I wonder if Asterisk can run at all without res_features. My guess is that there's propably a lot of more modules and the core that depends on it. Reported by: caio1982 (closes issue #11574) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@93182 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-17In http://lists.digium.com/pipermail/asterisk-dev/2007-December/031145.html,kpfleming1-2/+8
rizzo brought up some issues related to the way that the metadata required for menuselect and the rest of the build system is extracted from the source files. Since I had a few hours to kill on an airplane today, I decided to improve this situation... so now the system caches the extracted metadata and uses it to build the menuselect 'tree' as much as it can. The result of this is that when a single source file is changed, only the metadata for that file needs to be extracted again, and the rest is used from the cache files. I also reduced the number of forked processes required to do the metadata extraction; it was actually possible to do most of what we needed in the Makefiles themselves without using any shell scripts at all! On my laptop, these changes resulted in an 80% decrease in the time required for the 'menuselect.makeopts' automatic check to occur after editing a single source file. While doing this work I also cleaned up a few minor things in the Makefiles, adding a check for 'awk' to the configure script and changed all remaining places we use 'grep' or 'awk' to use the ones found by the configure script, and changed the 'prep_tarball' script to build the menuselect metadata so that tarballs of Asterisk will include it and won't require the user to wait while it is extracted after unpacking. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@93180 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-13Prevent another potential fd leakmmichelson1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@92807 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-13Prevent a possible fd leak. mmichelson1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@92803 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-12Don't increment user count until after name has been recorded (if enabled).qwell1-21/+29
Issue 11048, tested by pep. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@92617 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-12Removing an unused variable.mmichelson1-7/+0
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@92443 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-11Fixing autofill to be more accurate. Specifically, if calls ahead of the currentmmichelson1-1/+4
caller were ringing members (but not yet bridged) there could be available members and waiting callers who would not get matched up. The member availability checker was correctly determining the number of available members in this scenario, but the queue itself did not parallelly reflect this status on the pending calls. This commit corrects the issue. (closes issue #11459, reported by equissoftware, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@92323 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-10If there are no members in a queue, then the loop where the datastore for ↵mmichelson1-2/+4
detecting duplicate dialed numbers will be skipped, meaning the datastore isn't created. This means that when we try to free it, there's a crash. This stops that crash from occurring. (closes issue #11499, reported by slavon, patched by eliel) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@92202 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-07* Add channel locking around datastore operations that expect the channelrussell1-26/+43
to be locked. * Document why we don't record Local channels in the dialed interfaces list. * Remove the dialed variable as it isn't needed. * Restructure some code for clarity and coding guidelines stuff git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@91783 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-07* Add channel locking around datastore operations that expect the channelrussell1-17/+39
to be locked. * Document why we don't record Local channels in the dialed interfaces list. * Handle memory allocation failure. * Remove the dialed variable, as it wasn't actually needed. * Tweak some formatting to conform to coding guidelines. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@91780 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-07Don't unlock the dialed_interfaces list until we're done messing with the ↵russell1-1/+1
iterator. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@91693 f38db490-d61c-443f-a65b-d21fe96a405b
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-05 12:53:03 +0000