aboutsummaryrefslogtreecommitdiffstats
path: root/apps
AgeCommit message (Collapse)AuthorFilesLines
2008-02-29If the message file does not exist, just return harmlessly, instead of crashing.tilghman1-1/+3
(Closes issue #12108) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105296 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-29Bump up the size of the uniqueid variable.file1-1/+1
(closes issue #12107) Reported by: asgaroth git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105261 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-28When using autofill, members who are in use should be counted towards the mmichelson1-0/+4
number of available members to call if ringinuse is set to yes. Thanks to jmls who brought this issue up on IRC git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105059 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-27Don't loop around infinitely trying to spy on our own channel, and don't ↵file1-5/+5
forget to free/detach the datastore upon hangup of the spy. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104787 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-27Fix a problem in ChanSpy where it could get stuck in an infinite loop withoutrussell1-1/+7
being able to detect that the calling channel hung up. (closes issue #12076, reported by junky, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104625 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-27Avoid some recursion in the cleanup code for the chanspy datastorerussell1-0/+2
(closes issue #12076, reported by junky, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104334 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-26Merge changes from team/russell/smdi-1.4russell1-6/+3
This commit brings in a significant set of changes to the SMDI support in Asterisk. There were a number of bugs in the current implementation, most notably being that it was very likely on busy systems to pop off the wrong message from the SMDI message queue. So, this set of changes fixes the issues discovered as well as introducing some new ways to use the SMDI support which are required to avoid the bugs with grabbing the wrong message off of the queue. This code introduces a new interface to SMDI, with two dialplan functions. First, you get an SMDI message in the dialplan using SMDI_MSG_RETRIEVE() and then you access details in the message using the SMDI_MSG() function. A side benefit of this is that it now supports more than just chan_zap. For example, with this implementation, you can have some FXO lines being terminated on a SIP gateway, but the SMDI link in Asterisk. Another issue with the current implementation is that it is quite common that the station ID that comes in on the SMDI link is not necessarily the same as the Asterisk voicemail box. There are now additional directives in the smdi.conf configuration file which let you map SMDI station IDs to Asterisk voicemail boxes. Yet another issue with the current SMDI support was related to MWI reporting over the SMDI link. The current code could only report a MWI change when the change was made by someone calling into voicemail. If the change was made by some other entity (such as with IMAP storage, or with a web interface of some kind), then the MWI change would never be sent. The SMDI module can now poll for MWI changes if configured to do so. This work was inspired by and primarily done for the University of Pennsylvania. (also related to issue #9260) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104119 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25This patch fixes some pretty significant problems with how app_chanspy handlesrussell1-32/+178
pointers to channels that are being spied upon. It was very likely that a crash would occur if the channel being spied upon hung up. This was because the current ast_channel handling _requires_ that the object is locked or else it could disappear at any time (except in the owning channel thread). So, this patch uses some channel datastore magic on the spied upon channel to be able to detect if and when the channel goes away. (closes issue #11877) (patch written by me, but thanks to kpfleming for the idea, and to file for review) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104106 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25If the destination folder is full, don't delete a message when exiting.tilghman1-2/+4
(closes issue #12065) Reported by: selsky Patch by: (myself) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104094 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-20Clear up confusion when viewing the QUEUE_WAITING_COUNT of a mmichelson1-0/+8
"dead" realtime queue. Since from the user's perspective, the queue does exist, we shouldn't tell them we couldn't find the queue. Instead since it is a dead queue, report a 0 waiting count This issue was brought up on IRC by jmls git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103956 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-14Change to the configure logic regarding IMAP. Prior to this commit, if you ↵mmichelson1-16/+23
wished to configure Asterisk with IMAP support, you would use the --with-imap configure switch in one of the following two ways: --with-imap=/some/directory would look in the directory specified for a UW IMAP source installation --with-imap would assume that you had imap-2004g installed in .. relative to the Asterisk source With this set of changes the two above options still work the same, but there are two new behaviors, too. --with-imap=system will assume that you have -libc-client.so where you store your shared objects and will attempt to find c-client headers in your include path either in the imap or c-client directory. If either of the two original methods of specifying the imap option should fail, then the check for --with-imap =system will be performed in addition. It is only after this "system" check that failure can happen. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103698 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-14Fix build for non-IMAP buildsmmichelson1-0/+4
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103690 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-14Fix the new message count if delete=yes when using IMAP storage.mmichelson1-7/+12
(closes issue #11406) Reported by: jaroth Patches: deleteflag_v2.patch uploaded by jaroth (license 50) Tested by: jaroth git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103688 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-13Refuse to load app_voicemail if res_adsi is not loaded (which is a symbol ↵tilghman1-0/+7
dependency) (closes issue #11760) Reported by: non-poster Patches: 20080114__bug11760.diff.txt uploaded by Corydon76 (license 14) Tested by: Corydon76, non-poster, jamesgolovich git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103556 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-11If entering a conference with the 'w' option ensure that we can't listen or ↵file1-1/+3
speak until the marked user appears. (closes issue #11835) Reported by: alanmcmillan git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103324 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-09Commit fix for being unable to send voicemail from VoiceMailMaintilghman1-1/+5
Reported by: William F Acker (via the -users mailing list) Patch by: Corydon76 (license 14) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103197 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-08Prevent a potential three-thread deadlock. Also added a comment blockmmichelson1-7/+22
to explicitly state the locking order necessary inside app_queue. (closes issue #11862) Reported by: flujan Patches: 11862.patch uploaded by putnopvut (license 60) Tested by: flujan git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103120 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-06Move around some defines to unbreak ODBC storage.tilghman1-27/+25
(closes issue #11932) Reported by: snuffy git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@102576 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-01Fix the VM_DUR variable for forwarded voicemail, and fixed several other bugstilghman1-29/+61
while I'm in the area. (closes issue #11615) Reported by: jamessan Patches: 20071226__bug11615__2.diff.txt uploaded by Corydon76 (license 14) Tested by: Corydon76, jamessan git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101942 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-01Remove a needless (and incorrect) call to feof() after fgets().qwell1-1/+1
This would have exited the loop early if you had an authentication file with no newline at the end. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101822 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-01off by one errorrussell1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101820 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-01Don't overwrite the last character of a line if it's not a newline. This wouldrussell1-1/+3
happen if the last line in the file doesn't have a newline. (pointed out by Qwell) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101818 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-01From bugtracker: "fix totalAnalysisTime to handle periods of no channel ↵mmichelson1-8/+40
activity" (closes issue #9256) Reported by: cmaj Patches: amd-dont-wait-too-long-for-frames-take3.diff.txt uploaded by cmaj (license 111) Tested by: cmaj, skygreg, ZX81, rjain git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101649 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-30Fix a logic error with regards to autofill. Prior to this change, it was ↵mmichelson1-2/+3
possible for a caller to go out of turn if autofill were enabled and callers ahead in the queue were attempting to call a member. This change fixes this. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101216 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-29Remove a memory leak from updating realtime queuesmmichelson1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@101035 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-29Fixing an erroneous return value returned when attempting to pause or ↵mmichelson1-2/+2
unpause a queue member fails. Fixes BE-366, thanks to John Bigelow for writing the patch. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100973 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-29Don't forget to record the channel so we know whether it is bridged or not ↵file1-0/+1
later. (closes issue #11811) Reported by: slavon git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100934 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-28When using ODBC_STORAGE, make sure we put greeting files into the database ↵qwell1-33/+40
like we do with the others. Issue #11795 Reported by: dimas Patches: vmgreet.patch uploaded by dimas (license 88) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@100672 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-23Fixing a typo.mmichelson1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99975 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-23ChanSpy issues a beep when it starts at the beginning of a list of channels torussell1-2/+5
potentially spy on. However, if there were no matching channels, it would beep at you over and over, which is pretty annoying. Now, it will only beep once in the case that there are no channels to spy on, but it will still beep again once it reaches the beginning of the channel list again. (closes issue #11738, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99923 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-23When we reset the password via an external command, we should also reset thetilghman1-1/+4
password stored in the in-memory list, too (otherwise it doesn't really take effect). (closes issue #11809) Reported by: davetroy Patches: fix_externpass.diff uploaded by davetroy (license 384) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99777 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-22Add more dependencies on chan_local and add a note to the description of ↵oej1-0/+4
chan_local so that people don't disable it in menuselect just to clean up. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99594 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-22Add dependency on chan_local to app_dial.oej1-0/+5
Dial still runs without chan_local, but will be missing forwarding functionality. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@99592 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-16Replace current spy architecture with backport of audiohooks. This should ↵file3-181/+103
take care of current known spy issues. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98972 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-14Adding in appropriate unlocks for the locks I added. Thanks to joetester on IRCmmichelson1-0/+3
for pointing this out. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98849 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-14Fixing another compilation error. I'm a bit off today :(mmichelson1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98737 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-14Oops. Last commit had compilation error.mmichelson1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98734 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-14Adding explicit defaults for missing options to init_queue. This is ↵mmichelson1-0/+11
necessary because if a user either removes or comments one of these options and reloads their queues, the option will not reset to its default, instead maintaining the value from prior to the reload. Thanks to John Bigelow for pointing this error out to me. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98733 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-11Ensure the return value of ast_bridge_call is passed back up as the ↵file1-1/+0
application return value. This is needed for transfers to function so the PBX core knows to continue execution. (closes issue #10327) Reported by: kkiely git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@98219 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-10Let us leave a voicemail for ourself if we have logged into VoiceMailMain ↵mmichelson1-2/+2
and chosen to leave a message. (closes issue #11735, reported and patched by jamessan) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97925 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-09Part 2 of app_queue doxygen improvements. Some smaller functions this timemmichelson1-4/+11
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97575 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-09Don't do conferencing totally in Zaptel if Monitor is running on the channel.file1-3/+3
(closes issue #11709) Reported by: BigJimmy Patches: patch-meetmerec uploaded by BigJimmy (license 371) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97450 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-09use the \retval doxygen command properlymmichelson1-1/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97308 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-08Part 1 of N of adding doxygen comments to app_queue. I picked some of the ↵mmichelson1-3/+82
most common functions used (which also happen to be some the biggest/ugliest functions too) to document first. I'm pretty new to doxygen so criticism is welcome. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97304 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-08Some coding guidelines-related cleanupmmichelson1-11/+11
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97206 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-08Making some changes designed to not allow for a corrupted mailstream for a ↵mmichelson1-4/+8
vm_state. 1. Add locking to the vm_state retrieval functions so that no linked list corruption occurs. 2. Make sure to always grab the persistent vm_state when mailstream access is necessary. 3. Correct an incorrect return value in the init_mailstream function. (closes issue #11304, reported by dwhite) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97192 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-08Make app_queue calls work with directed pickup.file1-0/+10
(closes issue #11700) Reported by: jbauer git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@97093 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-02We need to reset the membername to NULL on each iteration of this loop, ↵mmichelson1-0/+1
otherwise the result is that multiple members can have the same name, since the variable was not reset on each iteration of the loop. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@96102 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-02app_macro only needs a rdlock on the contexts list.russell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@96020 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-02A change to improve the accuracy of queue logging in the case where a member ↵mmichelson1-6/+23
does not answer during the specified timeout period. Prior to this change, there was a small chance that the member name recorded in this case would be blank. Also prior to this change, if using the ringall strategy, if no one answered the call during the specified timeout, the member name listed in the queue log would randomly be one of the members that was rung. (closes issue #11498, reported and tested by hloubser, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@95890 f38db490-d61c-443f-a65b-d21fe96a405b