| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
does not
answer during the specified timeout period. Prior to this change, there was a small chance
that the member name recorded in this case would be blank. Also prior to this change, if using
the ringall strategy, if no one answered the call during the specified timeout, the member name
listed in the queue log would randomly be one of the members that was rung.
(closes issue #11498, reported and tested by hloubser, patched by me)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@95890 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
small setup.
If a queue uses the ringall strategy, it was possible through unfortunate coincidence for a single member at a given penalty level to
make app_queue think that all members at that penalty level were unavailable and cause the members at the
next penalty level to be rung. With this patch, we will only move to the next penalty level if ALL the members
at a given penalty level are unreachable.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@95095 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@94543 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #11415, reported by jaroth)
(closes issue #11152, reported by selsky)
Patch provided by jaroth
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@94540 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
just the name of the mailbox.
(closes issue #11419, reported and patched by jaroth, with additional patchwork from me)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@94538 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@94464 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
guidelines cleanup.
(closes issue #11599, reported and patched by caio1982, coding guidelines cleanup by me)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@94420 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
IMAP storage
since greetings are stored in the filesystem.
(closes issue #11388, reported by spditner, patch by me inspired by a patch by spditner)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@93291 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
I wonder if Asterisk can run at all without res_features. My guess is that
there's propably a lot of more modules and the core that depends on it.
Reported by: caio1982
(closes issue #11574)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@93182 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
rizzo brought up some issues related to the way that the metadata required
for menuselect and the rest of the build system is extracted from the source
files. Since I had a few hours to kill on an airplane today, I decided to
improve this situation... so now the system caches the extracted metadata
and uses it to build the menuselect 'tree' as much as it can. The result
of this is that when a single source file is changed, only the metadata for
that file needs to be extracted again, and the rest is used from the cache
files. I also reduced the number of forked processes required to do the
metadata extraction; it was actually possible to do most of what we needed
in the Makefiles themselves without using any shell scripts at all! On my
laptop, these changes resulted in an 80% decrease in the time required
for the 'menuselect.makeopts' automatic check to occur after editing a single
source file.
While doing this work I also cleaned up a few minor things in the Makefiles,
adding a check for 'awk' to the configure script and changed all remaining
places we use 'grep' or 'awk' to use the ones found by the configure script,
and changed the 'prep_tarball' script to build the menuselect metadata so
that tarballs of Asterisk will include it and won't require the user to
wait while it is extracted after unpacking.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@93180 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@92807 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@92803 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Issue 11048, tested by pep.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@92617 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@92443 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
caller were ringing members (but not yet bridged) there could be available members
and waiting callers who would not get matched up. The member availability checker
was correctly determining the number of available members in this scenario, but
the queue itself did not parallelly reflect this status on the pending calls. This
commit corrects the issue.
(closes issue #11459, reported by equissoftware, patched by me)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@92323 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
detecting
duplicate dialed numbers will be skipped, meaning the datastore isn't created. This means
that when we try to free it, there's a crash. This stops that crash from occurring.
(closes issue #11499, reported by slavon, patched by eliel)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@92202 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
to be locked.
* Document why we don't record Local channels in the dialed interfaces list.
* Remove the dialed variable as it isn't needed.
* Restructure some code for clarity and coding guidelines stuff
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@91783 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
to be locked.
* Document why we don't record Local channels in the dialed interfaces list.
* Handle memory allocation failure.
* Remove the dialed variable, as it wasn't actually needed.
* Tweak some formatting to conform to coding guidelines.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@91780 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
iterator.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@91693 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
flaw in the code to prevent call forwards from looping that caused this problem.
(related to issue #11486)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@91677 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
on every call into a queue. I'm not entirely sure about the logic in this part
of the code, so I want to look at it some more tomorrow. However, this makes
it safe and keeps it from crashing.
(closes issue #11486, reported by adamg, patched by me)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@91675 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
had the possibility
of crashing if a user had more than 256 messages in their voicemail. This patch kills two birds with
one stone by adding maxmsg support and also setting a hard limit on the number of messages at 255 so
that the crashes cannot happen.
(closes issue #11101, reported by Skavin, patched by me)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@91541 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@91292 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
label was
provided. This was due to the fact that the answering channel did not have an extension
set, so ast_parseable_goto would fail. This fix eliminates the call to ast_parseable_goto
on the answering channel since it is a wasteful call. The answering channel and the calling
channel are both directed to the same extension and context, just different priorities, so
we can just copy the values from the calling channel to the answering channel and increment
the answering channel's priority.
(closes issue #11382, reported by jon, patch by me with correction by jon)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@91273 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@90798 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
This is the merge of the forward-loop branch. The main change here is that call-forwards can no longer loop.
This is accomplished by creating a datastore on the calling channel which has a linked list of all devices
dialed. If a forward happens, then the local channel which is created inherits the datastore. If, through this
progression of forwards and datastore inheritance, a device is attempted to be dialed a second time, it will simply
be skipped and a warning message will be printed to the CLI. After the dialing has been completed, the datastore
is detached from the channel and destroyed.
This change also introduces some side effects to the code which I shall enumerate here:
1. Datastore inheritance has been backported from trunk into 1.4
2. A large chunk of code has been removed from app_dial. This chunk is the section of code
which handles the call forward case after the channel has been requested but before it has
been called. This was removed because call-forwarding still works fine without it, it makes the
code less error-prone should it need changing, and it made this set of changes much less painful
to just have the forwarding handled in one place in each module.
3. Two new files, global_datastores.h and .c have been added. These are necessary since the datastore
which is attached to the channel may be created and attached in either app_dial or app_queue, so they
need a common place to find the datastore info. This approach was taken in case similar datastores are
needed in the future, there will be a common place to add them.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@90735 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Issue 11383, reported by markmhy, patch by eliel.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@90696 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
change, I added some code to set pointers to NULL after they were unreferenced.
This pointed out that in this place, the object was unreferenced before the
code was done using it. So, move the unref down a little bit.
(crash reported by jmls on IRC)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@90470 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Now, it automatically increases the reference count to reflect the reference
that is now held by the container.
This was done to be more consistent with ao2_unlink(), which automatically
releases the reference held by the container. It also makes it so it is
no longer possible for a pointer to be invalid after ao2_link() returns.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@90348 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
added
via the manager. If a negative value is submitted for a member penalty, we set it to 0.
(closes issue #11411, reported and patched by Laureano)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@90163 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #11405)
Reported by: eliel
Patches:
load_realtime.patch uploaded by eliel (license 64)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@90101 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
be stored.
Since greetings are not retrieved from IMAP anyway, it is pointless to attempt storing them there.
(closes issue #11359, reported by spditner, patched by me)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89999 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
eventwhencalled variable to 1.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89844 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
1) Due to some signed vs. unsigned silliness, setting 'eventwhencalled' to
'vars' or 'yes' did exactly the same thing. Thus the sign change of the
ast_true call.
2) The vars2manager function overwrote a \n for every channel variable it parsed, resulting
in bizarre output for the channel variables. This patch remedies this.
(related to issue #11385, however I'm not sure if this will actually be enough to close it)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89837 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
cdr.conf file, I added the option 'unanswered', which defaults to 'no'. In this mode, you will see a cdr for a call, whether it was answered or not. The disposition will be NO ANSWER or ANSWERED, as appropriate. The src is as you'd expect, the destination channel will be one of the channels from the Dial() call, usually the last in the list if more than one chan was specified. With unanswered set to 'yes', you will still see this cdr entry in both cases. But in the case where the dial timed out, you will also see a cdr for each line attempted, marked NO ANSWER, with no destination channel name. The new option defaults to 'no', so you don't see the pesky extra cdr's by default, and you will not see the irritating 'not posted' messages.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89622 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
playback of a number,
app_playback will continue to try to play the remaining files. With this change, no more files will
be played back upon hangup.
(closes issue #11345, reported and patched by IgorG)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89618 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
out to the CLI every time do_say in app_playback is called. Removing these
warnings
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89616 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #11357)
Reported by: reformed
Patches:
mixmonitor.patch uploaded by reformed (license 330)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89587 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
was called. This prevents sending a duplicate e-mail.
(closes issue #11204, reported by spditner, patched by me)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89580 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #11367)
Reported by: eliel
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89571 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
This change fixes the problem, with a multi-faceted approach. First, we
do our best to avoid these messages from being created in the first place,
and second, if that fails, we detect when the voicemail message is
zero-length and avoid exiting at that point.
Reported by: dtyoo
Patch by: gkloepfer,tilghman
(Closes issue #11083)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89540 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89495 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
circumstances, this
message would always report that there were 0 members available, even though that may not be true.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89493 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #11271, reported and patched by atis, with small modifications from me)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89323 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
has a call out to the station, but the user has pressed a line button to answer
the call instead of picking up the handset. If they do, the phone sends out a
new INVITE. So, the SLAStation app must check to see if it is picking up a
ringing trunk, and ensure that the other stations stop ringing.
(reported internally, patched by me, tested by mogorman)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89296 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Thanks to Kevin for pointing this out
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89241 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
args.options
and args.post_process strings are uninitialized and could contain garbage. This change
handles this situation properly by only using arguments that we have parsed.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89205 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
it in 1.4 as
well. If an imapfolder is specified in voicemail.conf, don't ever explicitly connect to
INBOX since it may not exist.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89111 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
A huge thanks go to lvl- for patiently providing the necessary valgrind output
that was necessary to finding this problem of memory corruption.
Reported by: lvl-
Patch by: tilghman
Closes issue #11174
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@89093 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
and ast_string_field_free_all to ast_string_field_reset_all
to avoid misuse (due to too similar names and an error in
documentation). Fix two related memory leaks in app_meetme.
No need to merge to trunk, different fix already applied there.
Not applicable to 1.2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@88471 f38db490-d61c-443f-a65b-d21fe96a405b
|
