aboutsummaryrefslogtreecommitdiffstats
path: root/apps
AgeCommit message (Collapse)AuthorFilesLines
2007-10-04Don't allocate space for queue members unless it's needed. You end up ↵mmichelson1-1/+2
deleting dynamic members on a reload. Not good. closes issue (#10879, reported by dazza76, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@84692 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-04Create a duplicate of the channel's member name as the tab completion stuff ↵file1-1/+1
will free it. (closes issue #10884) Reported by: adamg git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@84637 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-01Simplify the CAN_EARLY_BRIDGE macro a bit.russell1-1/+3
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@84166 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-01Only attempt early bridging if the options given to Dial() permit it.file1-4/+7
(closes issue #10861) Reported by: peekyb git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@84158 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-20If # is pressed after dialing an extension in DISA, stop trying to collect ↵qwell1-0/+4
more digits. (issue #10754) Reported by: atis Patches: app_disa.c.branch.patch uploaded by atis (license 242) app_disa.c.trunk.patch uploaded by atis (license 242) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@83246 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-19The System() and TrySystem() applications can take a substantial amount ofrussell1-0/+4
time to execute while not servicing the channel. So, put the channel in autoservice while the command is being executed. (closes issue #10726, reported by mnicholson) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@83179 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-19Protect the CDR record from modification by pbx_exec so that the application ↵file1-1/+5
data contains the Queue data. (closes issue #10761) Reported by: snar Patches: app-queue-mixmonitor.patch uploaded by snar (license 245) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@83074 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-19Change the description of app_flash to note how it can be a useful tool insteadrussell1-3/+4
of just saying that it is generally a worthless feature. (Thanks to Jim Van Meggelen for pointing it out and providing the proposed text) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82992 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-18Initialize a variable to NULL to make the world happy.file1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82961 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-18Moving the logic for handling an empty membername to the create_member ↵mmichelson1-15/+8
function so that there is a common place where this occurs instead of being spread out to several different places. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82865 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-18there is no need for conditional logic to select ->interface or ↵kpfleming1-11/+5
->membername, snince ->membername will always be populated git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82834 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-17Put a memset in ast_localtime() instead of a couple places in app_voicemailrussell1-3/+0
to prevent the problem everywhere instead of just a couple of places. (related to issue #10746) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82676 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-17Initialize some memory to fix crashes when leaving voicemail. This problemrussell1-1/+7
was fixed by running Asterisk under valgrind. (closes issue #10746, reported by arcivanov, patched by me) *** IMPORTANT NOTE: We need to check to see if this same bug exists elsewhere. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82644 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-17fix a couple of places where a logical member name (if specified) was not ↵kpfleming1-5/+11
used, but instead the direct interface was listed git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82590 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-14Crap, I broke the build. Fixed.mmichelson1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82398 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-14Adding member name field to manager events where they were missing beforemmichelson1-2/+4
(closes issue #10721, reported by snar) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82396 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-14Fixed problem with changes made to cdr functionalityjdixon1-0/+45
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82368 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-14Added channel driver for USB Radio device andjdixon1-76/+265
support thereof. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82366 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-13Preemptively fixing a possible segfault. It is possible that queuename is NULL mmichelson1-1/+1
(meaning pause ALL queues), so use q->name instead. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82346 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-13Added logic to handle the unlikely case that someone has two queues with the ↵mmichelson1-1/+13
same name. Asterisk will log a warning message letting the user know that one was already defined with that name and is it skipping all further instances. This also will work for realtime queues but in order for that to happen, the user would have to trigger a perfectly timed reload as a realtime queue is being looked up, which is highly unlikely (but taken care of nonetheless). git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82326 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-12remove a race condition for the creation of recordthread's, and fix a small ↵dhubbard1-2/+10
memory leak. This closes issue# 10636 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82286 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-12Accidentally committed changes to app_voicemail which do NOT need to be in ↵mmichelson1-45/+5
the 1.4 branch yet. reverting... git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82276 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-12We should only initialize a realtime queue when it is allocated, not every ↵mmichelson2-7/+46
time we access it. This prevents the members ao2_container from being reallocated every time the queue is accessed. I also removed a debug message I had accidentally left in on a previous commit. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82274 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-11Fix incorrect uses of ao2_find(). Every one of these calls was reading bogusrussell1-8/+16
memory ... git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82267 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-11Fix another missing unref of member objects. This one was pointed out by Marta.russell1-0/+2
When building the outgoing list in try_calling(), a member reference is stored in each outgoing entry. However, when this list got destroyed, the reference was not released. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82263 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-11All instances of ao2_iterators which were just named 'i' have been renamedmmichelson1-50/+51
to 'mem_iter' so that when refcounted queues are merged into trunk, there will be little confusion regarding iterator names, especially when a queue and member iterator are used in the same function. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82252 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-11Add a couple more missing unrefs of queue member objectsrussell1-0/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82240 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-11Add a missing unref of a queue member in an error handling blockrussell1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82238 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-11Document why membercount can not simply be replaced by ao2_container_count()russell1-1/+6
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82236 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-10Convert struct member to use refcounts (closes issue #10199)tilghman1-159/+180
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@82155 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-07Allow the MEMBERINTERFACE variable to be used as the mixmonitor filename.qwell1-2/+4
This moves the setting of the MEMBERINTERFACE variable to before mixmonitor. Issue 10671, patch by sim. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81923 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-06(closes issue #10122)file1-7/+0
Reported by: stevefeinstein Patches: meetme-unmute-manager.diff uploaded by qwell (license 4) Tested by: stevefeinstein After looking over the code I agree with Qwell. Setting the file descriptor to conference each time just causes a fight back and forth. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81776 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-06Fixes an issue where valid DTMF had to be pressed twice to exit a queue if a ↵mmichelson1-3/+2
member's phone was ringing. (closes issue #10655, reported by strider2k, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81713 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-05Fixing the build...mmichelson1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81525 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-05Reverting behavior of QUEUE_MEMBER_COUNT to only count members who are logged inmmichelson1-1/+6
and available. (related to issue #10652, reported by wuwu) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81520 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-04Rather than attempt to play a file, we can just check whether it exists.qwell1-5/+1
Issue 10634, patch by me, testing by pabelanger, sanity checked by bweschke git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81455 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-01Changed a comment to be more accurate.mmichelson1-1/+1
(really this is just a test to make sure I can commit properly from home) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81428 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-31Fixed broken behavior of a reload on realtime queues. Prior to this patch, ↵mmichelson1-2/+4
if a reload was issued and a realtime queue had callers waiting in it, then the queue would be removed from the queue list, but it would not actually be freed (in fact, a debug message warning about a memory leak would come up). With this patch, reloads do not touch realtime queues at all. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81416 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-31Re-order dial options to be in line with the existing alpha order.qwell1-8/+8
Issue 10621, initial patch by junky git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81412 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-30Removing an extraneous (and possibly misleading) log message. Firstly, if ↵mmichelson1-2/+1
the announce file isn't found, the streaming functions will report it. Secondly, not all non-zero returns from play_file mean that the announce file wasn't found. Positive return values simply mean that a digit was pressed (most likely to skip through the announcement). (closes issue #10612, reported and patched by dimas) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81397 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-30Changed some manager event messages to reflect whether a queue member is a ↵mmichelson1-2/+2
realtime member or not git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81381 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-29This patch, in essence, will correctly pause a realtime queue member and ↵mmichelson1-0/+22
reflect those changes in the realtime engine. (issue #10424, reported by irroot, patch by me) This patch creates a new function called update_realtime_member_field, which is a generic function which will allow any one field of a realtime queue member to be updated. This patch only uses this function to update the paused status of a queue member, but it lays the foundation for persisting the state of a realtime member the same way that static members' state is maintained when using the persistentmembers setting git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81349 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-29Changed some tabs to spacesmmichelson1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81346 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-29This fix creates a more accurate way of detecting whether realtime members ↵mmichelson1-4/+8
were deleted. (closes issue 10541, reported by Alric, patched by me) The REALLY nice things about this patch is that queue members now have a "realtime" field which will be true if the member is a realtime member. This means we can check this value prior to certain processing if it should ONLY be done for realtime members. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81340 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-27Resolve a potential deadlock. In this case, a single queue is locked, then ↵mmichelson1-0/+4
the queue list. In changethread(), the queue list is locked, and then each individual queue is locked. Under the right circumstances, this could deadlock. As such, I have unlocked the individual queue before locking the queue list, and then locked the queue back after the queue list is unlocked. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81158 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-27Found a case where the queue's membercount is off. It does not take into ↵mmichelson1-1/+4
account dynamic members on a reload. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@81010 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-24An empty string is an empty callerid ... so zap it. This closes issue ↵dhubbard1-1/+1
#10502, which was pointed out by dswartz. Thank you, and may the swartz be with you git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@80878 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-24 A minor correction to the available logic of autofill. If a queue member is ↵bweschke1-1/+2
paused, they're not really "available" so don't count them as such. Somewhat related to issue #10155 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@80818 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-24Fix a possible crash in IMAP voicemail.mmichelson1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@80750 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-20Fix the build of app_queuerussell1-49/+49
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@80088 f38db490-d61c-443f-a65b-d21fe96a405b