aboutsummaryrefslogtreecommitdiffstats
path: root/apps/app_voicemail.c
AgeCommit message (Collapse)AuthorFilesLines
2007-11-16Start untangling header inclusion in a way that does not affectrizzo1-5/+0
build times - tested, there is no measureable difference before and after this commit. In this change: use asterisk/compat.h to include a small set of system headers: inttypes.h, unistd.h, stddef.h, stddint.h, sys/types.h, stdarg.h, stdlib.h, alloca.h, stdio.h Where available, the inclusion is conditional on HAVE_FOO_H as determined by autoconf. Normally, source files should not include any of the above system headers, and instead use either "asterisk.h" or "asterisk/compat.h" which does it better. For the time being I have left alone second-level directories (main/db1-ast, etc.). git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89333 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-16Adding confirmation playback when forwarding voicemail messages. This will ↵mmichelson1-0/+18
attempt to play the name(s) of the person(s) to whom you are forwarding the message prior to prompting for prepending. If no name is found, the extension is read back verbatim. (closes issue #9046, reported and patched by jaroth) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89327 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-14make the 'name' and 'value' fields in ast_variable const char *rizzo1-3/+3
This prevents modifying the strings in the stored variables, and catched a few instances where this was actually done. Given the differences between trunk and 1.4 (and the fact that this is effectively an API change) it is better to fix 1.4 independently. These are chan_sip.c::sip_register() chan_skinny.c:: near line 2847 config.c:: near line 1774 logger.c::make_components() res_adsi.c:: near line 1049 I may have missed some instances for modules that do not build here. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89268 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-08app_voicemail failed to build when compiling with IMAP_STORAGEmmichelson1-3/+2
Now it does not. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89123 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-08use %f instead of %lf (the 'l' is ignored anyways).rizzo1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89110 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-08improve linked-list macros in two ways:kpfleming1-2/+2
- the *_CURRENT macros no longer need the list head pointer argument - add AST_LIST_MOVE_CURRENT to encapsulate the remove/add operation when moving entries between lists git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89106 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-07If imapfolder has been specified in voicemail.conf, we should not connect to ↵mmichelson1-2/+2
INBOX... ever. It may not exist. (closes issue #11151, reported by selsky, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89092 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-29Remove duplicate stdlib.h include.file1-1/+0
(closes issue #11105) Reported by: eliel Patches: app_voicemail.c.patch uploaded by eliel (license 64) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@87327 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-22Switch from AST_CLI (formerly NEW_CLI) to AST_CLI_DEFINE, since the former ↵qwell1-2/+2
didn't make much sense git-svn-id: http://svn.digium.com/svn/asterisk/trunk@86820 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-22Merged revisions 86694 via svnmerge from mmichelson1-2/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r86694 | mmichelson | 2007-10-22 09:48:46 -0500 (Mon, 22 Oct 2007) | 5 lines Account for the fact that sometimes headers may be terminated with \r\n instead of just \n (closes issue #11043, reported by yehavi) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@86696 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-19Convert NEW_CLI to AST_CLI.qwell1-2/+2
Closes issue #11039, as suggested by seanbright. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@86536 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-16Merged revisions 85896 via svnmerge from russell1-3/+0
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r85896 | russell | 2007-10-16 14:10:01 -0500 (Tue, 16 Oct 2007) | 2 lines Remove a pointless lock. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@85897 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-16Fix IMAP compilation error.mmichelson1-1/+1
(closes issue #10986, reported and patched by snuffy) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@85883 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-10Merged revisions 85276 via svnmerge from mmichelson1-194/+23
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r85276 | mmichelson | 2007-10-10 09:26:31 -0500 (Wed, 10 Oct 2007) | 5 lines A bunch of changes from sprintf to snprintf. See security advisory AST-2002-022 ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@85279 f38db490-d61c-443f-a65b-d21fe96a405b
2007-10-10Merged revisions 85242 via svnmerge from file1-0/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r85242 | file | 2007-10-10 11:14:56 -0300 (Wed, 10 Oct 2007) | 6 lines Close voicemail message description file if duration did not meet the minimum, or else we will eventually run out of file descriptors. (closes issue #10918) Reported by: brak2718 Patches: vm1.4.12.1.patch uploaded by brak2718 (license 279) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@85254 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-19More conversions to NEW_CLIqwell1-71/+80
(issue #10724) Patches: chan_zap.c.patch uploaded by moy (license 222) app_queue.c.patch uploaded by eliel (license 64) app_voicemail.c.patch uploaded by eliel (license 64) app_meetme.c.patch uploaded by eliel (license 64) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@83213 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-18(closes issue #10739)qwell1-2/+11
Reported by: ruffle Patches: app_voicemail.c.diff uploaded by ruffle (license 201) 10739-moveheard.diff uploaded by qwell (license 4) Tested by: callguy, ruffle Add an option to disable the automatic moving of "heard" messages to the Old folder. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@82871 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-17Merged revisions 82676 via svnmerge from russell1-2/+0
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r82676 | russell | 2007-09-17 15:16:25 -0500 (Mon, 17 Sep 2007) | 4 lines Put a memset in ast_localtime() instead of a couple places in app_voicemail to prevent the problem everywhere instead of just a couple of places. (related to issue #10746) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@82678 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-17Merged revisions 82644 via svnmerge from russell1-0/+5
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r82644 | russell | 2007-09-17 15:00:32 -0500 (Mon, 17 Sep 2007) | 6 lines Initialize some memory to fix crashes when leaving voicemail. This problem was fixed by running Asterisk under valgrind. (closes issue #10746, reported by arcivanov, patched by me) *** IMPORTANT NOTE: We need to check to see if this same bug exists elsewhere. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@82660 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-16Option maxmessage should be maxsecs per-folder, too (closes issue #10729)tilghman1-4/+6
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@82496 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-08Make Callerid more consistent in IMAP mail headersmmichelson1-10/+19
(closes issue #10056, reported and patched by jaroth, with small modification by me) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@81984 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-29This code was in team/murf/bug8684-trunk; it should fix bug 8684 in trunk. I ↵murf1-1/+1
didn't add it to 1.4 yet, because it's not entirely clear to me if this is a bug fix or an enhancement. A lot of files were affected by small changes like ast_variable_new getting an added arg, for the file name the var was defined in; ast_category_new gets added args of filename and lineno; ast_category and ast_variable structures now record file and lineno for each entry; a list of all #include and #execs in a config file (or any of its inclusions are now kept in the ast_config struct; at save time, each entry is put back into its proper file of origin, in order. #include and #exec directives are folded in properly. Headers indicating that the file was generated, are generated also for each included file. Some changes to main/manager.c to take care of file renaming, via the UpdateConfig command. Multiple inclusions of the same file are handled by exploding these into multiple include files, uniquely named. There's probably more, but I can't remember it right now. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@81361 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-24Merged revisions 80750 via svnmerge from mmichelson1-2/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r80750 | mmichelson | 2007-08-24 10:51:03 -0500 (Fri, 24 Aug 2007) | 3 lines Fix a possible crash in IMAP voicemail. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@80751 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-20Remove remnants of last commit so trunk builds again.file1-2/+0
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@80046 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-20Merged revisions 80044 via svnmerge from mmichelson1-1/+94
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r80044 | mmichelson | 2007-08-20 10:34:43 -0500 (Mon, 20 Aug 2007) | 5 lines Ukrainian language voicemail support. (closes issue #10458, reported and patched by Oleh) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@80045 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-20Merged revisions 79998 via svnmerge from tilghman1-2/+3
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r79998 | tilghman | 2007-08-19 21:42:49 -0500 (Sun, 19 Aug 2007) | 2 lines Missing curly braces. Oops. (Reported by snuffy via IRC) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@79999 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-18Merged revisions 79947 via svnmerge from tilghman1-14/+8
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r79947 | tilghman | 2007-08-18 09:30:44 -0500 (Sat, 18 Aug 2007) | 3 lines Don't allocate vmu for messagecount when we could just use the stack instead (closes issue #10490) Also, remove a useless (and leaky) SQLAllocHandle (closes issue #10480) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@79949 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-17I broke the build. Now I'm fixing it.mmichelson1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@79915 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-17Merged revisions 79906 via svnmerge from mmichelson1-1/+10
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r79906 | mmichelson | 2007-08-17 14:14:05 -0500 (Fri, 17 Aug 2007) | 6 lines Patch allows for more seamless transition from file storage voicemail to ODBC storage voicemail. If a retrieval of a greeting from the database fails, but the file is found on the file system, then we go ahead an insert the greeting into the database. The result of this is that people who switch from file storage to ODBC storage do not need to rerecord their voicemail greetings. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@79907 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-16Don't reload a configuration file if nothing has changed.tilghman1-13/+29
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@79747 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-16added counter for voicemail show users, issue 10462, thanks junkydhubbard1-0/+3
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@79724 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-16Merged revisions 79690 via svnmerge from mmichelson1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r79690 | mmichelson | 2007-08-16 10:58:34 -0500 (Thu, 16 Aug 2007) | 5 lines base_encode is not trying to open a log file, so we should not call it a log file in the warning. (related to issue #10452, reported by bcnit) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@79691 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-15Merged revisions 79527 via svnmerge from mmichelson1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r79527 | mmichelson | 2007-08-15 09:26:40 -0500 (Wed, 15 Aug 2007) | 5 lines Fixed an error in the Russian language voicemail intro. (issue #10458, reported and patched by Oleh) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@79529 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-09Merged revisions 78907 via svnmerge from mmichelson1-7/+13
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r78907 | mmichelson | 2007-08-09 18:47:00 -0500 (Thu, 09 Aug 2007) | 4 lines Improved a bit of logic regarding comma-separated mailboxes in has_voicemail. Also added some braces to some compound if statements since unbraced if statements scare me in general. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@78908 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-09Merged revisions 78859 via svnmerge from mmichelson1-134/+186
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r78859 | mmichelson | 2007-08-09 16:51:17 -0500 (Thu, 09 Aug 2007) | 9 lines Quite a few changes regarding IMAP storage. 1. instead of using inboxcount as the core message counting function, we use messagecount instead. This makes it possible to count messages in folders besides just INBOX and Old. 2. inboxcount and hasvoicemail now use messagecount as their means of determining return values. 3. Added a copy_message function for IMAP storage. Unfortunately I don't have the means to test it, but it seems like a pretty straightforward function. 4. Removed a #ifndef IMAP_STORAGE and matching #endif from leave_voicemail for a couple of reasons. One, we want to support copying mail to multiple IMAP boxes, and two, IMAP was broken because a STORE macro had been moved into this section of code. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@78861 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-09Merged revisions 78778 via svnmerge from russell1-0/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r78778 | russell | 2007-08-09 12:58:31 -0500 (Thu, 09 Aug 2007) | 1 line add a comment to indicate that inboxcount for ODBC_STORAGE needs to be fixed to support multiple mailboxes ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@78779 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-09Merged revisions 78749 via svnmerge from russell1-10/+11
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r78749 | russell | 2007-08-09 12:24:40 -0500 (Thu, 09 Aug 2007) | 9 lines Fix subscriptions to multiple mailboxes for ODBC_STORAGE. Also, leave a comment for this to be fixed for IMAP_STORAGE, as well. I left IMAP alone since I know MarkM was working on this code right now for another reason. This is broken even worse in trunk, but for a different reason. The fact that the mailbox option supported multiple mailboxes is completely not obvious from the code in the channel drivers. Anyway, I will fix that in another commit ... ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@78750 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-09Fix a problem that I had introduced into MWI handling. I had ignoredrussell1-4/+7
the mailbox context. Now, all related MWI event dealings pay attention to the context as well. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@78747 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-07Merged revisions 78450 via svnmerge from mmichelson1-4/+4
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r78450 | mmichelson | 2007-08-07 14:43:57 -0500 (Tue, 07 Aug 2007) | 5 lines The logic behind inboxcount's return value was reversed in has_voicemail and message_count. (closes issue #10401, reported by st1710, patched by me) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@78451 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-07Merged revisions 78415 via svnmerge from tilghman1-178/+72
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r78415 | tilghman | 2007-08-07 14:09:38 -0500 (Tue, 07 Aug 2007) | 2 lines Reconnection doesn't happen automatically when a DB goes down (fixes issue #9389) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@78417 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-03Merged revisions 78101 via svnmerge from russell1-0/+6
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r78101 | russell | 2007-08-03 15:14:06 -0500 (Fri, 03 Aug 2007) | 10 lines (closes issue #10194) Reported by: blitzrage Patches: bug0010194 uploaded by vovochka Tested by: blitzrage Fix a problem when you call Voicemail() with multiple mailboxes specified and ODBC_STORAGE is in use. The audio part of the message was only given to the first mailbox specified. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@78102 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-01Merged revisions 77886 via svnmerge from tilghman1-0/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r77886 | tilghman | 2007-08-01 17:14:47 -0500 (Wed, 01 Aug 2007) | 2 lines Voicemail with ODBC_STORAGE defined does not compile cleanly (missing def) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@77888 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-01Merged revisions 77869 via svnmerge from file1-2/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r77869 | file | 2007-08-01 14:56:59 -0300 (Wed, 01 Aug 2007) | 2 lines Add some fixes for building on Solaris. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@77870 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-31Mostly cleanup of documentation to substitute the pipe with the comma, but a ↵tilghman1-4/+4
few other formatting cleanups, too. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@77808 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-26Do a massive conversion for using the ast_verb() macrorussell1-24/+13
(closes issue #10277, patches by mvanbaak) Basically, this changes ... if (option_verbose > 2) ast_verbose(VERBOSE_PREFIX_3, "Something\n"); to ... ast_verb(3, "Something\n"); git-svn-id: http://svn.digium.com/svn/asterisk/trunk@77299 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-23Merged revisions 76708 via svnmerge from tilghman1-0/+7
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r76708 | tilghman | 2007-07-23 17:38:06 -0500 (Mon, 23 Jul 2007) | 4 lines It was our stated intention for 1.4 that files created in app_voicemail should depend upon the umask. Unfortunately, mkstemp() creates files with mode 0600, regardless of the umask. This corrects that deficiency. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@76709 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-23Merge the dialplan_aesthetics branch. Most of this patch simply converts ↵tilghman1-3/+3
applications using old methods of parsing arguments to using the standard macros. However, the big change is that the really old way of specifying application and arguments separated by a comma will no longer work (e.g. NoOp,foo|bar). Instead, the way that has been recommended since long before 1.0 will become the only method available (e.g. NoOp(foo,bar). git-svn-id: http://svn.digium.com/svn/asterisk/trunk@76703 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-19After some study, thought, comparing, etc. I've backed out the previous ↵murf1-3/+3
universal mod to make ast_flags a 64 bit thing. Instead, I added a 64-bit version of ast_flags (ast_flags64), and 64-bit versions of the test-flag, set-flag, etc. macros, and an app_parse_options64 routine, and I use these in app_dial alone, to eliminate the 30-option limit it had grown to meet. There is room now for 32 more options and flags. I was heavily tempted to implement some of the other ideas that were presented, but this solution does not intro any new versions of dial, doesn't have a different API, has a minimal/zero impact on code outside of dial, and doesn't seriously (I hope) affect the code structure of dial. It's the best I can think of right now. My goal was NOT to rewrite dial. I leave that to a future, coordinated effort. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@75983 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-18Merged revisions 75749 via svnmerge from tilghman1-1/+8
https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r75749 | tilghman | 2007-07-18 15:40:18 -0500 (Wed, 18 Jul 2007) | 10 lines Merged revisions 75748 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r75748 | tilghman | 2007-07-18 15:31:36 -0500 (Wed, 18 Jul 2007) | 2 lines Store prior to copy (closes issue #10193) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@75750 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-18Merge in ast_strftime branch, which changes timestamps to be accurate to the ↵tilghman1-14/+12
microsecond, instead of only to the second git-svn-id: http://svn.digium.com/svn/asterisk/trunk@75706 f38db490-d61c-443f-a65b-d21fe96a405b