aboutsummaryrefslogtreecommitdiffstats
path: root/apps/app_voicemail.c
AgeCommit message (Collapse)AuthorFilesLines
2010-02-01Merged revisions 244243 via svnmerge from tilghman1-7/+33
https://origsvn.digium.com/svn/asterisk/trunk ................ r244243 | tilghman | 2010-02-01 17:16:12 -0600 (Mon, 01 Feb 2010) | 18 lines Merged revisions 244242 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r244242 | tilghman | 2010-02-01 17:13:44 -0600 (Mon, 01 Feb 2010) | 11 lines Backup and restore original textfile, for prosthesis (gerund of prepend). Also, fix menuselect such that changing voicemail build options correctly causes rebuild. (closes issue #16415) Reported by: tomo1657 Patches: prepention.patch uploaded by tomo1657 (license 484) (with modifications by me to backport to 1.4) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@244320 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-15Merged revisions 240415 via svnmerge from tilghman1-4/+75
https://origsvn.digium.com/svn/asterisk/trunk ................ r240415 | tilghman | 2010-01-15 14:54:24 -0600 (Fri, 15 Jan 2010) | 22 lines Merged revisions 240414 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r240414 | tilghman | 2010-01-15 14:52:27 -0600 (Fri, 15 Jan 2010) | 15 lines Disallow leaving more than maxmsg voicemails. This is a possibility because our previous method assumed that no messages are left in parallel, which is not a safe assumption. Due to the vmu structure duplication, it was necessary to track in-process messages via a separate structure. If at some point, we switch vmu to an ao2-reference-counted structure, which would eliminate the prior noted duplication of structures, then we could incorporate this new in-process structure directly into vmu. (closes issue #16271) Reported by: sohosys Patches: 20100108__issue16271.diff.txt uploaded by tilghman (license 14) 20100108__issue16271__trunk.diff.txt uploaded by tilghman (license 14) 20100108__issue16271__1.6.0.diff.txt uploaded by tilghman (license 14) Tested by: jsutton ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@240418 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-28Merged revisions 236667 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r236667 | tilghman | 2009-12-28 11:37:46 -0600 (Mon, 28 Dec 2009) | 4 lines Use recommended option, not deprecated option. (closes issue #16515) Reported by: ManChicken ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@236670 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-04Merged revisions 233121 via svnmerge from dvossel1-3/+9
https://origsvn.digium.com/svn/asterisk/trunk ................ r233121 | dvossel | 2009-12-04 11:22:31 -0600 (Fri, 04 Dec 2009) | 12 lines Merged revisions 233116 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r233116 | dvossel | 2009-12-04 11:21:34 -0600 (Fri, 04 Dec 2009) | 6 lines document and rename strip_control() in app_voicemail (closes issue #16291) Reported by: wdoekes ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@233165 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-03Merged revisions 232854 via svnmerge from tilghman1-66/+79
https://origsvn.digium.com/svn/asterisk/trunk ................ r232854 | tilghman | 2009-12-03 14:47:07 -0600 (Thu, 03 Dec 2009) | 15 lines Merged revisions 232820 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r232820 | tilghman | 2009-12-03 14:10:19 -0600 (Thu, 03 Dec 2009) | 8 lines Deprecate "cz" in favor of "cs". Also, change the use of language codes so that language registers as a prefix, rather than an exact match. (closes issue #16272) Reported by: patrol-cz Patches: 20091203__issue16272.diff.txt uploaded by tilghman (license 14) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@232866 f38db490-d61c-443f-a65b-d21fe96a405b
2009-11-30Merged revisions 231688 via svnmerge from mnicholson1-2/+10
https://origsvn.digium.com/svn/asterisk/trunk ................ r231688 | mnicholson | 2009-11-30 15:31:55 -0600 (Mon, 30 Nov 2009) | 15 lines Merged revisions 231614 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r231614 | mnicholson | 2009-11-30 15:11:44 -0600 (Mon, 30 Nov 2009) | 8 lines Remove duplicate entries from voicemail format lists. This prevents app_voicemail from entering an infinite loop when the same format is specified twice in the format list. (closes issue #15625) Reported by: Shagg63 Tested by: mnicholson Review: https://reviewboard.asterisk.org/r/429/ ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@231689 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-19Merged revisions 224448 via svnmerge from tilghman1-84/+92
https://origsvn.digium.com/svn/asterisk/trunk ........ r224448 | tilghman | 2009-10-18 19:05:56 -0500 (Sun, 18 Oct 2009) | 3 lines Allow ODBC storage to be queried with multiple mailboxes, and remove multiple goto's. This corrects an issue reported on the -users list. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@224451 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-30Merged revisions 221085 via svnmerge from seanbright1-1/+13
https://origsvn.digium.com/svn/asterisk/trunk ........ r221085 | seanbright | 2009-09-30 10:47:58 -0400 (Wed, 30 Sep 2009) | 9 lines Clarify documentation for VoiceMailMain()'s a() option. We require box numbers, not names as the documentation implies. (issue #14740) Reported by: pj Patches: __20090729-app_voicemail-documentation.patch uploaded by lmadsen (license 10) Tested by: seanbright, lmadsen ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@221089 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-30Remove optional_api from 1.6.2 branch, since it is not currently working.tilghman1-4/+0
This is a blocking issue for the 1.6.2 release. (closes issue #15914) Reported by: mbeckwell Branch: http://svn.digium.com/svn/asterisk/team/tilghman/optional_api_162 Tested by: mbeckwell git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@221042 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-29Merged revisions 220833 via svnmerge from jpeeler1-6/+8
https://origsvn.digium.com/svn/asterisk/trunk ........ r220833 | jpeeler | 2009-09-29 11:58:29 -0500 (Tue, 29 Sep 2009) | 12 lines Make deletion of temporary greetings work properly with IMAP_STORAGE When imapgreetings was set to yes, the message was being deleted but wasn't actually being expunged. When imapgreetings was set to no, the file based message was not being deleted at all. All good now! (closes issue #14949) Reported by: noahisaac Patches: vm_tempgreeting_removal.patch uploaded by noahisaac (license 748), modified by me ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@220836 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-22Merged revisions 219818 via svnmerge from tilghman1-0/+24
https://origsvn.digium.com/svn/asterisk/trunk ................ r219818 | tilghman | 2009-09-22 16:43:22 -0500 (Tue, 22 Sep 2009) | 17 lines Merged revisions 219816 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r219816 | tilghman | 2009-09-22 16:37:03 -0500 (Tue, 22 Sep 2009) | 10 lines When IMAP variables were changed during a reload, Voicemail did not use the new values. This change introduces a configuration version variable, which ensures that connections with the old values are not reused but are allowed to expire normally. (closes issue #15934) Reported by: viniciusfontes Patches: 20090922__issue15934.diff.txt uploaded by tilghman (license 14) Tested by: viniciusfontes ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@219821 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-18Merged revisions 219412 via svnmerge from tilghman1-0/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r219412 | tilghman | 2009-09-18 08:54:51 -0500 (Fri, 18 Sep 2009) | 6 lines Missing value setting line for maxsecs/maxmessage (closes issue #15696) Reported by: fhackenberger Patches: maxsecs.patch uploaded by fhackenberger (license 592) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@219415 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-15Merged revisions 218731 via svnmerge from tilghman1-15/+14
https://origsvn.digium.com/svn/asterisk/trunk ................ r218731 | tilghman | 2009-09-15 17:33:10 -0500 (Tue, 15 Sep 2009) | 13 lines Merged revisions 218730 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r218730 | tilghman | 2009-09-15 17:27:41 -0500 (Tue, 15 Sep 2009) | 6 lines If the user enters the same password as before, don't signal an error when the change does nothing. (closes issue #15492) Reported by: cbbs70a Patches: 20090713__issue15492.diff.txt uploaded by tilghman (license 14) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@218733 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-14Merged revisions 218361 via svnmerge from tilghman1-0/+13
https://origsvn.digium.com/svn/asterisk/trunk ................ r218361 | tilghman | 2009-09-14 14:29:48 -0500 (Mon, 14 Sep 2009) | 11 lines Recorded merge of revisions 218331 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r218331 | tilghman | 2009-09-14 14:16:35 -0500 (Mon, 14 Sep 2009) | 4 lines Don't say "Please try again" if we don't give the user another chance to try again. (issue #15055, SWP-129) Reported by: jthurman ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@218364 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-04Merged revisions 216593 via svnmerge from seanbright1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r216593 | seanbright | 2009-09-04 15:29:02 -0400 (Fri, 04 Sep 2009) | 1 line Use ast_free() instead of free(). ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@216597 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-24Merged revisions 213833 via svnmerge from jpeeler1-5/+8
https://origsvn.digium.com/svn/asterisk/trunk ........ r213833 | jpeeler | 2009-08-24 11:43:57 -0500 (Mon, 24 Aug 2009) | 14 lines Fix storage of greetings when using IMAP_STORAGE The store macro was not getting called preventing storage of IMAP greetings at all. This has been corrected along with fixing checking if the imapgreetings option is turned on to store the greeting in IMAP. Lastly, the attachment filename was incorrectly using the full path instead of just the basename, which was causing problems with retrieval of the greeting. (closes issue #14950) Reported by: noahisaac (closes issue #15729) Reported by: lmadsen ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@213836 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-21Merged revisions 213697 via svnmerge from kpfleming1-13/+18
https://origsvn.digium.com/svn/asterisk/trunk ........ r213697 | kpfleming | 2009-08-21 16:39:51 -0500 (Fri, 21 Aug 2009) | 12 lines Ensure that realtime mailboxes properly report status on subscription. This patch modifies app_voicemail's response to mailbox status subscriptions (via the internal event system) to ensure that a subscription triggers an explicit poll of the mailbox, so the subscriber can get an immediate cached event with that status. Previously, the cache was only populated with the status of non-realtime mailboxes. (closes issue #15717) Reported by: natmlt ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@213698 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-20Merged revisions 213404 via svnmerge from jpeeler1-4/+15
https://origsvn.digium.com/svn/asterisk/trunk ........ r213404 | jpeeler | 2009-08-20 16:33:11 -0500 (Thu, 20 Aug 2009) | 12 lines Fix greeting retrieval from IMAP Properly check for the current voicemail state and if it doesn't exist, create it. (closes issue #14597) Reported by: wtca Patches: 14597_v2.patch uploaded by mmichelson (license 60) Tested by: jpeeler ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@213413 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-17Merged revisions 212627 via svnmerge from tilghman1-1/+4
https://origsvn.digium.com/svn/asterisk/trunk ........ r212627 | tilghman | 2009-08-17 14:57:42 -0500 (Mon, 17 Aug 2009) | 4 lines Check the return value of opendir(3), or we may crash. (closes issue #15720) Reported by: tobias_e ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@212631 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-10AST-2009-005tilghman1-23/+23
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@211580 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-18Merged revisions 207317 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r207317 | tilghman | 2009-07-17 23:16:44 -0500 (Fri, 17 Jul 2009) | 3 lines Flag field in wrong position. Reported by "Hoggins!" on asterisk-dev list. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@207327 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-13Merged revisions 206185 via svnmerge from tilghman1-4/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r206185 | tilghman | 2009-07-13 11:23:07 -0500 (Mon, 13 Jul 2009) | 2 lines Remove reference to non-existent help file ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@206187 f38db490-d61c-443f-a65b-d21fe96a405b
2009-06-30Recorded merge of revisions 204470 via svnmerge from tilghman1-10/+10
https://origsvn.digium.com/svn/asterisk/trunk ................ r204470 | tilghman | 2009-06-30 13:36:24 -0500 (Tue, 30 Jun 2009) | 18 lines Recorded merge of revisions 204469 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r204469 | tilghman | 2009-06-30 13:23:35 -0500 (Tue, 30 Jun 2009) | 11 lines "tw" is the language specification for Twi (from Ghana) not Taiwanese. (closes issue #15346) Reported by: volivier Patches: 20090617__issue15346__1.4.diff.txt uploaded by tilghman (license 14) 20090617__issue15346__trunk.diff.txt uploaded by tilghman (license 14) 20090617__issue15346__1.6.0.diff.txt uploaded by tilghman (license 14) 20090617__issue15346__1.6.1.diff.txt uploaded by tilghman (license 14) 20090617__issue15346__1.6.2.diff.txt uploaded by tilghman (license 14) Tested by: volivier ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@204473 f38db490-d61c-443f-a65b-d21fe96a405b
2009-06-26Merged revisions 203721 via svnmerge from dbrooks1-2/+4
https://origsvn.digium.com/svn/asterisk/trunk ........ r203721 | dbrooks | 2009-06-26 15:13:51 -0500 (Fri, 26 Jun 2009) | 16 lines Fixing voicemail's error in checking max silence vs min message length Max silence was represented in milliseconds, yet vmminsecs (minmessage) was represented as seconds. Also, the inequality was reversed. The warning, if triggered, was "Max silence should be less than minmessage or you may get empty messages", which should have been logged if max silence was greater than minmessage, but the check was for less than. Also, conforming if statement to coding guidelines. closes issue #15331) Reported by: markd Review: https://reviewboard.asterisk.org/r/293/ ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@203731 f38db490-d61c-443f-a65b-d21fe96a405b
2009-06-17Merged revisions 201531 via svnmerge from tilghman1-1/+2
https://origsvn.digium.com/svn/asterisk/trunk ........ r201531 | tilghman | 2009-06-17 16:31:39 -0500 (Wed, 17 Jun 2009) | 7 lines Initialize additional variables, to prevent a possible crash. (closes issue #15186) Reported by: ajohnson Patches: 20090528__issue15186.diff.txt uploaded by tilghman (license 14) Tested by: ajohnson ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@201533 f38db490-d61c-443f-a65b-d21fe96a405b
2009-06-16Merged revisions 200943 via svnmerge from mvanbaak1-0/+7
https://origsvn.digium.com/svn/asterisk/trunk ........ r200943 | mvanbaak | 2009-06-16 17:51:36 +0200 (Tue, 16 Jun 2009) | 9 lines add FILE_STORAGE to Voicemail Build Options Voicemail can only use one storage module at the moment. Because it's unclear that selecting one of the storage modules in menuselect will disable filesystem storage we now have a FILE_STORAGE option that conflicts with the other modules. (closes issue #15333) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@200948 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-19Merged revisions 195521 via svnmerge from tilghman1-0/+3
https://origsvn.digium.com/svn/asterisk/trunk ................ r195521 | tilghman | 2009-05-19 15:16:01 -0500 (Tue, 19 May 2009) | 14 lines Merged revisions 195520 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r195520 | tilghman | 2009-05-19 15:12:20 -0500 (Tue, 19 May 2009) | 7 lines Ensure thread keys are initialized before attempting to access them. (closes issue #14889) Reported by: jaroth Patches: app_voicemail.c.patch uploaded by msirota (license 758) Tested by: msirota, BlargMaN ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@195531 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-18Merged revisions 195370 via svnmerge from tilghman1-2/+2
https://origsvn.digium.com/svn/asterisk/trunk ................ r195370 | tilghman | 2009-05-18 15:52:33 -0500 (Mon, 18 May 2009) | 15 lines Recorded merge of revisions 195366 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r195366 | tilghman | 2009-05-18 15:24:13 -0500 (Mon, 18 May 2009) | 8 lines Add a similar dependency on SMDI for voicemail as already exists for ADSI. (closes issue #14846) Reported by: pj Patches: 20090413__bug14846__1.4.diff.txt uploaded by tilghman (license 14) 20090507__issue14846__1.6.0.diff.txt uploaded by tilghman (license 14) 20090507__issue14846__1.6.1.diff.txt uploaded by tilghman (license 14) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@195373 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-12Merged revisions 193956 via svnmerge from tilghman1-4/+7
https://origsvn.digium.com/svn/asterisk/trunk ................ r193956 | tilghman | 2009-05-12 15:40:22 -0500 (Tue, 12 May 2009) | 13 lines Merged revisions 193955 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r193955 | tilghman | 2009-05-12 15:39:21 -0500 (Tue, 12 May 2009) | 6 lines Avoid initializing routines if the authentication fails. Fixes a crash (RR) issue. (closes issue #14508) Reported by: tiziano Patches: 20090221_2_wrongmailbox.diff.txt uploaded by tiziano (license 377) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@193959 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-12Merged revisions 193870 via svnmerge from tilghman1-4/+14
https://origsvn.digium.com/svn/asterisk/trunk ........ r193870 | tilghman | 2009-05-12 12:29:33 -0500 (Tue, 12 May 2009) | 2 lines Convert a THREADSTORAGE object into a simple malloc'd object (as suggested by Russell on -dev) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@193873 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-11Recorded merge of revisions 193756 via svnmerge from tilghman1-4/+6
https://origsvn.digium.com/svn/asterisk/trunk ................ r193756 | tilghman | 2009-05-11 17:50:47 -0500 (Mon, 11 May 2009) | 25 lines Recorded merge of revisions 193755 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r193755 | tilghman | 2009-05-11 17:48:20 -0500 (Mon, 11 May 2009) | 18 lines Move 300 bytes around on the stack, to make more room for an extension buffer. This allows more concurrent extensions to be copied for a single voicemail, without creating a possibility of upsetting existing users, where a dialplan could run out of stack space where it had run fine before. Alternatively, we could have allocated off the heap, but that is a larger change and would have increased the chance for instability introduced by this change. This is really solved starting in 1.6.0.11, as the use of an ast_str buffer allows an unlimited number of extensions (up to available memory). We additionally create a new warning message when the buffer length is exceeded, permitting administrators to see an issue after the fact, whereas previously the list was silently truncated. (closes issue #14739) Reported by: p_lindheimer Patches: 20090417__bug14739.diff.txt uploaded by tilghman (license 14) Tested by: p_lindheimer ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@193823 f38db490-d61c-443f-a65b-d21fe96a405b
2009-04-16Merged revisions 188774 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r188774 | tilghman | 2009-04-16 16:03:31 -0500 (Thu, 16 Apr 2009) | 11 lines Merged revisions 188773 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r188773 | tilghman | 2009-04-16 16:02:29 -0500 (Thu, 16 Apr 2009) | 4 lines Umask should not be exported into global namespace. (closes issue #14912) Reported by: jcapp ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@188777 f38db490-d61c-443f-a65b-d21fe96a405b
2009-04-03Merged revisions 186444,186447 via svnmerge from tilghman1-24/+102
https://origsvn.digium.com/svn/asterisk/trunk ................ r186444 | tilghman | 2009-04-03 14:30:34 -0500 (Fri, 03 Apr 2009) | 14 lines Merged revisions 186415 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r186415 | tilghman | 2009-04-03 14:06:58 -0500 (Fri, 03 Apr 2009) | 7 lines Distinguish in a sent email between simple sends and forwards. (closes issue #11678) Reported by: jamessan Patches: 20090330__bug11678.diff.txt uploaded by tilghman (license 14) Tested by: tilghman, lmadsen ........ ................ r186447 | tilghman | 2009-04-03 14:59:55 -0500 (Fri, 03 Apr 2009) | 9 lines Merged revisions 186445 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r186445 | tilghman | 2009-04-03 14:56:48 -0500 (Fri, 03 Apr 2009) | 2 lines Found a conflict in the last commit, due to multiple targets ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@186449 f38db490-d61c-443f-a65b-d21fe96a405b
2009-04-03Merged revisions 186286 via svnmerge from mmichelson1-16/+8
https://origsvn.digium.com/svn/asterisk/trunk ........ r186286 | mmichelson | 2009-04-03 09:32:05 -0500 (Fri, 03 Apr 2009) | 20 lines Fix the ability to retrieve voicemail messages from IMAP. A recent change made interactive vm_states no longer get added to the list of vm_states and instead get stored in thread-local storage. In trunk and all the 1.6.X branches, the problem is that when we search for messages in a voicemail box, we would attempt to update the appropriate vm_state struct by directly searching in the list of vm_states instead of using the get_vm_state_by_imap_user function. This meant we could not find the interactive vm_state that we wanted. (closes issue #14685) Reported by: BlargMaN Patches: 14685.patch uploaded by mmichelson (license 60) Tested by: BlargMaN, qualleyiv, mmichelson ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@186289 f38db490-d61c-443f-a65b-d21fe96a405b
2009-03-31Merged revisions 185469 via svnmerge from mmichelson1-6/+2
https://origsvn.digium.com/svn/asterisk/trunk ................ r185469 | mmichelson | 2009-03-31 14:46:18 -0500 (Tue, 31 Mar 2009) | 14 lines Merged revisions 185468 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r185468 | mmichelson | 2009-03-31 14:45:30 -0500 (Tue, 31 Mar 2009) | 8 lines Fix Russian voicemail intro to say the word "messages" properly. (closes issue #14736) Reported by: chappell Patches: voicemail_no_messages.diff uploaded by chappell (license 8) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@185472 f38db490-d61c-443f-a65b-d21fe96a405b
2009-03-27Merged revisions 184693 via svnmerge from russell1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r184693 | russell | 2009-03-27 11:21:10 -0500 (Fri, 27 Mar 2009) | 2 lines Change global_app_buf to ast_str_thread_global_buf. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@184707 f38db490-d61c-443f-a65b-d21fe96a405b
2009-03-25Merged revisions 184339 via svnmerge from russell1-4/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r184339 | russell | 2009-03-25 16:57:19 -0500 (Wed, 25 Mar 2009) | 35 lines Improve performance of the ast_event cache functionality. This code comes from svn/asterisk/team/russell/event_performance/. Here is a summary of the changes that have been made, in order of both invasiveness and performance impact, from smallest to largest. 1) Asterisk 1.6.1 introduces some additional logic to be able to handle distributed device state. This functionality comes at a cost. One relatively minor change in this patch is that the extra processing required for distributed device state is now completely bypassed if it's not needed. 2) One of the things that I noticed when profiling this code was that a _lot_ of time was spent doing string comparisons. I changed the way strings are represented in an event to include a hash value at the front. So, before doing a string comparison, we do an integer comparison on the hash. 3) Finally, the code that handles the event cache has been re-written. I tried to do this in a such a way that it had minimal impact on the API. I did have to change one API call, though - ast_event_queue_and_cache(). However, the way it works now is nicer, IMO. Each type of event that can be cached (MWI, device state) has its own hash table and rules for hashing and comparing objects. This by far made the biggest impact on performance. For additional details regarding this code and how it was tested, please see the review request. (closes issue #14738) Reported by: russell Review: http://reviewboard.digium.com/r/205/ ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@184343 f38db490-d61c-443f-a65b-d21fe96a405b
2009-03-06Merged revisions 180567 via svnmerge from mmichelson1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r180567 | mmichelson | 2009-03-06 12:23:09 -0600 (Fri, 06 Mar 2009) | 2 lines Make compilation succeed in dev-mode when IMAP storage is enabled. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@180579 f38db490-d61c-443f-a65b-d21fe96a405b
2009-03-05Merged revisions 180464 via svnmerge from mmichelson1-0/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r180464 | mmichelson | 2009-03-05 17:26:11 -0600 (Thu, 05 Mar 2009) | 16 lines [IMAP] Fix message retrieval issues when identical mailbox names were defined in separate contexts. There was a fix put in a while back so that an X-Asterisk-VM-Context message header was added to stored IMAP voicemails. This would allow for us to differentiate if the same mailbox name was used in multiple contexts. The problem still left was that not all places where messages were retrieved actually attempted to use this header for information when retrieving messages. This commit fixes that so that MWI and message retrieval from VoiceMailMain work as expected. (closes issue #13853) Reported by: vicks1 Patches: 13853_v2.patch uploaded by mmichelson (license 60) Tested by: lmadsen ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@180465 f38db490-d61c-443f-a65b-d21fe96a405b
2009-03-05Merged revisions 180380 via svnmerge from mmichelson1-7/+14
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r180380 | mmichelson | 2009-03-05 12:58:48 -0600 (Thu, 05 Mar 2009) | 25 lines Fix broken mailbox parsing when searchcontexts option is enabled. When using the searchcontexts option in voicemail.conf, the code made the assumption that all mailbox names defined were unique across all contexts. However, the code did nothing to actually enforce this assumption, nor did it do anything to alert a user that he may have created an ambiguity in his voicemail.conf file by defining the same mailbox name in multiple contexts. With this change, we now will issue a nice long warning if searchcontexts is on and we encounter the same mailbox name in multiple contexts and ignore any duplicates after the first box. Whether searchcontexts is enabled or not, if we come across a duplicate mailbox in the same context, then we will issue a warning and ignore the duplicated mailbox. I have also added a small note to voicemail.conf.sample in the explanation for searchcontexts explaining that you cannot define the same mailbox in multiple contexts if you have enabled the option. (closes issue #14599) Reported by: lmadsen Patches: 14599.patch uploaded by mmichelson (license 60) (with slight modification) Tested by: lmadsen ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@180383 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-23Permit emailsubject and emailbody to be set per mailbox.tilghman1-7/+26
(closes issue #14372) Reported by: fhackenberger Patches: voicemail_individual_subject_and_body_1.6.1 uploaded by fhackenberger (license 592) with additional fixes by Corydon76 (license 14) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@178107 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-20Oops, merge broke trunktilghman1-3/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@177661 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-19Merged revisions 177536 via svnmerge from tilghman1-2/+39
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r177536 | tilghman | 2009-02-19 16:26:01 -0600 (Thu, 19 Feb 2009) | 7 lines Fix up potential crashes, by reducing the sharing between interactive and non-interactive threads. (closes issue #14253) Reported by: Skavin Patches: 20090219__bug14253.diff.txt uploaded by Corydon76 (license 14) Tested by: Skavin ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@177537 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-13Merged revisions 175590 via svnmerge from mmichelson1-1/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r175590 | mmichelson | 2009-02-13 13:47:48 -0600 (Fri, 13 Feb 2009) | 16 lines Fix a potential crash situation when using IMAP voicemail If calling into VoiceMailMain when using IMAP storage, it was possible to crash Asterisk by hanging up the phone when prompted for a voicemail mailbox. This patch fixes the issue. While it may appear that this patch is superficial, it allows code execution to continue to the failure case just below the IMAP_STORAGE code block where this patch has been applied (closes issue #14473) Reported by: dwpaul Patches: voicemail_imap_crash_no_mailbox.patch uploaded by dwpaul (license 689) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@175591 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-10Fix0ring buildtilghman1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@174503 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-05Properly set "seen" and "unseen" flags when moving messages from the new to ↵mmichelson1-0/+3
the old folder when using IMAP for voicemail storage (closes issue #13905) Reported by: jaroth Patches: foldermove_v2.patch uploaded by jaroth (license 50) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@173773 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-05Merged revisions 173696 via svnmerge from jpeeler1-3/+12
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r173696 | jpeeler | 2009-02-05 14:47:51 -0600 (Thu, 05 Feb 2009) | 12 lines Add new configuration option to make shared IMAP mailboxes function as expected. The new option is "imapvmshareid" which is an ID to tag multiple mailboxes using the same IMAP storage location to function as one mailbox. This allows all messages to be retrieved for any user in the group. The patch alters the 'X-Asterisk-VM-Extension' header that is responsible for matching voicemails for a given user. (closes issue #13673) Reported by: howardwilkinson ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@173697 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-01Blank argument crashes Asterisktilghman1-0/+5
(closes issue #14377) Reported by: amorsen git-svn-id: http://svn.digium.com/svn/asterisk/trunk@172741 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-23Reset the ast_str used for escape substitution. We need to do this since it ↵file1-0/+2
is a thread local variable that may contain the value of a previous substitution. (closes issue #14312) Reported by: pj git-svn-id: http://svn.digium.com/svn/asterisk/trunk@170498 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-16Merged revisions 168828 via svnmerge from tilghman1-146/+98
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168828 | tilghman | 2009-01-16 12:41:35 -0600 (Fri, 16 Jan 2009) | 6 lines Fix the conjugation of Russian and Ukrainian languages. (related to issue #12475) Reported by: chappell Patches: vm_multilang.patch uploaded by chappell (license 8) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@168832 f38db490-d61c-443f-a65b-d21fe96a405b