aboutsummaryrefslogtreecommitdiffstats
path: root/apps/app_voicemail.c
AgeCommit message (Collapse)AuthorFilesLines
2009-10-19git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@224450 ↵tilghman1-84/+92
f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-30Merged revisions 221085 via svnmerge from seanbright1-1/+12
https://origsvn.digium.com/svn/asterisk/trunk ........ r221085 | seanbright | 2009-09-30 10:47:58 -0400 (Wed, 30 Sep 2009) | 9 lines Clarify documentation for VoiceMailMain()'s a() option. We require box numbers, not names as the documentation implies. (issue #14740) Reported by: pj Patches: __20090729-app_voicemail-documentation.patch uploaded by lmadsen (license 10) Tested by: seanbright, lmadsen ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@221088 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-29Merged revisions 220833 via svnmerge from jpeeler1-6/+8
https://origsvn.digium.com/svn/asterisk/trunk ........ r220833 | jpeeler | 2009-09-29 11:58:29 -0500 (Tue, 29 Sep 2009) | 12 lines Make deletion of temporary greetings work properly with IMAP_STORAGE When imapgreetings was set to yes, the message was being deleted but wasn't actually being expunged. When imapgreetings was set to no, the file based message was not being deleted at all. All good now! (closes issue #14949) Reported by: noahisaac Patches: vm_tempgreeting_removal.patch uploaded by noahisaac (license 748), modified by me ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@220835 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-22Merged revisions 219818 via svnmerge from tilghman1-0/+24
https://origsvn.digium.com/svn/asterisk/trunk ................ r219818 | tilghman | 2009-09-22 16:43:22 -0500 (Tue, 22 Sep 2009) | 17 lines Merged revisions 219816 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r219816 | tilghman | 2009-09-22 16:37:03 -0500 (Tue, 22 Sep 2009) | 10 lines When IMAP variables were changed during a reload, Voicemail did not use the new values. This change introduces a configuration version variable, which ensures that connections with the old values are not reused but are allowed to expire normally. (closes issue #15934) Reported by: viniciusfontes Patches: 20090922__issue15934.diff.txt uploaded by tilghman (license 14) Tested by: viniciusfontes ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@219820 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-18Merged revisions 219412 via svnmerge from tilghman1-0/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r219412 | tilghman | 2009-09-18 08:54:51 -0500 (Fri, 18 Sep 2009) | 6 lines Missing value setting line for maxsecs/maxmessage (closes issue #15696) Reported by: fhackenberger Patches: maxsecs.patch uploaded by fhackenberger (license 592) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@219414 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-15Merged revisions 218731 via svnmerge from tilghman1-9/+8
https://origsvn.digium.com/svn/asterisk/trunk ................ r218731 | tilghman | 2009-09-15 17:33:10 -0500 (Tue, 15 Sep 2009) | 13 lines Merged revisions 218730 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r218730 | tilghman | 2009-09-15 17:27:41 -0500 (Tue, 15 Sep 2009) | 6 lines If the user enters the same password as before, don't signal an error when the change does nothing. (closes issue #15492) Reported by: cbbs70a Patches: 20090713__issue15492.diff.txt uploaded by tilghman (license 14) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@218734 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-14Merged revisions 218361 via svnmerge from tilghman1-0/+13
https://origsvn.digium.com/svn/asterisk/trunk ................ r218361 | tilghman | 2009-09-14 14:29:48 -0500 (Mon, 14 Sep 2009) | 11 lines Recorded merge of revisions 218331 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r218331 | tilghman | 2009-09-14 14:16:35 -0500 (Mon, 14 Sep 2009) | 4 lines Don't say "Please try again" if we don't give the user another chance to try again. (issue #15055, SWP-129) Reported by: jthurman ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@218363 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-04Merged revisions 216593 via svnmerge from seanbright1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r216593 | seanbright | 2009-09-04 15:29:02 -0400 (Fri, 04 Sep 2009) | 1 line Use ast_free() instead of free(). ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@216596 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-24Merged revisions 213833 via svnmerge from jpeeler1-5/+8
https://origsvn.digium.com/svn/asterisk/trunk ........ r213833 | jpeeler | 2009-08-24 11:43:57 -0500 (Mon, 24 Aug 2009) | 14 lines Fix storage of greetings when using IMAP_STORAGE The store macro was not getting called preventing storage of IMAP greetings at all. This has been corrected along with fixing checking if the imapgreetings option is turned on to store the greeting in IMAP. Lastly, the attachment filename was incorrectly using the full path instead of just the basename, which was causing problems with retrieval of the greeting. (closes issue #14950) Reported by: noahisaac (closes issue #15729) Reported by: lmadsen ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@213835 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-21Merged revisions 213697 via svnmerge from kpfleming1-13/+18
https://origsvn.digium.com/svn/asterisk/trunk ........ r213697 | kpfleming | 2009-08-21 16:39:51 -0500 (Fri, 21 Aug 2009) | 12 lines Ensure that realtime mailboxes properly report status on subscription. This patch modifies app_voicemail's response to mailbox status subscriptions (via the internal event system) to ensure that a subscription triggers an explicit poll of the mailbox, so the subscriber can get an immediate cached event with that status. Previously, the cache was only populated with the status of non-realtime mailboxes. (closes issue #15717) Reported by: natmlt ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@213699 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-20Merged revisions 213404 via svnmerge from jpeeler1-4/+15
https://origsvn.digium.com/svn/asterisk/trunk ........ r213404 | jpeeler | 2009-08-20 16:33:11 -0500 (Thu, 20 Aug 2009) | 12 lines Fix greeting retrieval from IMAP Properly check for the current voicemail state and if it doesn't exist, create it. (closes issue #14597) Reported by: wtca Patches: 14597_v2.patch uploaded by mmichelson (license 60) Tested by: jpeeler ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@213412 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-17Merged revisions 212627 via svnmerge from tilghman1-1/+4
https://origsvn.digium.com/svn/asterisk/trunk ........ r212627 | tilghman | 2009-08-17 14:57:42 -0500 (Mon, 17 Aug 2009) | 4 lines Check the return value of opendir(3), or we may crash. (closes issue #15720) Reported by: tobias_e ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@212630 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-10AST-2009-005tilghman1-23/+23
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@211569 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-18Recorded merge of revisions 207317 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r207317 | tilghman | 2009-07-17 23:16:44 -0500 (Fri, 17 Jul 2009) | 3 lines Flag field in wrong position. Reported by "Hoggins!" on asterisk-dev list. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@207321 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-13Merged revisions 206185 via svnmerge from tilghman1-4/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r206185 | tilghman | 2009-07-13 11:23:07 -0500 (Mon, 13 Jul 2009) | 2 lines Remove reference to non-existent help file ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@206186 f38db490-d61c-443f-a65b-d21fe96a405b
2009-06-30Recorded merge of revisions 204470 via svnmerge from tilghman1-10/+10
https://origsvn.digium.com/svn/asterisk/trunk ................ r204470 | tilghman | 2009-06-30 13:36:24 -0500 (Tue, 30 Jun 2009) | 18 lines Recorded merge of revisions 204469 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r204469 | tilghman | 2009-06-30 13:23:35 -0500 (Tue, 30 Jun 2009) | 11 lines "tw" is the language specification for Twi (from Ghana) not Taiwanese. (closes issue #15346) Reported by: volivier Patches: 20090617__issue15346__1.4.diff.txt uploaded by tilghman (license 14) 20090617__issue15346__trunk.diff.txt uploaded by tilghman (license 14) 20090617__issue15346__1.6.0.diff.txt uploaded by tilghman (license 14) 20090617__issue15346__1.6.1.diff.txt uploaded by tilghman (license 14) 20090617__issue15346__1.6.2.diff.txt uploaded by tilghman (license 14) Tested by: volivier ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@204472 f38db490-d61c-443f-a65b-d21fe96a405b
2009-06-26Merged revisions 203721 via svnmerge from dbrooks1-2/+4
https://origsvn.digium.com/svn/asterisk/trunk ........ r203721 | dbrooks | 2009-06-26 15:13:51 -0500 (Fri, 26 Jun 2009) | 16 lines Fixing voicemail's error in checking max silence vs min message length Max silence was represented in milliseconds, yet vmminsecs (minmessage) was represented as seconds. Also, the inequality was reversed. The warning, if triggered, was "Max silence should be less than minmessage or you may get empty messages", which should have been logged if max silence was greater than minmessage, but the check was for less than. Also, conforming if statement to coding guidelines. closes issue #15331) Reported by: markd Review: https://reviewboard.asterisk.org/r/293/ ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@203727 f38db490-d61c-443f-a65b-d21fe96a405b
2009-06-17Merged revisions 201531 via svnmerge from tilghman1-1/+2
https://origsvn.digium.com/svn/asterisk/trunk ........ r201531 | tilghman | 2009-06-17 16:31:39 -0500 (Wed, 17 Jun 2009) | 7 lines Initialize additional variables, to prevent a possible crash. (closes issue #15186) Reported by: ajohnson Patches: 20090528__issue15186.diff.txt uploaded by tilghman (license 14) Tested by: ajohnson ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@201532 f38db490-d61c-443f-a65b-d21fe96a405b
2009-06-16Merged revisions 200943 via svnmerge from mvanbaak1-0/+7
https://origsvn.digium.com/svn/asterisk/trunk ........ r200943 | mvanbaak | 2009-06-16 17:51:36 +0200 (Tue, 16 Jun 2009) | 9 lines add FILE_STORAGE to Voicemail Build Options Voicemail can only use one storage module at the moment. Because it's unclear that selecting one of the storage modules in menuselect will disable filesystem storage we now have a FILE_STORAGE option that conflicts with the other modules. (closes issue #15333) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@200947 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-19Merged revisions 195521 via svnmerge from tilghman1-0/+3
https://origsvn.digium.com/svn/asterisk/trunk ................ r195521 | tilghman | 2009-05-19 15:16:01 -0500 (Tue, 19 May 2009) | 14 lines Merged revisions 195520 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r195520 | tilghman | 2009-05-19 15:12:20 -0500 (Tue, 19 May 2009) | 7 lines Ensure thread keys are initialized before attempting to access them. (closes issue #14889) Reported by: jaroth Patches: app_voicemail.c.patch uploaded by msirota (license 758) Tested by: msirota, BlargMaN ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@195526 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-18Recorded merge of revisions 195370 via svnmerge from tilghman1-2/+2
https://origsvn.digium.com/svn/asterisk/trunk ................ r195370 | tilghman | 2009-05-18 15:52:33 -0500 (Mon, 18 May 2009) | 15 lines Recorded merge of revisions 195366 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r195366 | tilghman | 2009-05-18 15:24:13 -0500 (Mon, 18 May 2009) | 8 lines Add a similar dependency on SMDI for voicemail as already exists for ADSI. (closes issue #14846) Reported by: pj Patches: 20090413__bug14846__1.4.diff.txt uploaded by tilghman (license 14) 20090507__issue14846__1.6.0.diff.txt uploaded by tilghman (license 14) 20090507__issue14846__1.6.1.diff.txt uploaded by tilghman (license 14) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@195372 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-12Merged revisions 193956 via svnmerge from tilghman1-4/+7
https://origsvn.digium.com/svn/asterisk/trunk ................ r193956 | tilghman | 2009-05-12 15:40:22 -0500 (Tue, 12 May 2009) | 13 lines Merged revisions 193955 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r193955 | tilghman | 2009-05-12 15:39:21 -0500 (Tue, 12 May 2009) | 6 lines Avoid initializing routines if the authentication fails. Fixes a crash (RR) issue. (closes issue #14508) Reported by: tiziano Patches: 20090221_2_wrongmailbox.diff.txt uploaded by tiziano (license 377) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@193958 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-12Merged revisions 193870 via svnmerge from tilghman1-4/+14
https://origsvn.digium.com/svn/asterisk/trunk ........ r193870 | tilghman | 2009-05-12 12:29:33 -0500 (Tue, 12 May 2009) | 2 lines Convert a THREADSTORAGE object into a simple malloc'd object (as suggested by Russell on -dev) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@193872 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-11Recorded merge of revisions 193756 via svnmerge from tilghman1-4/+6
https://origsvn.digium.com/svn/asterisk/trunk ................ r193756 | tilghman | 2009-05-11 17:50:47 -0500 (Mon, 11 May 2009) | 25 lines Recorded merge of revisions 193755 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r193755 | tilghman | 2009-05-11 17:48:20 -0500 (Mon, 11 May 2009) | 18 lines Move 300 bytes around on the stack, to make more room for an extension buffer. This allows more concurrent extensions to be copied for a single voicemail, without creating a possibility of upsetting existing users, where a dialplan could run out of stack space where it had run fine before. Alternatively, we could have allocated off the heap, but that is a larger change and would have increased the chance for instability introduced by this change. This is really solved starting in 1.6.0.11, as the use of an ast_str buffer allows an unlimited number of extensions (up to available memory). We additionally create a new warning message when the buffer length is exceeded, permitting administrators to see an issue after the fact, whereas previously the list was silently truncated. (closes issue #14739) Reported by: p_lindheimer Patches: 20090417__bug14739.diff.txt uploaded by tilghman (license 14) Tested by: p_lindheimer ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@193822 f38db490-d61c-443f-a65b-d21fe96a405b
2009-04-16Merged revisions 188774 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r188774 | tilghman | 2009-04-16 16:03:31 -0500 (Thu, 16 Apr 2009) | 11 lines Merged revisions 188773 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r188773 | tilghman | 2009-04-16 16:02:29 -0500 (Thu, 16 Apr 2009) | 4 lines Umask should not be exported into global namespace. (closes issue #14912) Reported by: jcapp ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@188776 f38db490-d61c-443f-a65b-d21fe96a405b
2009-04-03Merged revisions 186444,186447 via svnmerge from tilghman1-24/+102
https://origsvn.digium.com/svn/asterisk/trunk ................ r186444 | tilghman | 2009-04-03 14:30:34 -0500 (Fri, 03 Apr 2009) | 14 lines Merged revisions 186415 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r186415 | tilghman | 2009-04-03 14:06:58 -0500 (Fri, 03 Apr 2009) | 7 lines Distinguish in a sent email between simple sends and forwards. (closes issue #11678) Reported by: jamessan Patches: 20090330__bug11678.diff.txt uploaded by tilghman (license 14) Tested by: tilghman, lmadsen ........ ................ r186447 | tilghman | 2009-04-03 14:59:55 -0500 (Fri, 03 Apr 2009) | 9 lines Merged revisions 186445 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r186445 | tilghman | 2009-04-03 14:56:48 -0500 (Fri, 03 Apr 2009) | 2 lines Found a conflict in the last commit, due to multiple targets ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@186448 f38db490-d61c-443f-a65b-d21fe96a405b
2009-04-03Merged revisions 186286 via svnmerge from mmichelson1-16/+8
https://origsvn.digium.com/svn/asterisk/trunk ........ r186286 | mmichelson | 2009-04-03 09:32:05 -0500 (Fri, 03 Apr 2009) | 20 lines Fix the ability to retrieve voicemail messages from IMAP. A recent change made interactive vm_states no longer get added to the list of vm_states and instead get stored in thread-local storage. In trunk and all the 1.6.X branches, the problem is that when we search for messages in a voicemail box, we would attempt to update the appropriate vm_state struct by directly searching in the list of vm_states instead of using the get_vm_state_by_imap_user function. This meant we could not find the interactive vm_state that we wanted. (closes issue #14685) Reported by: BlargMaN Patches: 14685.patch uploaded by mmichelson (license 60) Tested by: BlargMaN, qualleyiv, mmichelson ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@186288 f38db490-d61c-443f-a65b-d21fe96a405b
2009-03-31Merged revisions 185469 via svnmerge from mmichelson1-6/+2
https://origsvn.digium.com/svn/asterisk/trunk ................ r185469 | mmichelson | 2009-03-31 14:46:18 -0500 (Tue, 31 Mar 2009) | 14 lines Merged revisions 185468 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r185468 | mmichelson | 2009-03-31 14:45:30 -0500 (Tue, 31 Mar 2009) | 8 lines Fix Russian voicemail intro to say the word "messages" properly. (closes issue #14736) Reported by: chappell Patches: voicemail_no_messages.diff uploaded by chappell (license 8) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@185471 f38db490-d61c-443f-a65b-d21fe96a405b
2009-03-25Merged revisions 184339 via svnmerge from russell1-4/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r184339 | russell | 2009-03-25 16:57:19 -0500 (Wed, 25 Mar 2009) | 35 lines Improve performance of the ast_event cache functionality. This code comes from svn/asterisk/team/russell/event_performance/. Here is a summary of the changes that have been made, in order of both invasiveness and performance impact, from smallest to largest. 1) Asterisk 1.6.1 introduces some additional logic to be able to handle distributed device state. This functionality comes at a cost. One relatively minor change in this patch is that the extra processing required for distributed device state is now completely bypassed if it's not needed. 2) One of the things that I noticed when profiling this code was that a _lot_ of time was spent doing string comparisons. I changed the way strings are represented in an event to include a hash value at the front. So, before doing a string comparison, we do an integer comparison on the hash. 3) Finally, the code that handles the event cache has been re-written. I tried to do this in a such a way that it had minimal impact on the API. I did have to change one API call, though - ast_event_queue_and_cache(). However, the way it works now is nicer, IMO. Each type of event that can be cached (MWI, device state) has its own hash table and rules for hashing and comparing objects. This by far made the biggest impact on performance. For additional details regarding this code and how it was tested, please see the review request. (closes issue #14738) Reported by: russell Review: http://reviewboard.digium.com/r/205/ ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@184342 f38db490-d61c-443f-a65b-d21fe96a405b
2009-03-06Merged revisions 180579 via svnmerge from mmichelson1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r180579 | mmichelson | 2009-03-06 12:25:44 -0600 (Fri, 06 Mar 2009) | 9 lines Merged revisions 180567 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r180567 | mmichelson | 2009-03-06 12:23:09 -0600 (Fri, 06 Mar 2009) | 2 lines Make compilation succeed in dev-mode when IMAP storage is enabled. ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@180585 f38db490-d61c-443f-a65b-d21fe96a405b
2009-03-05Merged revisions 180465 via svnmerge from mmichelson1-0/+2
https://origsvn.digium.com/svn/asterisk/trunk ................ r180465 | mmichelson | 2009-03-05 17:26:58 -0600 (Thu, 05 Mar 2009) | 22 lines Merged revisions 180464 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r180464 | mmichelson | 2009-03-05 17:26:11 -0600 (Thu, 05 Mar 2009) | 16 lines [IMAP] Fix message retrieval issues when identical mailbox names were defined in separate contexts. There was a fix put in a while back so that an X-Asterisk-VM-Context message header was added to stored IMAP voicemails. This would allow for us to differentiate if the same mailbox name was used in multiple contexts. The problem still left was that not all places where messages were retrieved actually attempted to use this header for information when retrieving messages. This commit fixes that so that MWI and message retrieval from VoiceMailMain work as expected. (closes issue #13853) Reported by: vicks1 Patches: 13853_v2.patch uploaded by mmichelson (license 60) Tested by: lmadsen ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@180467 f38db490-d61c-443f-a65b-d21fe96a405b
2009-03-05Merged revisions 180383 via svnmerge from mmichelson1-7/+14
https://origsvn.digium.com/svn/asterisk/trunk ................ r180383 | mmichelson | 2009-03-05 13:14:14 -0600 (Thu, 05 Mar 2009) | 31 lines Merged revisions 180380 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r180380 | mmichelson | 2009-03-05 12:58:48 -0600 (Thu, 05 Mar 2009) | 25 lines Fix broken mailbox parsing when searchcontexts option is enabled. When using the searchcontexts option in voicemail.conf, the code made the assumption that all mailbox names defined were unique across all contexts. However, the code did nothing to actually enforce this assumption, nor did it do anything to alert a user that he may have created an ambiguity in his voicemail.conf file by defining the same mailbox name in multiple contexts. With this change, we now will issue a nice long warning if searchcontexts is on and we encounter the same mailbox name in multiple contexts and ignore any duplicates after the first box. Whether searchcontexts is enabled or not, if we come across a duplicate mailbox in the same context, then we will issue a warning and ignore the duplicated mailbox. I have also added a small note to voicemail.conf.sample in the explanation for searchcontexts explaining that you cannot define the same mailbox in multiple contexts if you have enabled the option. (closes issue #14599) Reported by: lmadsen Patches: 14599.patch uploaded by mmichelson (license 60) (with slight modification) Tested by: lmadsen ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@180425 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-20Merged revisions 177661 via svnmerge from tilghman1-3/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r177661 | tilghman | 2009-02-20 11:22:19 -0600 (Fri, 20 Feb 2009) | 2 lines Oops, merge broke trunk ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@177663 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-19Merged revisions 177537 via svnmerge from tilghman1-2/+37
https://origsvn.digium.com/svn/asterisk/trunk ................ r177537 | tilghman | 2009-02-19 16:33:00 -0600 (Thu, 19 Feb 2009) | 14 lines Merged revisions 177536 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r177536 | tilghman | 2009-02-19 16:26:01 -0600 (Thu, 19 Feb 2009) | 7 lines Fix up potential crashes, by reducing the sharing between interactive and non-interactive threads. (closes issue #14253) Reported by: Skavin Patches: 20090219__bug14253.diff.txt uploaded by Corydon76 (license 14) Tested by: Skavin ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@177539 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-13Merged revisions 175591 via svnmerge from mmichelson1-1/+2
https://origsvn.digium.com/svn/asterisk/trunk ................ r175591 | mmichelson | 2009-02-13 13:49:38 -0600 (Fri, 13 Feb 2009) | 22 lines Merged revisions 175590 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r175590 | mmichelson | 2009-02-13 13:47:48 -0600 (Fri, 13 Feb 2009) | 16 lines Fix a potential crash situation when using IMAP voicemail If calling into VoiceMailMain when using IMAP storage, it was possible to crash Asterisk by hanging up the phone when prompted for a voicemail mailbox. This patch fixes the issue. While it may appear that this patch is superficial, it allows code execution to continue to the failure case just below the IMAP_STORAGE code block where this patch has been applied (closes issue #14473) Reported by: dwpaul Patches: voicemail_imap_crash_no_mailbox.patch uploaded by dwpaul (license 689) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@175593 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-10Merged revisions 174503 via svnmerge from tilghman1-2/+2
https://origsvn.digium.com/svn/asterisk/trunk ........ r174503 | tilghman | 2009-02-10 01:06:29 -0600 (Tue, 10 Feb 2009) | 2 lines Fix0ring build ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@174504 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-05Merged revisions 173773 via svnmerge from mmichelson1-0/+3
https://origsvn.digium.com/svn/asterisk/trunk ........ r173773 | mmichelson | 2009-02-05 17:28:19 -0600 (Thu, 05 Feb 2009) | 7 lines Properly set "seen" and "unseen" flags when moving messages from the new to the old folder when using IMAP for voicemail storage (closes issue #13905) Reported by: jaroth Patches: foldermove_v2.patch uploaded by jaroth (license 50) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@173775 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-05Merged revisions 173697 via svnmerge from jpeeler1-3/+12
https://origsvn.digium.com/svn/asterisk/trunk ................ r173697 | jpeeler | 2009-02-05 15:00:26 -0600 (Thu, 05 Feb 2009) | 18 lines Merged revisions 173696 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r173696 | jpeeler | 2009-02-05 14:47:51 -0600 (Thu, 05 Feb 2009) | 12 lines Add new configuration option to make shared IMAP mailboxes function as expected. The new option is "imapvmshareid" which is an ID to tag multiple mailboxes using the same IMAP storage location to function as one mailbox. This allows all messages to be retrieved for any user in the group. The patch alters the 'X-Asterisk-VM-Extension' header that is responsible for matching voicemails for a given user. (closes issue #13673) Reported by: howardwilkinson ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@173699 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-01Merged revisions 172741 via svnmerge from tilghman1-0/+5
https://origsvn.digium.com/svn/asterisk/trunk ........ r172741 | tilghman | 2009-01-31 20:44:23 -0600 (Sat, 31 Jan 2009) | 4 lines Blank argument crashes Asterisk (closes issue #14377) Reported by: amorsen ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@172743 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-16Merged revisions 168832 via svnmerge from tilghman1-146/+98
https://origsvn.digium.com/svn/asterisk/trunk ................ r168832 | tilghman | 2009-01-16 12:49:09 -0600 (Fri, 16 Jan 2009) | 13 lines Merged revisions 168828 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168828 | tilghman | 2009-01-16 12:41:35 -0600 (Fri, 16 Jan 2009) | 6 lines Fix the conjugation of Russian and Ukrainian languages. (related to issue #12475) Reported by: chappell Patches: vm_multilang.patch uploaded by chappell (license 8) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168836 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-18Merged revisions 165797 via svnmerge from tilghman1-10/+52
https://origsvn.digium.com/svn/asterisk/trunk ................ r165797 | tilghman | 2008-12-18 15:41:02 -0600 (Thu, 18 Dec 2008) | 15 lines Merged revisions 165767 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r165767 | tilghman | 2008-12-18 15:14:47 -0600 (Thu, 18 Dec 2008) | 8 lines Add mutexes around accesses to the IMAP library interface. This prevents certain crashes, especially when shared mailboxes are used. (closes issue #13653) Reported by: howardwilkinson Patches: asterisk-1.4.21.2-appvoicemail-sharedimap-lock.patch uploaded by howardwilkinson (license 590) Tested by: jpeeler ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@165808 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-18Merged revisions 165658 via svnmerge from tilghman1-5/+10
https://origsvn.digium.com/svn/asterisk/trunk ........ r165658 | tilghman | 2008-12-18 12:36:48 -0600 (Thu, 18 Dec 2008) | 2 lines Fix 2 resource leaks and fix another pipe-to-comma conversion ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@165660 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-17Merged revisions 165318 via svnmerge from mmichelson1-0/+2
https://origsvn.digium.com/svn/asterisk/trunk ................ r165318 | mmichelson | 2008-12-17 15:17:20 -0600 (Wed, 17 Dec 2008) | 15 lines Merged revisions 165255 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r165255 | mmichelson | 2008-12-17 14:51:38 -0600 (Wed, 17 Dec 2008) | 7 lines Fix some memory leaks found while looking at how realtime configs are handled. Also cleaned up some coding guidelines violations in app_realtime.c, mostly related to spacing ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@165324 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-17Merged revisions 165142-165143 via svnmerge from mmichelson1-18/+7
https://origsvn.digium.com/svn/asterisk/trunk ........ r165142 | mmichelson | 2008-12-17 11:52:50 -0600 (Wed, 17 Dec 2008) | 10 lines Use the create_vm_state_from_user function in a place where it was not being used before. Also, I've moved the urgent folder check in messagecount() up a bit so that the flow is a bit better. This was something I noticed while taking a look at issue #13973, although I don't think this is the underlying cause of the issue. ........ r165143 | mmichelson | 2008-12-17 11:53:37 -0600 (Wed, 17 Dec 2008) | 3 lines And actually assign the function to a pointer... ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@165146 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-11Merged revisions 163213 via svnmerge from mmichelson1-1/+10
https://origsvn.digium.com/svn/asterisk/trunk ........ r163213 | mmichelson | 2008-12-11 14:57:44 -0600 (Thu, 11 Dec 2008) | 9 lines Add an option to voicemail.conf to allow urgent messages to be forwarded as not urgent. (closes issue #14063) Reported by: jaroth Patches: urgfwd_v2.patch uploaded by jaroth (license 50) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@163214 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-09Merged revisions 162466 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r162466 | tilghman | 2008-12-09 17:10:34 -0600 (Tue, 09 Dec 2008) | 9 lines Merged revisions 162463 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r162463 | tilghman | 2008-12-09 17:08:53 -0600 (Tue, 09 Dec 2008) | 2 lines Oops, should be "tz", not "zonetag". ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@162472 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-09Merged revisions 162355 via svnmerge from tilghman1-0/+5
https://origsvn.digium.com/svn/asterisk/trunk ................ r162355 | tilghman | 2008-12-09 15:57:09 -0600 (Tue, 09 Dec 2008) | 11 lines Merged revisions 162348 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r162348 | tilghman | 2008-12-09 15:53:25 -0600 (Tue, 09 Dec 2008) | 4 lines We appear to have documented tz= in the [general] section of voicemail.conf, without actually having implemented it. Oops. (Reported by Olivier on the -users list) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@162372 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-05Merged revisions 161349-161350 via svnmerge from seanbright1-50/+51
https://origsvn.digium.com/svn/asterisk/trunk ........ r161349 | seanbright | 2008-12-05 10:56:15 -0500 (Fri, 05 Dec 2008) | 5 lines When using IMAP_STORAGE, it's important to convert bare newlines (\n) in emailbody and pagerbody to CR-LF so that the IMAP server doesn't spit out an error. This was informally reported on #asterisk-dev a few weeks ago. Reviewed by Mark M. on IRC. ........ r161350 | seanbright | 2008-12-05 11:04:36 -0500 (Fri, 05 Dec 2008) | 2 lines Use ast_free() instead of free(), pointed out by eliel on IRC. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@161352 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-05Merged revisions 161147 via svnmerge from seanbright1-2/+11
https://origsvn.digium.com/svn/asterisk/trunk ........ r161147 | seanbright | 2008-12-04 21:47:54 -0500 (Thu, 04 Dec 2008) | 3 lines Check the return value of fread/fwrite so the compiler doesn't complain. Only a problem when IMAP_STORAGE is enabled. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@161149 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-03Merged revisions 160791 via svnmerge from tilghman1-6/+6
https://origsvn.digium.com/svn/asterisk/trunk ................ r160791 | tilghman | 2008-12-03 15:58:21 -0600 (Wed, 03 Dec 2008) | 9 lines Merged revisions 160770 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r160770 | tilghman | 2008-12-03 15:54:07 -0600 (Wed, 03 Dec 2008) | 2 lines Some compilers warn on null format strings; some don't (caught by buildbot) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@160811 f38db490-d61c-443f-a65b-d21fe96a405b