aboutsummaryrefslogtreecommitdiffstats
path: root/apps/app_voicemail.c
AgeCommit message (Collapse)AuthorFilesLines
2010-11-12Return correct error code if lock path fails. The recent changes to ↵jpeeler1-1/+1
open_mailbox actually caused it to be fixed, but let's be consistent. Reported by alecdavis in asterisk-dev. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@294910 f38db490-d61c-443f-a65b-d21fe96a405b
2010-11-12Merged revisions 294903 via svnmerge from jpeeler1-1/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r294903 | jpeeler | 2010-11-12 14:49:09 -0600 (Fri, 12 Nov 2010) | 16 lines Fix regression causing abort in voicemail after opening a mailbox with no mesgs. In order to be more safe, some error handling code was changed to respect more error conditions including the potential memory allocation failure for deleted and heard message tracking introduced in 293004. However, last_message_index returns -1 for zero messages (perhaps as expected) and was triggering the stricter error checking. Because last_message_index is only called directly in one place, just return 0 from open_mailbox (for file based storage) when no messages are detected unless a real error has occurred. (closes issue #18240) Reported by: leobrown Patches: bug18240.1-6-2.diff.txt uploaded by alecdavis (license 585) Tested by: pabelanger ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@294904 f38db490-d61c-443f-a65b-d21fe96a405b
2010-10-26Merged revisions 293004 via svnmerge from jpeeler1-21/+91
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r293004 | jpeeler | 2010-10-25 17:55:28 -0500 (Mon, 25 Oct 2010) | 29 lines Fix inprocess_container in voicemail to correctly restrict max messages. The comparison function logic was off, so the number of sessions for a given mailbox were not being incremented properly. This problem caused the maximum number of messages per folder to not be respected when simultaneously leaving multiple voicemails just below the threshold. These problems should be fixed by the above, but just in case: Fixed resequence_mailbox to rely on the actual number of detected number of files in a directory rather than just assuming only 10 messages more than the maximum had been left. Also if more messages than the maximum are deleted they are actually removed now. The second purpose of this commit should have been separated out probably, but is related to the above. Again, if the number of messages in a given voicemail folder exceeds the maximum set limit make sure to allocate enough space for the deleted and heard index tracking array. A few random fixes: There was a forgotten decrement of the inprocess count in imap_store_file. When using IMAP storage, do not look in the directory where file based storage messages may still reside and influence the message count. Ensure to use only the first format in sendmail. ABE-2516 ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@293118 f38db490-d61c-443f-a65b-d21fe96a405b
2010-10-18Merged revisions 292223 via svnmerge from jpeeler1-2/+12
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r292223 | jpeeler | 2010-10-18 16:50:30 -0500 (Mon, 18 Oct 2010) | 11 lines Fix improper operator key acceptance and clean up temp recording files. This is a fix for when pressing the operator key after recording an unavailable, busy, name, or temporary message in mailbox options. The operator key should not be accepted here, but should be allowed during the message recording. If the operator key is pressed during ensure the file is saved or deleted as apporopriate. Also, ensure removal of temporary recorded files after an early hang up or when message acceptance confirmation times out. ABE-2518 ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@292226 f38db490-d61c-443f-a65b-d21fe96a405b
2010-10-02Merged revisions 289873 via svnmerge from tilghman1-12/+6
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r289873 | tilghman | 2010-10-01 23:42:08 -0500 (Fri, 01 Oct 2010) | 8 lines When forwarding a message, a prepend means that the filesystem will always have a better copy. (closes issue #17803) Reported by: dpetersen Patches: 20100923__issue17803.diff.txt uploaded by tilghman (license 14) Tested by: dpetersen ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@289874 f38db490-d61c-443f-a65b-d21fe96a405b
2010-09-15Merged revisions 286941 via svnmerge from jpeeler1-5/+29
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r286941 | jpeeler | 2010-09-15 15:08:52 -0500 (Wed, 15 Sep 2010) | 7 lines Ensure mailbox is not filled to capacity before doing message forwarding. Specifically, before prompting to record a prepended message the capacity is checked first. If the mailbox is full the extension will be reprompted. ABE-2517 ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@286998 f38db490-d61c-443f-a65b-d21fe96a405b
2010-09-09Fixes an issue with dialplan pattern matching where the specificity for ↵bbryant1-4/+5
pattern ranges and pattern special characters was inconsistent. (closes issue #16903) Reported by: Nick_Lewis Patches: pbx.c-specificity.patch uploaded by Nick Lewis (license 657) Tested by: Nick_Lewis git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@285710 f38db490-d61c-443f-a65b-d21fe96a405b
2010-08-02Allow the pipe, but also allow the commatilghman1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@280671 f38db490-d61c-443f-a65b-d21fe96a405b
2010-07-20Merged revisions 278275 via svnmerge from tilghman1-41/+49
https://origsvn.digium.com/svn/asterisk/trunk ................ r278275 | tilghman | 2010-07-20 17:40:19 -0500 (Tue, 20 Jul 2010) | 14 lines Merged revisions 278261 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r278261 | tilghman | 2010-07-20 17:23:13 -0500 (Tue, 20 Jul 2010) | 7 lines Delete IMAP messages in reverse order, to ensure reordering after each expunge does not cause deletion of the wrong message. (closes issue #16350) Reported by: noahisaac Patches: 20100623__issue16350.diff.txt uploaded by tilghman (license 14) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@278276 f38db490-d61c-443f-a65b-d21fe96a405b
2010-07-02Fix typos reported by Lintiantzafrir1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@273642 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-17Merged revisions 263589 via svnmerge from tilghman1-24/+26
https://origsvn.digium.com/svn/asterisk/trunk ........ r263589 | tilghman | 2010-05-17 14:31:15 -0500 (Mon, 17 May 2010) | 9 lines With IMAP backend, messages in INBOX were counted twice for MWI. (closes issue #17135) Reported by: edhorton Patches: 20100513__issue17135.diff.txt uploaded by tilghman (license 14) 17135_2.diff uploaded by ebroad (license 878) Tested by: edhorton, ebroad ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@263590 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-11Merged revisions 262330 via svnmerge from tilghman1-0/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r262330 | tilghman | 2010-05-11 12:23:51 -0500 (Tue, 11 May 2010) | 9 lines Merged revisions 262321 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r262321 | tilghman | 2010-05-11 12:22:07 -0500 (Tue, 11 May 2010) | 2 lines Fix issue #17302 a slightly different way (mad props to Qwell) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@262340 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-06Merged revisions 261736 via svnmerge from jpeeler1-1/+4
https://origsvn.digium.com/svn/asterisk/trunk ................ r261736 | jpeeler | 2010-05-06 15:11:53 -0500 (Thu, 06 May 2010) | 15 lines Merged revisions 261735 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r261735 | jpeeler | 2010-05-06 15:10:59 -0500 (Thu, 06 May 2010) | 8 lines Only allow the operator key to be accepted after leaving a voicemail. Or rather disallow the operator key from being accepted when not offered, such as after finishing a recording from within the mailbox options menu. ABE-2121 SWP-1267 ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@261739 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-04Merged revisions 260924 via svnmerge from jpeeler1-7/+8
https://origsvn.digium.com/svn/asterisk/trunk ................ r260924 | jpeeler | 2010-05-04 13:51:28 -0500 (Tue, 04 May 2010) | 18 lines Merged revisions 260923 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r260923 | jpeeler | 2010-05-04 13:46:46 -0500 (Tue, 04 May 2010) | 12 lines Voicemail transfer to operator should occur immediately, not after main menu. There were two scenarios in the advanced options that while using the operator=yes and review=yes options, the transfer occurred only after exiting the main menu (after sending a reply or leaving a message for an extension). Now after the audio is processed for the reply or message the transfer occurs immediately as expected. ABE-2107 ABE-2108 ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@260927 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-28Merged revisions 259672 via svnmerge from jpeeler1-2/+2
https://origsvn.digium.com/svn/asterisk/trunk ................ r259672 | jpeeler | 2010-04-28 12:18:43 -0500 (Wed, 28 Apr 2010) | 11 lines Merged revisions 259664 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r259664 | jpeeler | 2010-04-28 12:13:29 -0500 (Wed, 28 Apr 2010) | 4 lines Do not play goodbye prompt after timeout of message review. ABE-2124 ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@259681 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-21Merged revisions 258433 via svnmerge from jpeeler1-2/+10
https://origsvn.digium.com/svn/asterisk/trunk ................ r258433 | jpeeler | 2010-04-21 16:56:09 -0500 (Wed, 21 Apr 2010) | 15 lines Merged revisions 258432 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r258432 | jpeeler | 2010-04-21 16:45:36 -0500 (Wed, 21 Apr 2010) | 8 lines Fix looping forever when no input received in certain voicemail menu scenarios. Specifically, prompting for an extension (when leaving or forwarding a message) or when prompting for a digit (when saving a message or changing folders). ABE-2122 SWP-1268 ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@258436 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-20Merged revisions 258065 via svnmerge from jpeeler1-20/+39
https://origsvn.digium.com/svn/asterisk/trunk ................ r258065 | jpeeler | 2010-04-20 12:06:19 -0500 (Tue, 20 Apr 2010) | 17 lines Merged revisions 258029 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r258029 | jpeeler | 2010-04-20 11:16:33 -0500 (Tue, 20 Apr 2010) | 11 lines Play correct prompt when voicemail store failure occurs after attempted forward. If a user's mailbox was full and a message was attempted to be forwarded to said box, warnings on the console would indicate failure. However, the played prompt was that of success (vm-msgsaved). Now storage failure is taken into account and the correct prompt (vm-mailboxfull) is played when appropriate. ABE-2123 SWP-1262 ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@258108 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-12Merged revisions 256860 via svnmerge from lmadsen1-1/+0
https://origsvn.digium.com/svn/asterisk/trunk ........ r256860 | lmadsen | 2010-04-12 11:16:43 -0500 (Mon, 12 Apr 2010) | 3 lines Remove silly debug message that is not useful. (issue #17159) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@256862 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-31Recorded merge of revisions 255592 via svnmerge from tilghman1-11/+28
https://origsvn.digium.com/svn/asterisk/trunk ................ r255592 | tilghman | 2010-03-31 14:13:02 -0500 (Wed, 31 Mar 2010) | 22 lines Recorded merge of revisions 255591 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r255591 | tilghman | 2010-03-31 14:09:46 -0500 (Wed, 31 Mar 2010) | 15 lines Ensure line terminators in email are consistent. Fixes an issue with certain Mail Transport Agents, where attachments are not interpreted correctly. (closes issue #16557) Reported by: jcovert Patches: 20100308__issue16557__1.4.diff.txt uploaded by tilghman (license 14) 20100308__issue16557__1.6.0.diff.txt uploaded by tilghman (license 14) 20100308__issue16557__trunk.diff.txt uploaded by tilghman (license 14) Tested by: ebroad, zktech Reviewboard: https://reviewboard.asterisk.org/r/544/ ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@255676 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-12Merged revisions 251989 via svnmerge from tilghman1-2/+0
https://origsvn.digium.com/svn/asterisk/trunk ........ r251989 | tilghman | 2010-03-12 13:43:23 -0600 (Fri, 12 Mar 2010) | 8 lines Don't override a user option with the global option. (closes issue #16849) Reported by: ip-rob Patches: 20100311__issue16849.diff.txt uploaded by tilghman (license 14) Tested by: ip-rob ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@251994 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-05Merged revisions 250913 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r250913 | tilghman | 2010-03-04 22:37:36 -0600 (Thu, 04 Mar 2010) | 7 lines Missing quote in ODBC query. (closes issue #16953) Reported by: elguero Patches: app_voicemail-odbc-syntax-fix.diff uploaded by elguero (license 37) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@250916 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-01Merged revisions 249672 via svnmerge from seanbright1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r249672 | seanbright | 2010-03-01 14:36:30 -0500 (Mon, 01 Mar 2010) | 18 lines Merged revisions 249671 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r249671 | seanbright | 2010-03-01 14:35:01 -0500 (Mon, 01 Mar 2010) | 11 lines Fix crash in app_voicemail related to message counting. We were passing a 'struct inprocess **' and treating it like a 'struct inprocess *' causing a segfault. (closes issue #16921) Reported by: whardier Patches: 20100301_issue16921.patch uploaded by seanbright (license 71) Tested by: whardier ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@249675 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-01Merged revisions 249623 via svnmerge from tilghman1-11/+12
https://origsvn.digium.com/svn/asterisk/trunk ........ r249623 | tilghman | 2010-03-01 12:36:06 -0600 (Mon, 01 Mar 2010) | 2 lines Constify a bit of app_voicemail, to make ODBC and IMAP compile once again. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@249625 f38db490-d61c-443f-a65b-d21fe96a405b
2010-02-28Merged revisions 249491 via svnmerge from tilghman1-1/+4
https://origsvn.digium.com/svn/asterisk/trunk ........ r249491 | tilghman | 2010-02-28 14:50:01 -0600 (Sun, 28 Feb 2010) | 5 lines Fix unit test that Alec Davis broke. (closes issue #16927) Reported by: alecdavis ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@249493 f38db490-d61c-443f-a65b-d21fe96a405b
2010-02-28Merged revisions 249405 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r249405 | tilghman | 2010-02-28 01:10:22 -0600 (Sun, 28 Feb 2010) | 2 lines Properly document voicemail API documents. Also fix a crash reported via the -dev list. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@249407 f38db490-d61c-443f-a65b-d21fe96a405b
2010-02-26Merged revisions 249187 via svnmerge from tilghman1-46/+62
https://origsvn.digium.com/svn/asterisk/trunk ........ r249187 | tilghman | 2010-02-26 12:41:57 -0600 (Fri, 26 Feb 2010) | 18 lines Cleanups to fix bugs in the VM count API functions. - Urgent voicemails were not attached, because the attachment code looked in the wrong folder. - Urgent voicemails were sometimes counted twice when displaying the count of new messages. - Backends were inconsistent as to which voicemails each API counted. (closes issue #15654) Reported by: tomo1657 Patches: 20100225__issue15654.diff.txt uploaded by tilghman (license 14) Tested by: tilghman (closes issue #16448) Reported by: hevad Review: https://reviewboard.asterisk.org/r/525/ ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@249190 f38db490-d61c-443f-a65b-d21fe96a405b
2010-02-01Merged revisions 244243 via svnmerge from tilghman1-7/+33
https://origsvn.digium.com/svn/asterisk/trunk ................ r244243 | tilghman | 2010-02-01 17:16:12 -0600 (Mon, 01 Feb 2010) | 18 lines Merged revisions 244242 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r244242 | tilghman | 2010-02-01 17:13:44 -0600 (Mon, 01 Feb 2010) | 11 lines Backup and restore original textfile, for prosthesis (gerund of prepend). Also, fix menuselect such that changing voicemail build options correctly causes rebuild. (closes issue #16415) Reported by: tomo1657 Patches: prepention.patch uploaded by tomo1657 (license 484) (with modifications by me to backport to 1.4) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@244320 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-15Merged revisions 240415 via svnmerge from tilghman1-4/+75
https://origsvn.digium.com/svn/asterisk/trunk ................ r240415 | tilghman | 2010-01-15 14:54:24 -0600 (Fri, 15 Jan 2010) | 22 lines Merged revisions 240414 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r240414 | tilghman | 2010-01-15 14:52:27 -0600 (Fri, 15 Jan 2010) | 15 lines Disallow leaving more than maxmsg voicemails. This is a possibility because our previous method assumed that no messages are left in parallel, which is not a safe assumption. Due to the vmu structure duplication, it was necessary to track in-process messages via a separate structure. If at some point, we switch vmu to an ao2-reference-counted structure, which would eliminate the prior noted duplication of structures, then we could incorporate this new in-process structure directly into vmu. (closes issue #16271) Reported by: sohosys Patches: 20100108__issue16271.diff.txt uploaded by tilghman (license 14) 20100108__issue16271__trunk.diff.txt uploaded by tilghman (license 14) 20100108__issue16271__1.6.0.diff.txt uploaded by tilghman (license 14) Tested by: jsutton ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@240418 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-28Merged revisions 236667 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r236667 | tilghman | 2009-12-28 11:37:46 -0600 (Mon, 28 Dec 2009) | 4 lines Use recommended option, not deprecated option. (closes issue #16515) Reported by: ManChicken ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@236670 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-04Merged revisions 233121 via svnmerge from dvossel1-3/+9
https://origsvn.digium.com/svn/asterisk/trunk ................ r233121 | dvossel | 2009-12-04 11:22:31 -0600 (Fri, 04 Dec 2009) | 12 lines Merged revisions 233116 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r233116 | dvossel | 2009-12-04 11:21:34 -0600 (Fri, 04 Dec 2009) | 6 lines document and rename strip_control() in app_voicemail (closes issue #16291) Reported by: wdoekes ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@233165 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-03Merged revisions 232854 via svnmerge from tilghman1-66/+79
https://origsvn.digium.com/svn/asterisk/trunk ................ r232854 | tilghman | 2009-12-03 14:47:07 -0600 (Thu, 03 Dec 2009) | 15 lines Merged revisions 232820 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r232820 | tilghman | 2009-12-03 14:10:19 -0600 (Thu, 03 Dec 2009) | 8 lines Deprecate "cz" in favor of "cs". Also, change the use of language codes so that language registers as a prefix, rather than an exact match. (closes issue #16272) Reported by: patrol-cz Patches: 20091203__issue16272.diff.txt uploaded by tilghman (license 14) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@232866 f38db490-d61c-443f-a65b-d21fe96a405b
2009-11-30Merged revisions 231688 via svnmerge from mnicholson1-2/+10
https://origsvn.digium.com/svn/asterisk/trunk ................ r231688 | mnicholson | 2009-11-30 15:31:55 -0600 (Mon, 30 Nov 2009) | 15 lines Merged revisions 231614 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r231614 | mnicholson | 2009-11-30 15:11:44 -0600 (Mon, 30 Nov 2009) | 8 lines Remove duplicate entries from voicemail format lists. This prevents app_voicemail from entering an infinite loop when the same format is specified twice in the format list. (closes issue #15625) Reported by: Shagg63 Tested by: mnicholson Review: https://reviewboard.asterisk.org/r/429/ ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@231689 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-19Merged revisions 224448 via svnmerge from tilghman1-84/+92
https://origsvn.digium.com/svn/asterisk/trunk ........ r224448 | tilghman | 2009-10-18 19:05:56 -0500 (Sun, 18 Oct 2009) | 3 lines Allow ODBC storage to be queried with multiple mailboxes, and remove multiple goto's. This corrects an issue reported on the -users list. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@224451 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-30Merged revisions 221085 via svnmerge from seanbright1-1/+13
https://origsvn.digium.com/svn/asterisk/trunk ........ r221085 | seanbright | 2009-09-30 10:47:58 -0400 (Wed, 30 Sep 2009) | 9 lines Clarify documentation for VoiceMailMain()'s a() option. We require box numbers, not names as the documentation implies. (issue #14740) Reported by: pj Patches: __20090729-app_voicemail-documentation.patch uploaded by lmadsen (license 10) Tested by: seanbright, lmadsen ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@221089 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-30Remove optional_api from 1.6.2 branch, since it is not currently working.tilghman1-4/+0
This is a blocking issue for the 1.6.2 release. (closes issue #15914) Reported by: mbeckwell Branch: http://svn.digium.com/svn/asterisk/team/tilghman/optional_api_162 Tested by: mbeckwell git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@221042 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-29Merged revisions 220833 via svnmerge from jpeeler1-6/+8
https://origsvn.digium.com/svn/asterisk/trunk ........ r220833 | jpeeler | 2009-09-29 11:58:29 -0500 (Tue, 29 Sep 2009) | 12 lines Make deletion of temporary greetings work properly with IMAP_STORAGE When imapgreetings was set to yes, the message was being deleted but wasn't actually being expunged. When imapgreetings was set to no, the file based message was not being deleted at all. All good now! (closes issue #14949) Reported by: noahisaac Patches: vm_tempgreeting_removal.patch uploaded by noahisaac (license 748), modified by me ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@220836 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-22Merged revisions 219818 via svnmerge from tilghman1-0/+24
https://origsvn.digium.com/svn/asterisk/trunk ................ r219818 | tilghman | 2009-09-22 16:43:22 -0500 (Tue, 22 Sep 2009) | 17 lines Merged revisions 219816 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r219816 | tilghman | 2009-09-22 16:37:03 -0500 (Tue, 22 Sep 2009) | 10 lines When IMAP variables were changed during a reload, Voicemail did not use the new values. This change introduces a configuration version variable, which ensures that connections with the old values are not reused but are allowed to expire normally. (closes issue #15934) Reported by: viniciusfontes Patches: 20090922__issue15934.diff.txt uploaded by tilghman (license 14) Tested by: viniciusfontes ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@219821 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-18Merged revisions 219412 via svnmerge from tilghman1-0/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r219412 | tilghman | 2009-09-18 08:54:51 -0500 (Fri, 18 Sep 2009) | 6 lines Missing value setting line for maxsecs/maxmessage (closes issue #15696) Reported by: fhackenberger Patches: maxsecs.patch uploaded by fhackenberger (license 592) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@219415 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-15Merged revisions 218731 via svnmerge from tilghman1-15/+14
https://origsvn.digium.com/svn/asterisk/trunk ................ r218731 | tilghman | 2009-09-15 17:33:10 -0500 (Tue, 15 Sep 2009) | 13 lines Merged revisions 218730 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r218730 | tilghman | 2009-09-15 17:27:41 -0500 (Tue, 15 Sep 2009) | 6 lines If the user enters the same password as before, don't signal an error when the change does nothing. (closes issue #15492) Reported by: cbbs70a Patches: 20090713__issue15492.diff.txt uploaded by tilghman (license 14) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@218733 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-14Merged revisions 218361 via svnmerge from tilghman1-0/+13
https://origsvn.digium.com/svn/asterisk/trunk ................ r218361 | tilghman | 2009-09-14 14:29:48 -0500 (Mon, 14 Sep 2009) | 11 lines Recorded merge of revisions 218331 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r218331 | tilghman | 2009-09-14 14:16:35 -0500 (Mon, 14 Sep 2009) | 4 lines Don't say "Please try again" if we don't give the user another chance to try again. (issue #15055, SWP-129) Reported by: jthurman ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@218364 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-04Merged revisions 216593 via svnmerge from seanbright1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r216593 | seanbright | 2009-09-04 15:29:02 -0400 (Fri, 04 Sep 2009) | 1 line Use ast_free() instead of free(). ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@216597 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-24Merged revisions 213833 via svnmerge from jpeeler1-5/+8
https://origsvn.digium.com/svn/asterisk/trunk ........ r213833 | jpeeler | 2009-08-24 11:43:57 -0500 (Mon, 24 Aug 2009) | 14 lines Fix storage of greetings when using IMAP_STORAGE The store macro was not getting called preventing storage of IMAP greetings at all. This has been corrected along with fixing checking if the imapgreetings option is turned on to store the greeting in IMAP. Lastly, the attachment filename was incorrectly using the full path instead of just the basename, which was causing problems with retrieval of the greeting. (closes issue #14950) Reported by: noahisaac (closes issue #15729) Reported by: lmadsen ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@213836 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-21Merged revisions 213697 via svnmerge from kpfleming1-13/+18
https://origsvn.digium.com/svn/asterisk/trunk ........ r213697 | kpfleming | 2009-08-21 16:39:51 -0500 (Fri, 21 Aug 2009) | 12 lines Ensure that realtime mailboxes properly report status on subscription. This patch modifies app_voicemail's response to mailbox status subscriptions (via the internal event system) to ensure that a subscription triggers an explicit poll of the mailbox, so the subscriber can get an immediate cached event with that status. Previously, the cache was only populated with the status of non-realtime mailboxes. (closes issue #15717) Reported by: natmlt ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@213698 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-20Merged revisions 213404 via svnmerge from jpeeler1-4/+15
https://origsvn.digium.com/svn/asterisk/trunk ........ r213404 | jpeeler | 2009-08-20 16:33:11 -0500 (Thu, 20 Aug 2009) | 12 lines Fix greeting retrieval from IMAP Properly check for the current voicemail state and if it doesn't exist, create it. (closes issue #14597) Reported by: wtca Patches: 14597_v2.patch uploaded by mmichelson (license 60) Tested by: jpeeler ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@213413 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-17Merged revisions 212627 via svnmerge from tilghman1-1/+4
https://origsvn.digium.com/svn/asterisk/trunk ........ r212627 | tilghman | 2009-08-17 14:57:42 -0500 (Mon, 17 Aug 2009) | 4 lines Check the return value of opendir(3), or we may crash. (closes issue #15720) Reported by: tobias_e ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@212631 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-10AST-2009-005tilghman1-23/+23
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@211580 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-18Merged revisions 207317 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r207317 | tilghman | 2009-07-17 23:16:44 -0500 (Fri, 17 Jul 2009) | 3 lines Flag field in wrong position. Reported by "Hoggins!" on asterisk-dev list. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@207327 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-13Merged revisions 206185 via svnmerge from tilghman1-4/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r206185 | tilghman | 2009-07-13 11:23:07 -0500 (Mon, 13 Jul 2009) | 2 lines Remove reference to non-existent help file ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@206187 f38db490-d61c-443f-a65b-d21fe96a405b
2009-06-30Recorded merge of revisions 204470 via svnmerge from tilghman1-10/+10
https://origsvn.digium.com/svn/asterisk/trunk ................ r204470 | tilghman | 2009-06-30 13:36:24 -0500 (Tue, 30 Jun 2009) | 18 lines Recorded merge of revisions 204469 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r204469 | tilghman | 2009-06-30 13:23:35 -0500 (Tue, 30 Jun 2009) | 11 lines "tw" is the language specification for Twi (from Ghana) not Taiwanese. (closes issue #15346) Reported by: volivier Patches: 20090617__issue15346__1.4.diff.txt uploaded by tilghman (license 14) 20090617__issue15346__trunk.diff.txt uploaded by tilghman (license 14) 20090617__issue15346__1.6.0.diff.txt uploaded by tilghman (license 14) 20090617__issue15346__1.6.1.diff.txt uploaded by tilghman (license 14) 20090617__issue15346__1.6.2.diff.txt uploaded by tilghman (license 14) Tested by: volivier ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@204473 f38db490-d61c-443f-a65b-d21fe96a405b
2009-06-26Merged revisions 203721 via svnmerge from dbrooks1-2/+4
https://origsvn.digium.com/svn/asterisk/trunk ........ r203721 | dbrooks | 2009-06-26 15:13:51 -0500 (Fri, 26 Jun 2009) | 16 lines Fixing voicemail's error in checking max silence vs min message length Max silence was represented in milliseconds, yet vmminsecs (minmessage) was represented as seconds. Also, the inequality was reversed. The warning, if triggered, was "Max silence should be less than minmessage or you may get empty messages", which should have been logged if max silence was greater than minmessage, but the check was for less than. Also, conforming if statement to coding guidelines. closes issue #15331) Reported by: markd Review: https://reviewboard.asterisk.org/r/293/ ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@203731 f38db490-d61c-443f-a65b-d21fe96a405b